Re: Review Request 25035: Fix for MESOS-1688

2014-09-10 Thread Vinod Kone
/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92338 s/mem/memory/ src/tests/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92339 s/tasks/task/ - Vinod Kone On Sept. 10, 2014, 10 p.m., Martin Weindel wrote

Re: Review Request 25035: Fix for MESOS-1688

2014-09-10 Thread Vinod Kone
On Sept. 11, 2014, 5:35 a.m., Vinod Kone wrote: Can you also update the summary of the review to something more meaningful? We typically use the summary to generate the commit message. - Vinod --- This is an automatically generated

Re: Completed tasks remains in TASK_RUNNING when framework is disconnected

2014-09-11 Thread Vinod Kone
the status updates until the entire stream actually gets forwarded+acknowledged. Thoughts? On Wed, Sep 10, 2014 at 5:55 PM, Vinod Kone vinodk...@gmail.com wrote: The main reason is to keep status update manager simple. Also, it is very easy to enforce the order of updates to the master

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

2014-09-11 Thread Vinod Kone
://reviews.apache.org/r/25525/#comment92521 You should checkpoint the updated slave info! - Vinod Kone On Sept. 11, 2014, 8:13 a.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 25549: Basic filesystem isolator for Linux.

2014-09-11 Thread Vinod Kone
://reviews.apache.org/r/25549/#comment92587 s/sContainer/containerStat/ - Vinod Kone On Sept. 11, 2014, 6:46 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549

Re: Review Request 25549: Basic filesystem isolator for Linux.

2014-09-11 Thread Vinod Kone
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/ --- (Updated Sept. 11, 2014, 6:46 p.m.) Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Bugs: MESOS-1586

Re: Mesos webcast

2014-09-12 Thread Vinod Kone
difficulties. Thanks in advance, Kamil On 09/09/2014 07:22 PM, Vinod Kone wrote: Hi folks, I'm doing a webcast on Mesos this thursday (h/t Mesosphere) where I will talk about some of the core features of Mesos (slave recovery, authentication and authorization). At the end, we will have time

Re: 0.20.1 Release Manager

2014-09-12 Thread Vinod Kone
Tim St. Clair or Adam, would you guys be willing to work with Bhuvan to get the release out? On Fri, Sep 12, 2014 at 10:12 AM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Hi Bhuvan, that's great! However, doing a release requires commit access. On Sep 12, 2014, at 8:06 AM, Bhuvan

Re: 0.20.1 Release Manager

2014-09-12 Thread Vinod Kone
to, but this next month is going to be crazy for me. Perhaps the next cycle. Regards, Tim - Original Message - From: Vinod Kone vinodk...@gmail.com To: dev dev@mesos.apache.org Sent: Friday, September 12, 2014 12:22:59 PM Subject: Re: 0.20.1 Release Manager Tim St. Clair

Re: Review Request 25565: Added a removeExecutor helper in the Master.

2014-09-12 Thread Vinod Kone
? How about ...possibly unknown to the slave? I'm assuming you wanted to rephrase because slave could actually know it? - Vinod Kone On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply

Re: ANN: Mesos bindings for Haskell

2014-09-12 Thread Vinod Kone
Great to see the Haskell bindings Ian! See my answers inline. * It seems like there are portions of mesos.proto that aren’t currently supported by the API yet: in particular, “Credentials”, “ACL”, “ACLS”, “RateLimit”, “RateLimits” don’t seem like they do anything yet. Am I missing

Re: Review Request 25604: Fixed the flaky FaultToleranceTest.ReconcilePendingTasks.

2014-09-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25604/#review53254 --- Ship it! Ship It! - Vinod Kone On Sept. 13, 2014, 12:13 a.m

Re: Contributor role in Jira

2014-09-14 Thread Vinod Kone
Done. On Sun, Sep 14, 2014 at 5:24 PM, Bhuvan Arumugam bhu...@apache.org wrote: Vinod, I'm working with Adam Bordelon to manage 0.20.1 release. Can you grant me Contributor access in jira to manage versions and changelogs? Thank you, -- Regards, Bhuvan Arumugam www.livecipher.com

Re: Review Request 25035: Fix for MESOS-1688

2014-09-15 Thread Vinod Kone
and Vinod Kone. Bugs: MESOS-1688 https://issues.apache.org/jira/browse/MESOS-1688 Repository: mesos-git Description --- As already explained in JIRA MESOS-1688, there are schedulers allocating memory only for the executor and not for tasks. For tasks only CPU resources

Re: Review Request 25035: Fix for MESOS-1688

2014-09-15 Thread Vinod Kone
/#comment92993 ditto. log requested memory. src/tests/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92991 2 blank lines. src/tests/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92990 2 blank lines. - Vinod Kone On Sept. 13, 2014, 7:10 p.m

Re: Review Request 25566: Minor cleanups to the Master code.

2014-09-16 Thread Vinod Kone
/#comment93108 - Vinod Kone On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25566

Re: Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.

2014-09-16 Thread Vinod Kone
/#comment93109 s/updateTaskState/updateTask/ since you are not just updating the state? src/master/master.hpp https://reviews.apache.org/r/25567/#comment93110 s/a/the/ - Vinod Kone On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote

Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

2014-09-16 Thread Vinod Kone
message? Isn't the receipt of the update guarantee that? Actually, thinking a bit more, how do you guarantee that the second update was due to reconcile tasks and not a retry by the slave? - Vinod Kone On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote

Re: Mesos 0.20.1 release status

2014-09-16 Thread Vinod Kone
On Mon, Sep 15, 2014 at 11:19 PM, Bhuvan Arumugam bhu...@apache.org wrote: I'll cut the tag for RC1 and send for voting, once these issues are reviewed/submitted or 9/15 @6pm PDT, whichever comes first! The open issues (if any) will be moved to next release, at that point in time. You want

Re: Review Request 25695: Update to enable systemd control of mesos services

2014-09-16 Thread Vinod Kone
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/ --- (Updated Sept. 16, 2014, 6:19 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1195

Re: Build failed in Jenkins: mesos-reviewbot #1600

2014-09-17 Thread Vinod Kone
On Wed, Sep 17, 2014 at 9:56 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: ../../src/tests/docker_tests.cpp: In member function 'virtual void DockerTest_ROOT_DOCKER_CheckPortResource_Test::TestBody()': ../../src/tests/docker_tests.cpp:263:28: error: 'AWAIT_EXPECTED_FAILED' was

Re: Review Request 25549: Basic filesystem isolator for Linux.

2014-09-17 Thread Vinod Kone
. - Vinod Kone On Sept. 15, 2014, 8:01 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/ --- (Updated Sept. 15

Re: Review Request 25655: Add alternate os::chown taking uid and gid.

2014-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25655/#review53714 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2014, 8 p.m., Ian

Re: Review Request 25261: Check for variadic template support

2014-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/#review53715 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2014, 10:26 p.m

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

2014-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25622/#review53718 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2014, 10:20 p.m

Re: [VOTE] Release Apache Mesos 0.20.1 (rc2)

2014-09-17 Thread Vinod Kone
+1 (binding) make check passes on CentOS 5.5 w/ gcc 4.8.2. On Wed, Sep 17, 2014 at 7:42 PM, Adam Bordelon a...@mesosphere.io wrote: Update: The vote is open until Mon Sep 22 10:00:00 PDT 2014 and passes if a majority of at least 3 +1 PMC votes are cast. On Wed, Sep 17, 2014 at 6:27 PM,

Review Request 25801: Fixed example frameworks to launch tasks based of offered resources.

2014-09-18 Thread Vinod Kone
a1e36dfd47e7e6a0d2a10382c410780dfe36391e src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a Diff: https://reviews.apache.org/r/25801/diff/ Testing --- make check GTEST_FILTER=*EXAMPLESTEST* Thanks, Vinod Kone

Review Request 25805: Fixed example frameworks to fail fast on an unexpected status udpate.

2014-09-18 Thread Vinod Kone
1dd2b99bd3f8817e629b70849d9ea0d3fdb82411 src/examples/python/test_framework.py 75ca5092d07789aa97e76c2224c86acf83e0d7e3 src/examples/test_framework.cpp e6e7137e6d4df40ceae7345500a14e7bee68b2c5 Diff: https://reviews.apache.org/r/25805/diff/ Testing --- make check GTEST_FILTER=*ExamplesTest* Thanks, Vinod Kone

Re: Review Request 25805: Fixed example frameworks to fail fast on an unexpected status udpate.

2014-09-18 Thread Vinod Kone
--- make check GTEST_FILTER=*ExamplesTest* Thanks, Vinod Kone

Re: Review Request 25801: Fixed example frameworks to launch tasks based of offered resources.

2014-09-18 Thread Vinod Kone
, Vinod Kone

Re: Review Request 25801: Fixed example frameworks to launch tasks based of offered resources.

2014-09-18 Thread Vinod Kone
e8d72a3be80cc215576fbf3ecc58d7b25975c0b8 src/tests/python_framework_test.sh a1e36dfd47e7e6a0d2a10382c410780dfe36391e src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a Diff: https://reviews.apache.org/r/25801/diff/ Testing --- make check GTEST_FILTER=*EXAMPLESTEST* Thanks, Vinod Kone

Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

2014-09-18 Thread Vinod Kone
://reviews.apache.org/r/25568/#comment93766 s/we do this// ? - Vinod Kone On Sept. 18, 2014, 9:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568

Re: Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.

2014-09-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25567/#review53904 --- Ship it! Ship It! - Vinod Kone On Sept. 18, 2014, 9:30 p.m

Fwd: New mesos questions for Sep 18 - Stack Exchange

2014-09-18 Thread Vinod Kone
-- Forwarded message -- From: Stack Exchange do-not-re...@stackexchange.com Date: Thu, Sep 18, 2014 at 4:33 PM Subject: New mesos questions for Sep 18 - Stack Exchange To: vi...@twitter.com 1 new question in Mesos Filter filter

Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)

2014-09-18 Thread Vinod Kone
+1 (binding) sudo make check on CentOS 5.5 w/ gcc-4.8.2 On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon a...@mesosphere.io wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.20.1. 0.20.1 includes the following:

Re: Review Request 25805: Fixed example frameworks to fail fast on an unexpected status udpate.

2014-09-18 Thread Vinod Kone
/ Testing --- make check GTEST_FILTER=*ExamplesTest* Thanks, Vinod Kone

Re: New mesos questions for Sep 18 - Stack Exchange

2014-09-18 Thread Vinod Kone
. On Thu, Sep 18, 2014 at 5:33 PM, Vinod Kone vinodk...@gmail.com wrote: -- Forwarded message -- From: Stack Exchange do-not-re...@stackexchange.com Date: Thu, Sep 18, 2014 at 4:33 PM Subject: New mesos questions for Sep 18 - Stack Exchange To: vi...@twitter.com 1 new

Re: Review Request 25810: Fixed a segfault regression in the master.

2014-09-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25810/#review53923 --- Ship it! Ship It! - Vinod Kone On Sept. 19, 2014, 2:33 a.m

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

2014-09-19 Thread Vinod Kone
On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote: OK. I went through parts of this review but I have a bigger suggestion in mind, before I get too much into the weeds. I think it's worthwhile for you to write up a design doc similar to the framework info doc w.r.t. updating SlaveInfo

Re: Review Request 25218: Updated a comment and some syntax formatting.

2014-09-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25218/#review53976 --- Ship it! Ben, I'll commit this for you. - Vinod Kone On Aug. 31

Re: Review Request 25844: Ignore terminal task resources in the Master's Framework struct.

2014-09-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25844/#review54020 --- Ship it! Ship It! - Vinod Kone On Sept. 19, 2014, 7:57 p.m

Re: Review Request 25843: Fixed an executor accounting bug in framework re-registration.

2014-09-19 Thread Vinod Kone
/#comment93904 kill the if. - Vinod Kone On Sept. 19, 2014, 7:57 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843

Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-19 Thread Vinod Kone
/ Testing --- make check Thanks, Vinod Kone

Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-19 Thread Vinod Kone
: https://reviews.apache.org/r/25867/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-20 Thread Vinod Kone
154386044d0247b39d84719d7ff14250682a0695 Diff: https://reviews.apache.org/r/25866/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-20 Thread Vinod Kone
28eb02852ddcc10efe589a8069dba9c895bc160e src/tests/partition_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25867/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-22 Thread Vinod Kone
://reviews.apache.org/r/25866/#review54094 --- On Sept. 20, 2014, 6:46 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866

Re: Review Request 25866: Updated semantics of disconnected/deactivated slaves/frameworks in master.

2014-09-22 Thread Vinod Kone
--- make check Thanks, Vinod Kone

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

2014-09-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54078 --- On Sept. 20, 2014, 6:46 p.m., Vinod Kone wrote

Re: Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-22 Thread Vinod Kone
28eb02852ddcc10efe589a8069dba9c895bc160e src/tests/partition_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25867/diff/ Testing --- make check Thanks, Vinod Kone

Re: Mesos Modules Design

2014-09-23 Thread Vinod Kone
Ok. I finally had a chance to read the design doc, go through the comments on this thread and glance at the review. Here are my comments. I like the concept of dynamic loading of libraries when it comes to making the lives of end users/operators easy, esp when they want to mix and match the

Re: Review Request 25549: Basic filesystem isolator for Linux.

2014-09-23 Thread Vinod Kone
particular reason the container was added to ExecutorInfo instead of TaskInfo? - Vinod Kone On Sept. 22, 2014, 6:45 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2123

2014-09-24 Thread Vinod Kone
ben is this expected? On Wed, Sep 24, 2014 at 1:34 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2123/changes Changes: [yujie.jay] Added support for getting socket diagnosis information.

Re: Review Request 25866: Updated semantics of disconnected/deactivated slaves/frameworks in master.

2014-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54384 --- On Sept. 22, 2014, 11:50 p.m., Vinod Kone wrote: --- This is an automatically

Re: Review Request 25867: Updated ping message to embed the slave registered status.

2014-09-25 Thread Vinod Kone
9a6646f0249fd43ae5d13bd9ee3b5da08412 src/tests/partition_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25867/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 24177: Pass executor directory to Isolator::prepare().

2014-09-25 Thread Vinod Kone
temporary directories. s/os::mkdtemp()/os::mkdtemp(./XX)/ mind adding a TODO? - Vinod Kone On Sept. 23, 2014, 11:42 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-09-25 Thread Vinod Kone
/slave/containerizer/mesos/containerizer.cpp https://reviews.apache.org/r/25861/#comment94828 s/isolators/isolator/ - Vinod Kone On Sept. 22, 2014, 6:45 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 25549: Basic filesystem isolator for Linux.

2014-09-25 Thread Vinod Kone
is specified in flags? - Vinod Kone On Sept. 24, 2014, 6:09 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549

Re: Review Request 25863: Rename stout/os/setns.hpp to namespaces.hpp.

2014-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25863/#review54630 --- Ship it! Ship It! - Vinod Kone On Sept. 23, 2014, 11:39 p.m

Re: Review Request 25965: Update libprocess Makefile for setns namechange.

2014-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25965/#review54632 --- Ship it! Ship It! - Vinod Kone On Sept. 24, 2014, 6:13 p.m

Re: Review Request 25964: Update libprocess Makefile for setns namechange.

2014-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25964/#review54631 --- Ship it! Ship It! - Vinod Kone On Sept. 24, 2014, 6:14 p.m

Re: Review Request 25865: Pid namespace isolator for the MesosContainerizer.

2014-09-25 Thread Vinod Kone
and stderr right? - Vinod Kone On Sept. 23, 2014, 11:39 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25865

Re: Review Request 25865: Pid namespace isolator for the MesosContainerizer.

2014-09-25 Thread Vinod Kone
On Sept. 26, 2014, 1:17 a.m., Vinod Kone wrote: Can you attach the bug. Also, need documentation. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25865/#review54637

Re: Review Request 25966: Use pid namespace in LinuxLauncher::destroy().

2014-09-25 Thread Vinod Kone
://reviews.apache.org/r/25966/#comment94890 do we need to call destroy? how about improving cgroups::remove() to do recursive removal and just calling that here? src/slave/containerizer/linux_launcher.cpp https://reviews.apache.org/r/25966/#comment94887 Tests? - Vinod Kone On Sept. 23, 2014

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/#review54643 --- Ship it! lgtm modulo comments. - Vinod Kone On Sept. 23, 2014

Re: Review Request 25549: Basic filesystem isolator for Linux.

2014-09-25 Thread Vinod Kone
On Sept. 25, 2014, 11:56 p.m., Vinod Kone wrote: Mind adding documentation for this? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review54627

Re: Review Request 25551: Add standard versioning to shared libmesos.so

2014-09-26 Thread Vinod Kone
why not just libmesos_la_LDFLAGS = -version-info $(PACKAGE-VERSION) More importantly how do the resulting dylibs (symlink and regular) look like compared to the previous style? Is it backwards compatible or needs re-linking? - Vinod Kone On Sept. 26, 2014, 3:31 p.m

Re: Regarding adding as a contributor in apache mesos group

2014-09-28 Thread Vinod Kone
Added you as a contributor. Good luck! On Sun, Sep 28, 2014 at 2:24 AM, namrata singh namrata.ii...@gmail.com wrote: respected sir , I would like to introduce myself as Namrata Singh chauhan, a student of IIIT Allahabad, India and a want-to-be a OPW contributor for mesos group , sir I would

Re: Review Request 26141: Increased the store timeout for the Registrar tests.

2014-09-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26141/#review54843 --- Ship it! Ship It! - Vinod Kone On Sept. 29, 2014, 6:30 p.m

Fwd: Regarding OPW mesos project

2014-09-29 Thread Vinod Kone
Hi prospective OPW interns, I've been contacted by quite a few of you regarding Mesos Getting Started Documentation OPW project. So, wanted to send out a list of starter tickets that you can work on. https://issues.apache.org/jira/browse/MESOS-1647

Mesos OPW project

2014-09-29 Thread Vinod Kone
Hi prospective OPW interns, I've been contacted by quite a few of you regarding Mesos Getting Started Documentation OPW project. So, wanted to send out a list of starter tickets that you can work on. https://issues.apache.org/jira/browse/MESOS-1647

Review Request 26144: Fixed AllocatorTest.FrameworkExited test.

2014-09-29 Thread Vinod Kone
the resourcesAllocated() dispatches starving the 1st one. Diffs - src/tests/allocator_tests.cpp 9cd5da36daf144ba1c759003bc1376ce74833245 Diff: https://reviews.apache.org/r/26144/diff/ Testing --- Ran the test 500 times in repetition. Thanks, Vinod Kone

Re: Review Request 26149: Remove depreacted webui_hostname and webui_port fields

2014-09-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26149/#review54882 --- Ship it! Ship It! - Vinod Kone On Sept. 29, 2014, 9:01 p.m

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2131

2014-09-29 Thread Vinod Kone
https://issues.apache.org/jira/browse/MESOS-1347 On Mon, Sep 29, 2014 at 12:30 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2131/changes Changes: [dlester] Adds OpenCredo and WooRank to

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2132

2014-09-29 Thread Vinod Kone
bumped up the inactive timeout from 10min to 30 min to account for build slowness. On Mon, Sep 29, 2014 at 4:48 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2132/changes Changes: [bmahler]

Re: scheduler.killExecutor()

2014-09-29 Thread Vinod Kone
Adding a shutdownExecutor() driver call has been discussed before. https://issues.apache.org/jira/browse/MESOS-330 As a work around, have you considered sending a special kill task as a signal to the executor to commit suicide? On Mon, Sep 29, 2014 at 5:27 PM, Tom Arnfeld t...@duedil.com

Review Request 26159: Fixed framework logging in master.cpp.

2014-09-29 Thread Vinod Kone
d6380199421840aa17d4ce2725dcbcf4a11ce85f src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e Diff: https://reviews.apache.org/r/26159/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 26163: Fixed AllocatorTest.SlaveLost test.

2014-09-29 Thread Vinod Kone
b824f77a0e941ecb623d1e64c2cdebea7871b71a Diff: https://reviews.apache.org/r/26163/diff/ Testing --- Ran the test in a loop ~500 times. Thanks, Vinod Kone

Re: Review Request 26185: Update documentation/flags regarding new default hostname semantics

2014-09-30 Thread Vinod Kone
binds to (see --ip flag)/ - Vinod Kone On Sept. 30, 2014, 6:25 p.m., Evelina Dumitrescu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26185

Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI

2014-09-30 Thread Vinod Kone
a shepherd for a issue you want to work on and get a committment from them to review your code. That ensures reviews don't fall through the cracks. include/mesos/mesos.proto https://reviews.apache.org/r/26125/#comment95335 Add a blurb about it in the comment above? - Vinod Kone On Sept. 28

Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI

2014-09-30 Thread Vinod Kone
On Sept. 30, 2014, 9:16 p.m., Niklas Nielsen wrote: Vinod Tobi: I can help out landing this if you are interested. I can't claim to be an angular expert though. One high-level comment: how about we write a test so we make sure it works in the future too? A simple framework

Re: MESOS-1739 Design Document: Allow slave reconfiguration on restart

2014-09-30 Thread Vinod Kone
All our design docs (likely after review phase in google docs) will live here https://cwiki.apache.org/confluence/display/MESOS. We haven't been great about design docs in the past, but we are getting better. On Tue, Sep 30, 2014 at 6:05 PM, Jay Buffington m...@jaybuff.com wrote: Design

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

2014-10-01 Thread Vinod Kone
://reviews.apache.org/r/23912/#comment95467 s/killed/killTask/ src/tests/slave_tests.cpp https://reviews.apache.org/r/23912/#comment95460 ditto. formatting. also, this expectation should be set after driver.launchTasks(). - Vinod Kone On Sept. 18, 2014, 1:47 a.m., Bernd

Review Request 26242: Changed checkpoint logging from LOG(INFO) to VLOG(1).

2014-10-01 Thread Vinod Kone
--- Also, added a log line for executor launch to log its work directory. Diffs - src/slave/slave.cpp e56dcbd80114730949a0d4b553470802a4d38281 Diff: https://reviews.apache.org/r/26242/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 26243: Fixed the flaky SlaveRecoverTest.MultipleSlaves.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26243/#review55128 --- Ship it! Ship It! - Vinod Kone On Oct. 1, 2014, 7:20 p.m., Ben

Re: Review Request 26198: Fixed a log line in the master.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26198/#review55136 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:30 p.m

Re: Review Request 26200: Added validation for missing ExecutorInfo::framework_id.

2014-10-01 Thread Vinod Kone
. // TODO(bmahler): Set this field in the master instead // of depending on the scheduler driver do it. - Vinod Kone On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 26201: Properly deprecated ReregisterSlaveMessage::slave_id.

2014-10-01 Thread Vinod Kone
/26201/#comment95528 File a ticket for this? - Vinod Kone On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26201

Re: Review Request 26202: Introduced a version during slave (re-)registration.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26202/#review55145 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:30 p.m

Re: Review Request 26203: Removed redundant logging in the Master.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26203/#review55146 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:30 p.m

Re: Review Request 26204: Removed the need for Master::readdSlave.

2014-10-01 Thread Vinod Kone
/#comment95531 Pull this down too as you did for _registerSlave() ? - Vinod Kone On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26204

Re: Review Request 26205: Cleaned up Master::addFramework.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26205/#review55149 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:31 p.m

Re: Review Request 26206: Introduced Master - Slave reconciliation.

2014-10-01 Thread Vinod Kone
/#comment95533 s/no/no need for/ Can you also add a comment about why this doesn't need to go through the status update manager? - Vinod Kone On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote: --- This is an automatically

Re: Review Request 26207: Split out partition and reconciliation tests from FaultTolerace tests.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26207/#review55155 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:31 p.m

Re: Review Request 26199: Eliminated redundant resource accounting in the master.

2014-10-01 Thread Vinod Kone
/#comment95539 hmmm. slave-used() doesn't really tell what is being returned here. how about calling it slave-resources() instead. do you think that's less confusing? slave-resources() # used resources. slave-info.resources() # total resources. - Vinod Kone On Sept. 30

Re: Review Request 26208: Added a test for the Master - Slave reconciliation race.

2014-10-01 Thread Vinod Kone
://reviews.apache.org/r/26208/#comment95540 s/launch/launch task/ src/tests/master_slave_reconciliation_tests.cpp https://reviews.apache.org/r/26208/#comment95543 Neither the slave nor the master right? - Vinod Kone On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote

Re: Review Request 26199: Eliminated redundant resource accounting in the master.

2014-10-01 Thread Vinod Kone
On Oct. 1, 2014, 11:05 p.m., Vinod Kone wrote: src/master/master.cpp, line 4293 https://reviews.apache.org/r/26199/diff/1/?file=709864#file709864line4293 hmmm. slave-used() doesn't really tell what is being returned here. how about calling it slave-resources() instead. do you

Re: Review Request 26256: MESOS-1857 Fix path::join() on older libstdc++ which lack back()

2014-10-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26256/#review55219 --- Ship it! Ship It! - Vinod Kone On Oct. 2, 2014, 1:43 a.m., Cody

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2141

2014-10-02 Thread Vinod Kone
+jake removed ubuntu6 jenkins slave from the labels because it doesn't seem to have libcurl installed. On Thu, Oct 2, 2014 at 10:07 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2141/changes

Re: Review Request 26254: Replaced default port value for mesos master in documentation

2014-10-02 Thread Vinod Kone
/#comment95613 This section of the document talks about common options between master and slaves. We need to make it clear that the default is 5050 for master and 5051 for slave. - Vinod Kone On Oct. 1, 2014, 11:55 p.m., Evelina Dumitrescu wrote

<    1   2   3   4   5   6   7   8   9   10   >