Re: JS library dynamic import

2022-05-27 Thread James Yong
Hi Florian, The reason for using importLibrary is for maintainability and was done under OFBIZ-11799. Beside those you have listed, there is also JS libraries like jstree, readmore, fjTimer, cookies, moments. Before the change, it was often unclear where and when the JS/CSS were used and how th

Re: Single Form Widget on CSS Grid Layout

2021-01-27 Thread James Yong
Hi Ingo, Some macros like renderTextFindField contains a number of fields. The addition of span tags will group these fields together so that they can be correctly placed next to the form field label. I haven't looked info flexbox much. Thanks Jacques for the additional info. Regards, James O

Re: Single Form Widget on CSS Grid Layout

2021-01-27 Thread James Yong
> check the extend logic OFBIZ-11335 > <https://issues.apache.org/jira/browse/OFBIZ-11335>[1] [James] Ok, need to look into the usage again. > > My feel is keep more simple as possible the form type code. > > Nicolas > > [1] https://issues.apache.org/jira/browse/OFBIZ

Re: Ofbiz integrate Python script

2021-01-26 Thread James Yong
Hi Nguyen, Any python library you have in mind? For calling python from java, the information from the following link may helps: https://www.baeldung.com/java-working-with-python Regards, James On 2021/01/23 07:41:28, Thanh Nguyen wrote: > Hi everyone, > > How do you think about integrate P

Single Form Widget on CSS Grid Layout

2021-01-26 Thread James Yong
Hi all, Planning to add a new form widget type i.e. single_css-grid-layout. This new type allows Single Form Widget to be layout with CSS Grid, instead of table. Created OFBIZ-12162 with patch for it. Regards, James

Re: [ofbiz-framework] branch trunk updated: Improved: Updated tasks.checkstyleMain.maxErrors to 278

2021-01-21 Thread James Yong
y this push: > > new b679d36 Improved: Updated tasks.checkstyleMain.maxErrors to 278 > > b679d36 is described below > > > > commit b679d36b492b23fc0a5797e9a637f5924aa0cba8 > > Author: James Yong > > AuthorDate: Thu

Re: OFBIZ-12081: DB driver download and configuration based on gradle property

2021-01-14 Thread James Yong
Hi Daniel, IMO, splitting entityengine.xml file into db-specific is good in general. I have the following suggestions: Gradle Allow more 1 db driver to be downloaded. Different datasource can be in use at the same time, like mysql for olap and postgreql for others. Non-Gradle Allow ENTITY_ENGI

Re: It's no more possible to enter a date manually

2021-01-11 Thread James Yong
Tooltip issue fixed at OFBIZ-12123. On 2021/01/12 03:19:12, James Yong wrote: > Hi Oliver, > > Found the regression comes from OFBIZ-12097. > The fix is now in trunk. > > Will look into the tooltip issue. > > Thanks, > James > > On 2021/01/12 01:32:31, J

Re: It's no more possible to enter a date manually

2021-01-11 Thread James Yong
Hi Oliver, Found the regression comes from OFBIZ-12097. The fix is now in trunk. Will look into the tooltip issue. Thanks, James On 2021/01/12 01:32:31, James Yong wrote: > Hi Olivier, > > Please see my reply inline.. > > Regards, > James > > On 2021/01/11 20:41:5

Re: It's no more possible to enter a date manually

2021-01-11 Thread James Yong
Hi Olivier, Please see my reply inline.. Regards, James On 2021/01/11 20:41:53, Olivier Heintz wrote: > Hello, > > It's a question before creating a Jira. > > In a datetime field, I'm not able to enter in the field, directly the > date-time I want, because going to the next field with tab,

Re: CSS Grid Layout

2021-01-01 Thread James Yong
t; Le 01/01/2021 à 15:48, James Yong a écrit : > > Hi all, > > > > According to the page at https://caniuse.com/css-grid, CSS Grid Layout > > (level 1) is supported by most browsers. I think we can start adopting this > > feature to layout the form fields. > > In m

Re: Welcome to Daniel Watford as new committer!

2021-01-01 Thread James Yong
Hi Daniel, Congratulations on joining the Committer team! All the best with your new role. Regards, James On 2020/12/31 16:20:26, Jacopo Cappellato wrote: > The OFBiz PMC has invited Daniel to become a new committer and we are > pleased to announce that he has accepted the nomination. > > We

CSS Grid Layout

2021-01-01 Thread James Yong
Hi all, According to the page at https://caniuse.com/css-grid, CSS Grid Layout (level 1) is supported by most browsers. I think we can start adopting this feature to layout the form fields. In my opinion, it is easier to arrange the form fields using CSS Grid than with tables. HTML codes will b

Re: Change ${...} to [=...] for freemarker template

2020-12-20 Thread James Yong
Created OFBIZ-12099 for this new feature. On 2020/12/20 07:41:03, James Yong wrote: > Hi all, > > Thanks for the feedbacks. > > Plan to allow freemarker square interpolation syntax, i.e. [=...], > when the template filename extension is '.sqi.ftl'. > So it wil

Re: Change ${...} to [=...] for freemarker template

2020-12-19 Thread James Yong
Regards, James On 2020/12/15 12:38:32, James Yong wrote: > Hi Michael, > > Please see my reply inline. > > Regards, > James > > On 2020/12/14 08:12:26, Michael Brohl wrote: > > Hi James, > > > > I cannot recall having any problems with tha

Re: Change ${...} to [=...] for freemarker template

2020-12-15 Thread James Yong
t; codebase. Wouldn't it be possible to use both ways, leaving it up to the > developer to use the [=...] Syntax where necessary? [James] Let me check this possibility.. > > Best regards, > > Michael Brohl > > ecomify GmbH - www.ecomify.de > > > Am 12.12

Re: Change ${...} to [=...] for freemarker template

2020-12-12 Thread James Yong
t; *HotWax Systems* > *Enterprise open source experts* > http://www.hotwaxsystems.com > > > On Sat, Dec 12, 2020 at 3:59 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi James, > > > > I see no problems with that: +1 > > > > Jacques

Change ${...} to [=...] for freemarker template

2020-12-12 Thread James Yong
Hi all, Currently interpolation syntax used for freemarker template is ${...}. This is the same as the interpolation syntax for template literal in javascript. As a result, extra coding is needed to escape the interpolation expression for javascript coding with freemarker template. Propose to

Re: Can't build OFBiz

2020-12-07 Thread James Yong
Hi Tomek, Thanks for reporting. The issue is fixed in trunk. Regards, James On 2020/12/07 14:58:31, Tomek wrote: > > On 07.12.2020 13:41, Aditya Sharma wrote: > > Hi Tomek, > > > Hi > > > > I would recommend you to ask such queries on the user mailing as the > > list is intended for such

Re: Remove datejs

2020-11-26 Thread James Yong
Hi all, Will load language-specific js for date.js only when required. Created OFBIZ-12064 for it. Regards, James On 2020/11/21 06:47:48, James Yong wrote: > Hi Michael, > > You are right. Found one dependency with datetimepicker. > Will check further.. > > Thanks, >

Re: Remove datejs

2020-11-20 Thread James Yong
> Michael Brohl > > ecomify GmbH - www.ecomify.de > > > Am 19.11.20 um 18:07 schrieb Jacques Le Roux: > > Hi James, > > > > Though I did not find when it was removed, sounds good to me > > > > Thanks > > > > Jacques > > > > L

Remove datejs

2020-11-19 Thread James Yong
Hi all, Javascript library at themes/common-themes/webapp/common/js/jquery/plugins/datejs doesn't seem to be in use. Suggest to remove it, along with some language-specific code in JsLanguageFilesMapping.java etc. Regards, James

Re: Re: Default ordering of webapps titles in main menu

2020-10-15 Thread James Yong
ortance. If we agree we should discuss the OOTB order of importance of > > applications webapps and then plugins. > > > > I think we can quickly agree, and hope it would not open a Pandora box :) > > > > Also the feature should be easily changed by custom proj

Re: Default ordering of webapps titles in main menu

2020-10-10 Thread James Yong
Hi Jacques, What kind of ordering are you looking for the webapp menu items? Customer specific ordering? Regards, James On 2020/10/08 10:34:08, Jacques Le Roux wrote: > Hi, > > Today Deepak answered on user ML > https://markmail.org/message/syzvyyueheejyyce how to order webapps titles in >

Re: Open FTL file from the browser

2020-09-21 Thread James Yong
I put <> > >>>> I got no result but a JavaScript message saying "Source file opened". Do > >>>> I miss something? How would it be for Eclipse? > >>>> > >>>> Also I don't think it should be enabled OOTB (ie NONE should be used)

Re: buildbot failure in on ofbizTrunkFramework

2020-09-19 Thread James Yong
t; Buildslave for this Build: asf947_ubuntu > > > > Build Reason: The AnyBranchScheduler scheduler named > > 'onTrunkFrameworkCommit' triggered this build > > Build Source Stamp: [branch trunk] 347c9056743b63c7898f5e5dc52cd31193b55258 > > Blamelist: James Yong > > > > BUILD FAILED: failed testIntegration > > > > Sincerely, > > -The Buildbot > > > > > > >

Open FTL file from the browser

2020-09-19 Thread James Yong
Hi all, Propose to allow developer to open FTL source file from the browser. This saves times locating for the template in the IDE. JIRA issue is created at OFBIZ-12018 with patch file. Regards, James

Re: Add border and file name on content rendered from ftl

2020-09-13 Thread James Yong
> > IMO it is also possible to view the iriginally loaded source code in the > web developer tools inside the browser without reloading as it is done > in the view source feature. > > Thanks, > > Michael > > > Am 11.09.20 um 17:13 schrieb James Yong: > > H

Add border and file name on content rendered from ftl

2020-09-11 Thread James Yong
Hi all, There are comments containing file names around contents generated from ftl files. But we need to open the page source from browser to see these comments. The browser will re-fetch the page source from the server and hit error if the page is expecting a POST submission. It would be eas

Re: Re: need help to test my patch

2020-08-23 Thread James Yong
Hi Alex, After choosing the mentioned item and clicking 'Add to Order', you should be able to see the ftl included in the screen. Can add some text in the ftl to identify it. Don't think productdetail.ftl is used during finalize order. Regards, James On 2020/08/23 16:52:01, Alex Bodnaru wro

Re: need help to test my patch

2020-08-23 Thread James Yong
Hi Alex, Please see my reply inline. Regards, James On 2020/08/23 12:53:05, Alex Bodnaru wrote: > hello friends, > I'd like to test a change in > application/order/template/entry/catalog/ProductDetail.ftl. Go to "Order Entry" and proceed with the Sales Order. Choose "WG-9943" then click "Add t

Re: Replace Mask Js

2020-08-18 Thread James Yong
Thanks Jacques. Created OFBIZ-11964 for it. Regards, James On 2020/08/18 14:59:45, Jacques Le Roux wrote: > +1 > > I see no problems with that > > Jacques > > Le 18/08/2020 à 15:08, James Yong a écrit : > > Hi all, > > > > Would like to propose repl

Replace Mask Js

2020-08-18 Thread James Yong
Hi all, Would like to propose replacing github.com/igorescobar/jQuery-Mask-Plugin with https://github.com/RobinHerbots/Inputmask With the current library, I am not able to load using the new importLibrary function in ofbizUtil.js. The mask function seems only used in the page at /example/contro

Re: checkNewPassword and ignoreCurrentPassword

2020-07-12 Thread James Yong
Hi Jacques, There is a number of reports relating to CSRF. To reduce the number of false positive security alerts, I think the CSRF defense should be turned on in the demo. I feel there should be additional verification like checking current password when the user is doing password change. Ple

Re: Add notice on previous repository

2020-06-22 Thread James Yong
e/ofbiz-plugins > > Jacques > > Le 08/05/2020 à 17:48, James Yong a écrit : > > Hi Jacques, > > > > Done at INFRA-20244 > > > > Regards, > > James > > > > On 2020/05/08 15:08:39, Jacques Le Roux > > wrote: > >> I

Re: Use Compound Widget on rest of the project

2020-06-17 Thread James Yong
> On 14/06/2020 08:47, Jacques Le Roux wrote: > > Hi James, > > > > I see you pushed changes for FindRequest. Maybe we should wait a bit > > feedback from others? > > > > Jacques > > > > Le 14/06/2020 à 05:18, James Yong a écrit : > >> Hi J

Re: Use Compound Widget on rest of the project

2020-06-17 Thread James Yong
xampleFeatureAppl > I'm waiting for more time using them to say if it's the correct group size or > not. > > So I suggest to use compound Widget, but not convert all xml files > immediately, we need more developer experience to find the correct group size. > > Regar

Re: Use Compound Widget on rest of the project

2020-06-14 Thread James Yong
Hi Jacques, Ok sure. Will wait then. Regards, James On 2020/06/14 06:47:27, Jacques Le Roux wrote: > Hi James, > > I see you pushed changes for FindRequest. Maybe we should wait a bit feedback > from others? > > Jacques > > Le 14/06/2020 à 05:18, James Yong

Re: Use Compound Widget on rest of the project

2020-06-13 Thread James Yong
Hi Jacques, Ok, I created OFBIZ-11821 for this. Regards, James On 2020/06/13 18:03:21, Jacques Le Roux wrote: > Hi James, > > As a 1st thought I'd see no problem with that. > > Jacques > > Le 13/06/2020 à 14:32, James Yong a écrit : > > Hi all, > >

Use Compound Widget on rest of the project

2020-06-13 Thread James Yong
Hi all, Currently, compound widget tag is only used in Examples application. Propose to convert rest of the project to use compound widget, so that dependencies are grouped together. Regards, James

Re: Allow definition of external style sheet in multi-block html template

2020-06-10 Thread James Yong
Hi all, I have created OFBIZ-11819 for this. Regards, James On 2020/06/06 12:05:33, James Yong wrote: > Hi all, > > Some external style sheets defined in layoutSettings.styleSheets are > page-specific. > E.g. jquery.jgrowl-1.4.6.min.css, select2-4.0.6.css > > Propos

Allow definition of external style sheet in multi-block html template

2020-06-06 Thread James Yong
Hi all, Some external style sheets defined in layoutSettings.styleSheets are page-specific. E.g. jquery.jgrowl-1.4.6.min.css, select2-4.0.6.css Propose new function to set the external style sheet in multi-block html template. Regards, James

Re: Unused location="${parameters.quoteDecoratorLocation}"

2020-06-06 Thread James Yong
I see no reasons to keep it either > > Jacques > > Le 06/06/2020 à 07:06, James Yong a écrit : > > Hi all, > > > > There are decorator screens with location > > ${parameters.quoteDecoratorLocation} i.e. > > > location="${parameters.quoteDecor

Unused location="${parameters.quoteDecoratorLocation}"

2020-06-05 Thread James Yong
Hi all, There are decorator screens with location ${parameters.quoteDecoratorLocation} i.e. But quoteDecoratorLocation variable isn't set anywhere in the project. Suggest to remove the location when value is "${parameters.quoteDecoratorLocation}". Regards, James

Re: linting issues on ‘trunk’, ‘gradlew check’ fails.

2020-06-05 Thread James Yong
Hi all, +1 to INFRA-20314. Committer should install a checkstyle plugin in the IDE pointing to our checkstyle.xml. This helps to highlight Lint errors so that style issues can be corrected early. Regards, James On 2020/06/05 17:30:18, Jacques Le Roux wrote: > Hi All, > > Since then we also

Re: Allow external script in multi-block html template to be headerized

2020-05-25 Thread James Yong
Hi all, Created JIRA issue OFBIZ-11741. Also uploaded a patch usimg jstree library as example. The library will only be loaded when required. Regards, James On 2020/05/25 15:34:01, James Yong wrote: > Hi all, > > Currently setting multi-block=true for the html-template, allo

Allow external script in multi-block html template to be headerized

2020-05-25 Thread James Yong
Hi all, Currently setting multi-block=true for the html-template, allows inline script within the freemarker to be transformed to an external script. This helps to reduce the CSP errors. Propose to allow external scripts within the multi-block html template, to be rendered within the html head

Re: Modify OFBiz commit message template

2020-05-20 Thread James Yong
+1 to [Implemented | Improved | Fixed | Completed| Documented | Reverted]: [Jira title | Free text] [(OFBIZ-)] [More detailed explanation of what has been done and what the fix achieves, sideeffects etc.] [Thanks:] [ for ... and for] Regards, James On 2020/05/20 09:01

Re: FTL not work after: commit branch trunk updated: Improved: <script-template> widget tag (OFBIZ-11686)

2020-05-18 Thread James Yong
ded to refs/heads/trunk by this push: > > new 60c78d2 Improved: widget tag (OFBIZ-11686) > > 60c78d2 is described below > > > > commit 60c78d24be4ab2b4f8aa2f6603968863c12b9b92 > > Author: James Yong > > AuthorDate: Fri May 15 11:16:15 2020 +0800 > &g

Re: Refactoring for externalKeyParam

2020-05-17 Thread James Yong
Hi all, Created JIRA issue OFBIZ-11711 for this. Also added patch for ofbiz-framework. Regards, James On 2020/05/17 03:50:47, James Yong wrote: > Hi all, > > OfbizUrl macro can add externalKeyParam to the link when required > So planning to remove externalKeyParam from content

Refactoring for externalKeyParam

2020-05-16 Thread James Yong
Hi all, OfbizUrl macro can add externalKeyParam to the link when required So planning to remove externalKeyParam from content of ofbizUrl calls. Regards, James

Re: Chapter two: Rules to dynamize screen

2020-05-15 Thread James Yong
Hi Gil, Sorry for the late reply. I agree that button actions should be decoupled from forms. Shall we continue with Part 3? Regards, James On 2020/01/10 17:58:59, Gil Portenseigne wrote: > Hello ! > > In previous thread we focused on the process of how to define a dynamic > workflow that ra

Re: [ofbiz-framework] branch trunk updated: Improved: <script-template> widget tag (OFBIZ-11686)

2020-05-14 Thread James Yong
Hi Jacques, Will do. Thanks, James On 2020/05/14 11:20:55, Jacques Le Roux wrote: > Thanks Olivier, > > It works: > > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1354 > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1354/steps/shell_3/logs/stdio > > Bu

Re: new <script-template> widget

2020-05-14 Thread James Yong
be then done... > > Jacques > > Le 11/05/2020 à 12:21, James Yong a écrit : > > Hi Jacques, > > > > I think having RequireJs for loading dependencies, can go in another JIRA > > issue. > > It requires us to change the way Javascript coding is done. >

Re: new <script-template> widget

2020-05-11 Thread James Yong
mentioned. But could not some > these of these scripts be handled by Require.js? > > Jacques > > Le 10/05/2020 à 14:32, James Yong a écrit : > > Hi Michael, > > > > There are CSP errors being logged in the browser console, due to the use of > > inline javasc

Re: new <script-template> widget

2020-05-10 Thread James Yong
a decorator? > > Thanks, > > Michael Brohl > > ecomify GmbH - www.ecomify.de > > > Am 10.05.20 um 06:53 schrieb James Yong: > > Hi all, > > > > I have created a JIRA issue for this, i.e. OFBIZ-11686. > > Decided not to have a placement att

Re: new <script-template> widget

2020-05-09 Thread James Yong
Hi all, I have created a JIRA issue for this, i.e. OFBIZ-11686. Decided not to have a placement attribute because script will always be placed after body tag. Regards, James On 2020/05/07 11:48:32, James Yong wrote: > Hi all, > > Propose a new widget tag that adds an extern

Re: Add notice on previous repository

2020-05-08 Thread James Yong
Hi Jacques, Done at INFRA-20244 Regards, James On 2020/05/08 15:08:39, Jacques Le Roux wrote: > I guess that's us to do that after > > Le 08/05/2020 à 17:02, James Yong a écrit : > > Hi Jacques, > > > > Ok, can. Will Infra be able to change the description tha

Re: Add notice on previous repository

2020-05-08 Thread James Yong
s > > Le 06/05/2020 à 20:57, Jacques Le Roux a écrit : > > James, > > > > We can simply change the README.md. It's also recommended to close all PRs, > > a bit tedious... > > > > Jacques > > > > Le 06/05/2020 à 17:43, James Yong a écrit : &g

new widget

2020-05-07 Thread James Yong
Hi all, Propose a new widget tag that adds an external script inside html head tag, or after body tag. The external script will contain the rendered result of the specified template file location. e.g. This will allow inline script from a freemarker file, to

Re: Theme files loading taking longer time

2020-05-06 Thread James Yong
Hi Pawan, +1 to the use of more specific basePath for the search Regards, James On 2020/05/06 11:33:15, Pawan Verma wrote: > Hello Devs, > > Greetings for the day, I hope you all are doing well in this pandemic > situation. > > I wanted to bring your attention to a case where it takes a lot

Re: new <html-script> widget

2020-05-06 Thread James Yong
js file on screen and can be included in the header. > > Am I missing something here? > > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org > > > On Wed, May 6, 2020 at 10:03 PM James Yong wrote: > > > Hi all, > > > > There ar

new widget

2020-05-06 Thread James Yong
Hi all, There are javascript files that only applies to a specific screen. While the javascript can be added via ftl templates, the Content Security Policy will need to be relaxed to allow inline scripts. Using requireJs is not an appropriate solution as there is little reusability between diff

Re: Add notice on previous repository

2020-05-06 Thread James Yong
, > > > > I try... > > > > Jacques > > > > Le 06/05/2020 à 15:10, James Yong a écrit : > >> Hi all, > >> > >> Thanks for the feedbacks. > >> Who can access and make the change? > >> > >> Regards, > >> Jam

Re: Add notice on previous repository

2020-05-06 Thread James Yong
> > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org > > > On Mon, May 4, 2020 at 8:54 PM Jacques Le Roux > wrote: > > > Le 04/05/2020 à 15:16, James Yong a écrit : > > > Hi all, > > > > > > I saw some recent PR fro

Re: Upgrade Gradle and Groovy

2020-05-06 Thread James Yong
Thanks Jacques. I have created OFBIZ-11661 for this. Correction: Groovy version used in OFBiz trunk is 2.5.8, not 2.5.4 On 2020/05/04 13:10:42, Jacques Le Roux wrote: > Hi James, > > I trust a Jira fits > > Thanks > > Jacques > > Le 04/05/2020 à 14:54, Jame

Add notice on previous repository

2020-05-04 Thread James Yong
Hi all, I saw some recent PR from https://github.com/apache/ofbiz Suggest to add a notice to indicate the repository is old and for user to use https://github.com/apache/ofbiz-framework instead. Regards, James

Upgrade Gradle and Groovy

2020-05-04 Thread James Yong
Hi all, Current Gradle version used in OFBiz trunk is 5.0. Propose to update to Gradle 6.3 which is the current stable version. Gradle 6.3 requires groovy 2.5.10., but Groovy version used in OFBiz trunk is 2.5.4 Suggest to upgrade Groovy to 2.5.11 which is the current stable version. For Gradle

Re: Welcome James Young as new PMC member

2020-04-22 Thread James Yong
Hi all, Thank you for your words of congratulations. Hope everyone is well and safe. Also thanks PMC for the kind invitation. Looking forward to deeper collaboration. Regards, James On 2020/04/22 10:16:36, Deepak Nigam wrote: > Congratulations James!!! > > Regards > -- > Deepak Nigam > > >

Re: [DISCUSSION] Make Back-Office screens dynamic

2020-04-09 Thread James Yong
Hi all, Done some refactoring for OFBIZ-11409: POC for Dynamic Screen Using MVVM to allow multiple view models working together. Will prepare a PR if there is community interest. Regards, James On 2020/03/15 01:01:43, James Yong wrote: > Hi all, > > Updated the patch for OFBIZ-1

Re: [TEST] Test "POC for CSRF Token"

2020-04-04 Thread James Yong
alse" must remain) we need to decide if should set the CSRF token > check to false. > > Anyway it does not hinder our work on CSRF, but I feel I now miss something > that I wanted to say then, just an intuitive feeling, certainly nothing > serious > > I think we are r

Re: [TEST] Test "POC for CSRF Token"

2020-03-28 Thread James Yong
> Apart that my > https://github.com/JacquesLeRoux/ofbiz-framework/tree/POC-for-CSRF-Token-OFBIZ-11306 > branch is ready to create a PR. We can't wait too > long about those 2 points, even if the 2nd needs a "bit" of work. Anyway, for > now I'll wait answers,

Re: [TEST] Test "POC for CSRF Token"

2020-03-25 Thread James Yong
+1 with CSRF defense enabled in Demo > Hi, > > I thought about that a bit more. I suggest to let the stable version (soon, > R17) as is, ie with  CSRF defense enabled. This way users, mostly > interested in stable, would  see the real situation. > > And to use the NoCsrfDefenseStrategy in tru

Re: Adopting Github Workflow

2020-03-18 Thread James Yong
Hi all, I personally feel we should allow both JIRA and Github for issue management, and let contributers use their own judgement on which one to use. JIRA contains wealth of information and many open issues for review, while Github allows easier review of source codes. So do either JIRA + Pat

Re: [DISCUSSION] Make Back-Office screens dynamic

2020-03-14 Thread James Yong
Hi all, Updated the patch for OFBIZ-11409: POC for Dynamic Screen Using MVVM. I think is worth checking out. Regards, James On 2020/02/23 14:58:55, James Yong wrote: > Hi all, > > I have created a JIRA issue for it > i.e. OFBIZ-11409: POC for Dynamic Screen Using MVVM. > >

Re: Re: OFBIZ-4035: change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander

2020-03-02 Thread James Yong
+1 On 2020/03/02 16:52:08 Daniel Watford wrote: > Hi Mathieu, > > Yes I agree that mocking of static methods is an indicator of refactoring > needed. > > There are always exceptions to every rule, but in this case with > MacroFormRenderer longer than > 3000 lines in R18 and its role is to map fr

Re: [DISCUSSION] Make Back-Office screens dynamic

2020-02-23 Thread James Yong
look into all details, but this one looks good indeed. > > Thanks > > Jacques > > Le 14/01/2020 à 16:49, James Yong a écrit : > > Hi Jacques, > > > > Found another JQuery friendly MVVM framework to consider: > > https://knockoutjs.com/. > > Support

Re: Removing “base/config/component-load.xml”

2020-01-29 Thread James Yong
Added my comments on the technical aspects of the proposal at https://issues.apache.org/jira/browse/OFBIZ-11296 On 2020/01/29 08:26:00, Jacques Le Roux wrote: > Hi Mathieu, Samuel, > > You were the most visible proponents of this. After 5 days w/o exchanges > should we consider the idea is ab

Re: [VOTE] Do not release R17 and directly publish R18 instead.

2020-01-27 Thread James Yong
+1 Regards, James On 2020/01/24 10:27:15, Jacques Le Roux wrote: > Hi, > > R16 is now an old distribution and has almost reached its end of support. We > can soon expect a last release but we need to think about the next to be > released package > > Some would prefer to release R17 before r

Re: [DISCUSSION] Make Back-Office screens dynamic

2020-01-14 Thread James Yong
Hi Jacques, Found another JQuery friendly MVVM framework to consider: https://knockoutjs.com/. Support data-binding and computed properties etc. Regards, James On 2020/01/11 12:56:24, James Yong wrote: > Hi Jacques, > > Points taken. > > Thanks, > James > >

Re: [DISCUSSION] Make Back-Office screens dynamic

2020-01-11 Thread James Yong
ps://bower.io/blog/2017/how-to-migrate-away-from-bower/>! " > > > > And npm warns about it > > > > Jacques > > > > > > Le 11/01/2020 à 10:32, Jacques Le Roux a écrit : > >> I remember having read about MVVM years ago, quite interesting, than

Re: [DISCUSSION] Make Back-Office screens dynamic

2020-01-10 Thread James Yong
Hi Gil, I wonder if this library helps for a start: https://github.com/joshualjohnson/jquery.x Regards, James On 2019/12/13 15:52:38, Gil Portenseigne wrote: > Chapter One: How to manage the updating area > > Hello, > > After different discussions already listed by Taher [1-9], Leila, > Nico

Re: question about ServiceHandler.checkSecureParameter

2019-12-08 Thread James Yong
mes, > > Thanks for your detailed analysis and proposition. > > Le 26/11/2019 à 17:26, James Yong a écrit : > > Hi Jacques, all, > > > > Haven't look into the POC yet. Please see the following updates: > > > > 1. Not a good practice to allow state-chang

Re: question about ServiceHandler.checkSecureParameter

2019-11-26 Thread James Yong
mes, > > I see no reasons for you to not open a Jira and provide a patch, other > opinions may vary... > > Jacques > > Le 08/11/2019 à 17:46, James Yong a écrit : > > Hi Jacques, > > > > Inline... > > > > On 2019/11/06 18:28:26, Jacques Le Roux

Re: question about ServiceHandler.checkSecureParameter

2019-11-08 Thread James Yong
Hi Jacques, Inline... On 2019/11/06 18:28:26, Jacques Le Roux wrote: > Hi James, > > Inline... > > Le 06/11/2019 à 17:53, James Yong a écrit : > > Hi Jacques, > > > > Understand the intent of checkSecureParameter function is to avoid > > sensitive

Re: question about ServiceHandler.checkSecureParameter

2019-11-07 Thread James Yong
implemented for GET method. Regards, James On 2019/11/06 19:24:23, Mathieu Lirzin wrote: > Hello James, > > James Yong writes: > > > Understand the intent of checkSecureParameter function is to avoid > > sensitive information > > in the URL during POST method. A

Re: question about ServiceHandler.checkSecureParameter

2019-11-06 Thread James Yong
to > prevent a query string for a > particular event then false can be used. > > I'm not sure much people will care of that, not sure what others think... > > Jacques > > Le 05/11/2019 à 01:28, James Yong a écrit : > > Hi Jacques, Samuel, all, > >

Re: question about ServiceHandler.checkSecureParameter

2019-11-04 Thread James Yong
Hi Jacques, Samuel, all, I think the security concerns raised are valid. However we can look into adding an attribute when the url parameter check isn’t required. For example, 
 
 … Regards, James On 2019/10/31 14:20:11, Jacques Le Roux wrote: > Hi Samuel, > > You can go ahead

Re: Oracle Java release model changes and consequences for the project

2018-10-24 Thread James Yong
Answering my last question. >From the download page for Oracle JDK 11, demo purpose is allowed. On 2018/10/24 07:38:19, James Yong wrote: > Hi all, > > Will the release model and licensing changes impact our demos hosted with > Apache Software Foundation? > > Regards,

Re: Oracle Java release model changes and consequences for the project

2018-10-24 Thread James Yong
Hi all, Will the release model and licensing changes impact our demos hosted with Apache Software Foundation? Regards, James On 2018/10/24 06:54:05, James Yong wrote: > Hi all, > > OFBiz can be used as an application framework and not all business use-case > justify the yearly

Re: Oracle Java release model changes and consequences for the project

2018-10-23 Thread James Yong
Hi all, OFBiz can be used as an application framework and not all business use-case justify the yearly price-tag of Oracle JDK. Given that more products(1) are moving to support OpenJDK, should OFBiz follow? Regards, James (1) See plan of Atlasians product to support OpenJDK https://community.

Re: [PROPOSITION] Demos: replace old by trunk framework only

2018-08-23 Thread James Yong
Not sure why my 1st post didn't get through. So reposting again.. Hi all, Good discussion so far. I am in favour of having a proper solution from start rather than a stopgap. Propose something similar to what Nicolas mentioned but making use of a fragment-type plugin framework like https://p

Re: Gradle ‘gretty’ Plugin

2018-07-26 Thread James Yong
Hi Mathieu, Have you looked into http://dcevm.github.io/ ? No comment about gretty as I haven't tried. Regards, James Yong On 2018/07/26 09:08:44, Mathieu Lirzin wrote: > Hello, > > Being a bit frustrated by the slowness of having to stop/compile/restart > OFBiz manually

Re: Tomcat SSO

2018-06-20 Thread James Yong
Hi all, I have uploaded a patch to support SSO when OFBiz is clustered. Please see https://issues.apache.org/jira/browse/OFBIZ-10123 for patch and further discussion. Regards, James Yong On 2017/12/10 15:42:32, "James Yong" wrote: > Hi Taher, all, > > Sorry for the l

Re: [Discussion] Introduction of Bootstrap and Vue.js

2018-05-22 Thread James Yong
Hi All, My humble opinion is to switch to using JSON object to submit/retrieve form/table data to the server. With this change, it will be easier to introduce VUE later. Also try not to introduce any further jQuery dependency. Regards, James On 2018/05/21 20:09:43, Gavin Mabie wrote: > On Mo

Re: RE: RE: RE: Quantity missing for inventory transfer records

2018-04-25 Thread James Yong
t entity: For the tax. Regards, James Yong On 2018/04/24 08:20:44, Pawan Verma wrote: > Here is the right link for the subtask OFBIZ-10365< > https://issues.apache.org/jira/browse/OFBIZ-10365>. > > -- > Thanks and Regards, > > *Pawan Verma* | Sr. Enterprise Softwa

Re: Tree View of Call Graph for Services and Simple Methods

2018-04-21 Thread James Yong
Hi all, POC at https://issues.apache.org/jira/projects/OFBIZ/issues/OFBIZ-10351 Regards, James On 2018/04/19 06:26:50, James Yong wrote: > Hi all, > > I have uploaded a patch for POC. > > Thanks, > James Yong > > On 2017/12/29 20:53:37, Jacques Le Roux wrote:

Re: Tree View of Call Graph for Services and Simple Methods

2018-04-19 Thread James Yong
Hi Swapnil, Thanks for testing the patch. Regards, James Yong On 2018/04/19 10:36:37, Swapnil Mane wrote: > Hi James, > > Thanks for your contribution. > I have applied the patch locally and functionality wise it is working > really nice! :) > > > - Best R

Re: Tree View of Call Graph for Services and Simple Methods

2018-04-18 Thread James Yong
Hi Paul and all, Currently the output is logged directly in the console. Haven't looked into the capturing of parameter values but I think is a good idea. Feedbacks welcome for further usability and improvement. Regards, James Yong On 2018/01/03 00:22:26, Paul Foxworthy wrote: >

Re: Tree View of Call Graph for Services and Simple Methods

2018-04-18 Thread James Yong
Hi all, I have uploaded a patch for POC. Thanks, James Yong On 2017/12/29 20:53:37, Jacques Le Roux wrote: > Hi James, > > I think it deserves a POC in a Jira > > +1 > > Jacques > > > Le 23/12/2017 à 17:37, James Yong a écrit : > > Hi All, > > &

  1   2   3   4   >