[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

sion: 922887 > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org/jira/browse/LUCENE-2037 > Project: Lucene - Java > Issue Type: Improvement >

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

test if all ported test classes have all @Test added to all methods starting with "test". > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.or

[jira] Issue Comment Edited: (LUCENE-2037) Allow Junit4 tests in our environment.

ence :-). Yesterday I also wrote an extra test assertion, that verifies, that the ported test class has all methods starting with "test" annotated with @Test. Robert and me wants to maybe apply this patch during the migration phase when developers are not yet using Junit4 so long and forget to add @

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

that verifies, that the prorted testcase has all methods starting with "test" assigned a @Test. Robert and me wants to maybe apply this patch during the migration phase when developers are not yet using Junit4 so long and forget to add @Test. The path is very rough and maybe optimized (i

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

s exactly what you made LuceneTestCaseJ4.getName() do . But at least I found Kent Beck's version of the docs, which is a plus... So I guess there's nothing to do as far as getName is concerned If there is, let me know Erick > Allow Junit4 tests in our environment. &g

Re: [jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

cusedCommentId=12838872#action_12838872] > > Uwe Schindler commented on LUCENE-2037: > --- > > Committed revision: 916685 > > > Allow Junit4 tests in our environment. > > -- > > > >

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

[ https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838872#action_12838872 ] Uwe Schindler commented on LUCENE-2037: --- Committed revision: 916685 > Allow

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

localized one needs this watchman, too, you can siply create a second one. I also made the field final. Now the tests for random failures behave like before. I would like to commit this soon. This change also affects the uncaught exception handler. > Allow Junit4 tests in our environm

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

uot;" as test name. In the past this worked. Ideally it should print ot the current @Test method name as before. How to do this? I would like to have this and remove the getName() stuff from the class. > Allow Junit4 tests in our environment. > -- >

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

TestWatchman. Corrected minor typo in comment. > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org/jira/browse/LUCENE-2037 > Project: Lucene - Java >

[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

gure out for sure. > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from LocalizedTestCase > --- > > Key: LUCENE-2122 >

[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

dson failure: In the past Hudson used an internal junit.jar to do the testing, which was in version 4 (the exact version can only be found out by one with hudson access, Mike?). So Hudson was always using Junit4 for testing even in Lucene 2.9. After the clover updates, we removed this JUnit lib path

[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

ally look at this more... > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from LocalizedTestCase > --- > > Key: LUCENE-2122 >

[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

st I knew your test problems had disappeared, but memory can be tricky > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from LocalizedTestCase > --- > >

Re: [jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

<<>> Agree absolutely. I was just making sure we considered the *possibility* that the paramaterized version was showing an underlying Lucene problem rather than assuming the fault was with Junit4. Having spent a way too much of my programming life being absolutely sure I knew what

Re: [jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

#x27;s anything there > that I can see. > > Erick > > > On Sat, Dec 12, 2009 at 8:55 AM, Robert Muir (JIRA) wrote: > >> >> [ >> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] >>

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

- > > *From:* Erick Erickson [mailto:erickerick...@gmail.com] > *Sent:* Sunday, December 13, 2009 4:02 AM > *To:* java-dev@lucene.apache.org > *Subject:* Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for > more thorough Locale testing for classes deriving from Lo

RE: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de _ From: Erick Erickson [mailto:erickerick...@gmail.com] Sent: Sunday, December 13, 2009 4:02 AM To: java-dev@lucene.apache.org Subject: Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

- > > btw, I left 'ant clean test' running in a loop and just checked it with > this patch, no problems. > so perhaps its my own incompetence. Erick can you take a look? Do you see > some obvious problem? > > > > Use JUnit4 capabi

Re: [jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

rg/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > Robert Muir updated LUCENE-2122: > > >Assignee: (was: Robert Muir) > > i am unassigning in case someone else can figure this one out, at my wit

[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

ning in a loop and just checked it with this patch, no problems. so perhaps its my own incompetence. Erick can you take a look? Do you see some obvious problem? > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > fr

[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

, at my wits end here :) perhaps its just something wierd about my environment or something > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from LocalizedTe

[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

happened: 1. i tried to simplify localizedtestcase, so that it works just like the old one, with the exception of using junit4 parameterized facility. 2. i wrote some bad tests and ensured things worked well such as error messages, default locale being run first, etc etc. 3. i had everything good

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

;>>>> I'm running >>>>> on a Macbook Pro... >>>>> >>>>> I wonder if a repeating script would show an intermittent error >>>>> >>>>> Erick >>>>

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

;>>> Erick >>>> >>>> >>>> On Thu, Dec 10, 2009 at 3:10 PM, Robert Muir (JIRA) wrote: >>>> >>>>> >>>>>[ >>>>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jir

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

ttps://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1274#action_1274] >>>> >>>> Robert Muir commented on LUCENE-2122: >>>> - >

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

yed with this patch some and (not intentionally trying) I >>> would get random test failures for TestQueryParser under eclipse... its not >>> really something I am able to repeat though. >>> >>&g

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

ugh. >> >> maybe some race condition (I do not know how eclipse executes >> parameterized tests) ? >> >> if it is a problem with my IDE that is one thing, just makes me a

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

really something I am able to repeat though. > > maybe some race condition (I do not know how eclipse executes parameterized > tests) ? > > if it is a problem with my IDE that is one thing, just makes me a little > nervous right now. trying to think what could cause this

[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

just makes me a little nervous right now. trying to think what could cause this > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from Localiz

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

ll junit 4 attempt to >> print this parameter out in some way so I know that it failed? If not do you >> know of a hack? >> 2. i am thinking about reordering the locale array so that it tests the >> default one first. if you are trying to do some test-driven dev it mig

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

y so that it tests the > default one first. if you are trying to do some test-driven dev it might be > strange if the test fails under a different locale first. I think this one > is obvious, I will play with it to see how it behaves now. >

[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

rent locale first. I think this one is obvious, I will play with it to see how it behaves now. > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from Localiz

[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

base class to collect the different locales. Anyway, this one should be much better Erick > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from LocalizedTe

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

0] > > Robert Muir commented on LUCENE-2122: > - > > Hi Erick, in the Date tools test I think you can delete the public static > Collection data(), I think you might have accidentally included > it? > > > > Use JUnit4 capab

[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

you can delete the public static Collection data(), I think you might have accidentally included it? > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from Localiz

[jira] Assigned: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reassigned LUCENE-2122: --- Assignee: Robert Muir (was: Erick Erickson) > Use JUnit4 capabilites for more thoro

[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-2122: --- Attachment: LUCENE-2122-r3.patch Made LocalizedTestCase abstract... > Use JUn

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

are changing it on the fly here. >>> >>> this was stashed away here before: >>> {code} >>> /** >>> * Before changing the default Locale, save the default Locale here so >>> that it >>> * can be restored. >>> */ >

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786757#action_12786757] > > Robert Muir commented on LUCENE-2122: > - > > Erick do you think LocalizedTestCase should be abstract? > > > Us

[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

d be abstract? > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from LocalizedTestCase > --- > > Key: LUCENE-2122 >

[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

been run. Thanks Robert! > Use JUnit4 capabilites for more thorough Locale testing for classes deriving > from LocalizedTestCase > --- > > Key: LUCENE-2122 >

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

*/ >> private final Locale defaultLocale = Locale.getDefault(); >> {code} >> >> and restored in tearDown()... otherwise strange things could happen, such >> as your IDE could go bonkers after running the tests! (but maybe I am >> missing something) >> >>

Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

pen, such > as your IDE could go bonkers after running the tests! (but maybe I am > missing something) > > > Use JUnit4 capabilites for more thorough Locale testing for classes > deriving from LocalizedTestCase > > > ---

[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

that it * can be restored. */ private final Locale defaultLocale = Locale.getDefault(); {code} and restored in tearDown()... otherwise strange things could happen, such as your IDE could go bonkers after running the tests! (but maybe I am missing something) > Use JUnit4 capabilites f

[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

contrib) that derive from LocalizedTestCase. LocalizedTestCase now tests all test methods in all derived classes against all available Locales. If we want some of the tests to NOT run against all locales, we'd need to refactor them into their own test class > Use JUnit4 capabilites

[jira] Created: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase

Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase --- Key: LUCENE-2122 URL: https://issues.apache.org/jira/browse

[jira] Resolved: (LUCENE-2037) Allow Junit4 tests in our environment.

[ https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-2037. Resolution: Fixed > Allow Junit4 tests in our environm

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

anks Erick & Kay Kay! I'll commit shortly. > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org/jira/browse/LUCENE-2037 > Project: Lucene - Java >

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

x27;s changes, All tests pass. Junit 3.X no longer necessary, running with Junit 4.7 jar runs junit 3 style tests as well as annotated Junit4 style tests. It's preferable (but not necessary) to import from org.junit rather than junit.framework. > Allow Junit4 tests in ou

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

once you've had a chance to review/iterate, I plan to commit... then we can make use of junit4 features in our tests. > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apach

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

[ https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-2037: Attachment: LUCENE-2037_revised_2.patch > Allow Junit4 tests in our environm

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

[ https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-2037: Attachment: (was: LUCENE-2037_revised_2.patch) > Allow Junit4 tests in our environm

Re: (LUCENE-2037) Allow Junit4 tests in our environment.

Sure, but it won't be until late Saturday at the earliest, more likely Sunday. Got a busy Fri/Sat Erick On Fri, Dec 4, 2009 at 3:34 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > Thanks Kay Kay! Erick can you have a look / iterate? Thanks. > > Mike > > On Fri, Dec 4, 2009 at

Re: (LUCENE-2037) Allow Junit4 tests in our environment.

Thanks Kay Kay! Erick can you have a look / iterate? Thanks. Mike On Fri, Dec 4, 2009 at 3:30 PM, Kay Kay wrote: > Erick / Mike - >  With 2065 commited onto trunk now - I created another patch for 2037 and > attached in the ticket. > 3 classes remain pending though due to conflicts , that I ha

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

of no-arg ctor in TestCustomQuery . > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org/jira/browse/LUCENE-2037 > Project: Lucene - Java >

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

[ https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kay Kay updated LUCENE-2037: Attachment: (was: LUCENE-2037_revised_1.patch) > Allow Junit4 tests in our environm

Re: (LUCENE-2037) Allow Junit4 tests in our environment.

Erick / Mike - With 2065 commited onto trunk now - I created another patch for 2037 and attached in the ticket. 3 classes remain pending though due to conflicts , that I had listed with the patch. But we can probably revisit them subsequently. Please review them to serve as a starting point

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

: * TestCustomScoreQuery * TestFieldScoreQuery * TestDocValues patches have been removed due to conflicts. Should be able to revisit them separately again soon. > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 >

Re: (LUCENE-2037) Allow Junit4 tests in our environment.

OK I'll apply 2065 first, then we'll iterate on 2037 and get it in -- thanks Erick and Kay Kay! It's wonderful you all are putting in the energy to keep our tests current :) Mike On Thu, Dec 3, 2009 at 9:14 PM, Erick Erickson wrote: > Mike: > > I should be able to create a new 2037 patch pretty

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

this one as well, but, there will be conflicts b/w the two patches, I think. Should we do the generics first (simpler change, but touches many files), and then the junit4 upgrade? Personally I favor the generics patch can go in first since as mentioned - it is a large patchset but very simpl

Re: (LUCENE-2037) Allow Junit4 tests in our environment.

Mike: I should be able to create a new 2037 patch pretty easily if you want to apply 2065 first. Let me know Erick On Thu, Dec 3, 2009 at 9:05 PM, Kay Kay wrote: > Mike - > I have attached another patch to LUCENE-2065 , in sync with the trunk now. > > > > > Erick Erickson wrote: > >> That'

Re: (LUCENE-2037) Allow Junit4 tests in our environment.

Mike - I have attached another patch to LUCENE-2065 , in sync with the trunk now. Erick Erickson wrote: That's up to Mike, whichever way he finds easiest, I'll deal. Erick On Thu, Dec 3, 2009 at 8:43 PM, Kay Kay > wrote: I created Lucene-2065 while work

Re: (LUCENE-2037) Allow Junit4 tests in our environment.

That's up to Mike, whichever way he finds easiest, I'll deal. Erick On Thu, Dec 3, 2009 at 8:43 PM, Kay Kay wrote: > I created Lucene-2065 while working on 1257 , the original generics related > ticket , and since we were running out of time for 3.0 , I guess we could > not get src/test conver

Re: (LUCENE-2037) Allow Junit4 tests in our environment.

I created Lucene-2065 while working on 1257 , the original generics related ticket , and since we were running out of time for 3.0 , I guess we could not get src/test converted in. In any case , if you were comitting this one (2037) to trunk , may be I can wait before creating the patch agai

Re: (LUCENE-2037) Allow Junit4 tests in our environment.

I didn't realize 2065 had already been down this path, thought you were volunteering to change all the code starting from scratch. Your approach sounds like a fine plan. Note that I'm not entirely sure that I cleaned up *everything*, but we need to get to a known state before tackling the rest, so

Re: (LUCENE-2037) Allow Junit4 tests in our environment.

On Thu, Dec 3, 2009 at 5:48 PM, Erick Erickson wrote: > I generified the searches/function files in patch 2037. I don't really think > there's a conflict, just commit my patch and have at generifying the rest. OK so then we'll start with 2037, then take 2065's patch, hopefully updated to current

Re: [jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

port the existing tests to > Java 5 generics > > Ahh thanks for the reminder -- I can take this one as well, but, there will > be conflicts b/w the two patches, I think. Should we do the generics first > (simpler change, but touches many files), and

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

atch - LUCENE-2065 to port the existing tests to Java 5 generics Ahh thanks for the reminder -- I can take this one as well, but, there will be conflicts b/w the two patches, I think. Should we do the generics first (simpler change, but touches many files), and then the junit4 upgrade? >

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

e is another patch - LUCENE-2065 to port the existing tests to Java 5 generics . May be - somebody can have a look at it before it becomes out of sync with the trunk altogether. > Allow Junit4 tests in our environment. > -- > >

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

erns upgrading to Junit4? I plan to commit in a few days... > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org/jira/browse/LUCENE-2037 > Project: Lucene - Java

[jira] Assigned: (LUCENE-2037) Allow Junit4 tests in our environment.

[ https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reassigned LUCENE-2037: -- Assignee: Michael McCandless (was: Erick Erickson) > Allow Junit4 tests

Re: LUCENE-2037 (Junit4 capabilities)

I'll take it. The patch looks good, and tests pass. Thanks Erick, and thanks for the reminder... Mike On Wed, Dec 2, 2009 at 12:52 PM, Erick Erickson wrote: > Is anyone thinking about committing this patch? And/or what do I need to > do/should have done to indicate it's ready for review? > Poo

LUCENE-2037 (Junit4 capabilities)

Is anyone thinking about committing this patch? And/or what do I need to do/should have done to indicate it's ready for review? Poor lonely patch, sitting out there all alone and neglected ... Erick

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

nts right sometime and not have to retype them after making an attachment Anyway, this patch allows us to use Junit4 constructs as well as Junit3 constructs. It includes a sibling class to LuceneTestCase called LuceneTestCaseJ4 that provides the functionality we used to get from LuceneTestCa

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

[ https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-2037: --- Attachment: LUCENE-2037.patch See JIRA comments > Allow Junit4 tests in our environm

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

et a chance to submit a new one, we're straightening out LUCENE-1844 interdependencies between patches. > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

s on not altering what's tested, ie, simply cutover to juni4? And then open new issues for, eg, parameterizing tests across different Versions? If we do that, then Erick if you post your latest patch (that cuts over LocalizedTestCase -> new junit4 capabilities), then is that committab

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

case. I think its important that someone from say Korea, can download lucene source code, and run 'ant test'. how else are they supposed to contribute if this does not work? > Allow Junit4 tests in our environment. > -- > >

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

jink sideways just for fun. Best Erick > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org/jira/browse/LUCENE-2037 > Project: Lucene - Java >

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

all versions , but also in all Locales (m). Produces n x m test runs arrrgh. Any idea? at least the old tokenstream api is done, imagine if you wanted to test version, locales, and tokenstream api :) > Allow Junit4 tests in our envi

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

test compatibility. Problem, it interferes with LoalizedTestCase, because e.g. QueryParser needs a test in all versions (n), but also in all Locales (m). Produces n x m test runs *arrrgh*. Any idea? On the other hand, TestHighlighter only needs the version iteration to test fully. > Allow Junit

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

ut putting common behavior in one place or some nonsense like that . Erick > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org/jira/browse/LUCENE-2037 >

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

ould work without getting into the guts of the @RunWith(value = Parameterized.class) Junit4 annotation. As I understand it, that annotation *on the class* causes the framework to make a call to the static method that provides a list of parameters (annotated with @Parameters). The framework then

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

it Erick > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org/jira/browse/LUCENE-2037 > Project: Lucene - Java > Issue Type: Impro

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

for LocalizedTestCase: Just mark all test to run under all Locales with a Annotation like @AllLocales. looks like Parameterized supports limiting params on a per-method basis via annotation?: http://junit.org/apidocs/org/junit/runners/Parameterized.Parameters.html > Allow Junit4 tests in our envi

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

for LocalizedTestCase: Just mark all test to run under all Locales with a Annotation like @AllLocales. > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org/jira

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

itive tests should be refactored into a separate test class that extends LocalizedTestCase. The ones that are not locale-sensitive could be in a test class that extends LuceneTestCase > Allow Junit4 tests in our environment. > -- > >

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

But I did notice last night that a number of tests in contrib reference LocalizedTestCase (I have two separate projects, core and contrib so it wasn't obvious until I ran the ant task). I'll look into those tonight or tomorrow night. Erick

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

all locales, or maybe sort them so the default one is first, or something else? > Allow Junit4 tests in our environment. > -- > > Key: LUCENE-2037 > URL: https://issues.apache.org/jira/browse/LUCENE-2037 &g

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

feel about 10 seconds as far as LocalizedTestCase is concerned. JUnit4 is really not built to run some tests in a class with the @Parameterized notation and some not, it runs all the tests in the class with all the parameters. In the case of TestQueryParser, which is the only test class I saw that

Re: [jira] Issue Comment Edited: (LUCENE-2037) Allow Junit4 tests in our environment.

CENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778101#action_12778101] > > Robert Muir edited comment on LUCENE-2037 at 11/15/09 1:45 PM: > --- > > Is there some way to use Junit4 parameterized tests to do this > Local

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

[ https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778101#action_12778101 ] Robert Muir commented on LUCENE-2037: - Is there some way to use Junit4 parameter

[jira] Issue Comment Edited: (LUCENE-2037) Allow Junit4 tests in our environment.

5 PM: --- Is there some way to use Junit4 parameterized tests to do this LocalizedTestCase-type thing, so we don't have to override runBare()? was (Author: rcmuir): Is there some way to use Junit4 parameterized tests to do this LocalizedTestCase-type thing, so we don't ha

Re: [jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

uns all analyzer test for > different default versions (iterate over Version enum constants). We need > then something like @TestAllVersions or something like that. If we jump to > JUnit4, we should use the new features for a more elegant solution of these > multiple-run tests. > >

[jira] Commented: (LUCENE-2037) Allow Junit4 tests in our environment.

test now runs all analyzer test for different default versions (iterate over Version enum constants). We need then something like @TestAllVersions or something like that. If we jump to JUnit4, we should use the new features for a more elegant solution of these multiple-run tests. One note: It wo

[jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.

LuceneTestCase. There's a bit of overkill here to emulate the override of runBare in LuceneTestCase, but I thought it was worth it to work out the mechanisms. We'll need to put the lucene 4.7 jar in the right place. > Allow Junit4 tests in ou

Re: Junit4

On Sun, Nov 15, 2009 at 1:19 AM, Erick Erickson wrote: > Well, the patch is in shape to submit, but looking at the various comments > on the 3.0 release, I guess I should wait until 3.0 is actually out the door > before submitting unless someone just can't wait. You can go ahead and upload the pat

Re: Junit4

Well, the patch is in shape to submit, but looking at the various comments on the 3.0 release, I guess I should wait until 3.0 is actually out the door before submitting unless someone just can't wait. How do we include a new jar file in a patch? Best Erick On Fri, Nov 13, 2009 at 6:25 PM, Erick

Re: Junit4

OK thanks for adding me to the ACL. I'll have it tomorrow sometime. Does anyone object to deprecating LuceneTestCase with notations to use LuceneTestCaseJ4? I tried two approaches, both work. Both allow you to use LuceneTestCaseJ4 rather than LuceneTestCase as a superclass, with the caveat you hav

  1   2   >