On Mon, 8 Jul 2024 09:39:11 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Mon, 8 Jul 2024 15:37:04 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Mon, 8 Jul 2024 09:39:11 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Mon, 8 Jul 2024 09:39:11 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Mon, 8 Jul 2024 09:17:55 GMT, Abhishek Kumar wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Javadoc style comment, unused import removed
>
>> The diff modifies the generic `SynthGraphicsUtils.paintText` so
On Thu, 4 Jul 2024 10:22:15 GMT, Ravi Gupta wrote:
>> test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 171:
>>
>>> 169: EventQueue.invokeAndWait(() -> {
>>> 170: frame.dispose();
>>> 171: frame.setVisible(true);
>>
>> I'm not really
On Thu, 4 Jul 2024 10:25:38 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component
On Fri, 5 Jul 2024 19:02:06 GMT, lawrence.andrews wrote:
>> 1) After the fix , I could see the test was launched.
>
> lawrence.andrews has updated the pull request incrementally with one
> additional commit since the last revision:
>
> updated the copyright
Marked as reviewed by aivanov
On Fri, 5 Jul 2024 18:57:49 GMT, lawrence.andrews wrote:
>> 1) After the fix , I could see the test was launched.
>
> lawrence.andrews has updated the pull request incrementally with one
> additional commit since the last revision:
>
> updated the copyright
Looks good to me.
I'd still
On Fri, 5 Jul 2024 10:54:19 GMT, Alexey Ivanov wrote:
> > > This changeset enables hiding / showing mnemonics on JMenuBar only. Do
> > > you plan to update ButtonUI and LabelUI for GTK Look-and-Feel too?
> >
> >
> > Not as a part of this PR. It can be take
On Fri, 5 Jul 2024 11:12:50 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Thu, 4 Jul 2024 18:44:52 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Wed, 3 Jul 2024 04:16:53 GMT, Abhishek Kumar wrote:
> Updated the wild imports. My IDE doesn't indicate if imports are sorted or
> not or if any imports are unused. Does it require to do some settings in IDE?
Perhaps, it depends on how you configured your IDE and the project for JDK. I
On Wed, 3 Jul 2024 11:17:56 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Thu, 4 Jul 2024 13:15:28 GMT, Thomas Stuefe wrote:
> Using memmove is so uncommon that it is usually a clear indication for a
> deliberate choice.
It may still be an accidental choice. I didn't find any code review for
[JDK-6680988](https://bugs.openjdk.org/browse/JDK-6680988) where this
matting awt_Component.cpp
> - Merge branch 'openjdk:master' into patch-10
> - Update src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
>
>Co-authored-by: Alexey Ivanov
> - 8334599
Still looks good, except for the minor formatting comments.
src/java
On Wed, 3 Jul 2024 13:25:27 GMT, Julian Waters wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Component.cpp line 3368:
>>
>>> 3366: BYTE tmpState[256];
>>> 3367: WCHAR wc[2];
>>> 3368: memmove(tmpState, kstate, sizeof(kstate));
>>
>> Using `memcpy` could be more
On Fri, 28 Jun 2024 19:54:37 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove AquaMnemonicHandler class and unused APIs from WinDowsLookAndFeel,
>> copy
On Fri, 28 Jun 2024 11:32:49 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Thu, 27 Jun 2024 10:06:49 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Thu, 27 Jun 2024 13:15:19 GMT, Julian Waters wrote:
> It would be helpful if JNI had a jobject unique_ptr type for C++
But `std::unique_ptr` wasn't available when JNI had been conceived…
It could be added…
The declaration in your sample still looks cumbersome… or _unwieldy_ as you
said.
On Thu, 27 Jun 2024 12:54:55 GMT, Alexey Ivanov wrote:
> > …I believe I was referring to the use of C++'s std::unique_ptr, which has
> > the functionality for cleanup that we need.
>
> Yes, `std::unique_ptr` could be useful for handling automatic deallocation of
On Thu, 27 Jun 2024 11:26:24 GMT, Julian Waters wrote:
> …I believe I was referring to the use of C++'s std::unique_ptr, which has the
> functionality for cleanup that we need.
Yes, `std::unique_ptr` could be useful for handling automatic deallocation of
objects created with the `new`
On Wed, 26 Jun 2024 20:30:55 GMT, Alisen Chung wrote:
> > Yes, there is some disconnect. For all OS (MAC with above changes) print
> > range is working properly only with following values firstPage =0 and
> > lastPage =-1 at **RasterPrinterJob.java** and highly depend on
> >
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation for
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
>
> The former removed the `doIt` flag in #18584, bu
On Wed, 26 Jun 2024 23:42:16 GMT, Alisen Chung wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 640:
>>
>>> 638: HGLOBAL oldG = AwtPrintControl::getPrintHDMode(env, self);
>>> 639: if (setup.hDevMode != oldG) {
>>> 640:
On Thu, 27 Jun 2024 07:40:43 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Wed, 26 Jun 2024 10:40:47 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Wed, 26 Jun 2024 09:52:38 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor
On Wed, 26 Jun 2024 08:36:45 GMT, Prasanta Sadhukhan
wrote:
>> Alisen's concern is valid.
>>
>> What if `setEnabled(false)` is called when `isOneTouchExpandable` is `false`
>> and then `setOneTouchExpandable(true)` is called which adds the buttons? The
>> buttons are enabled when they should
On Wed, 26 Jun 2024 08:43:40 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java
>> line 376:
>>
>>> 374: leftButton.setEnabled(enabled);
>>> 375: }
>>> 376: }
>>
>> Is it possible to override `isEnabled`
On Wed, 26 Jun 2024 09:00:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Wed, 26 Jun 2024 08:40:24 GMT, Abhishek Kumar wrote:
>> Thank you for looking into it. A `MnemonicHandler` class in `sun.swing` or
>> `sun.swing.plaf` package could be a good candidate. The `sun.swing` package
>> contains a lot of support classes for Swing, including `SwingUtilities2` and
On Fri, 21 Jun 2024 07:55:24 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Tue, 25 Jun 2024 15:18:29 GMT, Alexey Ivanov wrote:
>>> In my initial fix, I added the `altProcessor` handler in
>>> `SynthLookAndFeel.initialize` with condition check for GTK L Phil has
>>> suggested not to check for GTK L instead look for some alternate way lik
On Tue, 25 Jun 2024 14:58:53 GMT, Alexey Ivanov wrote:
>>> If RootPane.altPress can be changed dynamically, you can install a
>>> PropertyChangeListener to UIManager.
>>
>> I think it can be changed but is it really required to handle it ?
>> I mean w
On Mon, 24 Jun 2024 07:20:24 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
>> line 751:
>>
>>> 749: * Repaints all the components with the mnemonics in the given
>>> window and all its owned windows.
>>> 750: */
>>> 751:
On Mon, 24 Jun 2024 07:21:49 GMT, Abhishek Kumar wrote:
>>>Requesting the value of RootPane.altPress from UIManager each time
>>>postProcessKeyEvent is called is inefficient, so you can store the value in
>>>altProcessor when look and feel is installed.
>>
>> I guess you are pointing out the
On Mon, 24 Jun 2024 07:19:49 GMT, Abhishek Kumar wrote:
> Should I revert it back to javadoc style comment ?
Absolutely!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1652814116
On Tue, 25 Jun 2024 03:41:05 GMT, Prasanta Sadhukhan
wrote:
> 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19874#pullrequestreview-2138314011
On Thu, 20 Jun 2024 08:29:39 GMT, Julian Waters wrote:
> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a
> memmove decay bug by rewriting a sizeof on an array to an explicit size of
> 256, but this is a bit of a band aid fix. It's come to my attention that in
> C++,
On Mon, 24 Jun 2024 19:32:15 GMT, Nizar Benalla wrote:
> Let me add a new commit to remove the sponsor label
Thank you!
-
PR Comment: https://git.openjdk.org/jdk/pull/19192#issuecomment-2187363695
This is somewhat a continuation for
[JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
[JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
The former removed the `doIt` flag in #18584, but it introduced a regression.
The regression is resolved by the latter in #19786, and
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 15:51:29 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so
On Mon, 24 Jun 2024 05:50:40 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 07:55:24 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Fri, 21 Jun 2024 14:46:33 GMT, Renjith Kannath Pariyangad
wrote:
> I don't think there is any issue with native code, with this change I have
> brought MAC same as other OS.
Hm… It works correctly now. But if a page range is used,
`SunPageSelection.RANGE` is added to attributes. Now it's
On Fri, 21 Jun 2024 18:33:37 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add forRemoval
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 18:08:45 GMT, Phil Race wrote:
> But it means that if we deprecated the consructor with args we'd probably
> want to look at those too. It seems like the ripple effect isn't worth it.
It would clean up the code… Yes, we would need to modify all the subclasses too.
> And
On Thu, 20 Jun 2024 20:03:20 GMT, Phil Race wrote:
>> All I wanted is to bring up the inconsistency so that a few people would
>> take a look at it while reviewing this change.
>
> It does look odd. Focus would need transferring in both cases I'd expect.
> It goes back to the very beginning of
On Fri, 21 Jun 2024 03:17:38 GMT, Prasanta Sadhukhan
wrote:
>> The way it was "before" is that we always returned the value of "doIt". Why
>> not restore that for consistency ?
>
> I believe that's what this PR is doing, it returns value of "doIt" at end,
> isn't it?
> The way it was
On Fri, 21 Jun 2024 15:51:29 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 11:10:56 GMT, Kevin Rushforth wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
>
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> This fix will resolve page range not printing proper pages if the rage begin
> from 2 or above on Mac machines.
> I have verified the manual range related tests like PageRanges.java,
> ClippedImages.java
On Thu, 20 Jun 2024 11:10:59 GMT, Renjith Kannath Pariyangad
wrote:
>> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java line 225:
>>
>>> 223: if (isRangeSet) {
>>> 224: attributes.add(new PageRanges(from+1, to+1));
>>> 225:
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> This fix will resolve page range not printing proper pages if the rage begin
> from 2 or above on Mac machines.
> I have verified the manual range related tests like PageRanges.java,
> ClippedImages.java
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor
On Tue, 18 Jun 2024 17:09:08 GMT, Alexey Ivanov wrote:
> > > How do we remove this constructor? Can it be removed right away? Should
> > > it be deprecated for several releases before it's removed?
> >
> >
> > Just delete it in all versions of 17+?
&
On Thu, 20 Jun 2024 03:39:47 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 694:
>>
>>> 692: ::GlobalUnlock(setup.hDevMode);
>>> 693: }
>>> 694: doIt = JNI_TRUE;
>>
>> Another option would be to return
On Thu, 20 Jun 2024 05:12:28 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so
On Mon, 17 Jun 2024 05:07:22 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java
>> line 369:
>>
>>> 367: @Override
>>> 368: public void setEnabled(boolean enabled) {
>>> 369: if (splitPane.isOneTouchExpandable()
On Wed, 19 Jun 2024 19:20:24 GMT, Alexey Ivanov wrote:
>>> You should rather call
>>> [setDelay(50)](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294)
>>> to add the
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
Marked as reviewed by aivanov (Reviewer).
-
PR Review:
On Wed, 19 Jun 2024 15:38:10 GMT, Alexander Zvegintsev
wrote:
>>> How does it help? You're delaying EDT.
>>
>> I was unable to reproduce the failure scenario in my local machine but
>> didn't observe any failure in mach5 also. Will ask Vitaly or @azvegint to
>> verify as they are able to
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
You should ask Vitaly to test your changeset in his environment to confirm the
On Wed, 19 Jun 2024 08:30:42 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so
On Wed, 12 Jun 2024 20:55:51 GMT, Sergey Bylokhov wrote:
> > How do we remove this constructor? Can it be removed right away? Should it
> > be deprecated for several releases before it's removed?
>
> Just delete it in all versions of 17+?
Now it is part of Java 17 and 21. It can't be removed
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Fri, 14 Jun 2024 09:28:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Mon, 17 Jun 2024 05:08:29 GMT, Prasanta Sadhukhan
wrote:
> All L including Aqua extends BasicSplitPaneUI so it's ok...The existing
> test iterates through all L without any issue..
That is true, yet it is still possible to set a L that doesn't extend
`BasicSplitPaneUI` and the updated
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor
On Tue, 11 Jun 2024 19:17:43 GMT, Jonathan Gibbons wrote:
>> src/java.desktop/share/classes/java/awt/geom/Path2D.java line 297:
>>
>>> 295: /**
>>> 296: * @since 10
>>> 297: */
>>
>> Not sure it's required…
>>
>> If it is, you should also add explicit
On Mon, 10 Jun 2024 20:33:05 GMT, Alexey Ivanov wrote:
> These improvements to the test can be combined with fixing
> [JDK-8333026](https://bugs.openjdk.org/browse/JDK-8333026), or the test can
> be updated separately.
>
> I'll submit a new bug to track this activity. Thank y
On Mon, 10 Jun 2024 20:15:55 GMT, Alisen Chung wrote:
> Maybe outside the scope of this issue, but could this test be automated?
I've been thinking about it, too.
No, it can't be automated completely: the tester has to click Print / OK button
in the Print dialog.
Yes, other aspects of the
On Wed, 5 Jun 2024 04:53:56 GMT, Abhishek Kumar wrote:
>> Hi Reviewers,
>> I have updated the test case with passing float value for evaluation and a
>> typo. Please review and let me know your suggestions if any.
>
> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172:
>
>> 170:
On Mon, 3 Jun 2024 23:33:53 GMT, Nizar Benalla wrote:
> method: void java.awt.geom.Path2D.Double.trimToSize(): `@since` version is 9
> instead of 10
> method: void java.awt.geom.Path2D.Float.trimToSize(): `@since` version is 9
> instead of 10
In JDK 10, a new method `trimToSize` was added to
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor
On Tue, 4 Jun 2024 00:02:56 GMT, Nizar Benalla wrote:
>> It seems that BasicSliderUI() was added by the mistake? it was not mentioned
>> in the bug report...Seems it is too late to delete it?
>
> I'm sorry but `method: void javax.swing.plaf.basic.BasicSliderUI.()`
> refers to the constructor,
On Tue, 4 Jun 2024 15:37:00 GMT, Abhishek Kumar wrote:
>> bug6492108.java test always fails in GTK L in single as well as dual
>> screen linux machines. Since this test was not marked as "_headful_" in it's
>> initial version, it never failed but after the fix of
>>
On Tue, 4 Jun 2024 14:46:37 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java
>> line 1:
>>
>>> 1: /*
>>
>> You should update the copyright year.
>
> Updated.
I can't see it in the PR. Didn't push?
>>
On Mon, 3 Jun 2024 05:48:18 GMT, Abhishek Kumar wrote:
>> Previous formatting was less confusing and aligned with Java Coding Style
>> Guidelines.
>>
>> The parameters to the method are aligned to the opening parenthesis; the
>> `throws` clause is not part of the parameters and it's placed on
On Mon, 3 Jun 2024 05:52:31 GMT, Abhishek Kumar wrote:
>> bug6492108.java test always fails in GTK L in single as well as dual
>> screen linux machines. Since this test was not marked as "_headful_" in it's
>> initial version, it never failed but after the fix of
>>
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
Marked as reviewed by aivanov (Reviewer).
-
PR Review:
On Mon, 3 Jun 2024 06:07:37 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 1031:
>>
>>> 1029: (p.x >= (frame.origin.x + contentRect.size.width -
>>> 3)) ||
>>> 1030: (fabs(frame.origin.x - p.x) < 3) ||
>>>
On Fri, 31 May 2024 04:39:24 GMT, Abhishek Kumar wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 136:
>>
>>> 134: if (refimg.getWidth() != testimg.getWidth() ||
>>> 135: refimg.getHeight() != testimg.getHeight())
>>> 136: {
On Fri, 31 May 2024 05:02:16 GMT, Abhishek Kumar wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 70:
>>
>>> 68: Class
>>> type)
>>> 69: throws Throwable
>>> 70: {
>>
>> I think formatting here looks a little odd, could
On Thu, 30 May 2024 07:30:10 GMT, Abhishek Kumar wrote:
>> Yeah, true..
>
> Tested in CI and there is no failure for multiple run. Removed this method.
> But as I told before this may not impact the result of the test, it is just
> to add extra delay to provide visual verification.
In this
On Fri, 31 May 2024 12:24:42 GMT, Prasanta Sadhukhan
wrote:
>> Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is
>> resized from the lower right corner, then the Menu / JPopupmenu stays open
>> unlike in native osx apps like Notes, Mail etc..
>>
>> This is because
On Tue, 14 May 2024 23:36:13 GMT, Nizar Benalla wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
>> line 154:
>>
>>> 152: * Constructs a {@code BasicSliderUI}.
>>> 153: *
>>> 154: * @since 16
>>
>> Hmm, the *explicit* default constructor was
On Tue, 14 May 2024 23:45:23 GMT, Nizar Benalla wrote:
> but for older code you can only guess "Element: X existed before JDK 10". So
> I was left to check on my own, and made a mistake.
Why is it? There's history beyond 10 and 9, yet accessing it requires more
effort. In addition to that,
On Fri, 29 Mar 2024 15:32:12 GMT, Alexey Ivanov wrote:
> The value of the
> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
> property is not inherited correctly in Swing. If the `` element is
> mixed with `` or ``, only the value from the `styl
On Fri, 17 May 2024 12:16:15 GMT, Prasanta Sadhukhan
wrote:
>> Inadvertent mention of Netscape in Javadoc is removed..
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - doc clarity
> - doc clarity
Marked as
On Wed, 15 May 2024 17:39:16 GMT, Larry Cable wrote:
>> the beancontext package was added (by me) in JDK 1.2 to provide
>> JavaBeans(tm) with a containment and services hierarchy.
>>
>> based upon concepts from OpenDoc, which was a popular component model at the
>> time, the API pre-dated the
1 - 100 of 1956 matches
Mail list logo
