Re: Plugin Audit 2015

2015-11-10 Thread Andrew Grieve
Nice work! Couldn't resist checking out the results of the thought-it-would-never-happen audit :). On Tue, Nov 10, 2015 at 9:25 AM, Raymond Camden wrote: > "Globalization (make sync" > > YES, YES, YES! > > (Sorry, but that makes me *very* happy to hear!) > > "Dialogs

Re: CordovaPlugin lifecycle differs from Activity lifecycle

2015-08-24 Thread Andrew Grieve
I noted this as weird as well, but it's just always been this way in Cordova. I think it came from the fact that on iOS you only get a resume after a pause. You can always use

Re: [Android] Working with M - An update

2015-08-18 Thread Andrew Grieve
Andrew Grieve agri...@chromium.org wrote: Was out last week, but did manage to escalate the geolocation bug. Will hopefully be fixed for official M release :) On Thu, Jul 16, 2015 at 1:31 PM, Joe Bowser bows...@gmail.com wrote: Sent you the test app off-list. On Wed, Jul

Re: Android Project Structures, Libraries and the Embedded Case

2015-08-13 Thread Andrew Grieve
The structure isn't a big deal to me, because it seems to work fine in Android Studio how it is. Moving plugins to maven as .aar files is actually possible now by using a maven ref in a framework within you plugin.xml. On Thu, Aug 13, 2015 at 2:05 PM, Joe Bowser bows...@gmail.com wrote: Hey

Re: [Android] Working with M - An update

2015-07-24 Thread Andrew Grieve
Was out last week, but did manage to escalate the geolocation bug. Will hopefully be fixed for official M release :) On Thu, Jul 16, 2015 at 1:31 PM, Joe Bowser bows...@gmail.com wrote: Sent you the test app off-list. On Wed, Jul 15, 2015 at 11:12 AM Andrew Grieve agri...@chromium.org wrote

Re: [Android] Working with M - An update

2015-07-15 Thread Andrew Grieve
Thanks for looking into this Joe! The runtime permissions is quite a big change! M is still in preview, so if you find any webview bugs, please feel free to send me a repro app and I'll do my best to get it fixed. In terms of Cordova API changes, here's some thoughts on your branch: - Plugins

Re: [iOS 4.x] cordova-plugin-whitelist deficiencies

2015-07-08 Thread Andrew Grieve
On Wed, Jul 8, 2015 at 4:47 AM, Shazron shaz...@gmail.com wrote: FYI, we get to revisit this whitelist stuff again for iOS 9 with it's Application Transport Security (ATS):

Re: Installation Preference in config.xml

2015-06-23 Thread Andrew Grieve
Doesn't ring a bell (I've never seen it). On Tue, Jun 23, 2015 at 2:30 PM, Joe Bowser bows...@gmail.com wrote: Hey When working on CB-9220, I noticed that there was a configuration that I didn't recognize. When did we add the android-installLocation preference, and where does this logic

Re: Cordova issue.

2015-06-22 Thread Andrew Grieve
+ dev@ mailing list There have been (fixed) bugs with the online bridge in the past. Are you running a recent version of cordova-android? https://issues.apache.org/jira/browse/CB-6761 https://issues.apache.org/jira/browse/CB-6746 As a quick fix, you can switch to use the PROMPT-based bridge. On

Re: [iOS] Remove non-CLI template

2015-06-17 Thread Andrew Grieve
I think the difference between the two templates is that the CLI template adds extra navigator entries to point to ../../www and ../../config.xml. Might still be worth not keeping two templates though, and just have these entries be red for non-CLI projects (doesn't break builds). On Tue, Jun

Re: [iOS 8] WKWebView moving forward

2015-06-11 Thread Andrew Grieve
Could maybe try creating symlinks / hardlinks to save on space / creation time? On Wed, Jun 10, 2015 at 12:00 PM, Shazron shaz...@gmail.com wrote: Safari View Controller video: https://developer.apple.com/videos/wwdc/2015/?id=504 What's New in Web Development in WebKit and Safari video:

Re: Sticky Channels

2015-06-09 Thread Andrew Grieve
I think the only place sticky channels are used is for startup events (deviceready, nativeready, pluginsready, etc). I think you could probably change them to fire multiple times without breaking too much, but the semantics of that seem really strange to me (fire the most recent event, or all

Re: plugins framework on Android

2015-06-02 Thread Andrew Grieve
We want plugman to always work, even if you don't have the android sdk installed. So, plugman calling android update project is not allowed. As of cordova-5.0, this line will be re-written by the build script to its Gradle equivalent, where no android update project call is necessary (this was an

Re: [Android] VERSION_CODE generation

2015-06-02 Thread Andrew Grieve
I can shed some light. The code for it is here: https://github.com/apache/cordova-android/blob/master/bin/templates/project/build.gradle#L178 There are two times we fiddle with it: 1 - When building multiple architectures (cough crosswalk cough) 2 - When a minSdkVersion is set. Play store

Re: [DISCUSS] Moving Rat Excludes closer to source

2015-06-01 Thread Andrew Grieve
sgtm! On Fri, May 29, 2015 at 9:05 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi all, Right now coho stores rat excludes inside its source code, which often goes out of date and we end up with a lot of noise in coho audit-license-headers”. Do you think it would be a good idea to

Re: Why does coho need coho?

2015-05-29 Thread Andrew Grieve
I think it's because it downloads the RAT tool to coho's directory. On Thu, May 28, 2015 at 9:52 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi all, When I run 'coho audit-licence-headers' INSIDE of 'cordova-js' (should work since it runs in the current directory by default), I get the

Re: [BUG] Fail to build Mobilespec with --thirdpartyplugins (CB-9032)

2015-05-29 Thread Andrew Grieve
. This also means that when we do deprecate something, we write why. Of course, we're tight on resources so if anyone wants to take that on, it would be great. It's been on our to-do list for years and has never happened. On Wed, May 27, 2015, 8:05 PM Andrew Grieve agri...@chromium.org wrote: I'm

Re: Building cordova.js on first build

2015-05-27 Thread Andrew Grieve
Certainly would be nice to have the create scripts generate cordova.js in the same way CLI does. Maybe have the create script call into cordova-js? Would it make sense in this case to have platforms depend on cordova-js, rather than the other way around? Having cordova-js depend on platforms

Re: [BUG] Fail to build Mobilespec with --thirdpartyplugins (CB-9032)

2015-05-27 Thread Andrew Grieve
I'm wary of creating any docs for the Java APIs, since I think they will inevitably get out of sync with the real code (it's hard enough getting code comments to match the code). I think some beefed up Javadocs might be nice, but I think plugin developers should just read through Cordova's code

Re: Cordova 5 - Android and 3rd party libraries question

2015-05-26 Thread Andrew Grieve
build.gradle is building project(':org.apache.cordova.xapkreader:library¹) Thanks, Ian On 5/19/15, 8:05 PM, Andrew Grieve agri...@chromium.org wrote: Hmm, I've written a couple of other plugins that don't suffer from multiple dex exceptions. I forget the first, but the second

Re: cordova-vm.apache.org

2015-05-22 Thread Andrew Grieve
avenue that has merit, and could eliminate the need for a DB in the middle. What are the reasons that we can't get the logs from some emulators/devices on some platforms? - Dmitry -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve

Re: Cordova 5 - Android and 3rd party libraries question

2015-05-19 Thread Andrew Grieve
I spoke with Andrew Grieve via email and he recommend changing the build.js file in cordova-android to enable the following in creating the settings.gradle . We can now properly reference the library in a build-extras.gradle include :org.apache.cordova.xapkreader:library project

Re: Cordova 5.0 user feedback - move to npm whitelist plugin

2015-05-13 Thread Andrew Grieve
is the default config.xml actually defined? I assume it is baked in and a user can't change the default used? On Tue, May 12, 2015 at 11:02 AM, Andrew Grieve agri...@chromium.org wrote: if you use --copy-from and the template doesn't already have a config.xml, then the default config.xml

Re: [DISCUSS] Dropping the -dev suffix

2015-05-13 Thread Andrew Grieve
I think -dev is working fine and doing what it's supposed to do. The logic of -label is subtle: var sem = require('semver') undefined sem.satisfies('4.0.0-dev', '=4.0.0') false sem.satisfies('4.0.0-dev', '=4.0') true So, the engine check should just to =4.0, or =4.0.0-dev On Wed, May 13,

Re: cordova-plugin-background-app

2015-05-13 Thread Andrew Grieve
Here we go! https://github.com/MobileChromeApps/cordova-plugin-background-app/tree/master/example-app Also makes use of CLI's ability to store plugins platforms in config.xml :) On Tue, May 5, 2015 at 2:50 PM, Andrew Grieve agri...@chromium.org wrote: Hmm, just have mobile chrome apps

Re: Cordova 5.0 user feedback - move to npm whitelist plugin

2015-05-12 Thread Andrew Grieve
thought the whitelist plugin was being added because it was in the default Cordova sample config.xml - but when I built a new project and used --copy-from, it *also* installed the plugin. So is it just *always* added? On Tue, May 12, 2015 at 9:21 AM, Andrew Grieve agri...@chromium.org wrote

Re: Cordova 5.0 user feedback - move to npm whitelist plugin

2015-05-12 Thread Andrew Grieve
On Mon, May 11, 2015 at 1:56 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Responses inline. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, May 7, 2015 6:17 PM To: dev@cordova.apache.org Subject: Re: Cordova 5.0 user feedback - move to

Re: Cordova Plugins with Symlinks

2015-05-07 Thread Andrew Grieve
AM, Shazron shaz...@gmail.com wrote: I think the right approach is what Andrew suggested. So the current workaround is to tarball it first then publish? On Mon, Aug 18, 2014 at 12:04 PM, Andrew Grieve agri...@chromium.org wrote: Tarballs support symlinks. npm uses

cordova-plugin-background-app

2015-05-05 Thread Andrew Grieve
Wanted to draw attention to a new plugin we've created for allowing Android apps to behave as a service on Android (without actually being a service!) https://github.com/MobileChromeApps/cordova-plugin-background-app We use it as part of our chrome.gcm, chrome.notifications, and chrome.alarms

Re: Would like to submit PR, unable to figure out JIRA

2015-05-05 Thread Andrew Grieve
Thanks Matt! Not sure what's going on with JIRA, but I created an issue for it: https://issues.apache.org/jira/browse/CB-8956 ICLA's are required only for big changes (though still a nice thing to have on file). I'll go ahead and merge. On Mon, May 4, 2015 at 6:50 PM, Matt Steele

Also moving to a new team

2015-05-05 Thread Andrew Grieve
As with Michal, you'll be seeing less of me around. My new full-time project will be on the Android port of Chrome. Just want to make it clear that us moving to new teams has nothing to do with a lack of faith in the project, but rather is due to needing a change of scenery and exciting new

Re: Does cordova-mobile-spec support CLI build?

2015-04-29 Thread Andrew Grieve
The createmobilespec.js script within the repo is meant to be the CLI for the test suite. Sounds like what you want it: createmobilespec.js --android --global --webview=crosswalk Of course, I just tried it and it failed due to some recent churn. I've now committed a fix for it though. The

Re: [Android] InAppBrowser and URI whitelisting

2015-04-27 Thread Andrew Grieve
, 2015 at 4:38 PM Andrew Grieve agri...@chromium.org wrote: The browser allows any intents, but attaches Category.BROWSABLE to the intents, which is supposed to make them safe. We don't restrict the IAB to the network whitelist, so it follows (maybe?) that we wouldn't restrict

Re: Two small tools for Cordova

2015-04-27 Thread Andrew Grieve
Thanks Murat! Sounds really useful! WDYT about integrating these with coho? - So that cordova devs don't need to npm install multiple dev commands - So that the commands will be more discoverable - So that you can restrict to repos: e.g. coho travis -r plugins On Sun, Apr 26, 2015 at 11:53 PM,

Re: Build signed archives using CLI

2015-04-22 Thread Andrew Grieve
-Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Wednesday, March 18, 2015 4:48 PM To: dev Subject: Re: Build signed archives using CLI Left some comments on the PR. On Tue, Mar 17, 2015 at 5:04 PM, Nikhil Khandelwal nikhi

Re: cordova 5.0.0 and gradle

2015-04-22 Thread Andrew Grieve
We do pin the gradle version since that's what we've tested with. Seems reasonable to add an option to try setting your own version though (feel free to file an issue / hack away at it). The two spots the version is pinned: - within build.gradle - within cordova/lib/build.js's prepEnv function

Re: [ANNOUNCEMENT] Cordova Tools (CLI 5.0.0) + Plugins (renamed) have been released

2015-04-22 Thread Andrew Grieve
WOOOHOOOHOHOOO!! On Wed, Apr 22, 2015 at 11:04 AM, Raymond Camden raymondcam...@gmail.com wrote: Ah - a shift reload fixed it. Is the caching a bit high for the page? On Wed, Apr 22, 2015 at 7:15 AM, Carlos Santana csantan...@gmail.com wrote: Hi Ray Home page http://cordova.apache.org

Re: Cookie support in docs.

2015-04-22 Thread Andrew Grieve
Cookies work the same as they do in a browser AFAIK. cookies for file: don't make sense because you talk to a server at file:. If you make an XHR to http:///, they it can set cookies. On Wed, Apr 22, 2015 at 6:12 AM, Andrey Kurdumov kant2...@googlemail.com wrote: Hi, I come across the

Re: Deprecation Wars: ICS vs Gingerbread

2015-04-22 Thread Andrew Grieve
Not sure it's worth doing another release just for this. Devs can already set the minSdkVersion using a preference. On Wed, Apr 22, 2015 at 5:33 PM, Joe Bowser bows...@gmail.com wrote: BTW: Sorry for rushing the commit and sticking the ugly merge commit to try and fix it. On Wed, Apr 22,

Re: Scoped package names for npm?

2015-04-21 Thread Andrew Grieve
Given the state of some of our plugins, dropping the distinguishing namespace might be a good thing :P On Tue, Apr 21, 2015 at 8:45 AM, Horn, Julian C julian.c.h...@intel.com wrote: I am also against another rename. These name changes are very costly and disruptive. There is code in several

Re: Question about bypassing the run-loop wait/entire bridge for plugins on iOS

2015-04-20 Thread Andrew Grieve
I think Jesse pretty much covered it. I would be surprised if you could get web animations to be in sync with native animations like the keyboard. If you are to try, I think you'd get closest by attaching a timestamp to the event you're sending to JS, and use requestAnimationFrame to animate. CSS

Re: moving plugins to npm

2015-04-20 Thread Andrew Grieve
On Thu, Apr 16, 2015 at 3:51 PM, Steven Gill stevengil...@gmail.com wrote: On Thu, Apr 16, 2015 at 1:36 PM, Don Coleman don.cole...@gmail.com wrote: I'm little nervous about changing the ids for my plugins for npm. I like the cordova-plugin-* prefix. I think the consistency is good. Is

Re: Proposal: Expose check_reqs at the CLI level

2015-04-15 Thread Andrew Grieve
We've worked to make iOS add'able from Windows, so I do think it's a good idea to *not* run check_reqs from add (we used to but removed it). We already run it on build, so potentially we already have this command: cordova platform build android --nobuild On Tue, Apr 14, 2015 at 9:51 PM,

Re: Tools for Cordova Commits Presentation Slides

2015-04-15 Thread Andrew Grieve
: Fantastic deck Andrew! On Mon, Apr 13, 2015 at 10:46 PM, Carlos Santana csantan...@gmail.com wrote: slides look great ! ;-) On Mon, Apr 13, 2015 at 5:53 PM, Andrew Grieve agri...@chromium.org wrote: Thanks guys! Jesse - your name is there because you were last

Android 4.0 Blog Post

2015-04-15 Thread Andrew Grieve
The 4.0 release is posted to npm, and I've updated the blog post to work without the need for a tools release: I'd like to publish the blog post without waiting for a CLI release: - I've updated the post to use plugins-from-git so it works without new CLI - I've mentioned those can just wait for

Re: [Vote] 4.0.0 Android Release

2015-04-15 Thread Andrew Grieve
The vote has now closed. The results are: Positive Binding Votes: 6 Andrew Grieve Joe Bowser Brian LeRoux Simon MacDonald Sergey Grebnov Ian Clelland Negative Binding Votes: 0 The vote has passed. On Wed, Apr 15, 2015 at 10:15 AM, Ian Clelland iclell...@chromium.org wrote: +1 Verified

Re: Android 4.0 Blog Post

2015-04-15 Thread Andrew Grieve
platforms 'catch up')? If not, thanks. If so, what would be the best way to handle the differences - perhaps using the merges functionality? Thanks, Leo -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve

Re: Android 4.0 Blog Post

2015-04-15 Thread Andrew Grieve
-Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Wednesday, April 15, 2015 11:51 AM To: dev Subject: Re: Android 4.0 Blog Post You can customize the tags per-platform via platform name=android.../platform. Although, the new

Re: [Vote] 4.0.0 Android Release

2015-04-14 Thread Andrew Grieve
, Apr 9, 2015 at 12:15 PM, Andrew Grieve agri...@chromium.org javascript:; wrote: Please review and vote on this 4.0.0 Android Release. Release issue: https://issues.apache.org/jira/browse/CB-8833 Repos ready to be released have been published to dist/dev: https

Tools for Cordova Commits Presentation Slides

2015-04-13 Thread Andrew Grieve
Created the slides to be readable without me talking over them in hopes to be a form of documentation for the project :) Mainly: - how to use some of coho, - how to do a pull request - picture guides to visual debugging for node, android, ios http://goo.gl/ciGnaR

Re: Tools for Cordova Commits Presentation Slides

2015-04-13 Thread Andrew Grieve
...@microsoft.com wrote: Looks pretty good to me! -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Monday, April 13, 2015 1:14 PM To: dev Subject: Tools for Cordova Commits Presentation Slides

Fwd: Infrastructure introduces JIRA Service Desk

2015-04-13 Thread Andrew Grieve
Right on the front page is a button for creating a new git repo :) https://infrahelp.apache.org -- Forwarded message -- From: Tony Stevenson pct...@apache.org Date: Mon, Apr 13, 2015 at 4:29 PM Subject: Infrastructure introduces JIRA Service Desk To: committers

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-04-09 Thread Andrew Grieve
? On Wed, Apr 8, 2015 at 7:09 PM Andrew Grieve agri...@chromium.org wrote: CB-8684 is now merged and I've updated the targetSdk (and made a couple other changes). I'll start the release process in the morning as long as there no objections. On Tue, Apr 7

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-04-09 Thread Andrew Grieve
...@gmail.com wrote: So, wasn't there a change regarding icons and spashscreens being moved? I have no idea if we want to add that, or if adding that should happen after the release? On Wed, Apr 8, 2015 at 7:09 PM Andrew Grieve agri...@chromium.org wrote: CB-8684

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-04-09 Thread Andrew Grieve
Michal - Good point about npm vs github for links. We tend to tweak docs post npm publish, so I've changed the blog post links to github ones. On Thu, Apr 9, 2015 at 3:55 PM, Andrew Grieve agri...@chromium.org wrote: The plugins being on npm will likely be a bump. Perhaps we should mention

Re: Does Cordova have a problem making developers happy?

2015-04-09 Thread Andrew Grieve
Apache provides a lot of benefit. I don't want elaborate right now, but I will promise to post back with some formulated thoughts a bit later (some of this I'm prepping for my ApacheCon talk, so I need to do it anyways). Joe - Please please *please* do not write emails that are not constructive.

Re: Discussions on vote threads

2015-04-09 Thread Andrew Grieve
that we probably shouldn't proceed and should discuss it more. Too much discussion on vote thread means we don't have any sort of consensus and should work that out first. On Thu, Apr 9, 2015, 12:52 PM Andrew Grieve agri...@chromium.org wrote: Have become very common for us. Probably

Discussions on vote threads

2015-04-09 Thread Andrew Grieve
Have become very common for us. Probably because the release VOTE is the thing that actually gets people motivated to take a good look. Thought it'd be good for us to discuss this practice. My thoughts: - I think it still makes sense to DISCUSS before starting a release - I think it's perfectly

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-04-09 Thread Andrew Grieve
and spashscreens being moved? I have no idea if we want to add that, or if adding that should happen after the release? On Wed, Apr 8, 2015 at 7:09 PM Andrew Grieve agri...@chromium.org wrote: CB-8684 is now merged and I've updated the targetSdk (and made a couple other

[Vote] 4.0.0 Android Release

2015-04-09 Thread Andrew Grieve
Please review and vote on this 4.0.0 Android Release. Release issue: https://issues.apache.org/jira/browse/CB-8833 Repos ready to be released have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-8833 The package was published from its corresponding git tag:

Re: Does Cordova have a problem making developers happy?

2015-04-08 Thread Andrew Grieve
Fun survey! Other highlights: The more things change, the more likely it is those things are written in JavaScript with NotePad++ on a Windows machine (theme: dark) using Git, and tabs instead of spaces. users who have 10,000 rep or more prefer spaces to tabs at a ratio of 3 to 1. On Wed, Apr

cordova-vm.apache.org

2015-04-08 Thread Andrew Grieve
We got a VM a while ago with the idea to use it for BuildBot / cordova-docs ruby environment. I don't think either of these are still applicable (http://ci.cordova.io is *awesome*!!!) Any reason to not ask for it to be decommissioned?

Re: cordova-vm.apache.org

2015-04-08 Thread Andrew Grieve
. On 4/8/15, 8:35 AM, Andrew Grieve agri...@chromium.org wrote: We got a VM a while ago with the idea to use it for BuildBot / cordova-docs ruby environment. I don't think either of these are still applicable (http://ci.cordova.io is *awesome*!!!) Any reason to not ask

Re: cordova-vm.apache.org

2015-04-08 Thread Andrew Grieve
Although - could you remind me why we need a couchdb? It's a hasstle and will require maintentance. The logs from the builders seem sufficient to me (they show which tests fail). Effort might be better spent improving the tests fixing bugs. On Wed, Apr 8, 2015 at 2:53 PM, Andrew Grieve agri

Re: proposed utility

2015-04-08 Thread Andrew Grieve
I think my reservation about this tool is that I'm afraid that adding yet another command to the mix of options will add more confusion than it's worth. Those that know the difference between npm local vs. global can trivially create an npm run command (or batch script, or alias, or gulp task)

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-04-08 Thread Andrew Grieve
CB-8684 is now merged and I've updated the targetSdk (and made a couple other changes). I'll start the release process in the morning as long as there no objections. On Tue, Apr 7, 2015 at 2:20 PM, Andrew Grieve agri...@chromium.org wrote: I'll start on it once CB-8684 lands (Tony - assuming

Re: Who Runs cordova.io?

2015-04-07 Thread Andrew Grieve
was going to mention that perhaps some of Google's Cordova folks (Andrew Grieve, Ian Clelland, et al.) might have had issues with changing the domain from their Buildbot installation, but they haven't responded, so I guess we can presume that they don't mind. However, I think now it would be worth

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-04-07 Thread Andrew Grieve
for the plugins? On Mon, Mar 16, 2015 at 11:17 PM, Ian Clelland iclell...@chromium.org wrote: +1 -- Let's get this out the door :) I'll see what I can get done to move it in that direction. On Mon, Mar 16, 2015 at 7:51 PM, Andrew Grieve agri...@chromium.org

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-04-07 Thread Andrew Grieve
I'll start on it once CB-8684 lands (Tony - assuming you'll have this done shortly and would prefer it lands?) On Tue, Apr 7, 2015 at 1:33 PM, Jesse purplecabb...@gmail.com wrote: Sweet! @purplecabbage risingj.com On Tue, Apr 7, 2015 at 8:35 AM, Andrew Grieve agri...@chromium.org wrote

Re: Platform guides update

2015-04-07 Thread Andrew Grieve
These changes all sound great! On Tue, Apr 7, 2015 at 3:01 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Hi guys, I see that some docs are outdated or not actual anymore so I want to improve this. Please let me know if someone already working on this or going to take a look.

Re: Platform guides update

2015-04-07 Thread Andrew Grieve
really recommend this over CLI + your favorite editor ? On Tue, Apr 7, 2015 at 2:35 PM, Jesse purplecabb...@gmail.com wrote: +1000 @purplecabbage risingj.com On Tue, Apr 7, 2015 at 12:31 PM, Andrew Grieve agri...@chromium.org wrote: These changes all sound great! On Tue, Apr

Re: Jira CB-831: File transfer tests crash on Android L

2015-04-07 Thread Andrew Grieve
- In 4.0.0, we remove OkHttp from our code, but Android L starts including it for its own network stack (crazy coincidence!) - We're not sure how frequent the crash happens - just that MobileSpec's use of FileTransfer triggers it every time - It is fixed by replacing the network stack with a newer

Re: Platform guides update

2015-04-07 Thread Andrew Grieve
Do we really recommend this over CLI + your favorite editor ? On Tue, Apr 7, 2015 at 2:35 PM, Jesse purplecabb...@gmail.com wrote: +1000 @purplecabbage risingj.com On Tue, Apr 7, 2015 at 12:31 PM, Andrew Grieve agri...@chromium.org wrote: These changes all

Re: ApacheCon NA, Austin, April 13-16

2015-04-02 Thread Andrew Grieve
Sosa sosah.vic...@gmail.com wrote: Welcome aboard!! 2015-03-24 11:47 GMT-06:00 Andrew Grieve agri...@chromium.org: Woohoo! Glad to hear more are coming! On Sat, Mar 21, 2015 at 11:51 AM, Ross Gardler (MS OPEN TECH) ross.gard...@microsoft.com wrote: Some of my day job colleagues

Re: [proposal] [ANDROID] move inAppBrowser intents from onPageStarted to shouldOverrideUrlLoading

2015-04-02 Thread Andrew Grieve
shouldOverrideUrlLoading is what the main cordova webview uses, so that's certainly the right approach. I believe it should also add CATEGORY_BROWSABLE to the intent to ensure that the user is prompted to confirm whether they actually want to make the call. On Thu, Apr 2, 2015 at 7:07 PM, julio

Re: Camera: When was Crop added and why?

2015-04-01 Thread Andrew Grieve
My 2c on this is that camera is a mess and I doubt it'd be worth time looking at it (beyond fixing bugs from PRs). Instead, it would be better to invest in chopping it up into several usefull-on-their-own plugins. E.g.: - A plugin that can fire intents and receive the result via onActivityResult

Re: Keyboard plugin

2015-03-30 Thread Andrew Grieve
I definitely agree that KeyboardShrinksView makes a tonne more sense for apps (as opposed to webpages), and it's what we use on Android. Shame they reversed the decision (I didn't actually realize that). One reason to keep it as a plugin is that the logic seems to be hard to get right and so

Re: Question about plugin/platform --save: src vs version?

2015-03-30 Thread Andrew Grieve
I don't think we'd want to try a fallback in this case. Better to fail loudly if the plugin can't be found where it's expected to be. I think since NPM uses only a single field (although theirs isn't labeled), we should do likewise. Don't feel strongly about it though. On Mon, Mar 30, 2015 at

Re: [VOTE] Cordova-Plugin-Whitelist and Cordova-Plugin-Legacy-Whitelist Plugins Release (attempt 2)

2015-03-30 Thread Andrew Grieve
On Fri, Mar 27, 2015 at 4:31 PM, Andrew Grieve agri...@chromium.org wrote: +1 * Tested that both plugins compile on Android * Tested that the non-legacy plugin does what its supposed to on Android On Thu, Mar 26, 2015 at 7:46 PM, Steven Gill stevengil

Re: introduction

2015-03-27 Thread Andrew Grieve
Welcome Serge! Just merged your PR ( https://github.com/apache/cordova-android/pull/169) Great stuff! On Fri, Mar 27, 2015 at 9:08 AM, Victor Sosa sosah.vic...@gmail.com wrote: Welcome aboard, Serge! On Mar 27, 2015 3:36 AM, Serge Huijben s.huij...@gmail.com wrote: Hi Everybody, I am a

Re: [VOTE] Cordova-Plugin-Whitelist and Cordova-Plugin-Legacy-Whitelist Plugins Release (attempt 2)

2015-03-27 Thread Andrew Grieve
+1 * Tested that both plugins compile on Android * Tested that the non-legacy plugin does what its supposed to on Android On Thu, Mar 26, 2015 at 7:46 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the releases of cordova-plugin-whitelist and

Re: Introduction

2015-03-26 Thread Andrew Grieve
Welcome Alex! Thanks for wanting to make Cordova better for everyone! :) On Wed, Mar 25, 2015 at 11:33 PM, Alex Talis alex.ta...@yahoo.com.invalid wrote: Hi guys, I’m planning to submit a pull request and so following the instructions in the “Process of Contributing” and introducing

Re: [VOTE] Cordova-Plugin-Whitelist and Cordova-Plugin-Legacy-Whitelist Plugins Release

2015-03-26 Thread Andrew Grieve
That'd be pretty sad if it were expected :P. Totally my bad on this one. I've committed a fix. On Thu, Mar 26, 2015 at 9:40 AM, Alexander Sorokin (Akvelon) v-als...@microsoft.com wrote: Hi guys, I am getting the following error when trying to build a project with legacy-whitelist plugin

Re: 'cordova plugin save' should also save plugin versions

2015-03-25 Thread Andrew Grieve
That's what we already do (CPR *is* an npm database) On Wed, Mar 25, 2015 at 12:00 AM, Michal Mocny mmo...@chromium.org wrote: ..Also with the move to put plugins in npm, I think we would be directly using npm's resolution of the version? On Tue, Mar 24, 2015 at 8:48 PM, Andrew Grieve agri

Re: crosswalk engine plugin for Cordova Android 4.0.0 release

2015-03-25 Thread Andrew Grieve
Published it to npm! https://www.npmjs.com/package/cordova-plugin-crosswalk-webview Once a CLI release happens, we can update the docs to install it via plugin ID. On Wed, Mar 25, 2015 at 8:56 AM, Ian Clelland iclell...@chromium.org wrote: Once we publish this to npm (or the Cordova plugin

Re: [Vote] 3.9.0 Cordova App Hello World Release

2015-03-25 Thread Andrew Grieve
+1 On Tue, Mar 24, 2015 at 9:29 AM, Ian Clelland iclell...@google.com wrote: +1 * Checked signatures and checksums * Verified contents against Git repo at 3.9.0 tag * Successfully built and ran hello world with Cordova-Android 3.7.1 and 4.0.0-dev (master) On Mon, Mar 23, 2015 at 8:13 PM,

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Andrew Grieve
behaviour is the expected because platforms behave that way. I guess we could just make shrinkwrap default and change the flag to --noshrinkwrap. -- Gorkem On 24 Mar 2015, at 13:58, Andrew Grieve wrote: On Tue, Mar 24, 2015 at 11:49 AM, Gorkem Ercan gorkem.er...@gmail.com wrote

Re: [DISCUSS] Whitelist Legacy Whitelist Plugins Release @1.0.0

2015-03-24 Thread Andrew Grieve
that grep looks fine to me. On Tue, Mar 24, 2015 at 5:13 PM, Steven Gill stevengil...@gmail.com wrote: Leo, the whitelist plugin will only start being used after the next tools release. So timing should be fine. Andrew, I did a quick grep search for org.apache.cordova for both whitelist

Re: ApacheCon NA, Austin, April 13-16

2015-03-24 Thread Andrew Grieve
and Hazem. Anybody else going ? I plan to attend. On Sat, Jan 31, 2015 at 6:46 PM, Andrew Grieve agri...@chromium.org wrote: Submitted a talk proposal: Abstract: The Cordova project can sometimes be hard to contribute to given the large number of pieces that make it up

Re: Cordova Monthly Hangouts

2015-03-24 Thread Andrew Grieve
+1! On Tue, Mar 24, 2015 at 1:23 PM, Jesse purplecabb...@gmail.com wrote: +1 asap, thanks Parash! We are much more coherent when we meet. On Mar 24, 2015, at 10:02 AM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Hi, I was wondering if folks would be interested in

Re: Introduction

2015-03-24 Thread Andrew Grieve
Welcome! On Fri, Mar 20, 2015 at 3:20 PM, Shazron shaz...@gmail.com wrote: Welcome Karen! Glad to have you on board. On Fri, Mar 20, 2015 at 12:12 PM, Karen Tran ktop...@gmail.com wrote: Hello, My name is Karen. I am a new addition to the Cordova team at IBM and will be focusing on

Re: gradleReference feature and gradle build

2015-03-24 Thread Andrew Grieve
Totally agree with your concern, and on Android master / tools master this is already fixed. When Android 4.0.0 ships (and is the case with master right now), Android Studio will work out-of-the-box without the need for a command-line build. On Mon, Mar 23, 2015 at 1:37 PM, Nell Gawor

Re: [DISCUSS] Whitelist Legacy Whitelist Plugins Release @1.0.0

2015-03-24 Thread Andrew Grieve
+1! Excited to have some npm-only plugins! On Tue, Mar 24, 2015 at 9:42 AM, Ian Clelland iclell...@chromium.org wrote: We should definitely do that -- and I think we should release them simultaneously with cordova-app-hello-world, since it now references cordova-plugin-whitelist by that name

Re: crosswalk engine plugin for Cordova Android 4.0.0 release

2015-03-24 Thread Andrew Grieve
Could this be fixed on plugman's side with git clone --depth 1? On Tue, Mar 24, 2015 at 9:02 AM, Ian Clelland iclell...@chromium.org wrote: On Tue, Mar 24, 2015 at 6:15 AM, Hu, Ningxin ningxin...@intel.com wrote: Crosswalk engine plugin is expected to work with upcoming Cordova Android

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Andrew Grieve
On Tue, Mar 24, 2015 at 11:49 AM, Gorkem Ercan gorkem.er...@gmail.com wrote: They are related but not same. CB-8594 asks to save the plugin version information during cordova plugin add --save. Right now we do not save version unless the command is cordova plugin add --save --shrinkwrap.

Re: [cordova.plugins.io] Dump of all plugin ids

2015-03-19 Thread Andrew Grieve
a plugin.xml with deps will fetch and install them all, and will almost certainly fail to install due to missing params, or conflicting files. Better to have a text file with all the IDs and a script that just fetches unpacks them all. On Wed, Mar 18, 2015 at 8:45 PM, Shazron shaz...@gmail.com

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-03-19 Thread Andrew Grieve
: +1 -- Let's get this out the door :) I'll see what I can get done to move it in that direction. On Mon, Mar 16, 2015 at 7:51 PM, Andrew Grieve agri...@chromium.org wrote: Everything's ready afaik (minus upgrade guide, publishing whitelist plugins, and making it so

Re: (Mobile spec) Replace dependency plugin with plugin list parameter in createmobilespec

2015-03-18 Thread Andrew Grieve
I've wanted to do this a few times (or implement plugin rm -f). +1 and thanks! On Wed, Mar 18, 2015 at 7:54 AM, Alexander Sorokin (Akvelon) v-als...@microsoft.com wrote: Hi guys, I would like to introduce a little improvement for mobile spec. Currently createmobilespec uses dependency

Re: Build signed archives using CLI

2015-03-18 Thread Andrew Grieve
Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Wednesday, January 28, 2015 10:18 AM To: dev Subject: Re: Build signed archives using CLI Sounds good, let's wait until Dan is back to discuss. The main point I'd like to cover

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Andrew Grieve
the deprecation is bizzare. On Wed, Mar 11, 2015 at 7:15 AM Andrew Grieve agri...@chromium.org wrote: I wanted to make sure that I didn't break the old way of doing things. On Tue, Mar 10, 2015 at 2:24 PM, Joe Bowser bows...@gmail.com wrote: The main

  1   2   3   4   5   6   7   8   9   10   >