Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

2016-06-14 Thread William A Rowe Jr
Two quick observations... Every time OpenSSL was compiled against a different CRT, whether is was a release build of OpenSSL and a debug build of httpd/ab, or whether OpenSSL was built under Visual Studio 2012 and httpd/ab was built against VS 2015, this issue would occur without this patch.

Re: h2_proxy_util.c, is this going make 2.4.21?

2016-06-13 Thread William A Rowe Jr
On Mon, Jun 13, 2016 at 1:59 PM, Gregg Smith wrote: > I have the to connect this module in the traditional windows build but as > of right now it's using h2_util.c which Bill had an objection to. See his > comments http://marc.info/?l=apache-httpd-dev=146543811201820=2 > > So to

Re: "Upgrade: h2" header for HTTP/1.1 via TLS (Bug 59311)

2016-06-09 Thread William A Rowe Jr
On Thu, Jun 9, 2016 at 3:52 PM, Michael Kaufmann wrote: > > Note that "Suppress 'h2' announcements in Upgrade: header" has been > inserted at the top of the STATUS file; it should probably be moved to the > bottom of the 'Patches proposed' section. > Yea, that would be

T 2.2.32 next week...

2016-06-09 Thread William A Rowe Jr
On Tue, Sep 1, 2015 at 2:31 AM, wrote: > Author: rpluem > Date: Tue Sep 1 07:31:11 2015 > New Revision: 1700408 > > URL: http://svn.apache.org/r1700408 > Log: > * Fix a regression with 2.2.31 that caused inherited workers to > use a different scoreboard slot then the

h2_utils duplicity

2016-06-08 Thread William A Rowe Jr
On Wed, Jun 8, 2016 at 7:19 PM, wrote: > Author: wrowe > Date: Thu Jun 9 00:19:24 2016 > New Revision: 1747470 > > URL: http://svn.apache.org/viewvc?rev=1747470=rev > Log: > The answer to the question appears to be in 2.4.21, drop h2_casecmpstr fork > > Modified: >

Re: svn commit: r1747469 [1/2] - in /httpd/httpd/trunk: include/ modules/aaa/ modules/cache/ modules/dav/main/ modules/filters/ modules/generators/ modules/http/ modules/http2/ modules/loggers/ module

2016-06-08 Thread William A Rowe Jr
Some of these items are dis-optimized by redundant logic that we seriously aught to clean up, if anyone is looking for some low hanging fruit. On Wed, Jun 8, 2016 at 7:06 PM, wrote: > Author: wrowe > Date: Thu Jun 9 00:06:42 2016 > New Revision: 1747469 > > URL:

Re: strncasecmp

2016-06-08 Thread William A Rowe Jr
migrating trunk/2.6 consumers to the apr 1.6/2.0 names with some helpful #define's. On Mon, Nov 23, 2015 at 11:10 PM, Mikhail T. <mi+t...@aldan.algebra.com> wrote: > On 23.11.2015 23:14, William A Rowe Jr wrote: > > L1 cache and other direct effects of cpu internal optimization. >

Re: svn commit: r1747027 - /httpd/httpd/branches/2.4.x/STATUS

2016-06-08 Thread William A Rowe Jr
PM, "Ruediger Pluem" <rpl...@apache.org> wrote: > > > On 06/08/2016 05:31 PM, William A Rowe Jr wrote: > > > > > jailletc36: v2: update as per discussion on dev@. Do not > mix ap_ and apr_ > > namespac

Re: svn commit: r1747027 - /httpd/httpd/branches/2.4.x/STATUS

2016-06-08 Thread William A Rowe Jr
On Tue, Jun 7, 2016 at 12:15 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > It seems the most critical point of my earlier post was missed... > > On Mon, Jun 6, 2016 at 10:08 AM, <wr...@apache.org> wrote: > >> Author: wrowe >> Date: Mon Jun 6 15

Re: svn commit: r1747056 - in /httpd/httpd/branches/2.4.x: ./ STATUS modules/mappers/mod_rewrite.c

2016-06-07 Thread William A Rowe Jr
On Tue, Jun 7, 2016 at 1:23 AM, Marion & Christophe JAILLET < christophe.jail...@wanadoo.fr> wrote: > Le 07/06/2016 à 06:59, William A Rowe Jr a écrit : > > On Mon, Jun 6, 2016 at 3:10 PM, Marion & Christophe JAILLET < > <christophe.jail...@wanadoo.fr>c

Re: svn commit: r1747027 - /httpd/httpd/branches/2.4.x/STATUS

2016-06-06 Thread William A Rowe Jr
It seems the most critical point of my earlier post was missed... On Mon, Jun 6, 2016 at 10:08 AM, wrote: > Author: wrowe > Date: Mon Jun 6 15:08:01 2016 > New Revision: 1747027 > > URL: http://svn.apache.org/viewvc?rev=1747027=rev > Log: > Showstopper to patch adoption,

Re: svn commit: r1747056 - in /httpd/httpd/branches/2.4.x: ./ STATUS modules/mappers/mod_rewrite.c

2016-06-06 Thread William A Rowe Jr
On Mon, Jun 6, 2016 at 3:10 PM, Marion & Christophe JAILLET < christophe.jail...@wanadoo.fr> wrote: > ap_casecmpstr breaks 2.4.x build. > Keep strncasecmp for now? (waiting for ap_cstr_casecmp[n]) > > Le 06/06/2016 à 21:11, j...@apache.org a écrit : > >> Author: jim >> Date: Mon Jun 6 19:11:20

Re: Confusion about SSLProxyCheckPeerName/CN

2016-06-02 Thread William A Rowe Jr
This looks like the resulting patch. Wordsmithing the docs changes today... On Wed, Jun 1, 2016 at 1:50 PM, Ruediger Pluem <rpl...@apache.org> wrote: > > On 06/01/2016 05:45 PM, William A Rowe Jr wrote: > > > > CheckPeerName CheckPeerCN > >on

[RESULTS] [POLL] Commitment to 2.2.x lifecycle? (Was: End of the road of 2.2.x maintenance?)

2016-06-01 Thread William A Rowe Jr
On Wed, May 25, 2016 at 10:11 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > > So let's try this... would 2.2.x maintainers and PMC folks please answer > this > poll -if- you have an intention to help throughout the wind-down of 2.2.x, > since > this is all predic

Re: Confusion about SSLProxyCheckPeerName/CN

2016-06-01 Thread William A Rowe Jr
On Wed, Jun 1, 2016 at 9:46 AM, Ruediger Pluem <rpl...@apache.org> wrote: > > > On 06/01/2016 04:19 PM, William A Rowe Jr wrote: > > Correcting one typo, below... > > > > On Wed, Jun 1, 2016 at 9:19 AM, William A Rowe Jr <wr...@rowe-clan.net &

Re: Confusion about SSLProxyCheckPeerName/CN

2016-06-01 Thread William A Rowe Jr
Correcting one typo, below... On Wed, Jun 1, 2016 at 9:19 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > > Proposal... > > CheckPeerName CheckPeerCN > unset | onunset | onCheckPeerName verification > off on*CheckPeerCN* verificatio

Re: Confusion about SSLProxyCheckPeerName/CN

2016-06-01 Thread William A Rowe Jr
On Tue, May 31, 2016 at 1:15 PM, Ruediger Pluem <rpl...@apache.org> wrote: > > On 05/31/2016 06:37 PM, William A Rowe Jr wrote: > > It seems the behavior introduced in 2.4.5 is causing a lot > > of confusion for users attempting to disable peer checking. > >

Re: Confusion about SSLProxyCheckPeerName/CN

2016-05-31 Thread William A Rowe Jr
On Tue, May 31, 2016 at 11:37 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > It seems the behavior introduced in 2.4.5 is causing a lot > of confusion for users attempting to disable peer checking. > > I would suggest that CheckPeerCN should NOT default to "on"

Confusion about SSLProxyCheckPeerName/CN

2016-05-31 Thread William A Rowe Jr
It seems the behavior introduced in 2.4.5 is causing a lot of confusion for users attempting to disable peer checking. Right now, nothing needs to be done to do deep inspection (altsubjectname plus common name). Neither directive is required, both default to on. Disabling checking is a pain in

Re: New segfault with 2.4.20 with mod_perl

2016-05-31 Thread William A Rowe Jr
On Tue, May 31, 2016 at 7:35 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > On May 29, 2016 01:02, "Jie Gao" <j@sydney.edu.au> wrote: > > > > Hi All > > > > I wonder if anybody is looking at this issue. At the moment, the build

Re: [POLL] Commitment to 2.2.x lifecycle? (Was: End of the road of 2.2.x maintenance?)

2016-05-27 Thread William A Rowe Jr
On Wed, May 25, 2016 at 10:11 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > > So let's try this... would 2.2.x maintainers and PMC folks please answer > this > poll -if- you have an intention to help throughout the wind-down of 2.2.x, > since > this is all predic

Re: Module Development - Advice Needed

2016-05-26 Thread William A Rowe Jr
On May 26, 2016 5:44 PM, "Van Ulden, Joost (NRCan/RNCan)" < joost.vanul...@canada.ca> wrote: > > We want to develop an httpd module, “mod_mapml” which will allow the admin to configure MapML responses over a map tile cache, using one or more URI templates as configuration parameters. A Java

Re: svn commit: r1745582 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-26 Thread William A Rowe Jr
On Thu, May 26, 2016 at 8:24 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > > Excellent, but one big issue, namespace collision. >> >> [...] >> > would be the proper doxygen, to dissuade users from directly consuming > ap_ flavor. However we would n

Re: svn commit: r1745582 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-26 Thread William A Rowe Jr
Premature ctrl+enter... sorry about that... +#if !APR_VERSION_AT_LEAST(1,6,0) > +/** > + * Known-fast version of strcasecmp(): ASCII case-folding, POSIX compliant > + * @param s1 The 1st string to compare > + * @param s2 The 2nd string to compare > + * @return 0 if s1 is lexicographically equal

Re: svn commit: r1745582 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-26 Thread William A Rowe Jr
This will teach me to go back to pine... gui web clients... grrr... Final draft... On Thu, May 26, 2016 at 8:16 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > Excellent, but one big issue, namespace collision. > > What about... > +#if !APR_VERSION_AT_LEAST(1,6,0) +

Re: svn commit: r1745582 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-26 Thread William A Rowe Jr
> > On Thu, May 26, 2016 at 3:52 AM, wrote: >> >>> Author: jailletc36 >>> Date: Thu May 26 08:52:09 2016 >>> New Revision: 1745582 >>> >>> URL: http://svn.apache.org/viewvc?rev=1745582=rev >>> Log: >>> Proposal >>> >>> Modified: >>> httpd/httpd/branches/2.4.x/STATUS >>>

Re: svn commit: r1745582 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-26 Thread William A Rowe Jr
Excellent, but one big issue, namespace collision. What about... +#if !APR_VERSION_AT_LEAST(1,6,0) +/** + * Known-fast version of strcasecmp(): ASCII case-folding, POSIX compliant + * @param s1 The 1st string to compare + * @param s2 The 2nd string to compare + * @return 0 if s1 is

Re: svn commit: r1745517 - /httpd/httpd/branches/2.4.x/support/win32/ApacheMonitor.c

2016-05-25 Thread William A Rowe Jr
On Wed, May 25, 2016 at 1:14 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > Your comment doesn't match the code, and I think you have the condition > inverted, _setargv() worked for decades, and only was broken in the more > recent MSVC's. > Correction, the code looks

Re: svn commit: r1745517 - /httpd/httpd/branches/2.4.x/support/win32/ApacheMonitor.c

2016-05-25 Thread William A Rowe Jr
Your comment doesn't match the code, and I think you have the condition inverted, _setargv() worked for decades, and only was broken in the more recent MSVC's. My thought is to unilaterally change this to the unicode implementation, because 1. ANSI-only are dead Windows OS's, and 2. Getting the

Re: [POLL] Commitment to 2.2.x lifecycle? (Was: End of the road of 2.2.x maintenance?)

2016-05-25 Thread William A Rowe Jr
*) I intend to help maintain/test 2.2.x releases over the next 12 mos *) I intend to backport/review 2.2.x security patches over the next 12 mos

[POLL] Commitment to 2.2.x lifecycle? (Was: End of the road of 2.2.x maintenance?)

2016-05-25 Thread William A Rowe Jr
On Mon, May 16, 2016 at 5:07 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > On Mon, May 16, 2016 at 1:26 PM, Gregg Smith <g...@gknw.net> wrote: > >> On 5/16/2016 11:03 AM, Eric Covener wrote: >> >>> One shortcoming of a 12 month countdown is that

Re: svn commit: r1733537 - /httpd/httpd/trunk/support/ab.c

2016-05-24 Thread William A Rowe Jr
On Thu, Mar 3, 2016 at 6:10 PM, wrote: > Author: ylavic > Date: Fri Mar 4 00:10:10 2016 > New Revision: 1733537 > > URL: http://svn.apache.org/viewvc?rev=1733537=rev > Log: > ab: Use caseless matching for HTTP tokens (e.g. content-length). > PR 59111. > > Modified: >

Re: New segfault with 2.4.20 with mod_perl

2016-05-19 Thread William A Rowe Jr
Re-sending to include the correct perl.a.o dev list. On Thu, Apr 14, 2016 at 1:25 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > The defect appears to be in t/protocol/TestProtocol/pseudo_http.pm... > > First, the handler is registered using > > PerlProcessConnectio

Re: mod_proxy_http2 windows build

2016-05-19 Thread William A Rowe Jr
On May 18, 2016 6:08 PM, "Jan Ehrhardt" <php...@ehrhardt.nl> wrote: > > William A Rowe Jr in gmane.comp.apache.devel (Wed, 18 May 2016 14:54:41 > -0500): > >The .dsp files become irrelevant in this day and age, the legacy environment > >it maps to is entire

Re: mod_proxy_http2 windows build

2016-05-18 Thread William A Rowe Jr
On Wed, May 18, 2016 at 10:58 AM, Michal Karm <michal.baba...@gmail.com> wrote: > On 05/18/2016 05:24 PM, William A Rowe Jr wrote: > >> ... and .mak/.dep files in 2.4 branch, I'm on it today. >> >> >> On Wed, May 18, 2016 at 10:09 AM, Stefan Eissi

Re: mod_proxy_http2 windows build

2016-05-18 Thread William A Rowe Jr
... and .mak/.dep files in 2.4 branch, I'm on it today. On Wed, May 18, 2016 at 10:09 AM, Stefan Eissing < stefan.eiss...@greenbytes.de> wrote: > Reaching out to the knowledgable and always helpful Windows people: do we > need a mod_proxy_http2.dsp in trunk/modules/http2 (and 2.4.x branch for >

Re: RFC 7230..7235 Parsing Conformance?

2016-05-17 Thread William A Rowe Jr
Based on Jason's question... On Tue, May 17, 2016 at 1:31 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > On Tue, May 17, 2016 at 1:00 PM, Julian Reschke <julian.resc...@gmx.de> > wrote: > >> On 2016-05-17 19:01, Graham Leggett wrote: >> >>> On 17 M

Re: RFC 7230..7235 Parsing Conformance?

2016-05-17 Thread William A Rowe Jr
On Tue, May 17, 2016 at 1:00 PM, Julian Reschke <julian.resc...@gmx.de> wrote: > On 2016-05-17 19:01, Graham Leggett wrote: > >> On 17 May 2016, at 6:43 PM, William A Rowe Jr <wr...@rowe-clan.net> >> wrote: >> >> Wondering what other contributors a

RFC 7230..7235 Parsing Conformance?

2016-05-17 Thread William A Rowe Jr
Wondering what other contributors are thinking on this topic. We have a number of changes in the ABNF grammar between RFC2616 and RFC7230..7235. Do we want trunk 2.6/3.0 to be an entirely RFC723x generation server, and drop all support for RFC2616? Do we want to backport these changes to 2.4.x?

Re: End of the road of 2.2.x maintenance?

2016-05-16 Thread William A Rowe Jr
On Mon, May 16, 2016 at 1:26 PM, Gregg Smith <g...@gknw.net> wrote: > On 5/16/2016 11:03 AM, Eric Covener wrote: > >> On Tue, May 10, 2016 at 1:38 PM, William A Rowe Jr<wr...@rowe-clan.net> >> wrote: >> >>> Are we ready to start the 12 month count

Re: End of the road of 2.2.x maintenance?

2016-05-16 Thread William A Rowe Jr
On Wed, May 11, 2016 at 2:31 PM, Mark Blackman <m...@exonetric.com> wrote: > > On 10 May 2016, at 21:38, William A Rowe Jr <wr...@rowe-clan.net> wrote: > > Are we ready to start the 12 month countdown as of the next/final bug > fix release of 2.2, and highlight t

Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-13 Thread William A Rowe Jr
On Fri, May 13, 2016 at 11:41 AM, Yann Ylavic <ylavic@gmail.com> wrote: > On Thu, May 12, 2016 at 4:55 PM, William A Rowe Jr <wr...@rowe-clan.net> > wrote: > > > > I'd explained in another thread this week why this patch is invalid, > > and I've gone a

Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-13 Thread William A Rowe Jr
On Thu, May 12, 2016 at 9:55 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > On Sun, May 8, 2016 at 8:53 AM, <rj...@apache.org> wrote: > >> Author: rjung >> Date: Sun May 8 13:53:37 2016 >> New Revision: 1742822 >> >> URL: http://svn.apac

Re: Scoreboard 3.0

2016-05-13 Thread William A Rowe Jr
On Fri, May 13, 2016 at 8:34 AM, Eric Covener <cove...@gmail.com> wrote: > On Wed, May 11, 2016 at 6:39 PM, William A Rowe Jr <wr...@rowe-clan.net> > wrote: > > In the next iteration for trunk I see a value in having both the basic > > activity flag per worker thr

Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-12 Thread William A Rowe Jr
On Sun, May 8, 2016 at 8:53 AM, wrote: > Author: rjung > Date: Sun May 8 13:53:37 2016 > New Revision: 1742822 > > URL: http://svn.apache.org/viewvc?rev=1742822=rev > Log: > Fix yet another case where we clobber the > server-status request info when a timeout happens. > >

Re: Scoreboard 3.0

2016-05-11 Thread William A Rowe Jr
On May 11, 2016 4:16 PM, "Eric Covener" wrote: > > On Wed, May 11, 2016 at 8:28 AM, Stefan Eissing > wrote: > > I got some such feedback when h2 connections truly went async and no longer showed up as occupying a slot. I share your idea that in an

Re: Scoreboard 3.0

2016-05-11 Thread William A Rowe Jr
On Wed, May 11, 2016 at 10:28 AM, Stefan Eissing < stefan.eiss...@greenbytes.de> wrote: > > > Am 11.05.2016 um 17:03 schrieb William A Rowe Jr <wr...@rowe-clan.net>: > > > > It seems like a lot of the scoreboard confusion lies in the event > > MPM lie

Scoreboard 3.0

2016-05-11 Thread William A Rowe Jr
It seems like a lot of the scoreboard confusion lies in the event MPM lies in the work-performed-by-thread model of the thread based scoreboard. Let's call this existing model 'ExtendedStatus threads' What it seems some users and committers are looking for is a different model, let's call this

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-11 Thread William A Rowe Jr
On Tue, May 10, 2016 at 11:36 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > On Tue, May 10, 2016 at 7:26 PM, Yann Ylavic <ylavic@gmail.com> wrote: > >> >> The case where this happens is for keepalive/lingering-close handling. >> Suppose thread t1

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-10 Thread William A Rowe Jr
On Tue, May 10, 2016 at 7:26 PM, Yann Ylavic <ylavic@gmail.com> wrote: > On Tue, May 10, 2016 at 5:23 PM, William A Rowe Jr <wr...@rowe-clan.net> > wrote: > > On Sun, May 8, 2016 at 7:29 AM, Yann Ylavic <ylavic@gmail.com> > wrote: > >> > &

End of the road of 2.2.x maintenance?

2016-05-10 Thread William A Rowe Jr
It's been a year, and seems to be a good time to revisit this topic while those folks who are present at ApacheCon can discuss f2f the merits of bringing the 2.2.x chapter to a close, and share their thoughts back here on-list. According to

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-10 Thread William A Rowe Jr
I believe this is the right patch (or close to correct) for 2.4 branch, and perhaps even trunk with additional refactoring. In the case of resuming a thread, it should be up to the event/advanced MPM to reflect the correct no-info | [connection-info [request-info]] state of the conn at the time

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-10 Thread William A Rowe Jr
On Sun, May 8, 2016 at 7:29 AM, Yann Ylavic wrote: > > ISTM that the request line has already been clobbered (blanked) by the > previous call to ap_update_child_status_from_conn(SERVER_BUSY_READ) in > ap_process_http_[a]sync_connection(), where we already lost the >

Re: Detecting client aborts and stream resets

2016-05-04 Thread William A Rowe Jr
On Wed, May 4, 2016 at 3:44 PM, Michael Kaufmann wrote: > William is right, this is not a good idea. The ->aborted flag should serve >> this purpose of telling anyone interested that this connection is not >> longer delivering. I will make a github release soon where

Re: Detecting client aborts and stream resets

2016-05-04 Thread William A Rowe Jr
On Tue, May 3, 2016 at 2:05 PM, Michael Kaufmann <m...@michael-kaufmann.ch> wrote: > Zitat von William A Rowe Jr <wr...@rowe-clan.net>: > >> >> Nope - an optional function in mod_http2 is too special case, generators >> must remain protocol (socket or ot

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

2016-05-03 Thread William A Rowe Jr
On Tue, May 3, 2016 at 10:51 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > > If we want to be more robust, have a look at the current 2.4.x > implementation of ap_get_useragent_host() in core.c... > > if (r->useragent_addr == conn->client_addr) { >

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

2016-05-03 Thread William A Rowe Jr
On Mon, May 2, 2016 at 3:09 AM, Ruediger Pluem wrote: > > On 04/28/2016 10:19 AM, Ruediger Pluem wrote: > > > > On 04/27/2016 08:41 PM, wr...@apache.org wrote: > >> Author: wrowe > >> Date: Wed Apr 27 18:41:49 2016 > >> New Revision: 1741310 > >> > >> URL:

Re: [PATCH 54255] mod_deflate adjusts the headers "too late"

2016-05-03 Thread William A Rowe Jr
Keep in mind that such changes alter the expected behavior that all of the third party module authors have worked around. This doesn't seem like a suitable change for 2.4.x maintenance branch but a good improvement for trunk, looking forwards. On Tue, May 3, 2016 at 9:42 AM, Michael Kaufmann

Re: Detecting client aborts and stream resets

2016-05-03 Thread William A Rowe Jr
On Tue, May 3, 2016 at 9:31 AM, Michael Kaufmann wrote: > Hi all, > > a content generator module can detect client aborts and stream resets > while it reads the request body. But how can it detect this afterwards, > while the response is being generated? > > This is

Re: mod_proxy_hcheck ouch in Windows

2016-04-29 Thread William A Rowe Jr
See the usage of APR_THREAD_FUNC macro. On Apr 28, 2016 9:53 PM, "Gregg Smith" wrote: > This one I cannot figure out > > .\mod_proxy_hcheck.c(925) : error C2440: 'function' : cannot convert from > 'void *(__cdecl *)(apr_thread_t *,void *)' to 'apr_thread_start_t' > > - Gregg - >

Re: svn commit: r1741419 [1/4] - in /httpd/httpd/branches/2.4.x: ./ modules/http2/

2016-04-28 Thread William A Rowe Jr
On Thu, Apr 28, 2016 at 11:57 AM, Gregg Smith wrote: > On 4/28/2016 5:43 AM, ic...@apache.org wrote: > >> Author: icing >> Date: Thu Apr 28 12:43:02 2016 >> New Revision: 1741419 >> >> URL: http://svn.apache.org/viewvc?rev=1741419=rev >> Log: >> mod_http2: backport of 1.5.2 to

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

2016-04-28 Thread William A Rowe Jr
On Thu, Apr 28, 2016 at 4:37 AM, Yann Ylavic <ylavic@gmail.com> wrote: > On Thu, Apr 28, 2016 at 4:30 AM, William A Rowe Jr <wr...@rowe-clan.net> > wrote: > > On Wed, Apr 27, 2016 at 6:16 PM, Yann Ylavic <ylavic@gmail.com> > wrote: > >>

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

2016-04-27 Thread William A Rowe Jr
On Wed, Apr 27, 2016 at 9:30 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > On Wed, Apr 27, 2016 at 6:16 PM, Yann Ylavic <ylavic@gmail.com> wrote: > >> >> So now, either we choose to not report workers' activity in between >> requests (there ar

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

2016-04-27 Thread William A Rowe Jr
On Wed, Apr 27, 2016 at 6:16 PM, Yann Ylavic wrote: > I was offline today so couldn't comment on the different messages on > the subject, so I'll try to summarize (here) my understanding, so > far... > > On Wed, Apr 27, 2016 at 8:41 PM, wrote: > >

h2 request processing score behavior...

2016-04-27 Thread William A. Rowe Jr.
Within h2_task.c, we have static apr_status_t h2_task_process_request(h2_task *task, conn_rec *c) { const h2_request *req = task->request; conn_state_t *cs = c->cs; request_rec *r; ap_log_cerror(APLOG_MARK, APLOG_TRACE1, 0, c, "h2_task(%s): create request_rec",

Re: svn commit: r1739876 - /httpd/httpd/branches/2.4.x/STATUS

2016-04-27 Thread William A Rowe Jr
us(session->c->sbh, SERVER_BUSY_WRITE, NULL); - note that the request / descr is not updated here so hopefully it was updated elsewhere already On Wed, Apr 27, 2016 at 9:15 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > For example... in event.c; > > i

Re: svn commit: r1739876 - /httpd/httpd/branches/2.4.x/STATUS

2016-04-27 Thread William A Rowe Jr
road grep of the trunk sources. On Wed, Apr 27, 2016 at 8:43 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > I'm not certain the error is -in- scoreboard.c. > > Suspecting that we used to call ap_update_child_status[_xxx] with the > NULL req/conn rec pointer when we were idl

Re: svn commit: r1739876 - /httpd/httpd/branches/2.4.x/STATUS

2016-04-27 Thread William A Rowe Jr
revert this all and get back to 2.4.18 behavior > (and code) > > > On Apr 27, 2016, at 12:40 AM, Stefan Eissing < > stefan.eiss...@greenbytes.de> wrote: > > > > > > > >> Am 27.04.2016 um 03:53 schrieb William A Rowe Jr <wr...@rowe-clan.net>: &g

Re: svn commit: r1741239 - /httpd/httpd/branches/2.4.x/STATUS

2016-04-27 Thread William A Rowe Jr
On Wed, Apr 27, 2016 at 7:20 AM, wrote: > Author: jim > Date: Wed Apr 27 12:20:57 2016 > New Revision: 1741239 > > URL: http://svn.apache.org/viewvc?rev=1741239=rev > > Modified: > httpd/httpd/branches/2.4.x/STATUS > > Modified: httpd/httpd/branches/2.4.x/STATUS > URL: >

Re: svn commit: r1739876 - /httpd/httpd/branches/2.4.x/STATUS

2016-04-26 Thread William A Rowe Jr
On Tue, Apr 26, 2016 at 5:01 PM, Yann Ylavic <ylavic@gmail.com> wrote: > On Tue, Apr 26, 2016 at 10:48 PM, William A Rowe Jr <wr...@rowe-clan.net> > wrote: > > On Tue, Apr 26, 2016 at 3:47 PM, William A Rowe Jr <wr...@rowe-clan.net> > > wrote: >

Re: svn commit: r1739876 - /httpd/httpd/branches/2.4.x/STATUS

2016-04-26 Thread William A Rowe Jr
On Tue, Apr 26, 2016 at 3:47 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > Reviewing the applicable patch, the client, request and protocol now appear > ... the client, vhost and protocol now appear ... > to persist for idle connections, but the reques

Re: svn commit: r1739876 - /httpd/httpd/branches/2.4.x/STATUS

2016-04-26 Thread William A Rowe Jr
Reviewing the applicable patch, the client, request and protocol now appear to persist for idle connections, but the request is still NULL? Is this by design? Or is something missing from the patch? On Tue, Apr 19, 2016 at 4:19 AM, wrote: > Author: rpluem > Date: Tue Apr 19

Re: "Upgrade: h2" header for HTTP/1.1 via TLS (Bug 59311)

2016-04-19 Thread William A Rowe Jr
On Tue, Apr 19, 2016 at 10:59 AM, Stefan Eissing < stefan.eiss...@greenbytes.de> wrote: > > > Am 19.04.2016 um 17:47 schrieb William A Rowe Jr <wr...@rowe-clan.net>: > > > > I agree with your analysis, "h2" is not an upgrade candidate. > > >

Re: "Upgrade: h2" header for HTTP/1.1 via TLS (Bug 59311)

2016-04-19 Thread William A Rowe Jr
On Tue, Apr 19, 2016 at 11:26 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > On Tue, Apr 19, 2016 at 11:04 AM, Jacob Champion <champio...@gmail.com> > wrote: > >> On 04/19/2016 08:47 AM, William A Rowe Jr wrote: >> > I agree with your analys

Re: "Upgrade: h2" header for HTTP/1.1 via TLS (Bug 59311)

2016-04-19 Thread William A Rowe Jr
On Tue, Apr 19, 2016 at 11:04 AM, Jacob Champion <champio...@gmail.com> wrote: > On 04/19/2016 08:47 AM, William A Rowe Jr wrote: > > I agree with your analysis, "h2" is not an upgrade candidate. > > > > "h2c" is an upgrade candidate. > > Is a

Re: "Upgrade: h2" header for HTTP/1.1 via TLS (Bug 59311)

2016-04-19 Thread William A Rowe Jr
I agree with your analysis, "h2" is not an upgrade candidate. "h2c" is an upgrade candidate. This isn't even an HTTP/2 issue (unless the working group reverses themselves on accepting Upgrade: h2 protocol switching), until we accept Upgrade: h2 we should be dropping h2 from the server Upgrade:

Re: allow newlines in T_ESCAPE_LOGITEM?

2016-04-18 Thread William A Rowe Jr
That doesn't work because it's no longer atomic, those log lines end up fanned out among all the other worker threads doing the same thing. Very hard to parse. On Mon, Apr 18, 2016 at 3:08 PM, Stefan Fritsch wrote: > On Monday 18 April 2016 10:42:23, Eric Covener wrote: > >

Re: New segfault with 2.4.20 with mod_perl

2016-04-14 Thread William A Rowe Jr
824;msg=5 On Thu, Apr 14, 2016 at 11:55 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > We can be more vigilant about unexpectedly null values, however... > > how are you running request processing in the connection callback > of mod_perl? That makes no sense, and probably sig

Re: New segfault with 2.4.20 with mod_perl

2016-04-14 Thread William A Rowe Jr
We can be more vigilant about unexpectedly null values, however... how are you running request processing in the connection callback of mod_perl? That makes no sense, and probably signals a deeper logic error. The access checker is configured per-dir, so until the request rec is completely

Re: New segfault with 2.4.20 with mod_perl

2016-04-13 Thread William A Rowe Jr
I wrote the patch for ap_get_useragent_host, but am not familiar with the details of the report. Researching... On Wed, Apr 13, 2016 at 5:33 PM, Stefan Fritsch wrote: > Hi, > > I got a report about a new crash in mod_perl tests with 2.4.20: > > (gdb) bt > #0

Re: svn commit: r1738292 - /httpd/httpd/branches/2.4.x/STATUS

2016-04-11 Thread William A Rowe Jr
On Fri, Apr 8, 2016 at 6:25 PM, Eric Covener <cove...@gmail.com> wrote: > On Fri, Apr 8, 2016 at 6:32 PM, William A Rowe Jr <wr...@rowe-clan.net> > wrote: > > It was working, in the sense that it had the intended effect (the > [un]define > > took effe

Re: svn commit: r1738292 - /httpd/httpd/branches/2.4.x/STATUS

2016-04-08 Thread William A Rowe Jr
It was working, in the sense that it had the intended effect (the [un]define took effect) in the broader global context. This is a breaking change to some potentially existing configs, however misguided they are, which is the sort of thing we've avoided in the released branch. Could we log an

Re: proxy API compat break in 2.4.7

2016-04-07 Thread William A Rowe Jr
The first most important documentation of this should be in ap_mmn.h, as we've done in the past (you'll see some highlights). A note under the CHANGES entry for 2.4.7 seems worthwhile. Pointing this out under Announcement seems appropriate, that users of third party mod_proxy-consuming modules

Re: Any one doing it?

2016-04-01 Thread William A Rowe Jr
On Fri, Apr 1, 2016 at 11:49 AM, Yann Ylavic wrote: > On Fri, Apr 1, 2016 at 6:36 PM, Luca Toscano > wrote: > > > > +1, let's concentrate on 2.4 :) > > You know, there is still many 2.2 around, and some people may have > backported 2.4 fixes to 2.2

Re: Status for 2.4.20

2016-03-29 Thread William A Rowe Jr
FULL STOP. The next person to demand the last word of this thread will be iptables deleted from existence at a.o. Can you all appreciate that ~2000 people have to read all of your pissing contests? This is simply not acceptable. Be done with it.

Re: Status for 2.4.20

2016-03-28 Thread William A Rowe Jr
@Everyone on this thread - keep it civil. On Fri, Mar 25, 2016 at 10:13 PM, Noel Butler wrote: > On 25/03/2016 19:52, Graham Leggett wrote: > >> On 23 Mar 2016, at 1:58 PM, Noel Butler wrote: >> >> as stated previously, this shit will happen when

Re: mod_http2 on Windows (was: Re: Status for 2.4.20)

2016-03-24 Thread William A Rowe Jr
On Thu, Mar 24, 2016 at 11:40 AM, Jan Ehrhardt <php...@ehrhardt.nl> wrote: > William A Rowe Jr in gmane.comp.apache.devel (Thu, 24 Mar 2016 09:16:17 > -0500): > >> > http://windows.php.net/downloads/snaps/master/r454ae8a/logs/make-ts-windows-vc14-x64-r454ae8a.html > &

Re: mod_status Total Accesses with 2.4.20

2016-03-24 Thread William A Rowe Jr
The inner http2 response to the outer h1 upgrade request remains a single request IMHO. Within that h2 collection of streams, each of the subsequent h2 requests should then be counted individually. On Thu, Mar 24, 2016 at 10:54 AM, Yann Ylavic wrote: > Should the

Re: mod_http2 on Windows (was: Re: Status for 2.4.20)

2016-03-24 Thread William A Rowe Jr
On Thu, Mar 24, 2016 at 9:31 AM, Yann Ylavic wrote: > >> nghttp2_session.c(160) : warning C4996: 'vsnprintf': This function or > >> variable may be unsafe. Consider using vsnprintf_s instead. To disable > >> deprecation, use _CRT_SECURE_NO_WARNINGS. > > [sarcasm] >

Re: mod_http2 on Windows (was: Re: Status for 2.4.20)

2016-03-24 Thread William A Rowe Jr
On Thu, Mar 24, 2016 at 8:49 AM, Jan Ehrhardt <php...@ehrhardt.nl> wrote: > William A Rowe Jr in gmane.comp.apache.devel (Thu, 24 Mar 2016 07:58:45 > -0500): > >Precisely, Jan. We don't know where these truncation errors lead - do > they > >portentially open sec

Re: apr_global_mutex_create vs apr_proc_mutex_create

2016-03-24 Thread William A Rowe Jr
proc_mutex can only be used to block on a cross process event. It can be used in a threaded server, but cannot be held in multiple threads, you might use it to block in a single thread queue per-process. Thread_mutex will not block between processes, this is used for the mutex-per-process logic

Re: apr_global_mutex_create vs apr_proc_mutex_create

2016-03-24 Thread William A Rowe Jr
proc_mutex can only be used to block on a cross process event. It can be used in a threaded server, but cannot be held in multiple threads, you might use it to block in a single thread queue per-process. Thread_mutex will not block between processes, this is used for the mutex-per-process logic

Re: 2.4.20 Change dsp: Win32-specific build files.

2016-03-24 Thread William A Rowe Jr
Studio 2010 users cannot convert our .dsp files. > That's not true, I convert them. > > Steffen > > > > From: William A Rowe Jr Sent: Wednesday, March 23, 2016 9:23 PM > To: httpd Subject: * Re: 2.4.20 Change dsp: Win32-specific build > files. > > On Wed, Mar 2

mod_http2 on Windows (was: Re: Status for 2.4.20)

2016-03-24 Thread William A Rowe Jr
On Mar 23, 2016 22:19, "Jan Ehrhardt" <php...@ehrhardt.nl> wrote: > > William A Rowe Jr in gmane.comp.apache.devel (Wed, 23 Mar 2016 08:00:19 > -0500): > >On Wed, Mar 23, 2016 at 7:42 AM, William A Rowe Jr <wr...@rowe-clan.net> > >wrote: > > &g

Re: 2.4.20 Change dsp: Win32-specific build files.

2016-03-23 Thread William A Rowe Jr
On Wed, Mar 23, 2016 at 11:12 AM, Steffen wrote: > I went earlier back, so I did a .dsp/GUI build with no issues. > > Build with SVN revision 1736328. > > Running looks also fine sofar. > Glad to hear, thanks for testing. I've updated the commit log message to more

Re: 2.4.20 Change dsp: Win32-specific build files.

2016-03-23 Thread William A Rowe Jr
On Mar 23, 2016 3:15 AM, "Steffen" wrote: > > Saw that wrowe did a change win make files in 2.4. branche. > > The comment says the the .dsp flies are entirely ! unusable. > > I can tell that they are entirely usable with V9-VC14. What was the issue ? They were directly

Re: Status for 2.4.20

2016-03-23 Thread William A Rowe Jr
On Wed, Mar 23, 2016 at 7:42 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > > branches/2.4.x/modules/http2/h2_filter.c > > Again, a C89 regression breaking the candidate, but in an experimental > module that we don't promise will always build. nghttp2 is filled with C

Re: Status for 2.4.20

2016-03-23 Thread William A Rowe Jr
On Mar 23, 2016 6:23 AM, "Steffen" wrote: > > Just did a export; > > Diff with the vote 2.4.19 one: > > branches/2.4.x/modules/cache/mod_socache_shmcb.c Correct. I'm not claiming this is win32-specific, it only happens to show up on that and other edge cases. >

Re: fate of mod_lbmethod_rr (was: Re: [VOTE] Release Apache httpd 2.4.19 as GA)

2016-03-22 Thread William A Rowe Jr
On Tue, Mar 22, 2016 at 4:15 PM, Jeff Trawick <traw...@gmail.com> wrote: > On Tue, Mar 22, 2016 at 5:03 PM, William A Rowe Jr <wr...@rowe-clan.net> > wrote: > >> On Tue, Mar 22, 2016 at 3:38 PM, Jeff Trawick <traw...@gmail.com> wrote: >> >>> On Tue

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

2016-03-22 Thread William A Rowe Jr
I've had success with Jeff's minimalist nghttp build schema. A larger effort at a cmake for the full stack (lib+apps) has been in the works for a month or two now, haven't had a chance to try it. On Mar 22, 2016 6:27 PM, "Jan Ehrhardt" wrote: > Jeff Trawick in

<    6   7   8   9   10   11   12   13   14   15   >