This is going to directly impact the selection script and permutation-based
compilation of GWT 2.x.
I've read several times that some people use a single user.agent value
(can't remember if it's gecko1_8 or safari), do we have some guarantees
that this will work reliably across "evergreen browse
Hi all,
3½ years ago, we announced 2.8.0-beta1 and that it now required JDK 7, and
that started quite a long discussion:
https://groups.google.com/d/topic/google-web-toolkit-contributors/TzsINiDf5xg/discussion
A few days ago, there's been renewed interest into upgrading the Jetty
version GWT is
Moved to Gerrit: https://gwt-review.googlesource.com/3834
http://gwt-code-reviews.appspot.com/1822803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from t
Moved to https://gwt-review.googlesource.com/3832
http://gwt-code-reviews.appspot.com/1430801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this grou
Moved to https://gwt-review.googlesource.com/3831
http://gwt-code-reviews.appspot.com/1594804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this grou
Patch moved to Gerrit: https://gwt-review.googlesource.com/3650
http://gwt-code-reviews.appspot.com/1839803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe
If you still care about it, could you please move the patch over to
Gerrit?
http://www.gwtproject.org/makinggwtbetter.html
http://gwt-code-reviews.appspot.com/1893803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to t
Can someone move that patch over to Gerrit? Would you prefer that I do
it?
(BTW, any reason this hadn't been reviewed yet?)
http://gwt-code-reviews.appspot.com/1839803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to
On 2013/05/28 08:52:04, larsaaslin wrote:
Can I run only MostToLeastDerivedPlaceTypeComparatorTest with an ant
command?
Yes "ant test
-Dgwt.junit.testcase.includes=**/MostToLeastDerivedPlaceTypeComparatorTest.class"
or "cd user && ant test.nongwt
-Dgwt.nongwt.testcase.includes=**/MostToLeastDe
Sounds good!
http://gwt-code-reviews.appspot.com/1899803/diff/5005/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
File
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
(right):
http://gwt-code-reviews.appspot.com/1899803/diff
Could you please add some unit-tests?
http://gwt-code-reviews.appspot.com/1899803/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from thi
We just need someone with commit rights. Calling in Matthew (at random),
who will delegate if needed.
http://gwt-code-reviews.appspot.com/1895803/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "
I'm still not convinced that this is an issue worth fixing (we don't
allow adding optgroups either; ListBox is a simple wrapper around a
select, with a simple API; if you want more, you can make a more complex
widget with a more complex API), but here are my comments anyway.
I'm not sure I agree
Marius: I agree with your comments, but this change has actually been
merged already (despite not being closed here).
Please file an issue and possibly provide a patch (preferably to Gerrit
rather than Rietveld)
As for the reasons of the method overrides, it probably has to do with
this:
http://
LGTM
http://gwt-code-reviews.appspot.com/1895803/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails
http://gwt-code-reviews.appspot.com/1893803/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from
On 2013/01/28 21:06:02, mdempsky wrote:
On 2013/01/12 15:35:19, tbroyer wrote:
> We're in dev-time code so we can use Guava (the re-packaged one) and
it's
> Objects.equal(a, b) which takes care of nulls.
I don't think that's true. This code still needs to be translatable
to
JavaScript to
According to
http://code.google.com/p/google-web-toolkit/issues/detail?id=7919 it
worked the way you describe in GWT 2.4 so let's go ahead and fix this.
Apparently the regression was introduced in
https://code.google.com/p/google-web-toolkit/source/detail?r=11174
Daniel: how's 2.5.1 going? is it
LGTM. Nothing controversial I believe.
This is a pretty big change though, so maybe an additional pair of eyes
would be better (but maybe you also have an internal review ongoing?)
http://gwt-code-reviews.appspot.com/1827804/diff/1/user/src/com/google/gwt/core/client/impl/Impl.java
File user/sr
Can you please make your patch from trunk/ rather than
trunk/user/src/com/google/gwt/user/datepicker/client/ ?
That said, there are other implications than just selecting from the
calendar view:
- what if I setValue() with a disabled date? (I mean, what should be
the expected behavior)
- what i
On 2013/01/22 15:46:27, arobison wrote:
Removed the new cell table builder and reworked to make the change in
AbstractCellTable instead. Removed the isKeyboardSelectable stuff.
Can you update the description to match the actual changes? (I must say
I'm a bit lost).
If it indeed is a fix for is
Superseded by http://gwt-code-reviews.appspot.com/1883803
miichal, you can close this review.
http://gwt-code-reviews.appspot.com/1882803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
FYI, an issue related to this change:
https://code.google.com/p/google-web-toolkit/issues/detail?id=7677
http://gwt-code-reviews.appspot.com/1879804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
(adding jtamplin as a reviewer as it's in I18N)
http://gwt-code-reviews.appspot.com/1882803/diff/1/user/src/com/google/gwt/i18n/client/TimeZoneInfo.java
File user/src/com/google/gwt/i18n/client/TimeZoneInfo.java (right):
http://gwt-code-reviews.appspot.com/1882803/diff/1/user/src/com/google/gwt
http://gwt-code-reviews.appspot.com/1879804/diff/1/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java
File user/src/com/google/gwt/xhr/client/XMLHttpRequest.java (right):
http://gwt-code-reviews.appspot.com/1879804/diff/1/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java#newcode377
user
http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):
http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapte
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/Edi
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/Edi
Ping; would be great to have it in 2.5.1! (IIRC, we initially talked
about including it in 2.5.0 and finally decided to postpone it to the
next release)
http://gwt-code-reviews.appspot.com/1587803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1649803/diff/1/src/test/java/com/google/gwt/junit/client/impl/JUnitHost.java
File src/test/java/com/google/gwt/junit/client/impl/JUnitHost.java
(right):
http://gwt-code-reviews.appspot.com/1649803/diff/1/src/test/java/com/google/gwt/junit/client/impl/JUnitHost
LGTM
http://gwt-code-reviews.appspot.com/1880804/diff/4001/user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
File user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
(right):
http://gwt-code-reviews.appspot.com/1880804/diff/4001/user/src/com/google/gwt/user/client/ui/SplitLa
http://gwt-code-reviews.appspot.com/1880804/diff/1/user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
File user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
(right):
http://gwt-code-reviews.appspot.com/1880804/diff/1/user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.ja
Note: this seems to be a fix for issue 7508.
https://code.google.com/p/google-web-toolkit/issues/detail?id=7508
http://gwt-code-reviews.appspot.com/1879803/diff/1/user/src/com/google/gwt/user/cellview/client/ExpandedCellTableBuilder.java
File
user/src/com/google/gwt/user/cellview/client/Expanded
http://gwt-code-reviews.appspot.com/1880803/diff/7001/dev/core/src/com/google/gwt/util/tools/Utility.java
File dev/core/src/com/google/gwt/util/tools/Utility.java (right):
http://gwt-code-reviews.appspot.com/1880803/diff/7001/dev/core/src/com/google/gwt/util/tools/Utility.java#newcode54
dev/core
LGTM
(BTW why was the GWT-Contrib group removed from CC?)
http://gwt-code-reviews.appspot.com/1880803/diff/1/user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1880803/diff/
You might want to try out Git/Gerrit ;-)
http://gwt-code-reviews.appspot.com/1880803/diff/1/user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1880803/diff/1/user/src/com/goo
Only suggestions, we probably need microbenchmarks to choose between the
alternatives, as AbstractMap is used a lot within applications (at least
one per Widget, then an additional one per event type with a registered
handler).
http://gwt-code-reviews.appspot.com/1877803/diff/1/user/super/com/go
And +1 to everything Matthew already said.
http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImpl.java
File user/src/com/google/gwt/http/client/RequestImpl.java (right):
http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/c
http://gwt-code-reviews.appspot.com/1873803/diff/1/user/src/com/google/gwt/dom/client/Element.java
File user/src/com/google/gwt/dom/client/Element.java (right):
http://gwt-code-reviews.appspot.com/1873803/diff/1/user/src/com/google/gwt/dom/client/Element.java#newcode565
user/src/com/google/gwt/d
http://gwt-code-reviews.appspot.com/1873803/diff/1/user/src/com/google/gwt/dom/client/Element.java
File user/src/com/google/gwt/dom/client/Element.java (right):
http://gwt-code-reviews.appspot.com/1873803/diff/1/user/src/com/google/gwt/dom/client/Element.java#newcode104
user/src/com/google/gwt/d
On 2012/11/02 16:37:08, rkj wrote:
On 2012/11/02 02:14:47, tbroyer wrote:
> FYI, there's an issue for that:
> http://code.google.com/p/google-web-toolkit/issues/detail?id=6865
> (understand: whose status should be updated)
Thanks, that's exactly this issue. I have a UI problem though - I do
n
FYI, there's an issue for that:
http://code.google.com/p/google-web-toolkit/issues/detail?id=6865
(understand: whose status should be updated)
http://gwt-code-reviews.appspot.com/1864803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
You're basically trading a compile-time error for a runtime error. I
must say I don't quite like it.
IIRC, the Editor framework mandates that the editor type (from the
Editor parameterization) and the edited type (from the property or
field, or the EditorDriver parameterization) must be the same.
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java
File
user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java
(right):
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/
On 2012/10/19 12:50:40, tbroyer wrote:
Except you missed one that spans 2 lines in ImageLoadingCell.
(caught using "grep -R -A 1 'setInnerHTML' user/src/com/google/gwt/
|grep
asString |grep -v setInnerHTML" ;-) )
Ah, missed it in the patch; you already caught it, great!
http://gwt-code-revie
D'oh, where was I when Element#setInnerSafeHtml was added? Didn't know
it even existed!
LGTM++
Except you missed one that spans 2 lines in ImageLoadingCell.
(caught using "grep -R -A 1 'setInnerHTML' user/src/com/google/gwt/
|grep asString |grep -v setInnerHTML" ;-) )
http://gwt-code-reviews.ap
On 2012/10/13 03:42:46, cromwellian wrote:
One option is to have an extra method like encodeForHtmlContext()
where you only
pay the tax in that circumstance.
Would it cost really that much to post-process the output from AutoBeans
(possibly depending on context)?
For instance, using OWASP ES
Should HTML-specific escaping be done on top of the value produced by
AutoBeans? Do we really want to pay the tax (each one of <>&='" is
replaced by 6 chars!) for each AutoBean-based exchanged over the wire
(for example, RequestFactory uses Base64-encoding for its stableId and
version, which makes
On 2012/10/07 02:00:09, rajneeshg wrote:
On 2012/05/21 20:03:28, stephenh wrote:
I am on 2.5.0-rc1. I am still having this issue. Anybody knows when is
this fix
scheduled for.
2.5.1 or 2.6: the version after 2.5.0.
http://gwt-code-reviews.appspot.com/1601804/
--
http://groups.google.com/
LGTM
http://gwt-code-reviews.appspot.com/1836803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1836803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Do you think it would be possible to share the BUILD file(s), or a
stripped-down version of it, even privately?
I'd love to see how it compares to Maven and other build systems.
Now back to the CL: given the move to Git soon, which will require some
changes on your side, is it wise to make such a
http://gwt-code-reviews.appspot.com/1828803/diff/9001/samples/dynatablerf/pom.xml
File samples/dynatablerf/pom.xml (right):
http://gwt-code-reviews.appspot.com/1828803/diff/9001/samples/dynatablerf/pom.xml#newcode120
samples/dynatablerf/pom.xml:120: 2.3.0-1
Oh, I'm really sorry I let it slip thr
My 2 c€nts
http://gwt-code-reviews.appspot.com/1831803/diff/1/user/src/com/google/gwt/aria/client/Roles.java
File user/src/com/google/gwt/aria/client/Roles.java (right):
http://gwt-code-reviews.appspot.com/1831803/diff/1/user/src/com/google/gwt/aria/client/Roles.java#newcode137
user/src/com/goo
I'm sorry I've only started to review the files (over the last few days)
but I have a first question/comment about where this is going:
There are many things that are not needed in the case of MobileWebApp as
the host page is protected behind authentication. Because the user won't
ever see this p
Possibly related:
http://code.google.com/p/google-web-toolkit/issues/detail?id=1821
http://gwt-code-reviews.appspot.com/1827804/diff/1/user/src/com/google/gwt/core/client/GWT.java
File user/src/com/google/gwt/core/client/GWT.java (right):
http://gwt-code-reviews.appspot.com/1827804/diff/1/user/
On 2012/09/14 00:27:24, skybrian wrote:
On 2012/09/13 20:22:43, tbroyer wrote:
> I kind of like the enums as in com.google.gwt.dom.client.Style (also
used in
> SafeStyles), but I'll make the setResponseType(String) public, and
add a
> getResponseTypeString() to the enum.
Oops, I guess I
https://gwt-code-reviews.appspot.com/1829804/diff/1/user/src/com/google/web/bindery/autobean/shared/impl/AutoBeanCodexImpl.java
File
user/src/com/google/web/bindery/autobean/shared/impl/AutoBeanCodexImpl.java
(right):
https://gwt-code-reviews.appspot.com/1829804/diff/1/user/src/com/google/web/bi
On 2012/09/13 18:23:04, skybrian wrote:
I don't see any usages of XmlHttpRequest.ResponseType in Google code.
OK, so I'll remove the create(ResponseType).
We could have constants instead of the enum.
I kind of like the enums as in com.google.gwt.dom.client.Style (also
used in SafeStyles), b
On 2012/09/13 18:35:35, manolo.carrasco wrote:
We are using domain interfaces in a couple of projects and finally we
decided to
patch this file to avoid such amount of extra code.
I thought this was a very small piece of code which IMHO fixes an
important
issue, and could be related with this
Reviewers: unnurg, jtamplin,
Message:
I've grep'ed in all com.google.web.bindery and didn't find any other
instance.
I also quickly looked into com.google.gwt in case there could have been
similar issues with GWT-RPC or some "shared" code, but didn't find
anything either.
Description:
Synchroniz
https://gwt-code-reviews.appspot.com/1830803/diff/2003/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java
File user/src/com/google/gwt/xhr/client/XMLHttpRequest.java (right):
https://gwt-code-reviews.appspot.com/1830803/diff/2003/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java#newcode
On 2012/09/13 17:16:52, skybrian wrote:
Since this API is essentially just a wrapper around the JavaScript
object and
there's no place to stash the desired response type, adding the setter
and
deprecating create() with a response type seems like the way to go.
Done.
I wonder if we shouldn
On 2012/09/12 21:02:42, jtamplin wrote:
On 2012/09/12 20:47:20, skybrian wrote:
> Hmm, I'm inclined to skip this patch for GWT 2.5. The typo fix at
least makes
it
> work on some browsers...
If I understand Thomas' test results, the getter works properly
everywhere -- it
is the existing set
On 2012/09/12 19:18:12, skybrian wrote:
We've decided against this change for now (increases the size of the
API too
much). A HasElement interface sounds somewhat reasonable but we can
add that
later if needed.
I suppose if Element implemented HasElement, returning itself, we
could avoid
I haven't looked at the changes (from the description, they should be
simple and straightforward) but what bothers me is that it introduces a
cyclic dependency: c.g.g.user depends on c.g.g.aria which now also
depends on c.g.g.user.
Also, that dependency isn't reflected in the .gwt.xml (so one cou
On 2012/09/12 16:03:13, tbroyer wrote:
I'll try on IE7, IE8 and IE9 next (currently downloading the VMs from
the MSDN).
Results from https://browserlab.adobe.com
IE7, IE8 and IE9: works as an expando (no error; prints undefined,
arraybuffer, dummy)
Chrome 18 / Windows: throws on setting to "du
On 2012/09/12 14:32:37, jtamplin wrote:
Did you test it? It probably needs testing on IE6 if GWT still
officially
supports it, since I recall some weirdness about getting exceptions if
you
referenced properties that didn't exist on native objects that were
exposed to
JS.
Just ran the fol
http://gwt-code-reviews.appspot.com/1828803/diff/1/samples/dynatablerf/pom.xml
File samples/dynatablerf/pom.xml (right):
http://gwt-code-reviews.appspot.com/1828803/diff/1/samples/dynatablerf/pom.xml#newcode55
samples/dynatablerf/pom.xml:55:
Is this still needed? Isn't the GPE smart enough?
(I
Reviewers: jtamplin, cromwellian,
Message:
Follow-up to https://gwt-code-reviews.appspot.com/1820806
See http://code.google.com/p/google-web-toolkit/issues/detail?id=7386#c8
Description:
Add a getter for XHR's responseType.
Issue 7386
Please review this at https://gwt-code-reviews.appspot.co
On 2012/09/10 22:57:14, skybrian wrote:
I don't know this code, but since pushViolations() and
iterableFromConstraintViolations() are both public methods, under the
principle
of being conservative about what you send and liberal about what you
receive, it
seems like iterableFromConstraintViol
Brian: Unnur thinks you'd review that patch faster than her ;-)
https://gwt-code-reviews.appspot.com/1827803/diff/1/user/src/com/google/gwt/user/cellview/client/CellTree.java
File user/src/com/google/gwt/user/cellview/client/CellTree.java (right):
https://gwt-code-reviews.appspot.com/1827803/di
Adding Brian as reviewer, as discussed with Unnur.
https://gwt-code-reviews.appspot.com/1820807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: atincheva,
Message:
Note: I only applied the suggested fix (after checking the WAI-ARIA
spec), I haven't tried it with a screenreader (actually, it's so
straightforward I haven't tried it at all).
Description:
Add aria-hidden state to layout panel rulers.
Issue 7646
Please review t
Reviewers: unnurg,
Description:
CellTree disappeared when clicking in the widget but outside tree nodes.
Issue 6359
Please review this at https://gwt-code-reviews.appspot.com/1827803/
Affected files:
M user/src/com/google/gwt/user/cellview/client/CellTree.java
Index: user/src/com/google/g
LGTM
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java
File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java#newcode878
us
On 2012/09/10 12:03:20, jtamplin wrote:
BTW: you should create code reviews at
http://gwt-code-reviews.appspot.com/
instead.
There is a also a TODO to support SafeHtml here. I'm not entirely
sure what
that means in this case (Doesn't TextBox already ensure the string is
uninterpreted? Do
My preferred option, with one small adjustment to make it a non-breaking
change.
https://codereview.appspot.com/6492092/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBox.java
File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):
https://codereview.appspot.com/6492092/diff/
I think I prefer the other option about changing SuggestBox.
https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBox.java
File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):
https://codereview.appspot.com/6494102/diff/1/user/src/com/googl
https://gwt-code-reviews.appspot.com/1826803/diff/2001/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java
File
user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java
(right):
https://gwt-code-revi
Reviewers: skybrian,
Description:
EditorDriver#setConstraintViolations used to thrown NPE if arg was null.
Issue 6578
Please review this at https://gwt-code-reviews.appspot.com/1826803/
Affected files:
M user/src/com/google/gwt/editor/client/impl/SimpleViolation.java
M
user/src/com/goog
On 2012/09/09 23:24:59, jtamplin wrote:
We really need to get an updated HtmlUnit so we can have automated
tests for
some of these things.
I don't know the status of HtmlUnit, but trying new versions should be
made much easier with the move Maven. That being said, I skimmed
HtmlUnit's Web si
Reviewers: jtamplin, unnurg,
Description:
xhr.responseType was misspelled as responsetype (lowercase t)
Issue 7386
Please review this at https://gwt-code-reviews.appspot.com/1820806/
Affected files:
M user/src/com/google/gwt/xhr/client/XMLHttpRequest.java
Index: user/src/com/google/gwt/xh
ping!
(would be great to have it in 2.5)
https://gwt-code-reviews.appspot.com/1772803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: cromwellian,
Message:
Didn't know who to assign this review to, feel free to reassign.
Description:
Long.parseLong raised exception for MIN_VALUE
This is because we accumulated positive values and -MIN_VALUE ==
MAX_VALUE + 1
so when parsing MIN_VALUE, the accumulated value overflows
On 2012/09/06 23:06:29, skybrian wrote:
Thanks Thomas, that helps. (I think serverTypeToProxyTypes might be a
better name.)
Well, "domain" and "client" are used throughout the RF APIs, so it's
more a matter of learning the definitions ;-)
http://google-web-toolkit.googlecode.com/svn/javadoc/lat
Note this fixes
http://code.google.com/p/google-web-toolkit/issues/detail?id=6197 and
there was already a patch pending review, submitted almost one year ago:
http://gwt-code-reviews.appspot.com/1568803/
http://gwt-code-reviews.appspot.com/1823803/
--
http://groups.google.com/group/Google-Web-To
https://gwt-code-reviews.appspot.com/1712803/diff/2001/user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java
File
user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java
(right):
https://gwt-code-reviews.appspot.com/1712803/diff/2001/user/src/com/google/web/bi
LGTM
http://gwt-code-reviews.appspot.com/1820805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: cromwellian, rdayal,
Description:
Remove long-deprecated event listeners and EventPreview.
Please review this at https://gwt-code-reviews.appspot.com/1822803/
Affected files:
M
reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java
D
reference/code-
https://gwt-code-reviews.appspot.com/1821804/diff/1/user/test/com/google/gwt/dev/shell/jsp/client/JspTest.java
File user/test/com/google/gwt/dev/shell/jsp/client/JspTest.java (right):
https://gwt-code-reviews.appspot.com/1821804/diff/1/user/test/com/google/gwt/dev/shell/jsp/client/JspTest.java#n
Reviewers: cromwellian,
Description:
Remove long-deprecated GWTShell and GWTCompiler tools.
Added a test to make sure JSP works.
Please review this at https://gwt-code-reviews.appspot.com/1821804/
Affected files:
M dev/build.xml
M dev/core/src/com/google/gwt/dev/CompileTaskRunner.java
D
Reviewers: cromwellian,
Message:
See
https://groups.google.com/d/topic/google-web-toolkit-contributors/6z9x8S0FYh0/discussion
for the rationale.
Description:
Remove Windows-specific JNI for the "check for updates"
Remove -Dgwt.devjar in many places, as we no longer have native libs.
Please re
http://gwt-code-reviews.appspot.com/1819803/diff/1/user/src/com/google/gwt/user/client/ui/Tree.java
File user/src/com/google/gwt/user/client/ui/Tree.java (right):
http://gwt-code-reviews.appspot.com/1819803/diff/1/user/src/com/google/gwt/user/client/ui/Tree.java#newcode641
user/src/com/google/gw
On 2012/08/28 13:17:58, jtamplin wrote:
LGTM, as far as it goes
However, when you use GWT.create in non-client code, there is some
setup you
need to do - you have to create the ServerGwtBridge, set the deferred
binding
properties (either globally or per-thread), and you need to register
a
Reviewers: skybrian,
Message:
For inclusion in GWT 2.5
Description:
Use c.g.g.core.shared.GWT in shared code.
Issue 7527
Please review this at https://gwt-code-reviews.appspot.com/1818803/
Affected files:
M user/src/com/google/gwt/dom/builder/shared/ElementBuilderFactory.java
M user/src/c
Are there tests that could be added / updated?
http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImpl.java
File src/com/google/gwt/dom/client/DOMImpl.java (right):
http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImpl.java#new
FYI, my take on authentication and RequestFactory can be found at
https://github.com/tbroyer/gwt-maven-archetypes/tree/master/guice-rf-activities
(also uses Guice, GIN and Guava).
I'm in the process of trading the userName and isAdmin JS variables for
an object (managing ser/deserialization with A
absoluteTop/Left are not enough:
http://code.google.com/p/google-web-toolkit/issues/detail?id=7575
And WebKit is probably not enough too (subpixel rendering is becoming
standard, and will soon be mainstream).
http://gwt-code-reviews.appspot.com/1797805/
--
http://groups.google.com/group/Google-
I'm not against this kind of change but IMO any deviation from the JSON
and/or ECMAScript specs should be documented, or we risk removing them
at a later time and break things again (that being said, I don't
understand what's "broken" here and how this CL "fixes" it wrt JDK 7, as
all I see is Java
1 - 100 of 532 matches
Mail list logo
