Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > I do not seem to have a server.log. At least I cannot find one in > WinSCP. Check PM. *Plugin repositories:* 'Ratings Light FAQ' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
AF1 wrote: > Material Skin should display the plugin version after its name on the > LMS settings plugins page. > Please do check your *server* log for any RL related server log > messages. I do not seem to have a server.log. At least I cannot find one in WinSCP. rpi 3+ with lms 8.1.0 -- rpi 2 with a hifiberry dac+ running picoreplayer -- sbr running firmware 8.0 -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, ratings light, exclude folders -- dsm 6.2.2 (synology disk station 115) has my music -- streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > Hi and thanks for your reply. > I just updated my signature and would like to state that I am on LMS 8.1 > on a RPI3plus, RL version I don't know, it's not listed in the plugins > section of Material Skin. I have a lot of rated tracks that also display > accordingly. > The location of my playlist folder is ok and working (judging by > playlist accessibility). I had restored my ratings from the original > playlist I had created in Musicbee. Material Skin should display the plugin version after its name on the LMS settings plugins page. Please do check your *server* log for any RL related server log messages. *Plugin repositories:* 'Ratings Light FAQ' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
AF1 wrote: > Works for me (RL 2.1.2, LMS 8.3 and 8.2). > Since you didn't provide your OS, LMS & RL versions or any *RL related > error or warning messages from the server log*, I'd have to guess. > You mentioned some time ago, a couple of posts earlier, that you'd lost > all of your LMS ratings for some reason. RL will not write a backup file > unless it finds at least 1 rated track (what would be the point?). You > could check: rate a track in LMS and then create a RL backup. > Also maybe check the location of your RL folder (i.e. its parent folder) > in the RL settings, just in case you've changed the default value (LMS > playlist folder). Hi and thanks for your reply. I just updated my signature and would like to state that I am on LMS 8.1 on a RPI3plus, RL version I don't know, it's not listed in the plugins section of Material Skin. I have a lot of rated tracks that also display accordingly. The location of my playlist folder is ok and working (judging by playlist accessibility). I had restored my ratings from the original playlist I had created in Musicbee. rpi 3+ with lms 8.1.0 -- rpi 2 with a hifiberry dac+ running picoreplayer -- sbr running firmware 8.0 -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, ratings light, exclude folders -- dsm 6.2.2 (synology disk station 115) has my music -- streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > Hello, > I have a folder in my playlist folder where I have older backups from > RatingsLight. When I tell it to backup or export I don't see any new > files there. Where would these backup files be located? I doubt that > anything happens at all because RatingsLight tells me after 0 seconds > that the task is completed. So I suspect nothing is happening at all. Works for me (RL 2.1.2, LMS 8.3 and 8.2). Since you didn't provide your OS, LMS & RL versions or any *RL related error or warning messages from the server log*, I'd have to guess. You mentioned some time ago, a couple of posts earlier, that you'd lost all of your LMS ratings for some reason. RL will not write a backup file unless it finds at least 1 rated track (what would be the point?). You could check: rate a track in LMS and then create a RL backup. Also maybe check the location of your RL folder (i.e. its parent folder) in the RL settings, just in case you've changed the default value (LMS playlist folder). *Plugin repositories:* 'Ratings Light FAQ' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Hello, I have a folder in my playlist folder where I have older backups from RatingsLight. When I tell it to backup or export I don't see any new files there. Where would these backup files be located? I doubt that anything happens at all because RatingsLight tells me after 0 seconds that the task is completed. So I suspect nothing is happening at all. dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, ratings light, exclude folders streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Wojtulek wrote: > I have only 50 cd which are already rated. Plus some tracks from my > favourite albums on Tidal. > Is it possible to export ratings to external services like last.fm or > allmusic? Or maybe integration should be bideraractional and I should > rate tracks/albums eg in last.fm (i prefer it over allmusic)? > Ok there is only rating on Allmusic for album and "hearts" on last.fm > for tracks... LMS has the best rating system then (Roon users are still > waiting for "starts" - they started asking for it 5y ago or so) Rating in LMS and Ratings Light is only about rating tracks that part of your LMS library (local and online, RL FAQ for more details). I've never considered syncing track ratings to online services, and I don't think I will. Most of them, as you saw, now use some kind of binary like/heart system, and I prefer the 5-star scale. The most important reason is simply that I would not have the time to keep RL compatible with possible (API) changes of the various -music streaming providers- and other -online- services in the long run, even if they supported 5-star ratings. Wojtulek wrote: > I guess I can do it somehow for my ripped cd and persist it to files - > as I remember there is a tag related to rating?... Unfortunately, there is no universal rating tag supported by all music file formats across different music players. Otherwise, LMS (and RL) would import and use this already. Yes, you have the POPM tag for ID3-tagged music files like mp3 or wav. But already with mp4/aac/alac and flac it starts to get problematic because there are no universally accepted tag names for ratings. So if you want to store your rating values in your music files, you have to choose a tag field that you don't use otherwise and one that is *scanned and imported by LMS*. Ratings Light does not and will not include a file scanner (like CustomTag). RL reads rating values from file tags that have been scanned and imported by LMS and that are therefore already part of the LMS database. You can make RL search the BPM tag or comment tag of your tracks *in the LMS database* and convert BPM values or keywords in the comment tags into rating values. *Plugin repositories:* 'Ratings Light FAQ' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
I have only 50 cd which are already rated. Plus some tracks from my favourite albums on Tidel. Is it possible to export ratings to external services like last.fm or allmusic? Or maybe integration should be bideraractional and I should rate tracks/albums eg in last.fm (i prefer it over allmusic)? I'm thinking about it because I don't want to do it just for fun :) I guess I can do it somehow for my ripped cd and persist it to files - as I remember there is a tag related to rating... Wojtulek's Profile: http://forums.slimdevices.com/member.php?userid=72682 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Thanks for that. I look forward to trying out the update. Ullid's Profile: http://forums.slimdevices.com/member.php?userid=72681 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Ullid wrote: > In iTunes, I like to keep persistent ratings stored in the audio files > in case of iTunes library calamity and I repurpose the Beats per Minute > (BPM) field for the rating (BPM = 10x iTunes Rating, e.g. 3.5 star = > 35). Conveniently, it sits under the track rating in the Song Info > Dialog and its validated as integer (0..100). I periodically do BPM bulk > updates to align the iTunes rating and BPM value. I think you mentioned > elsewhere that you maintain LMS and iTunes libraries and transfer > ratings between them. This hack could be a substitute for the "Comments" > method you use if users are averse to modifying or appending the > comments field. I don't know many users who actually use the BPM tag for its designated purpose or at all. And it's a tag unlike, for example, the grouping tag that LMS actually imports. So it doesn't hurt to repurpose it, if you don't use it otherwise. RL v2.1.0 will support importing rating values from BPM tags. *But* you'll have to use the *correct LMS rating values* in your BPM tags. The scale is 0-100 but to get the correct internal LMS rating values you'll have to multiply 5-star scale values by 20, i.e. *2*0x iTunes rating. Your example: 3.5 stars (iTunes) * 20 = 70 (internal LMS database). However many reasons there are to dislike iTunes or the Music app, the one good thing is its scriptability. With some Applescript script and smart playlist it just takes one click to sync iTunes ratings with the ratings store in the file tags. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Hello AF1, Many thanks for the Ratings Light plug which after a few teething problems as a new Daphile user allowed me to copy my iTunes ratings across to a large cloned music library on the LMS. I did this via your Playlist Export/Import method. In iTunes, I like to keep persistent ratings stored in the audio files in case of iTunes library calamity and I repurpose the Beats per Minute (BPM) field for the rating (BPM = 10x iTunes Rating, e.g. 3.5 star = 35). Conveniently, it sits under the track rating in the Song Info Dialog and its validated as integer (0..100). I periodically do BPM bulk updates to align the iTunes rating and BPM value. I think you mentioned elsewhere that you maintain LMS and iTunes libraries and transfer ratings between them. This hack could be a substitute for the "Comments" method you use if users are averse to modifying or appending the comments field. Thanks again for an excellent plugin. I look forward to experimenting with the Dynamic Playlists. Ullid's Profile: http://forums.slimdevices.com/member.php?userid=72681 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > Thank you for your quick reply. > I in fact managed to track down an old backup file and i will have to > live with the fact that some ratings are gone but it shouldn't really be > too much of a bother. > One thing I noticed as I was looking at the file persist.db in SQLite: > some ratings have been preserved but not all. I wonder if this has to do > with the date these rating were imported? If by "imported" you mean that you restored LMS ratings using a RL backup then probably yes, esp. if you had "clear ratings before restore" checked. The next version of RL will include an option (enabled by default) that will create a backup before every rescan. And if you value your ratings very much, you might want to enable scheduled backups too. Or even write some ratings to their tracks' comment tags. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Thank you for your quick reply. I in fact managed to track down an old backup file and i will have to live with the fact that some ratings are gone but it shouldn't really be too much of a bother. One thing I noticed as I was looking at the file persist.db in SQLite: some ratings have been preserved but not all. I wonder if this has to do with the date these rating were imported? dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, ratings light, exclude folders streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > Hello, > as of today all my ratings have disappeared. I had a couple of rescans > and also some files of the file system have gone missing. > Where would Ratings Light store the ratings and is there any way to get > them back? > Obviously I have not carried out any backup whatsoever and there are no > such files in the folder RL has set up in my playlist folder. RL doesn't store your rating data. It tells LMS to store them in the LMS persistent database. So RL is not really involved in this unless you have a RL backup - which you say you don't. Have you deleted your cache folder? That would have deleted the entire LMS database. Or have you changed the location / file path of your music folder? That would likely make the ratings disappear because LMS ties them to the file url. And you don't have *any* other backup at all that would include the LMS cache folder? Complete OS, user home folder...? Without any backup at all, I don't see how you would be able to recover your ratings - unless you have rating values stored in the files' metadata (e.g. comment tag) or some playlists with all tracks rated 1 star, 2 stars etc.). One last thing I can think of: sometimes LMS doesn't delete old entries from the persistent database right away if the file url has changed. Go to your LMS cache folder and open the current LMS persistent database, a file called "persist.db", with a SQLite browser/app to see if it contains rating values. If you don't know how to do that, send me the "persist.db" file and I'll take a look. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Hello, as of today all my ratings have disappeared. I had a couple of rescans and also some files of the file system have gone missing. Where would Ratings Light store the ratings and is there any way to get them back? Obviously I have not carried out any backup whatsoever and there are no such files in the folder RL has set up in my playlist folder. dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, ratings light, exclude folders streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
AF1 wrote: > LMS only stores ratings for individual tracks. There's no column in the > albums table or any other for album ratings. > So any *displayed* album rating would have to be calculated (i.e. > average track rating of all album tracks). Most people have only very > few rated tracks in an album, and so you get 'meaningful' (average) > album ratings like 0.23 or 0.35. I'm not sure how useful this would be. > *Setting* ratings for an -entire- album basically tells LMS/RL to set > the rating of *all* album tracks to some value - because there is no > album rating other than the calculated one. That would mean: all albums > tracks rated equally and even the best albums have weak tracks... > So is album ratings something you really really want and use then? If > so, maybe a future update will bring an option to display calculated > album ratings and batch rate all album tracks. Though I'm still not > convinced. Thanks for the reply and explanation. Much appreciated! I can see the logic behind it not being included. I guess the sensible thing would be to favourite albums and rate my individual tracks within that album as a workaround. Im pretty new to all this and its my first real attempt at upkeep of a growing digital collection. I am blown away by the quality of the plug ins for all this, I downloaded ratings last night and my instinct was to rate the album I just listened to (for the first time) so I thought Id ask the question. Cheers unworthypapalazaru's Profile: http://forums.slimdevices.com/member.php?userid=72006 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
unworthypapalazaru wrote: > Does this plugin support album ratings, or is it just tracks? LMS only stores ratings for individual tracks. There's no column in the albums table or any other for album ratings. So any *displayed* album rating would have to be calculated (i.e. average track rating of all album tracks). Most people have only very few rated tracks in an album, and so you get 'meaningful' (average) album ratings like 0.23 or 0.35. I'm not sure how useful this would be. *Setting* ratings for an -entire- album basically tells LMS/RL to set the rating of *all* album tracks to some value - because there is no album rating other than the calculated one. That would mean: all albums tracks rated equally and even the best albums have weak tracks... So is album ratings something you really really want and use then? If so, maybe a future update will bring an option to display calculated album ratings and batch rate all album tracks. Though I'm still not convinced. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Does this plugin support album ratings, or is it just tracks? unworthypapalazaru's Profile: http://forums.slimdevices.com/member.php?userid=72006 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
CypherMK wrote: > What I miss is this: 10 star rating. I've set it to allow half star > ratings, so there is a workaround, but 10 stars is more logical in my > opinion. Many apps have now opted for some kind of binary -Liked- or -Favourite- approach and dropped rating stars altogether. If apps still support rating stars they usually have a 5-star rating scale (mostly without half stars). The popular LMS Material skin has a 5-star rating scale which makes for a consistent user experience. So I'm sorry to disappoint you but there won't be a 10-star rating scale display option in RL. CypherMK wrote: > I also used trackstat to track when a song is last played, so I could > use the dynamic playlist to not play this song anymore within a certain > amount of time. Is this functionality also in this plugin? Or is there > another plugin for this? Or is it already built in LMS? RL is only about ratings. "last played", "added" or "playCount" are stored in the LMS persistent database. -Dynamic Playlists 3- uses them all the time without problems. One difference I think was that TrackStat allowed users to define a time period after which a track was considered played. With LMS it's considered "played" as soon as playback starts, even if it's only for a very short time and you skip it right away. IMO this makes play count and lastPlayed a bit less meaningful. Should I ever cobble together a small plugin to remedy this it probably won't be an officially released plugin. But you'll find it in my '*repo list*' (https://github.com/AF-1?tab=repositories). *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
I'm checking this plugin now as a replacement of Trackstat. Looks good so far. What I miss is this: 10 star rating. I've set it to allow half star ratings, so there is a workaround, but 10 stars is more logical in my opinion. I also used trackstat to track when a song is last played, so I could use the dynamic playlist to not play this song anymore within a certain amount of time. Is this functionality also in this plugin? Or is there another plugin for this? Or is it already built in LMS? Thanks. CypherMK's Profile: http://forums.slimdevices.com/member.php?userid=62798 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > I would like to add though that in Material skin there is no "browse > button on the right". Hence my confusion. Should be fixed with the next -Material Skin- update. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Hi, in the end this was pretty easy. Thank you for your support. (I would like to add though that in Material skin there is no "browse button on the right". Hence my confusion.) dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, ratings light, exclude folders streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > I have backed up the ratings of my tracks to Music\Playlists > Exported\RatingsLight\RL_Backup_20220201-1143.xml > Music is the standard 'music' folder Synology automatically creates. > The single entries in this file look like this: > > > file%3A%2F%2F%2Fvolume1%2Fmusic%2FKruder%2520%26%2520Dorfmeister_1998_The%2520K%26D%2520Sessions%2F03_Count%2520Basic_Speechless.mp3 > 3 > 0 > > > How would I restore these rating from the Backup of > Ratings Light? > I have tried a vast array of syntax for the path to the xml-file but no > matter what I tried it always returned an error a la "this is not a > valid value for restoring..." You don't *have* to deal with the "correct" path to the backup xml file yourself. Just use the *browse* button on the right to *select the RL backup file* and LMS will fill in the path to your backup file. The actual location of the backup file is irrelevant to the restore process. RL/LMS only needs the information from that file, no matter where it's located. streifenleopard wrote: > > AF1 wrote: > > That should work if the file paths are exactly the same.> > No I think the > > problem might not be the path to the file but the path > for each single entry and I would have to carry out a > find-and-replace-operation: > Changing volume1/music to synology/music or sth like this? Yes, that's what I was referring to with -file paths-. It's a simple replace keeping in mind that the file paths are escaped. Just to confirm, you are moving your LMS from a Synology to a Pi (piCorePlayer), right? So let's say the -parent- folder of your music is a folder called "-music-" in both cases. On the *Synology* its path was "*OLDPATH%2Fmusic*" (in escaped form a slash */* becomes "*%2F*" - without the double quotes). Now you need to know the *path to "music" on your new Pi LMS*. Pick a random track in LMS and you should find the complete path in its -song information-. Take note of the path up to where it's identical, i.e. the -music- folder in your case. Then just use a plain text editor to replace "OLDPATH%2Fmusic" with "NEWPATH%2Fmusic". Save and restore. Should work if the paths are correct. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
AF1 wrote: > That should work if the file paths are exactly the same. I have backed up the ratings of my tracks to Music\Playlists Exported\RatingsLight\RL_Backup_20220201-1143.xml Music is the standard 'music' folder Synology automatically creates. The single entries in this file look like this: file%3A%2F%2F%2Fvolume1%2Fmusic%2FKruder%2520%26%2520Dorfmeister_1998_The%2520K%26D%2520Sessions%2F03_Count%2520Basic_Speechless.mp3 3 0 How would I restore these rating from the Backup of Ratings Light? I have tried a vast array of syntax for the path to the xml-file but no matter what I tried it always returned an error a la "this is not a valid value for restoring..." No I think the problem might not be the path to the file but the path for each single entry and I would have to carry out a find-and-replace-operation: Changing volume1/music to synology/music or sth like this? dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, ratings light, exclude folders streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
dunq wrote: > it's actually successfully doing so (which I don't think was an intended > outcome of the update? lol) No, that was intended. I didn't forget about your problem. I found that one LMS command that checked for existing PLs didn't deliver reliable results, if at all. So I changed the code a bit. dunq wrote: > The SQL warning remains: > > > Code: > > [22-02-05 13:41:41.0925] Plugins::RatingsLight::Plugin::addToRecentlyRatedPlaylist (2119) playlistid = $VAR1 = 246817; > [22-02-05 13:41:41.5488] Slim::Utils::Misc::msg (1341) Warning: [13:41:41.5481] DBIx::Class::ResultSet::update_or_create(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/perl5/Slim/Schema.pm line 1905 > [22-02-05 13:41:41.6107] Plugins::RatingsLight::Plugin::refreshTitleFormats (2791) refreshing title formats > > I guess that's unrelated to RL. Maybe you have an older version of SQLite installed (-deprecated- seems to suggest as much)? Mine is -DBD::SQLite 1.58 (sqlite 3.22.0)-. No such errors here. If you can't find the cause of this I'd say as long as everything works ignore the warning. It's a warning and not an error. dunq wrote: > A question re the plugins-not-watching-each-other situation: I wonder > why, when I go to the track information, RL's "***" rating display > *does* know (to some extent?) that I have updated the rating in the > Material Skin player (ie, the TrackStat rating), not in RL itself. Is it > just a display quirk? LMS stores all ratings in the LMS *persistent* database where they "survive" rescans, even wipe/delete rescans. The LMS persistent database basically contains the same information (ratings, play count...) as TrackStat's own/separate database. Today that may seem a bit redundant but I think TrackStat may predate the introduction of the LMS persistent db. *Setting* ratings: RL writes to the LMS persistent database, TrackStat writes to its own db and to the LMS persistent db. Material just uses TrackStat *or* RL to set the rating, doesn't access neither db itself. *Getting* ratings: RL and Material Skin query the LMS persistent db. TrackStat - I think - gets track ratings from its own db and - I don't remember exactly - maybe as a fallback from the persistent db. RL will always display the current track rating found in the LMS persistent database. If you use TrackStat to set a rating it will write the rating to its own database but I have no idea how quickly it'll update the persistent db (which RL queries). And the display of song information (incl. ratings) in the LMS -default- skin is not dynamic. You'd have to refresh the song information to display the current values. But that applies to all song information AFAIK. If you need TrackStat keep it. If you're not sure try without it for a while and see if that works for you. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
AF1 wrote: > True true. BTW that wasn't meant to be a reproach or anything of the > sort. I'm very nice and polite, I don't do that. :) Thank you. I installed the updated version of RL and can confirm that I can both see the log entry for adding items to the playlist and, more importantly, it's actually successfully doing so (which I don't think was an intended outcome of the update? lol). The SQL warning remains: Code: [22-02-05 13:41:41.0925] Plugins::RatingsLight::Plugin::addToRecentlyRatedPlaylist (2119) playlistid = $VAR1 = 246817; [22-02-05 13:41:41.5488] Slim::Utils::Misc::msg (1341) Warning: [13:41:41.5481] DBIx::Class::ResultSet::update_or_create(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/perl5/Slim/Schema.pm line 1905 [22-02-05 13:41:41.6107] Plugins::RatingsLight::Plugin::refreshTitleFormats (2791) refreshing title formats A question re the plugins-not-watching-each-other situation: I wonder why, when I go to the track information, RL's "***" rating display *does* know (to some extent?) that I have updated the rating in the Material Skin player (ie, the TrackStat rating), not in RL itself. Is it just a display quirk? dunq's Profile: http://forums.slimdevices.com/member.php?userid=29876 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > I am in the process of moving my LMS from my Synology to an RPI > (whenever it may arrive). So I can just reload the old ratings back into > the new installation. That should work if the file paths are exactly the same. Personally I have my Music app write the current track rating to the file's comment tag from time to time as yet another ratings backup. Good luck. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
AF1 wrote: > Choose -Backup / Restore-. This will reload part of the RL settings page > to show the Backup / Restore settings. Some settings pages like Import, > Export, and Back/Restore include -buttons- that trigger actions like > manual back, import or export. Ah, this was the part I had been missing! Excellent. Thanks so much for your patience! Now I have a substantial xml-file with values backed up. dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, ratings light, exclude folders streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > Hello AF1, > thanks for your quick reply. So, with the dropdown menu I can make > Ratings Light create an entry in the mainmenu labelled Backup / Restore > where then I can find a tool to backup Ratings Light ratings? No, that's a misunderstanding, I think. Nothing's created per se in the main menu (if by that you mean home menu). It's all settings pages. Please use the link on the plugins page to get to the RL settings or go *LMS settings* > *Advanced* > *Ratings Light*. Either way, you'll end up on the Ratings Light settings page that will show the *Various* settings by default. At the top of -that- page you can switch between/display other settings sections: Various (default), Import, Export, Don't Stop the Music, Backup / Restore, Menus. Choose -Backup / Restore-. This will reload part of the RL settings page to show the Backup / Restore settings. Some settings pages like Import, Export, and Back/Restore include -buttons- that trigger actions like manual back, import or export. Then use the *Backup Now* button next to -Manual Backup- to create a manual backup. Some plugins only have one settings page and others (like RL) have too many settings, preferences or buttons to fit on one single page without cluttering the UI. That's why there are other settings subpages. Hope that works for you. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Hello AF1, thanks for your quick reply. So, with the dropdown menu I can make Ratings Light create an entry in the mainmenu labelled Backup / Restore where then I can find a tool to backup Ratings Light ratings? dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer (any old version?) -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, squeeze ctrl streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > I still cannot figure out how to make a backup of all my ratings. > I have a Ratings Light-folder in my Playlists-folder but all it contains > is a 33kb log of some rating process. > I can't find any settings section for Ratings Light either where I could > start any back up process. The plugin page of RL points me to a > "Various" section. But what is it? Various Artists? > Any help would be appreciated. -Various- (short for various settings/preferences) is just the landing/starting *sub*page with all sorts of settings that don't fit any of the other settings pages. If you click on *Various* you should see a drop-down menu where all the settings subpages are listed, among them *Backup / Restore* where you can create backups (manually or scheduled). BTW you can disable the log file that keeps track of your rating actions if you want to. The setting is called *Log changed ratings* and it's on the -Various- page. Hope that was helpful. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
I still cannot figure out how to make a backup of all my ratings. I have a Ratings Light-folder in my Playlists-folder but all it contains is a 33kb log of some rating process. I can't find any settings section for Ratings Light either where I could start any back up process. The plugin page of RL points me to a "Various" section. But what is it? Various Artists? Any help would be appreciated. dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer (any old version?) -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, squeeze ctrl streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
guptaas wrote: > Thank you for providing a very useful tool. I have been looking for a > way to use exported ratings in a Windows tagging program like MP3Tag or > Mediamonkey for a long time. The exported text files,however, have UNIX > paths which these programs cannot handle. Playlists saved from LMS > running on windows work fine. Is it possible to have the plugin follow > the filepath convention being used by LMS itself or have an export > setting for UNIX/Windows in the plugin? > As an alternative, any suggestion for an easy m3u converter would be > great. As a last resort, maybe I can create a macro in MS Word. Musicbee can export playlists in a way that LMS can read: In preferences, point the storage location for explored playlists to your Logitech playlist folder. Use filetype M3U. Tick "use relative file path". Tick "use unix path convention". When creating a playlist in MB be sure to tick "export a static copy". dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer (any old version?) -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, squeeze ctrl streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
dunq wrote: > An end-user is not aware of internal architecture and how plugins talk > to the database and/or each other. ... The end-user does not know what > will/won't happen by adjusting the visible rating. True true. BTW that wasn't meant to be a reproach or anything of the sort. I'm very nice and polite, I don't do that. :) Unfortunately, the log messages you've posted don't give me any clues as to what could be causing of your playlist problem. The SQL multiple rows error could be unrelated, like you said. If you see more error/warning messages when creating/adding to the Recently Rated PL look for messages with -Plugins::RatingsLight::Plugin::*addToRecentlyRatedPlaylist*-. But those new debug messages are only part of the lastest GitHub version 2.0.1*1* (manual install required). *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
AF1 wrote: > Yes. RL will only add rating changes to the PL / log if RL changes the > rating and not some other plugin. How else would it know about the > rating changes? An end-user is not aware of internal architecture and how plugins talk to the database and/or each other. Clearly Ratings Light reads TS ratings (and others) for which I'm a grateful user... but it is absolutely not an obvious conclusion for an end-user that plugins do not interact/modify the same data and notice changes, etc. A skin reveals the rating. The end-user does not know what will/won't happen by adjusting the visible rating. AF1 wrote: > BTW what's your Perl version? > > I can't really place the first error message, it lacks context. If you > find a related error/warning message above or below mentioning > -RatingsLight- please also include that line and all lines inbetween. Perl Version: 5.26.1 - x86_64-linux-gnu-thread-multi There is no error mentioning RL. At the point where the RL rating is changed and no RL playlist exists already, the listed warning message and following lines are generated: Code: [22-01-20 22:18:53.3681] Slim::Utils::Misc::msg (1341) Warning: [22:18:53.3667] DBIx::Class::ResultSet::update_or_create(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/perl5/Slim/Schema.pm line 1905 [22-01-20 22:18:54.1765] Plugins::RatingsLight::Plugin::refreshTitleFormats (2798) refreshing title formats [22-01-20 22:18:54.3608] Plugins::RatingsLight::Plugin::objectInfoHandler (1034) objectType = trackArtist ## url = $VAR1 = 'file:///[...]/Music/Depeche%20Mode/Playing%20the%20Angel/09%20-%20Depeche%20Mode%20-%20Introspectre.mp3'; [22-01-20 22:18:54.3654] Plugins::RatingsLight::Plugin::getRatedTracks (929) objectType = artist ## countOnly = 1 ## trackID = 230200 ## thisID = 63844 [22-01-20 22:18:54.3781] Plugins::RatingsLight::Plugin::getRatedTracks (1023) Pre-check found 59 rated tracks for artist with ID: 63844 [22-01-20 22:18:54.3786] Plugins::RatingsLight::Plugin::objectInfoHandler (1034) objectType = trackAlbum ## url = $VAR1 = 'file:///[...]/Music/Depeche%20Mode/Playing%20the%20Angel/09%20-%20Depeche%20Mode%20-%20Introspectre.mp3'; [22-01-20 22:18:54.3808] Plugins::RatingsLight::Plugin::getRatedTracks (929) objectType = album ## countOnly = 1 ## trackID = 230200 ## thisID = 18460 [22-01-20 22:18:54.3817] Plugins::RatingsLight::Plugin::getRatedTracks (1023) Pre-check found 11 rated tracks for album with ID: 18460 dunq's Profile: http://forums.slimdevices.com/member.php?userid=29876 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
dunq wrote: > Perhaps the first three points above are by design or technical > limitations in LMS, I don't know. Yes. RL will only add rating changes to the PL / log if RL changes the rating and not some other plugin. How else would it know about the rating changes? You can, of course, use TrackStat and RL at the same time. But Material checks for TS first (it's been around longer) and if TS is enabled it will use TrackStat to set the ratings (= not RL -> no RL log/PL entry). BTW what's your Perl version? I can't really place the first error message, it lacks context. If you find a related error/warning message above or below mentioning -RatingsLight- please also include that line and all lines inbetween. I've added a few more debug log lines to the recently rated playlist part of RL. So maybe give the current GitHub version a try and check for those debug messages. They basically tell you if RL has found an existing version of the "Recently Rated" playlist incl. its playlist ID (which your second error messages suggested was missing). So far I can't reproduce these errors here. Probably won't have any effect but have you considered updating to the latest LMS version '8.2.*1*' (https://downloads.slimdevices.com/nightly/?ver=8.2)? *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) AF1's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Ok, your description was how I expected it would work. But it doesn't work as described for me. With Debug logging enabled for Ratings Light, there are no special plugin events shown when any rating is added/changed for a track (just reading of track/album/artist data). With a lot of testing, what has become clear is that: - Changing a rating in *Material skin player interface* does not trigger any log/plyalist action by Ratings Light. - Changing the *Trackstat rating* in the *track info interface* does not trigger any log/playlist action by Ratings Light. - Changing the actual Ratings Light rating in the track info interface is the only way to trigger a RL_Rating-Log.txt entry being added. - That is also the only way to get a track added to the playlist Recently Rated Tracks (Ratings Light), and *it only adds the first changed track* (ie, creates the playlist with one track), then no further changed tracks are added. At the time of the first (successful) creation of the playlist and an entry in it, the server shows this warning (perhaps unrelated to Ratings Light) Code: [22-01-19 12:36:04.6088] Slim::Utils::Misc::msg (1341) Warning: [12:36:04.6084] DBIx::Class::ResultSet::update_or_create(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/perl5/Slim/Schema.pm line 1905 At the time any further addition to the playlist is attempted (with no result), an error in the server logs is shown: Code: [22-01-19 12:37:27.3563] Slim::Utils::Misc::msg (1341) Warning: [12:37:27.3559] Use of uninitialized value $playlistid in concatenation (.) or string at /var/lib/squeezeboxserver/cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 2137. Running on Ubuntu server 18.04.6, LMS 8.2.0, Ratings Light 2.0.10, Material Skin 2.8.4 dunq's Profile: http://forums.slimdevices.com/member.php?userid=29876 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
dunq wrote: > What are the criteria for a track being added to the "recently rated" > playlist? The first creation of the playlist happened fine (i.e. visible > in the LMS player interface), in that I changed a track's rating and the > playlist appeared. However, the playlist has not updated since then. So > I'm wondering: > > * is every rating change in the player interface (add new/changed > existing) noticed? > * when should an update to the playlist be triggered? > * when should the log file be written if "Log changed ratings" is ticked > in settings? -Changed- rating means: new/first-time rating, changed rating value, unrating (0). In general, every time you change a track's rating *with -Ratings Light-* (web interface, jivelite, CLI...) the track is added to the playlist and/or the log file if you've enabled that in the settings. Both are meant to help you keep track of your rating *actions*, i.e. the tracks whose rating you've changed. They're not a list all of your rated tracks. Personally I use the log file because it is has more (precise) information and I don't need another playlist. The playlist keeps a record of all tracks with -changed- ratings *but* - it will *not add* a track *twice* (ex.: new rating = 40, then rating = 0 ---> track will only show up *only once* in the -playlist- because the playlist shows all tracks whose ratings changed) - and if you *unrate* a track (rating = 0) it will *not* delete this track from the playlist because unrating is a rating change too. Playlist and log file work without any problems here. If you want to keep detailled track of your rating actions I suggest you use the log file. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
What are the criteria for a track being added to the "recently rated" playlist? The first creation of the playlist happened fine, in that I changed a track's rating and the playlist appeared. However, the playlist has not updated since then. So I'm wondering: * is every rating change in the player interface (add new/changed existing) noticed? * when should an update to the playlist be triggered? * when should the log file be written if "Log changed ratings" is ticked in settings? dunq's Profile: http://forums.slimdevices.com/member.php?userid=29876 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend wrote: > If LMS works it always has read/write permissions to the folder you > selected as your LMS playlist folder. Once installed Ratings Light - in > order to avoid clutter - creates a folder in that playlist folder called > -RatingsLight- where it stores everything: backups, exported playlists, > logs... Creating the folder and changing into it requires 755 > permissions. Please check if that folder exists (unless you moved it > elsewhere in the RL settings) and if LMS/squeezeboxserver has 755 > permissions for that folder. Permissions for files in that folder are > 644 as usual. Thanks for your reply! Running LMS 8.2 on Ubuntu Server 18.0.2. There was no RatingsLight folder in Playlists, and creating one manually and testing different scenarios didn't solve it. All attempts to export/backup from Ratings Light gave the "could not write" error mentioned in my previous post. I did a lot of testing of different permissions and ownership for the Playlists folder and below, but the only thing that worked in the end was deleting the prefs file for Ratings Light in /var/lib/squeezeboxserver/prefs/plugin . On next run, Ratings Light successfully created /Playlists/RatingsLight as squeezeboxserver:nogroup 0755 . dunq's Profile: http://forums.slimdevices.com/member.php?userid=29876 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
dunq wrote: > I've been trying to export data from Ratings Light using both the backup > option and the "recently rated playlist" option. In both cases, the > server log shows, e.g.: > > > > Exporting from TrackStat does not cause a problem (well, it's writing to > a file already created), owner being myusername:myusername > > Saving a playlist from the player interface, the created file has > owner/permissions squeezeboxserver:nogroup 0644 > > I don't know enough about ownership/permissions to understand what to > reliably tweak to make it possible for Ratings Light to write to the > directory (ownership is myusername:users). Any help appreciated. I can only test my plugin on macOS and maybe Linux Debian but this is actually the first I've heard of such behavior. Since I don't know what OS and LMS/plugin version you're using I can only guess but permissions seem a likely cause. If LMS works it always has read/write permissions to the folder you selected as your LMS playlist folder. Once installed Ratings Light - in order to avoid clutter - creates a folder in that playlist folder called -RatingsLight- where it stores everything: backups, exported playlists, logs... Creating the folder and changing into it requires 755 permissions. Please check if that folder exists (unless you moved it elsewhere in the RL settings) and if LMS/squeezeboxserver has 755 permissions for that folder. Permissions for files in that folder are 644 as usual. Another thing you could do is to *temporarily* set the -debug level- of the Ratings Light plugin to -debug- (settings > logging). And then try to create a backup or export something. Just don't forget to set it back to -warn- or -error- afterwards or your log will grow very large. Then check the server log for permissions related messages. Good luck. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
I've been trying to export data from Ratings Light using both the backup option and the "recently rated playlist" option. In both cases, the server log shows, e.g.: > Plugins::RatingsLight::Plugin::createBackup (1473) could not open > /media/bigdisk/MusicCentral/[...]/Playlists/RL_Backup_20220106-2325.xml > for writing. Exporting from TrackStat does not cause a problem (well, it's writing to a file already created), owner being myusername:myusername Saving a playlist from the player interface, the created file has owner/permissions squeezeboxserver:nogroup 0644 I don't know enough about ownership/permissions to understand what to reliably tweak to make it possible for Ratings Light to write to the directory (ownership is myusername:users). Any help appreciated. dunq's Profile: http://forums.slimdevices.com/member.php?userid=29876 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend wrote: > The EXTURL in m3u playlists should start with -file:///-, even on > Windows I think. The (other) file path below is OS specific I think. > I've made some adjustements but I can't test them on Windows (no Windows > PC or license). > So please download and -manually- install the latest GitHub version > (2.0.9) (instructions on the GitHub page) and test the *export* and > *backup/restore* features. > > BTW I wouldn't use Word macros. In my experience such programs often add > their own control characters which you don't want in playlist files. If > you really needed some kind of automated file path rewriting you could > try a script (if that's a thing on Windows) or some plain text editor > with a regex capable search/replace function. The new version exported Windows compatible file paths. Wonderful! Thank you so much. Now I can rate tracks listening anywhere and update the actual RATING tag periodically at a convenient time when tinkering with the library :cool: There is no equivalent of what this community has created - a dream jukebox! Many thanks to the handful of individuals who are willing to share the fruits of their skill and labor with the likes of me who can only copy and paste their ideas. guptaas's Profile: http://forums.slimdevices.com/member.php?userid=21096 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
guptaas wrote: > Thank you for providing a very useful tool. I have been looking for a > way to use exported ratings in a Windows tagging program like MP3Tag or > Mediamonkey for a long time. The exported text files,however, have UNIX > paths which these programs cannot handle. Playlists saved from LMS > running on windows work fine. Is it possible to have the plugin follow > the filepath convention being used by LMS itself or have an export > setting for UNIX/Windows in the plugin? > As an alternative, any suggestion for an easy m3u converter would be > great. As a last resort, maybe I can create a macro in MS Word. The EXTURL in m3u playlists should start with -file:///-, even on Windows I think. The (other) file path below is OS specific I think. I've made some adjustements but I can't test them on Windows (no Windows PC or license). So please download and -manually- install the latest GitHub version (2.0.9) (instructions on the GitHub page) and test the *export* and *backup/restore* features. BTW I wouldn't use Word macros. In my experience such programs often add their own control characters which you don't want in playlist files. If you really needed some kind of automated file path rewriting you could try a script (if that's a thing on Windows) or some plain text editor with a regex capable search/replace function. *Plugin repositories:* 'Ratings Light' (https://github.com/AF-1/lms-ratingslight) 'Visual Statistics' (https://github.com/AF-1/lms-visualstatistics) 'Use Comment Tag Info' (https://github.com/AF-1/lms-usecommenttaginfo) 'Dynamic Playlists 3 FAQ' (https://github.com/AF-1/lms-dynamicplaylists#faq) 'Custom Skip 3 FAQ' (https://github.com/AF-1/lms-customskip#faq) afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Thank you for providing a very useful tool. I have been looking for a way to use exported ratings in a Windows tagging program like MP3Tag or Mediamonkey for a long time. The exported text files,however, have UNIX paths which these programs cannot handle. Playlists saved from LMS running on windows work fine. Is it possible to have the plugin follow the filepath convention being used by LMS itself or have an export setting for UNIX/Windows in the plugin? As an alternative, any suggestion for an easy m3u converter would be great. As a last resort, maybe I can create a macro in MS Word. guptaas's Profile: http://forums.slimdevices.com/member.php?userid=21096 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Super; no hurry for me, but good to hear it's in the pipeline. I'm available for any beta testing if that's needed. Cheers, R 1x Classic / 2x Radio / 2x Receiver / LMS 8.0.0 - 1603862260 on HP Proliant N54L with Ubuntu 16.04 LTS http://www.last.fm/user/rndr rlem's Profile: http://forums.slimdevices.com/member.php?userid=46931 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
rlem wrote: > Hi afriend, > > On Github you write specifically that RL is "A plugin that takes care of > rating *local* tracks", so this is not a bug report but a feature > request. > Since the Online Library integration we've been heavily using and rating > Spotify tracks + mixing them with local tracks in Dynamic Playlists. > > I use TrackStat and RL together to test if we can completely switch to > RL and it seems that RL can rate Spotify tracks without a problem. > The only thing that seems to go wrong is in the Backup.xml -- there the > Spotify tracks are backed up as having rating "0", while I for sure know > that these are rated "100": > 35686 > > So, it would be great if the Spotify tracks were also backed up > correctly. > > Lastly -- a sincere thanks for reviving ratings and Dynamic Playlists! > > Best, > Randy Hi Randy, that's right, so far RL only covers local tracks. Support for -remote- tracks was already on my 2do list. Once this works I'll bump the version to *2*.x. And I'd actually planned on testing it with Spotify. I can't however give you an ETA for that. Best regards, AF afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Hi afriend, On Github you write specifically that RL is "A plugin that takes care of rating *local* tracks", so this is not a bug report but a feature request. Since the Online Library integration we've been heavily using and rating Spotify tracks + mixing them with local tracks in Dynamic Playlists. I use TrackStat and RL together to test if we can completely switch to RL and it seems that RL can rate Spotify tracks without a problem. The only thing that seems to go wrong is in the Backup.xml -- there the Spotify tracks are backed up as having rating "0", while I for sure know that these are rated "100": 35686 So, it would be great if the Spotify tracks were also backed up correctly. Lastly -- a sincere thanks for reviving ratings and Dynamic Playlists! Best, Randy +---+ |Filename: Capture.PNG | |Download: http://forums.slimdevices.com/attachment.php?attachmentid=35686| +---+ 1x Classic / 2x Radio / 2x Receiver / LMS 8.0.0 - 1603862260 on HP Proliant N54L with Ubuntu 16.04 LTS http://www.last.fm/user/rndr rlem's Profile: http://forums.slimdevices.com/member.php?userid=46931 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend wrote: > While I don't know your LMS setup/config and you didn't post any log > messages I know that sometimes very large playlists can be a problem > with LMS. But on the other hand I've tested this with playlists > 2000 > tracks. Could any of these tracks without displayed rating stars have > been deleted, moved or have their urls changed otherwise... can you play > them in LMS? What rating values does the persistent.db show for them? I had had a problem with permissions, so originally there were no logs. I've now partly rectified that . Based on the backup files generated by RatingsLight, I can see that LMS knows the ratings for the unmarked tracks, so this isn't a RatingsLight problem. dunq's Profile: http://forums.slimdevices.com/member.php?userid=29876 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
dunq wrote: > Using the comments technique, files which have a valid rating comment > (eg favstars4xx) get a correct rating imported, while files with no > comment have their existing rating in the database overridden -> no > rating. Is that the intended behaviour? Yes, that's by design. It helps me transfer changed track ratings from other software to LMS. In this case it's needed because otherwise LMS would still show tracks as rated that I unrated somewhere else. I might include an option (disabled by default though) in the next version so tracks without comment tag keywords won't be unrated while new and changed track ratings will still be imported. IMHO it's a corner case but I see no harm in adding this. dunq wrote: > Importing from a playlist, this mostly works (though on my first run of > testing yesterday the server would sometimes crash), but I now have a > handful of tracks that mysteriously refuse to display a rating [Material > skin], even though all others in the same playlist do. On further > examination, the database has been updated for all tracks including the > no-displayed-rating ones mentioned (correctly having a RATING value in > the database), so why isn't the LMS interface showing the stars anywhere > that other tracks do? (Although I realise this seems to be a non-Ratings > Light problem, it is only happening for files that I've rated using > this import process, so I'm posing the question here just in case.) While I don't know your LMS setup/config and you didn't post any log messages I know that sometimes very large playlists can be a problem with LMS. But on the other hand I've tested this with playlists > 2000 tracks. Could any of these tracks without displayed rating stars have been deleted, moved or have their urls changed otherwise... can you play them in LMS? What rating values does the persistent.db show for them? afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
I've been testing out this plugin for importing ratings. A few observations/problems: * Using the comments technique, files which have a valid rating comment (eg favstars4xx) get a correct rating imported, while files with no comment have their existing rating in the database overridden -> no rating. Is that the intended behaviour? * Importing from a playlist, this mostly works (though on my first run of testing yesterday the server would sometimes crash), but I now have a handful of tracks that mysteriously refuse to display a rating, even though all others in the same playlist do. On further examination, the database has been updated for all tracks including the no-displayed-rating ones mentioned (correctly having a RATING value in the database), so why isn't the LMS interface showing the stars anywhere that other tracks do? (Although I realise this seems to be a non-Ratings Light problem, it is only happening for files that I've rated using this import process, so I'm posing the question here just in case.) dunq's Profile: http://forums.slimdevices.com/member.php?userid=29876 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend wrote: > It's possible, just not as simple as one button click. Is this supposed > to be a one-time import or are you thinking of keeping ratings in sync > between 2 or more audio server systems? > > One straightforward way for a -one-time import- would be to > - create 5 playlists (1-5 stars) with your rated tracks in that other > music software and export them as m3u/m3u8-playlists, > - import these playists into LMS (settings > basic > rescan > only > playlists), > - use RL to assign a rating value to the tracks in those playlists. Yep, I think a one time-import will do, I am not a ratings fetishist. Thanks for explaining this to me. All I want is to manually add ratings to some tracks and I should be able to figure this out... dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer (any old version?) -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, squeeze ctrl streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
streifenleopard wrote: > I think I don't quite get what the plug in is for. You'll find a brief summary of what RL can do in the first post of this thread. streifenleopard wrote: > It is not possible to import ratings from musicbee or another music > player into Ratings Light? Or am I mistaken? It's possible, just not as simple as one button click. Is this supposed to be a one-time import or are you thinking of keeping ratings in sync between 2 or more audio server systems? One straightforward way for a -one-time import- would be to - create 5 playlists (1-5 stars) with your rated tracks in that other music software and export them as m3u/m3u8-playlists, - import these playists into LMS (settings > basic > rescan > only playlists), - use RL to assign a rating value to the tracks in those playlists. What I do to keep my ratings in sync between iTunes and LMS is to keep them (together with a keyword) stored in the music files' comment tag so they can travel with the files. RL can pick up rating values from comment tags and import them into LMS. If I rate tracks in LMS RL has an option to export playlists with just those new/changed ratings so I can easily set them in iTunes. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
I just installed this plugin as I wanted to give it a try. It is not possible to import ratings from musicbee or another music player into Ratings Light? Or am I mistaken? I think I don't quite get what the plug in is for. Thanks. dsm 6.2.2 (synology disk station 115) running lms 8.0 -- rpi with a hifiberry dac+ running picoreplayer (any old version?) -- plugins: material skin, mai, podcasts, musik - folge mir, squeezelite-x, squeeze ctrl streifenleopard's Profile: http://forums.slimdevices.com/member.php?userid=42019 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend wrote: > Could you do me a favour and check on your Windows OS if version 1.9.2 > fixed this? Thank you. I just got the new version and the scan is error free now. Thank you so much for the fix! Redbeard65's Profile: http://forums.slimdevices.com/member.php?userid=71732 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Redbeard65 wrote: > After installing Ratings Lite I get the following error in my scanner > log... Could you do me a favour and check on your Windows OS if version 1.9.2 fixed this? Thank you. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote:
> > Anyway, since it only affects the -post-scan refresh- I'll try a
> > workaround and add a dedicated post-scan function that calls the
> refresh
> > function unless it's been done in the last 30 seconds or so.
>
> What I sometimes do in such situations is to
> Slim::Utils::Timers::setTimer(), and first thing the handler would do
> _before_ setting the timer, is to kill any current timer for the
> respective function. That would make sure we only run once in the given
>
> delay.
It's a different approach.
What I had in mind was: do post-scan refresh unless post-scan refresh
already happened in the last 30 seconds. Users can see the results of
the refresh/import very quickly and won't get confused or think the
ratings import failed. ('code'
(https://github.com/AF-1/lms-ratingslight/blob/main/RatingsLight/Plugin.pm#L1259))
I like the timer solution because it's safe: however many calls happen
within any subsequent 30 secs window it will only take the last one.
Only downside is the final delay of 30 seconds + execution time before
the refresh results are available to the users.
Hard to choose.
afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306
View this thread: http://forums.slimdevices.com/showthread.php?t=113344
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Anyway, since it only affects the -post-scan refresh- I'll try a workaround and add a dedicated post-scan function that calls the refresh function unless it's been done in the last 30 seconds or so. What I sometimes do in such situations is to Slim::Utils::Timers::setTimer(), and first thing the handler would do _before_ setting the timer, is to kill any current timer for the respective function. That would make sure we only run once in the given delay. ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote: > Im away from my computer. But could you disable photo/video scanning > and try again? Uncheck the relevant boxes right to the path in the basic > settings. Even if one of the 2 messages/rescan done events is due to the external scanner crashing I'm guessing I can't get to the root of what's causing this. I mean what more can I do than a new install, disabling all plugins but the test plugin and then do a rescan. I think the 2 rescan done events even happen if there are no tracks in the library (when LMS starts for the first time). Anyway, since it only affects the -post-scan refresh- I'll try a workaround and add a dedicated post-scan function that calls the refresh function unless it's been done in the last 30 seconds or so. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote: > Im away from my computer. But could you disable photo/video scanning > and try again? Uncheck the relevant boxes right to the path in the basic > settings. There's only one path (for music files). Nothing else. *Server.prefs*: > ignoreInImageScan: > - /Users/defaultuser/Music/MEDIA > ignoreInVideoScan: > - /Users/defaultuser/Music/MEDIA > (...) > mediadirs: > - /Users/defaultuser/Music/MEDIA afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Im away from my computer. But could you disable photo/video scanning and try again? Uncheck the relevant boxes right to the path in the basic settings. Michael "It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!" (LMS: Settings/Information) mherger's Profile: http://forums.slimdevices.com/member.php?userid=50 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote: > > So that's only happening on my system? (with *all* other *plugins* > > (incl. LMS provided) *disabled* except Test Plugin) > > Anything in scanner.log? >From what I can see nothing suspicious (attached). If something is wrong/crashes is there any way to find out more? The *server*.log says these are the only importers imvolved: > Slim::Music::Import::addImporter (556) Adding > Slim::Music::VirtualLibraries Scan > Slim::Music::Import::countImporters (625) Found importer: > Slim::Music::VirtualLibraries > Slim::Music::Import::addImporter (556) Adding > Slim::Media::MediaFolderScan Scan > Slim::Music::Import::countImporters (625) Found importer: > Slim::Music::VirtualLibraries > Slim::Music::Import::countImporters (625) Found importer: > Slim::Media::MediaFolderScan > +---+ |Filename: scanner.log.zip | |Download: http://forums.slimdevices.com/attachment.php?attachmentid=34697| +---+ afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
So that's only happening on my system? (with *all* other *plugins* (incl. LMS provided) *disabled* except Test Plugin) Anything in scanner.log? ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote: > Something odd is going on here. I still can't reproduce the issue: > > > Code: > > [21-05-16 15:50:45.9369] Slim::Utils::SQLiteHelper::_notifyFromScanner (581) Notify from scanner: end > [21-05-16 15:50:45.9374] Slim::Utils::SQLiteHelper::updateProgress (466) Notify to server OK > [21-05-16 15:50:45.9387] Slim::Utils::SQLiteHelper::updateProgress (442) Notify to server: ["exit"] > [21-05-16 15:50:45.9393] Slim::Utils::SQLiteHelper::_notifyFromScanner (581) Notify from scanner: exit > [21-05-16 15:50:45.9486] Plugins::TestPlugin::Plugin::testcallback (23) Triggered by rescan done > [21-05-16 15:50:45.9487] Plugins::TestPlugin::Plugin::testcallback (25) > > ** TEST CALLBACK INIT ** > > [21-05-16 15:50:45.9488] Slim::Utils::SQLiteHelper::updateProgress (466) Notify to server OK > [21-05-16 15:50:45.9489] Slim::Schema::wipeCaches (2130) Wiped all in-memory caches. > [21-05-16 15:50:45.9490] Slim::Schema::wipeCaches (2130) Wiped all in-memory caches. > [21-05-16 15:50:45.9552] Slim::Schema::wipeCaches (2130) Wiped all in-memory caches. > > > > > One call. > > Now if I look at the code where you got called for the second time, it > mentions in a comment that this should only happen if something went > wrong: > > https://github.com/Logitech/slimserver/blob/public/8.2/Slim/Music/Import.pm#L735 > > You're on a Mac (so am I!)? What macOS? The latest 10.15.7 afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Something odd is going on here. I still can't reproduce the issue: Code: [21-05-16 15:50:45.9369] Slim::Utils::SQLiteHelper::_notifyFromScanner (581) Notify from scanner: end [21-05-16 15:50:45.9374] Slim::Utils::SQLiteHelper::updateProgress (466) Notify to server OK [21-05-16 15:50:45.9387] Slim::Utils::SQLiteHelper::updateProgress (442) Notify to server: ["exit"] [21-05-16 15:50:45.9393] Slim::Utils::SQLiteHelper::_notifyFromScanner (581) Notify from scanner: exit [21-05-16 15:50:45.9486] Plugins::TestPlugin::Plugin::testcallback (23) Triggered by rescan done [21-05-16 15:50:45.9487] Plugins::TestPlugin::Plugin::testcallback (25) ** TEST CALLBACK INIT ** [21-05-16 15:50:45.9488] Slim::Utils::SQLiteHelper::updateProgress (466) Notify to server OK [21-05-16 15:50:45.9489] Slim::Schema::wipeCaches (2130) Wiped all in-memory caches. [21-05-16 15:50:45.9490] Slim::Schema::wipeCaches (2130) Wiped all in-memory caches. [21-05-16 15:50:45.9552] Slim::Schema::wipeCaches (2130) Wiped all in-memory caches. One call. Now if I look at the code where you got called for the second time, it mentions in a comment that this should only happen if something went wrong: https://github.com/Logitech/slimserver/blob/public/8.2/Slim/Music/Import.pm#L735 You're on a Mac (so am I!)? What macOS? Michael "It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!" (LMS: Settings/Information) mherger's Profile: http://forums.slimdevices.com/member.php?userid=50 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote: > > And whatever I do the callback function is *always called twice* on > my > > system. I even talked a not very happy friend into installing LMS and > > softsqueeze on his old Windows7 laptop with only this test plugin > > enabled and he gets 2 messages as well. > > Does this happen on any type of scan, or only some (rescan, wipecache > etc.)? Just tested: not tied to any type, affects all types. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote: > > Can you confirm that *2* events for rescan done is normal or can get > I > > get it down to one?[/color] > No, I only get one. So I've added debug messages to all rescan done in the scanner related LMS pms. Here's the log of a wipecache: > [21-05-16 14:52:55.3970] Slim::Web::Settings::Server::Basic::handler > (54) Initiating scan of type: wipecache > [21-05-16 14:52:55.3973] Slim::Music::Import::initScanQueue (785) > initialize scan queue > [21-05-16 14:52:55.3974] Slim::Music::Import::initScanQueue (788) * > Rescan Done sent - line 788 in initScanQueue function * > > [21-05-16 14:52:55.3975] Slim::Music::Import::queueScanTask (849) full > wipecache requested, wipe queue > [21-05-16 14:52:55.3976] Slim::Music::Import::clearScanQueue (864) > clearing queue: () > [21-05-16 14:52:55.3981] Slim::Music::Import::nextScanTask (799) > triggering next scan: wipecache > [21-05-16 14:52:55.4014] Slim::Music::Import::countImporters (625) Found > importer: Slim::Media::MediaFolderScan > [21-05-16 14:52:55.4019] Slim::Music::Import::countImporters (625) Found > importer: Slim::Music::VirtualLibraries > [21-05-16 14:52:55.4082] Slim::Music::Import::launchScan (203) Running > scanner using arguments: /usr/bin/perl ( > > "/Library/PreferencePanes/Squeezebox.prefPane/Contents/server/scanner.pl", > "--logconfig=/Users/defaultuser/Library/Application > Support/Squeezebox/log.conf", > "--priority=0", > "--prefsdir=/Users/defaultuser/Library/Application > Support/Squeezebox", > "--novideo", > "--noimage", > "--wipe", > "--debug", > > "database.virtuallibraries=ERROR,artwork=ERROR,scan.scanner=DEBUG,scan=DEBUG,scan.import=DEBUG,database.info=ERROR,scan.auto=DEBUG,formats.playlists=ERROR,formats.audio=ERROR", > ) > [21-05-16 14:52:55.4138] Slim::Music::Import::nextScanTask (803) > remaining scans in queue: () > [21-05-16 14:52:56.5208] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.47423||importer||/Users/defaultuser/Music/MEDIA|discovering_directory||1||0|| > [21-05-16 14:52:56.5328] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576||importer||/Users/defaultuser/Music/MEDIA|discovering_directory||36||36||1621169576.53069 > [21-05-16 14:52:56.5371] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.53516||importer||/Users/defaultuser/Music/MEDIA|directory_new||1||35|| > [21-05-16 14:52:56.6544] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576||importer||/Users/defaultuser/Music/MEDIA|directory_new||35||35||1621169576.65239 > [21-05-16 14:52:56.6597] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.65689||importer||/Users/defaultuser/Music/Playlists|discovering_playlist||1||0|| > [21-05-16 14:52:56.6742] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576||importer||/Users/defaultuser/Music/Playlists|discovering_playlist||9||9||1621169576.6709 > [21-05-16 14:52:56.6922] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.68882||importer||/Users/defaultuser/Music/Playlists|playlist_new||1||7|| > [21-05-16 14:52:56.7333] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.68882||importer||/Users/defaultuser/Music/Playlists|playlist_new||2||7|| > [21-05-16 14:52:56.7588] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.68882||importer||/Users/defaultuser/Music/Playlists|playlist_new||3||7|| > [21-05-16 14:52:56.7851] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.68882||importer||/Users/defaultuser/Music/Playlists|playlist_new||4||7|| > [21-05-16 14:52:56.8437] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.68882||importer||/Users/defaultuser/Music/Playlists|playlist_new||5||7|| > [21-05-16 14:52:56.8584] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.68882||importer||/Users/defaultuser/Music/Playlists|playlist_new||6||7|| > [21-05-16 14:52:56.8776] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.68882||importer||/Users/defaultuser/Music/Playlists|playlist_new||7||7|| > [21-05-16 14:52:56.8915] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576||importer||/Users/defaultuser/Music/Playlists|playlist_new||7||7||1621169576.88951 > [21-05-16 14:52:56.8955] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: > progress:1621169576.89354||importer||virtuallibraries||1||1|| > [21-05-16 14:52:56.8995] Slim::Utils::SQLiteHelper::_notifyFromScanner > (581) Notify from scanner: >
Re: [SlimDevices: Plugins] [Announce] Ratings Light
And whatever I do the callback function is *always called twice* on my system. I even talked a not very happy friend into installing LMS and softsqueeze on his old Windows7 laptop with only this test plugin enabled and he gets 2 messages as well. Does this happen on any type of scan, or only some (rescan, wipecache etc.)? ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote:
> I can't reproduce this. Maybe you can disable 3rd part plugins to see
> whether this still happens without them?
Sorry, I forgot to mention that I'd already disabled *all* plugins (not
only 3rd party plugins) and deleted all databases and caches known to me
at some point.
So the only plugin enabled is my Test Plugin that gives me the debug
messages for rescan done events:
Code:
package Plugins::TestPlugin::Plugin;
use strict;
use warnings;
use utf8;
use base qw(Slim::Plugin::Base);
use Slim::Utils::Log;
my $log = Slim::Utils::Log->addLogCategory({
'category' => 'plugin.testplugin',
'defaultLevel' => 'DEBUG',
'description' => 'Test Plugin',
});
sub initPlugin {
my $class = shift;
Slim::Control::Request::subscribe(\,[['rescan'],['done']]);
$class->SUPER::initPlugin(@_);
}
sub testcallback {
$log->debug("\n\n** TEST CALLBACK INIT **\n\n");
}
1;
And whatever I do the callback function is *always called twice* on my
system. I even talked a not very happy friend into installing LMS and
softsqueeze on his old Windows7 laptop with only this test plugin
enabled and he gets 2 messages as well.
Ordinary install.xml be like
Code:
af1----
Test Plugin
Plugins::TestPlugin::Plugin
0.0.1
some desc
AF
enabled
Logitech Media Server
7.9
*
I really don't know where else to look. Are there any other settings
that could cause this? If I only knew what to look for...
_
Logitech Media Server Version: 8.1.2 - 1619728303 @ Fri Apr 30
Operating system: macOS 10.15.7 - EN - utf8
Platform Architecture: unknown
Perl Version: 5.18.4 - darwin-thread-multi-2level
Audio::Scan: 1.02
IO::Socket::SSL: 2.066
Database Version: DBD::SQLite 1.58 (sqlite 3.22.0)
afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306
View this thread: http://forums.slimdevices.com/showthread.php?t=113344
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Thanks for explaining this, will get rid of this. But what about the *2* rescan done events I get? I can't reproduce this. Maybe you can disable 3rd part plugins to see whether this still happens without them? Can you confirm that *2* events for rescan done is normal or can get I get it down to one? No, I only get one. ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote: > > BTW do I need a *'shutdownplugin' > > > (https://github.com/AF-1/lms-ratingslight/blob/main/RatingsLight/Importer.pm#L42)* > > in importer.pm as well? If I have one I've noticed the scanner will > call > > it once the scan is complete. > > It's kind of obsolete by now. Unless you have to eg. write out some > information on shutdown you don't need it at all. I'm not sure I've > implemented it for any of my plugins. > > "shutdownPlugin" is mostly a left over from earlier days when we tried > to make plugins loadable on the fly, without restarting LMS. Loading > would kind of work, but un-loading can't (with Perl). Thanks for explaining this, will get rid of this. But what about the *2* rescan done events I get? I've disabled/removed all of my import/scanner code and I still get *2* rescan done events after every rescan. Can you confirm that *2* events for rescan done is normal or can get I get it down to one? And if not, how would I make sure my callback function is only called *once*? Thank you. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
BTW do I need a *'shutdownplugin' (https://github.com/AF-1/lms-ratingslight/blob/main/RatingsLight/Importer.pm#L42)* in importer.pm as well? If I have one I've noticed the scanner will call it once the scan is complete. It's kind of obsolete by now. Unless you have to eg. write out some information on shutdown you don't need it at all. I'm not sure I've implemented it for any of my plugins. "shutdownPlugin" is mostly a left over from earlier days when we tried to make plugins loadable on the fly, without restarting LMS. Loading would kind of work, but un-loading can't (with Perl). ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote: > > > But it turns out the *refresh function tied to rescan done is called > > _twice_* after a scan. > > Your own refresh function? Is refreshAll() called twice or the callback > for the rescan done event? Yes, the callback (= the function *'importerPostScanRefresh' (https://github.com/AF-1/lms-ratingslight/blob/main/RatingsLight/Plugin.pm#L1268)*) for the *'rescan done event' (https://github.com/AF-1/lms-ratingslight/blob/main/RatingsLight/Plugin.pm#L89)* is triggered twice. Seems to receive 2 rescan done events?? BTW do I need a *'shutdownplugin' (https://github.com/AF-1/lms-ratingslight/blob/main/RatingsLight/Importer.pm#L42)* in importer.pm as well? If I have one I've noticed the scanner will call it once the scan is complete. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
After the import I used to refresh my virtual libraries and title formats and clear the display cache. It seems that this is not something I can do or kick off in the importer.pm. Those scanner limitations you mentioned, maybe? Whether code is in Importer.pm or some other file isn't important, as long as a feature is available in the context it's running: in the scanner you don't have the web server, no display cache etc., that's only available in the server. So I thought maybe I need to subscribe to "rescan" "done" in plugin.pm and handle it there. Sounds reasonable, yes. But it turns out the *refresh function tied to rescan done is called _twice_* after a scan. Your own refresh function? Is refreshAll() called twice or the callback for the rescan done event? ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mherger wrote: > I'd need much more information than the two snippets, in particular > answers to these two questions: > > - did you adjust the install.xml to use the new scanner module? > - what are the imports of the scanner module? I totally forgot about install.xml :-o So I've moved the importer code into a separate 'importer.pm' (https://github.com/AF-1/lms-ratingslight/blob/main/RatingsLight/Importer.pm). After the import I used to refresh my virtual libraries and title formats and clear the display cache. It seems that this is not something I can do or kick off in the importer.pm. Those scanner limitations you mentioned, maybe? So I thought maybe I need to subscribe to "rescan" "done" in plugin.pm and handle it there. But it turns out the *refresh function tied to rescan done is called _twice_* after a scan. Do I need to limit this to one refresh with a variable (0/1)? Or is there another way? And do you have any more examples of what should be moved into separate pms? afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
But the scanner still calls InitIR() from the plugin.pm initPlugin function which includes stuff the scanner can't deal with. That makes me think it would still give the same error on Windows. How do I tell the LMS scanner to just use the scanner.pm and that it should ignore the contents of *plugin.pm* otherwise that's causing the (Windows) problems? I'd need much more information than the two snippets, in particular answers to these two questions: - did you adjust the install.xml to use the new scanner module? - what are the imports of the scanner module? ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Ok, I have no problem with a separate scanner.pm, even if it's only for
calling one subfunction. It would certainly be nice if Windows users get
no more errors. And then all the reasons you mentioned.
Hope you can help me with some questions:
on macOS I just successfully ran something like this:
PLUGIN.PM
Code:
use Plugins::RatingsLight::Scanner;
...
sub initPlugin {
my $class = shift;
return if $initialised;
$class->SUPER::initPlugin(@_);
Slim::Music::Import->addImporter('Plugins::RatingsLight::Scanner', {
'type' => 'post',
'weight' => 99,
'use' => 1,
});
initPrefs();
initIR();
...
And then the *scanner.pm* basically gets the startScan and the import
function:
Code:
sub startScan {
my $enableautoscan = $prefs->get('autoscan');
if (defined $enableautoscan) {
importRatingsFromCommentTags();
}
Slim::Music::Import->endImporter(__PACKAGE__);
}
importRatingsFromCommentTags{...}
But the scanner still calls InitIR() from the plugin.pm initPlugin
function which includes stuff the scanner can't deal with. That makes me
think it would still give the same error on Windows.
How do I tell the LMS scanner to just use the scanner.pm and that it
should ignore the contents of *plugin.pm* otherwise that's causing the
(Windows) problems?
Or is it the addImporter part? Do I have to move to scanner.pm too or
use something else entirely?
Thank you.
afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306
View this thread: http://forums.slimdevices.com/showthread.php?t=113344
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Jim, I don't have a Windows license or test system. But since I can't reproduce this error on macOS or Linux it may either be a Windows thing or related to the Perl version (5.14.1?) or both. The lowest Perl version I tested was 5.18. Most likely the problem you're seeing is due to your using Plugin.pm for the scanner as well as the server side module. The scanner by default doesn't have all the Slim::Web infrastructure (and shouldn't!). On Linux/Mac, where we're running Perl directly, those dependencies would simply be loaded - which you should not do. You don't want all that overhead in your scanner. On Windows OTOH we don't have Perl, but run bundled up Perl versions with all the LMS code required to run that bundle. scanner.exe doesn't come with the Slim::Web stuff, therefore the scanner would fail on Windows. (the same applies for Slim::Networking::Async and the like - don't use them in the scanner!) Two solutions: * re-factor your code to separate out scanner related code into a scanner specific module (that's the preferred way) * wrap the Settings import in a "if (!main::SCANNER)" condition like you do for a lot of the initialization. You'd have to "require" rather than "use" then in that case. The second way might be easier in the short term, but risks to break again and again, as you introduce code not suitable for the scanner. ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend wrote: > Jim, I don't have a Windows license or test system. But since I can't > reproduce this error on macOS or Linux it may either be a Windows thing > or related to the Perl version (5.14.1?) or both. The lowest Perl > version I tested was 5.18. > APART FROM THAT ONE SCANNER RELATED ERROR MESSAGE DOES THE PLUGIN WORK > FINE OTHERWISE OR DOES IT NOT GET LOADED AT ALL? > BTW the importer module is only ever used for automatic import of > ratings from comment tag keywords. And even then, manual importing > shouldn't be affected. > If RL works fine otherwise I'd ignore this error message. Thank you for the reply. The plugin seems to work fine everywhere else and seeing that this would only affect ratings coming in from tags it won't affect me. Thank you for your work on this plugin. Jim Redbeard65's Profile: http://forums.slimdevices.com/member.php?userid=71732 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Redbeard65 wrote: > Hello, > After installing Ratings Lite I get the following error in my scanner > log: > > [21-05-11 15:02:07.2111] Slim::bootstrap::tryModuleLoad (286) Warning: > Module [Plugins::RatingsLight::Plugin] failed to load: > Base class package "Slim::Web::Settings" is empty. > (Perhaps you need to 'use' the module which defines that package > first, > or make that module available in @INC (@INC contains: > C:\ProgramData\Squeezebox\Cache\InstalledPlugins\Plugins\MusicArtistInfo\lib > C:\ProgramData\Squeezebox\Cache\InstalledPlugins\Plugins\Bandcamp\lib > C:\ProgramData\Squeezebox\Cache\InstalledPlugins > C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\5.14\MSWin32-x86-multi-thread > C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\5.14\MSWin32-x86-multi-thread\auto > C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\5.14.1\MSWin32-x86-multi-thread > C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\5.14.1\MSWin32-x86-multi-thread\auto > C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\MSWin32-x86-multi-thread > C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\5.14 > C:\PROGRA~2\SQUEEZ~1\server\lib C:\PROGRA~2\SQUEEZ~1\server\CPAN > C:/PROGRA~2/SQUEEZ~1/server > C:\Users\Jim\AppData\Local\Temp\pdk-Jim-9328\ > C:\PROGRA~2\SQUEEZ~1\server). > at > C:\ProgramData\Squeezebox\Cache\InstalledPlugins/Plugins/RatingsLight/Settings/BaseSettings.pm > line 27 > BEGIN failed--compilation aborted at > C:\ProgramData\Squeezebox\Cache\InstalledPlugins/Plugins/RatingsLight/Settings/BaseSettings.pm > line 27. > Compilation failed in require at (eval 1249) line 2. > ...propagated at /base.pm line 94. > BEGIN failed--compilation aborted at > C:\ProgramData\Squeezebox\Cache\InstalledPlugins/Plugins/RatingsLight/Settings/Basic.pm > line 27. > Compilation failed in require at > C:\ProgramData\Squeezebox\Cache\InstalledPlugins/Plugins/RatingsLight/Plugin.pm > line 53. > BEGIN failed--compilation aborted at > C:\ProgramData\Squeezebox\Cache\InstalledPlugins/Plugins/RatingsLight/Plugin.pm > line 53. > Compilation failed in require at (eval 1215) line 2. > BEGIN failed--compilation aborted at (eval 1215) line 2. > > [21-05-11 15:02:07.2217] Slim::Utils::PluginManager::load (323) Error: > Couldn't load Plugins::RatingsLight::Plugin > [21-05-11 15:02:13.0228] Slim::Music::Import::runImporter (577) Starting > Slim::Media::MediaFolderScan scan > > Does anybody have any ideas of how to fix this? > > I'm running LMS version: Version: 8.1.2 - 1619728303 @ Fri Apr 30 > 00:26:40 WEDT 2021 > > Thanks, > Jim Jim, I don't have a Windows license or test system. But since I can't reproduce this error on macOS or Linux it may either be a Windows thing or related to the Perl version (5.14.1?) or both. The lowest Perl version I tested was 5.18. APART FROM THAT ONE SCANNER RELATED ERROR MESSAGE DOES THE PLUGIN WORK FINE OTHERWISE OR DOES IT NOT GET LOADED AT ALL? BTW the importer module is only ever used for automatic import of ratings from comment tag keywords. And even then, manual importing shouldn't be affected. If RL works fine otherwise I'd ignore this error message. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Hello, After installing Ratings Lite I get the following error in my scanner log: [21-05-11 15:02:07.2111] Slim::bootstrap::tryModuleLoad (286) Warning: Module [Plugins::RatingsLight::Plugin] failed to load: Base class package "Slim::Web::Settings" is empty. (Perhaps you need to 'use' the module which defines that package first, or make that module available in @INC (@INC contains: C:\ProgramData\Squeezebox\Cache\InstalledPlugins\Plugins\MusicArtistInfo\lib C:\ProgramData\Squeezebox\Cache\InstalledPlugins\Plugins\Bandcamp\lib C:\ProgramData\Squeezebox\Cache\InstalledPlugins C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\5.14\MSWin32-x86-multi-thread C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\5.14\MSWin32-x86-multi-thread\auto C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\5.14.1\MSWin32-x86-multi-thread C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\5.14.1\MSWin32-x86-multi-thread\auto C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\MSWin32-x86-multi-thread C:\PROGRA~2\SQUEEZ~1\server\CPAN\arch\5.14 C:\PROGRA~2\SQUEEZ~1\server\lib C:\PROGRA~2\SQUEEZ~1\server\CPAN C:/PROGRA~2/SQUEEZ~1/server C:\Users\Jim\AppData\Local\Temp\pdk-Jim-9328\ C:\PROGRA~2\SQUEEZ~1\server). at C:\ProgramData\Squeezebox\Cache\InstalledPlugins/Plugins/RatingsLight/Settings/BaseSettings.pm line 27 BEGIN failed--compilation aborted at C:\ProgramData\Squeezebox\Cache\InstalledPlugins/Plugins/RatingsLight/Settings/BaseSettings.pm line 27. Compilation failed in require at (eval 1249) line 2. ...propagated at /base.pm line 94. BEGIN failed--compilation aborted at C:\ProgramData\Squeezebox\Cache\InstalledPlugins/Plugins/RatingsLight/Settings/Basic.pm line 27. Compilation failed in require at C:\ProgramData\Squeezebox\Cache\InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 53. BEGIN failed--compilation aborted at C:\ProgramData\Squeezebox\Cache\InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 53. Compilation failed in require at (eval 1215) line 2. BEGIN failed--compilation aborted at (eval 1215) line 2. [21-05-11 15:02:07.2217] Slim::Utils::PluginManager::load (323) Error: Couldn't load Plugins::RatingsLight::Plugin [21-05-11 15:02:13.0228] Slim::Music::Import::runImporter (577) Starting Slim::Media::MediaFolderScan scan Does anybody have any ideas of how to fix this? I'm running LMS version: Version: 8.1.2 - 1619728303 @ Fri Apr 30 00:26:40 WEDT 2021 Thanks, Jim Redbeard65's Profile: http://forums.slimdevices.com/member.php?userid=71732 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend and erland, I just discovered the availability of Ratings Light v1.9.1. I uninstalled the previous version and installed this one. Fabulous! The backup works like a charm! And when scrolling to the end of the backup file I saw a "WARNING" that a track had been ignored and that I could check the server.log for more information. I checked the server.log and, yep, there was a reference to the file I had deleted with this commentary: "WARNING: Ignoring this track, not found in LMS database" So, excellent diagnostics and revision. Many thanks to you both! radish112's Profile: http://forums.slimdevices.com/member.php?userid=11591 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend wrote:
>
> So the music file was deleted manually without a rescan afterwards? When
> I do track->rating to *get* a track rating does LMS check if the file
> exists? Or do you have to perform some (failed) action on it before it's
> marked dead?
>
track->rating just reads the database, it does not check if the file
exist.
If a track has been removed and you perform a rescan the entry will be
removed from tracks table but it will remain in track_persistence. In
this situation objectForUrl would return undef
afriend wrote:
>
> I guess when the backup function does
> -$track =
> Slim::Schema->resultset("Track")->objectForUrl($BACKUPtrackURL);-
> it would return undef and I could catch this.
>
Yes
afriend wrote:
>
> Since I use SQL to set the trackrating directly in the persistent
> database and not -$track->rating- to *set* the rating, I'm not sure if
> the restore function would mind processing urls for missing tracks.
>
> Anyway, will look into it.
As an alternative to check for undef, you could probably read the rating
using SQL directly from track_persitence also. Reading directly from
track_persitence would work, going through a $track object wont work
since there isnt an entry in tracks table. It depends if you want the
backup to contain information for all previously renamed/moved/deleted
tracks or not.
In normal situation a user is probably not interested to keep
information for deleted tracks. The only situation when it could be
useful is if you move all the music to a new disc/path and doesnt do a
backup before the move. In this situation LMS would loose all ratings
since all file URLs are changed, but if the user could do a backup to
export the information they could do a replace all in a text editor of
the backup file and restore it to restore the ratings. However, this is
a corner case, in normal situation the user should have a backup file
from before the move and could just use that. I think my suggestion
would be to instead do filtering of undef when creating the backup and
only store ratings for tracks that exist in tracks table.
Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)
*Starting with LMS 8.0 I no longer support my plugins/applets* ('see
here for more information'
(https://forums.slimdevices.com/showthread.php?49483-Announce-New-versions-of-erlands-plugins=998836=1#post998836)
)
erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=113344
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
erland wrote:
> You would have to restore it and perform a rescan. However, if it isnt
> urgent Id just wait for a new plugin release that ignores tracks that
> no longer exists.
Hey, nice to see you again.
So the music file was deleted manually without a rescan afterwards. When
I do track->rating to *get* a track rating does LMS check if the file
exists? Or do you have to perform some (failed) action on it before it's
marked dead?
I guess when the backup function does
-$track =
Slim::Schema->resultset("Track")->objectForUrl($BACKUPtrackURL);-
it would return undef and I could catch this. Since I use SQL to set the
trackrating directly in the persistent database and not -$track->rating-
to *set* the rating, I'm not sure if the restore function would mind
processing urls for missing tracks.
Anyway, will look into it.
afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306
View this thread: http://forums.slimdevices.com/showthread.php?t=113344
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
erland, Thanks. Truth be told, I'm not entirely sure which file/track it was, although I could probably figure it out. But given that there's no urgency whatsoever, I going to do as you suggested and wait for a new plugin release that ignores tracks that no longer exist. Now back to the music :) radish112's Profile: http://forums.slimdevices.com/member.php?userid=11591 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
radish112 wrote:
> erland,
>
> Yep, that may well be the problem. I did delete a track (it's a long
> story), and it may well have been a rated track.
>
> Assuming that is the problem, would restoring the file to its proper
> location solve the problem?
>
> Thanks for your reply.
You would have to restore it and perform a rescan. However, if it isnt
urgent Id just wait for a new plugin release that ignores tracks that
no longer exists.
Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)
*Starting with LMS 8.0 I no longer support my plugins/applets* ('see
here for more information'
(https://forums.slimdevices.com/showthread.php?49483-Announce-New-versions-of-erlands-plugins=998836=1#post998836)
)
erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=113344
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
erland, Yep, that may well be the problem. I did delete a track (it's a long story), and it may well have been a rated track. Assuming that is the problem, would restoring the file to its proper location solve the problem? Thanks for your reply. radish112's Profile: http://forums.slimdevices.com/member.php?userid=11591 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
radish112 wrote:
> And for what it's worth, here's line 3388:
>
> my $thisrating = $track->rating;
>
> I'm thinking an uninstall and reinstall might be in order. If so, how
> can I make sure to delete anything that might be "left behind" after a
> simple uninstall?
I suspect its related to a moved, renamed or deleted track. If a track
is rated and after this is moved, renamed or deleted it will remain in
track_persistent table but be removed/renamed in tracks table and this
will cause the error you are seeing. LMS isnt able to keep ratings for
moved, renamed or deleted tracks but its still there in the database
under the old file url in the track_persistent table.
Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)
*Starting with LMS 8.0 I no longer support my plugins/applets* ('see
here for more information'
(https://forums.slimdevices.com/showthread.php?49483-Announce-New-versions-of-erlands-plugins=998836=1#post998836)
)
erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=113344
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
And for what it's worth, here's line 3388: my $thisrating = $track->rating; I'm thinking an uninstall and reinstall might be in order. If so, how can I make sure to delete anything that might be "left behind" after a simple uninstall? radish112's Profile: http://forums.slimdevices.com/member.php?userid=11591 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend, Thanks for your quick response. It's probably something I've fouled up, so if you don't see an immediate solution don't worry about it. As long as I can rate tracks and produce playlists based on those ratings (which I am able to do) I'm AOK. So, I restarted LMS and ran a manual backup. This time I did get another backup file and it notes an additional 17 tracks that I've rated since I last produced a backup file, but still no list of tracks and their ratings. Here's the content of that new backup file: And here is the information that might be useful to you: Logitech Media Server Version: 8.1.2 - 1619728303 @ Fri Apr 30 00:42:49 CEST 2021 Operating system: piCore - EN - utf8 Platform Architecture: armv7l-linux Perl Version: 5.32.0 - arm-linux-gnueabihf-thread-multi-64int Audio::Scan: 1.02 IO::Socket::SSL: 2.068 Database Version: DBD::SQLite 1.58 (sqlite 3.22.0) And this appears to be the relevant section of the Server Log: [21-05-03 13:35:38.6251] Slim::Networking::IO::Select::__ANON__ (130) Error: Select task failed calling Slim::Web::HTTP::processHTTP: Can't call method "rating" on an undefined value at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 3388. ; fh=Slim::Web::HTTP::ClientConn=GLOB(0x7b35b70 Thanks! radish112's Profile: http://forums.slimdevices.com/member.php?userid=11591 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
radish112 wrote: > So my questions are: > How do I get RL to produce a backup file that shows my rated tracks and > their ratings? > How do I get RL to produce an updated version of that file every time I > choose to run a manual backup? > > I'm grateful for the Ratings Light backup; I just need to learn how to > succeed at using i RL should work just the way you're using it. Could be a bug in the backup function, maybe OS specific or perl version related, I don't know. I'll look into it but I'll need your help because I can't reproduce this bug here right now. So I'll definitely need more information: please *restart your LMS*. Then try to create a manual backup and post your *server.log*, your OS and Perl version here. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
I have a question about the ratings backup file that the Ratings Light plugin is to create, either manually or automatically via a scheduled time specified by the user. After installing the Ratings Light plugin I chose the parent folder into which RL files would be saved. I then ran a manual backup, which produced the RL folder and--inside that newly-created folder--a backup file. Here are the contents of the backup file: --- --- RL states that the backup file allows one to "Backup all rated tracks (from your entire library) and their rating values in a single backup file," so I was surprised to find no tracks with ratings data in the file , particularly given that RL found 404 rated tracks. (I used to use Trackstat, but to be on the safe side I uninstalled it when I upgraded LMS to version 8.1.2. I guess the tracks that RL discovered are from Trackstat; the Now Playing screen in LMS continues to show the correct number of "stars" for tracks I have rated even though I uninstalled Trackstat, and I have run several "clear library and rescan everything" scans since then. I thought that maybe I needed to play and rate some more tunes and then run the manual backup again, maybe "waking up" the now-installed RL somehow. So I did that, and this time when I ran the manual backup, RL produced no additional backup file at all. I tried a couple of more times with the same outcome. So my questions are: How do I get RL to produce a backup file that shows my rated tracks and their ratings? How do I get RL to produce an updated version of that file every time I choose to run a manual backup? I'm grateful for the Ratings Light backup; I just need to learn how to succeed at using i radish112's Profile: http://forums.slimdevices.com/member.php?userid=11591 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend wrote: > In v1.8.0 all (but one) Dynamic Playlist smart playlists will have an > option to play -all/play/unplayed- songs. And there are some -Don't Stop > The Music- mixes for unplayed tracks as well. > If you want a smart playlist where you can actually choose the > -percentage- of played/unplayed songs you could use 'this *\"un-played\" > playlist*' (https://github.com/AF-1/sobras). Just put it the playlist > folder of the -SQL Playlist- plugin, maybe restart LMS and use it with > the -Dynamic Playlist- plugin.Better late than never [emoji4], but really > appreciate the extra non played/rated functionality! Thx. Verstuurd vanaf mijn HD1903 met Tapatalk mvn2009's Profile: http://forums.slimdevices.com/member.php?userid=33172 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Fixed the settings URL. :-) There was a problem with 1.8.3. Seems that for some reason the sha1 digest of the package delivered by github was not correct. Please wait until 1.8.4 shows up on the LMS plugins page and give that a try. Installing 1.8.4 from github works for me. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
It looks to me that there's a problem with the latest update. The plugins tab keeps telling me to restart (auto update on). After removing Ratings light plugin and reactivating I'm not able to install it anymore. The plugin only shows under "updated plugins available". Selecting it and restarting won't do anything. mvn2009's Profile: http://forums.slimdevices.com/member.php?userid=33172 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend, Hi. This morning the Material Skin alerted me to the the availability of Ratings Light v1.8.2. I then installed it without a hitch, and everything appears to be working just fine. There is one anomaly that doesn't prevent me from using Ratings Light but that is puzzling. When I attempt to access the Settings for Ratings Light from the Plugin tab on the LMS default user interface, I get this message: "404 Not Found: plugins/Extensions/settings/plugins/RatingsLight/settings/settings.html" But when using the Material skin, I can access the Ratings Light settings with no problem. I'm running LMS Version: 8.1.2 (1614990085 @ Sat Mar 6 02:41:13 CET 2021) on a Raspberry Pi 4 (server only, not a player) with PiCorePlayer v 7.0.0 Many thanks for the fix in 8.1.2! radish112's Profile: http://forums.slimdevices.com/member.php?userid=11591 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
afriend wrote: > Log messages much appreciated. > The reason why this didn't show up here is because you're running Perl > 5.32 and all my systems run 5.18.4. When I find the time I'll have to > test the plugin against 5.32. > All I could do for today is release a quick patch (1.8.2). > Please let me know if that fixed the issue. If not I'll try to look into > it as soon as I can. As a temporary workaround you could download and > install the -previous- version from '*github*' > (https://github.com/AF-1/lms-ratingslight/releases). afriend, Thanks for your quick reply and explanation. Your quick patch (1.8.2) doesn't show up in the list of available 3rd party plugins, perhaps because Ratings Light (v1.8.0) shows up in the list of Active Plugins even though it is accompanied by the "Plugin failed to load" Description. Maybe if I deleted the Ratings Light v1.8.0 entry from the list of Active Plugins, the 1.8.2 would show up in the 3rd party plugins. But, I don't know how to go about deleting the Active Plugins entry (or if that would be of any help at all). I'll take at look at the github entry and see if it seems like something I could manage without making a mess of things :) radish112's Profile: http://forums.slimdevices.com/member.php?userid=11591 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
radish112 wrote: > Hi. > > After attempting to install the "Ratings Light" v.1.8.0 plugin, the > "Active Plugins" section of the Plugins tab on LMS shows Ratings Light > (v.1.8.0) in the "Name" Column, while the "Enable" column shows an > unchecked box, and the "Description" column shows "Plugin failed to > load." > > The LMS server log shows: > > > Code: > > [21-03-12 14:23:51.3675] main::init (389) Starting Logitech Media Server (v8.1.2, 1614990085, Sat Mar 6 02:41:13 CET 2021) perl 5.032000 - arm-linux-gnueabihf-thread-multi-64int > [21-03-12 14:23:53.7442] Slim::bootstrap::tryModuleLoad (286) Warning: Module [Plugins::RatingsLight::Plugin] failed to load: > Experimental keys on scalar is now forbidden at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 1703. > Type of arg 1 to keys must be hash or array (not private variable) at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 1703, near "$libraries) " > BEGIN not safe after errors--compilation aborted at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 3433. > Compilation failed in require at (eval 948) line 1. > BEGIN failed--compilation aborted at (eval 948) line 1. > > [21-03-12 14:23:53.7495] Slim::Utils::PluginManager::load (323) Error: Couldn't load Plugins::RatingsLight::Plugin > [21-03-12 14:28:03.1140] main::init (389) Starting Logitech Media Server (v8.1.2, 1614990085, Sat Mar 6 02:41:13 CET 2021) perl 5.032000 - arm-linux-gnueabihf-thread-multi-64int > [21-03-12 14:28:04.7922] Slim::bootstrap::tryModuleLoad (286) Warning: Module [Plugins::RatingsLight::Plugin] failed to load: > Experimental keys on scalar is now forbidden at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 1703. > Type of arg 1 to keys must be hash or array (not private variable) at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 1703, near "$libraries) " > BEGIN not safe after errors--compilation aborted at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 3433. > Compilation failed in require at (eval 944) line 1. > BEGIN failed--compilation aborted at (eval 944) line 1. > > > > On my rpi4 I'm running Logitech Media Server (server only, not a > player) Version: 8.1.2 - 1614990085 @ Sat Mar 6 02:41:13 CET 2021 > > I tried checking the "Enable" box and rebooting LMS, but that didn't > work. > > Any help appreciated. Log messages much appreciated. The reason why this didn't show up here is because you're running Perl 5.32 and all my systems run 5.18.4. When I find the time I'll have to test the plugin against 5.32. All I could do for today is release a quick patch (1.8.2). Please let me know if that fixed the issue. If not I'll try to look into it as soon as I can. As a temporary workaround you could download and install the -previous- version from '*github*' (https://github.com/AF-1/lms-ratingslight/releases). afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
Hi. After attempting to install the "Ratings Light" v.1.8.0 plugin, the "Active Plugins" section of the Plugins tab on LMS shows Ratings Light (v.1.8.0) in the "Name" Column, while the "Enable" column shows an unchecked box, and the "Description" column shows "Plugin failed to load." The LMS server log shows: Code: [21-03-12 14:23:51.3675] main::init (389) Starting Logitech Media Server (v8.1.2, 1614990085, Sat Mar 6 02:41:13 CET 2021) perl 5.032000 - arm-linux-gnueabihf-thread-multi-64int [21-03-12 14:23:53.7442] Slim::bootstrap::tryModuleLoad (286) Warning: Module [Plugins::RatingsLight::Plugin] failed to load: Experimental keys on scalar is now forbidden at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 1703. Type of arg 1 to keys must be hash or array (not private variable) at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 1703, near "$libraries) " BEGIN not safe after errors--compilation aborted at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 3433. Compilation failed in require at (eval 948) line 1. BEGIN failed--compilation aborted at (eval 948) line 1. [21-03-12 14:23:53.7495] Slim::Utils::PluginManager::load (323) Error: Couldn't load Plugins::RatingsLight::Plugin [21-03-12 14:28:03.1140] main::init (389) Starting Logitech Media Server (v8.1.2, 1614990085, Sat Mar 6 02:41:13 CET 2021) perl 5.032000 - arm-linux-gnueabihf-thread-multi-64int [21-03-12 14:28:04.7922] Slim::bootstrap::tryModuleLoad (286) Warning: Module [Plugins::RatingsLight::Plugin] failed to load: Experimental keys on scalar is now forbidden at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 1703. Type of arg 1 to keys must be hash or array (not private variable) at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 1703, near "$libraries) " BEGIN not safe after errors--compilation aborted at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/RatingsLight/Plugin.pm line 3433. Compilation failed in require at (eval 944) line 1. BEGIN failed--compilation aborted at (eval 944) line 1. On my rpi4 I'm running Logitech Media Server (server only, not a player) Version: 8.1.2 - 1614990085 @ Sat Mar 6 02:41:13 CET 2021 I tried checking the "Enable" box and rebooting LMS, but that didn't work. Any help appreciated. radish112's Profile: http://forums.slimdevices.com/member.php?userid=11591 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
Re: [SlimDevices: Plugins] [Announce] Ratings Light
mvn2009 wrote: > Thanks for explaining and pointing me in the right direction! The option > sounds interesting to me so if you see possibilities to implement I > would appreciate that for sure. In v1.8.0 all (but one) Dynamic Playlist smart playlists will have an option to play -all/play/unplayed- songs. And there are some -Don't Stop The Music- mixes for unplayed tracks as well. If you want a smart playlist where you can actually choose the -percentage- of played/unplayed songs you could use 'this *\"un-played\" playlist*' (https://github.com/AF-1/sobras). Just put it the playlist folder of the -SQL Playlist- plugin, maybe restart LMS and use it with the -Dynamic Playlist- plugin. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=113344 ___ plugins mailing list plugins@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/plugins
