[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205699504 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-04 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205406969 @bzz the push I just made fixed an issue that if -Pr wasn't specified, rat would complain about the licenses of files under the r/ subdirectory. There are n

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-04 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205298832 Looks good to me. thank you for the efforts. I think it is ready to be merged, and if there is no more discussion - I will merge it tomorrow. --- If y

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-03 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205132994 @bzz So we should be good to merge now right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205103615 @elbamos everything looks good, except one last thing - BSD license text need to be removed from `r/src/main/scala/scala/Console.scala` header as well, as it was

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-03 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205102505 @bzz thanks! Yeah, I was going to suggest, that getting CI to work reliably is probably something important to the project beyond the scope of this P

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-03 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205094815 @elbamos awesome, thank you! Please, let me do a final pass and I'll post back ASAP. Just FYI - I'm still working on fixing random CI failures under [ZE

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-03 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205051026 @bzz Are we good? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-02 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204879627 @bzz The push I just made should reflect all of the latest requests. Thank you for pointing out the effect of a case-insensitive FS. There are no substantiv

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-02 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204846957 Looks awesome! I think there are just 2 minor licence issue that are left in the .. Copied them here for convenience --- If your project is set up for

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-02 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204811160 @bzz We are green! Good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-02 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204675506 I believe that rebase to latest master must eliminate most of CI issues. Did one more round of reviews and updated https://github.com/apache/incubator-ze

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-02 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204665058 @elbamos I have switched to the containerized sudo-less method of R installation + dependencies in elbamos/Zeppelin-With-R#12 it works, let me rebase and we shou

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-01 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204616417 @bzz are we good? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-01 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204612256 We may be good now - the only failures on the last push were of the CI-random type. --- If your project is set up for it, you can reply to this email and ha

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-01 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204597130 Yeah, I may let it load from the Zeppelin R library if we can't find another solution. I really don't want to use a user-specific directory, because

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-01 Thread smartinsightsfromdata
Github user smartinsightsfromdata commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204586709 @elbamos A minor comment: `sudo` type of solution won't work on windows, of course. From a R perspective, the alternatives I can se

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-01 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204582739 @bzz Here's where we are: * I believe all the licensing, rat, and rebasing to-do's are resolved. * On CI, trying to follow your proposal, if we turn-o

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-04-01 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204351155 @ankurmitujjain please refer https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203834473 for things that need to be taken care of before merging

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-31 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204268855 I need to take care of Alex' license requests, which I will later this morning. > On Apr 1, 2016, at 2:10 AM, Ankur Jain wrote: > > Is it g

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-31 Thread ankurmitujjain
Github user ankurmitujjain commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204264921 Is it good to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-31 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203834473 @elbamos thank you, it looks great now. Could you please take care of the last step - updating `LICENSE` files, while I'll focus on [ZEPPELIN-776](https://i

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203756326 @bzz I think I've just done what you requested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203753693 @elbamos I'm sorry for a confusion! I was basically asking you to post same replies that you did before, but in the places where I have posted the questions - co

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203751439 @bzz I'm not questioning the wisdom of why you're asking me what to do what you're asking -- I just literally do not understand what you're asking. When you'

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203749879 @elbamos :+1: for keeping the docs update! Yes, I believe licenses for each contributed file are clear now, but what I was asking you for is just to follow each

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203733605 @jeffsteinmetz I just pushed the fixed screenshots. Thanks, by the way, for asking that the show functions be taken out --- I can see that the `googleVis` p

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203731211 @bzz I'm not sure I understand what you're requesting -- but in any event, I think the issue for right now is resolved, correct? --- If your project is set

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203730593 @elbamos got it, but could you please post your answers in the comments that I have made, and linked from the list, so we have full conversation history online?

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203726976 The `.z.show.googleVis` etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203726914 Ah - you mean because I took out the show() functions yesterday in respect of your comment about that. --- If your project is set up for it, you can reply

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203726802 @jeffsteinmetz Can you be more specific? Do you mean because they refer to %spark.r and %spark.knitr? --- If your project is set up for it, you can reply

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203726463 re Docs: I noticed this `docs/interpreter/screenshots/knitmotion.png` and a few other screen shots no longer reflect the current implementation. --- I

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203726453 @bzz I just looked at the list, and its all the same thing. I took out of rscala the code for making an R->scala connection. There isn't anything new added

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203726149 @elbamos sure, now I have updated list in https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203673589 could you please clarify few question left

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203722796 @bzz Thank you for catching RException - I have taken out the reference to DDahl. I don't think this is that complicated: * RClient.scala --- M

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203721628 @elbamos I have create file list and updated comment above to track our progress https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203673589

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203718108 On RException - then please feel free to remove `//Originally by David Dahl and released under the BSD license` if that is your contribution. > Meanwhile

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203714774 @bzz - The test is back in with @ignore, and CI is green. Do you have a decision on the license files? --- If your project is set up for it, you can reply

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203698160 @bzz - that's basically the list for scala files, except that I'm pretty sure RException was mine. The other thing is the R source. The rzeppelin.R is mine

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203693548 @elbamos right, I'm looking into licenses and will post back soon. Meanwhile can you please help providing the list of such files to save the time identifying th

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203684695 @bzz I will look into junit ignore. Regarding the licenses, that issue is where it has been: For files that are forked from other things, but also contain

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203673589 Great! Here is the list of things that need to be done in order to merge this PR: - [x] ~~master and this branch have diverged: we need to either mer

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread justsomeone1001
Github user justsomeone1001 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203268802 Its green now, Alex. ZeppelinSparkClusterTest.java is broken. I will try to fix it, but it isn't required that I debug broken tests of co

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203251582 I do not see how this words help. Please ping me when any of the issues above are solved and you want me to spend time reviewing this PR again. --- If your pro

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203250652 Open Jira issues for each failed test? It looks that you are just wasting time. These are all issues that *you* committed, to me and to the community, that

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203248777 I'm not sure I understand you, but please feel free to use whatever place you consider right for the any discussion you feel necessary (I would suggest starting

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203246814 @bzz The right place for the discussion of whether to work in this PR or a branch or whatever, if Tom's proposal is off the table, is the developers' mailing

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203240469 So you suggest to keep CI work in this branch is try to fix current issues first and then get back to `ZeppelinSparkClusterTest.java` - it's fine with me.

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203235774 @bzz I don't know what the implications are of those options. Honestly, I feel like if we spend time on that, its going to be a distraction, becaus

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203234120 @elbamos It is possible to do exactly so, but then we will need to create a new PR from that feature branch to master, in order to get it merged, right? And

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203226945 @bzz It does make sense. Tom's proposal, which everyone liked, was to merge this into a feature version branch, and we can all use that to track down the CI

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203224008 @elbamos I see. The problem is that such intentions (removing not permanently) are not obvious for a reviewers, as they just do not know and assume that current

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203213146 @bzz Do you intend to take any *constructive* action to move this *forward*? This PR has been waiting for *your* action items for three weeks, where you hav

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203206273 @elbamos removing test that do not pass under b848d98 is not an acceptable way to make CI green. It is not going to be possible to merge it without `Zeppeli

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203158716 @jeffsteinmetz They're *all* unrelated. That's kind of the point. A few minutes ago it was passing Spark 1.6 and selenium, but failing everything e

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203155499 @elbamos : It may be unrelated. I didn't take a close look at the specific CI failure - if its unrelated, please disregard. --- If your project is se

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203154616 @jeffsteinmetz I'm not sure I understand what you're proposing? At this moment this PR isn't failing CI. It builds and tests fine. When CI

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203153427 @elbamos : One thought: The `-Ppyspark` build profile will download the spark distribution in order to pass tests and include pyspark in build the di

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-29 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203134960 I just spent 3 hours trying to replicate the error. I cannot replicate it on Ubuntu or OSX with Spark 1.5.2 or Spark 1.6. Looking at the error cl

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-28 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202727314 @jeffsteinmetz I had a typo in the default template, it should be fixed now and %r show up. Thanks for catching! You are correct that build-distr wo

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-28 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202711880 As a reminder, building the distribution with `-Pbuild-distr` doesn't package the interpreter as expected. --- If your project is set up for it, you c

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-28 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202711574 Should the interpreter list %r in the header? Right now it shows %knitr, but not %r **spark** %spark (default) , %sql , %knitr , %pyspa

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-28 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202695901 Things that left to be done in order to merge this PR: - [x] ~~master and this branch have diverged: we need to either merge master in here, or rebase i

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-28 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202682652 The push earlier tonight *should* (if it doesn't, let me know) resolve all comments I've received about this PR. It currently passes CI for Spark 1.

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-27 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202223003 @bzz Let me just add, to avoid any doubt --- I hope I'm wrong. If I am, then I'll be most appreciate, and most apologetic for misjudging you. In th

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-27 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202220759 @bzz Alex - The two "issues" that you identified on my repo are as follows: 1. Two files are flagged as requiring an Apache license header --- these

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-27 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202217468 From what I can see - same three issue I have listed above still hold for this PR from being merged. Updates on my help with CI are tracked under elbamos

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-19 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-197538863 @bzz Can you update us on the status of this? What is the ETA on making progress with CI? --- If your project is set up for it, you can reply to this e

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195114026 Yes you did understand - I just checked and I know why it didn't work for you, I'll fix it next time I'm in the code. The xtable package generates

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195084517 To confirm, are you saying this should return Zeppelin displayed html? (I may have misunderstood) ``` %r cat("%html hello!”)

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195077353 `print(mtcars) ` returns text in a similar way as R as you suggested. Perhaps some hints in the interpreter docs. Not seeing the ro

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread justsomeone1001
Github user justsomeone1001 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195074172 I just want to reiterate, I am open on these issues. But who I think we should look to hear from regarding user expectations, are people who are regu

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195057406 The row id's aren't part of the table in R. Also, R actually is formatting the table in a specific way. Try returning a data_frame vs a data.frame in R and s

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195055673 Many R users prefer to use knitr over a repl. Knitr also enables a lot of things that would otherwise be very complex, like packages for producing properly f

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195054465 The R coding style standard is that variables defined by a package are prefixed with a '.' It seemed to me that "z" stands a good chance of being overwritten

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195053667 In R, when a string gets returned to the repl by an expression, it gets formatted by calling print(). This is why the magic isn't working as you expect-R is

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195046726 curious why you chose to start the `.z.show` method calls with a period? why not `z.show` --- If your project is set up for it, you can reply

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195050282 Does anybody have feedback regarding the use of `%knitr` for plotting? Seems having to use the `%knitr` interpreter for certain workflows is unneces

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195051151 RE: the `mtcars` example above, R and rstudio returns the dataframe as simple text, not a formatted table and with all of the correct row ids.

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195050132 The standard in R is that the return value of an expression is determined by the interpreter. When a data.frame is returned, the interpreter in the R distro

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195045409 This doesn't work as I would expect: ``` %r print("%html HTML Works") ``` and %table, %md, etc Shouldn't this work similar t

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195041973 It can be changed. I like verbose logging to help diagnose user issues. Logging especially the spark contection is very beneficial. But the level of logging

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195041323 I don't think this should output the result as a zeppelin table: ``` %r mtcars ``` Since it's not in line with how R or R S

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-10 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-195039526 I noticed some initial verbose logging - ``` Package Startup Message:

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-08 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-193688762 @elbamos it's totally up to you, as an author weather to do it or not. As a PPMC member I have just listed for you the requirements that project has for any cont

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-08 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-193685964 @bzz - The reason a rebase is required *again* is that so much time has passed. Moon committed to work on the CI issues in December. You committed to do it

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-07 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-193619433 @elbamos sorry for slow re, the only things that are left: - [ ] master and this branch have diverged: we need to either merge master in here, or rebase it o

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-03-06 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-193061151 @bzz Are there any tasks outstanding that you're waiting on me for? What's left to be done for merge? The only things I remember are outstanding, is

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-26 Thread sourav-mazumder
Github user sourav-mazumder commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-189323957 I do like this approach too. Regards, Sourav On Fri, Feb 26, 2016 at 7:09 AM, Jeff Steinmetz wrote: > Makes sense

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-26 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-189316874 Makes sense SPARK_HOME for SparkR ZEPPELIN_HOME for the relevant `R/` directories related to the R zeppelin interpreter. --- If your project

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-25 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-189144007 I think it is "complete" and "working" -- the convenience binary is not part of the release, and a new one isn't going to be made until there is a new releas

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-25 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-189140201 @elbamos please ping me if you need any help adding a profile for R in order to avoid failing default Zeppelin build for users who do not need R. --- If your p

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-25 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-189133244 Nothing I need pre-merge. I was mainly curious how close this was to working end to end. I wasn't familiar with the pre-merge / post-merge ex

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-25 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-189129155 Jeff - well that log explains it, the R package isn't being included in the distribution binary. I'm not sure I understand either the goal or the "

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-25 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-189117683 ah, I see. Well, if the pom's aren't setup to include it in the distribution binary that certainly the issue. I didn't set SPARK_HOME intenti

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-25 Thread elbamos
Github user elbamos commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-189116032 @jeffsteinmetz A couple of things are happening here -- First, I would expect it to fail if you run it from zeppelin-distribution because the pom's

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-25 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-189102577 @elbamos I tested a full build of a Zeppelin distribution using this PR in a virtual machine. When running from the source directory (not the distri

[GitHub] incubator-zeppelin pull request: R Interpreter for Zeppelin

2016-02-24 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-188610090 @elbamos - feel free to comment on this ticket: https://issues.apache.org/jira/browse/ZEPPELIN-700 Can you provide any insight (via comments

  1   2   3   >