Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Thomas Lübking
argument. Thomas Lübking wrote: It's SIC. NETRootInfo(connection, properties, 1); would now cause an error, but since it's been buggy anyway (enums are indeed not polymorphic, but for int,... though gcc could have known better) that should hardly matter. @Marco got

Re: Launch Bug Report Wizard failing on Apple OS X (was ksycoca4)

2014-05-05 Thread Thomas Lübking
On Samstag, 3. Mai 2014 23:38:22 CEST, mk-li...@email.de wrote: On 23 Mar 2014, at 19:18 , Thomas Lübking wrote: Another idea would be that OSX doesn't like the ! prefix (no idea why componentchooser writes it - here. Works fine w/o as well) Hmm, I think that’s indeed the problem! Many

Re: Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Thomas Lübking
On April 28, 2014, 12:41 p.m., Vishesh Handa wrote: I'm a little surprised that NTFS doesn't support xattr, but sure! NTFS /does/ support xattr (on ntfs-3g), but WinNT does support infinite length xattr via ADS only, so basically xattr invocation would have to be ported for Windows. -

Re: Review Request 117779: fix crash when textureNode-texture() is null

2014-04-25 Thread Thomas Lübking
://git.reviewboard.kde.org/r/117779/#comment39469 try before this call. - Thomas Lübking On April 25, 2014, 9:41 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117779: fix crash when textureNode-texture() is null

2014-04-25 Thread Thomas Lübking
On April 25, 2014, 9:44 p.m., Thomas Lübking wrote: src/declarativeimports/core/windowthumbnail.cpp, line 231 https://git.reviewboard.kde.org/r/117779/diff/1/?file=268344#file268344line231 try before this call. Alexander Richardson wrote: Okay, just thought I'd exit early

Re: Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

2014-04-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/#review56349 --- Ship it! Ship It! - Thomas Lübking On April 24, 2014, 5

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/#review56416 --- and this as well then. - Thomas Lübking On April 24, 2014

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Thomas Lübking
On April 24, 2014, 8:01 p.m., Thomas Lübking wrote: ksmserver/screenlocker/greeter/main.cpp, line 94 https://git.reviewboard.kde.org/r/117091/diff/7/?file=268053#file268053line94 was there a problem with SA_RESTART? --- KDE Workspaces 4.11.9 tagging

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Thomas Lübking
/#comment39335 ahhh... this one's the (semi-)obvious crasher =) (I had first only seen the other loops, which looked pretty harmless) Though i had assumed that the non-const iterator would have detached the list anyway. - Thomas Lübking On April 23, 2014, 9:35 a.m., Martin Gräßlin wrote

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Thomas Lübking
On April 23, 2014, 1:03 p.m., Thomas Lübking wrote: src/kstartupinfo.cpp, line 413 https://git.reviewboard.kde.org/r/117701/diff/1/?file=267866#file267866line413 this is somehow not equivalent to the other variant (ignores silent/uninited) - the iterator should perhaps go

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-23 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56333 --- Ship it! Ship It! - Thomas Lübking On April 23, 2014, 9

Re: Kronometer now in KDE Review

2014-04-23 Thread Thomas Lübking
On Mittwoch, 23. April 2014 13:17:02 CEST, Elvis Angelaccio wrote: I don't understand. Since there are only numbers I think that your point is already accomplished. Nope. To get monospace glyphs for sure, you must select a monospace font - otherwise you're going by luck. At least on my

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-22 Thread Thomas Lübking
wrong about just: signal(SIGUSR1, signalHandler); ? - Thomas Lübking On April 22, 2014, 4:41 p.m., Wolfgang Bauer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-22 Thread Thomas Lübking
On April 22, 2014, 5:34 p.m., Thomas Lübking wrote: ksmserver/screenlocker/greeter/main.cpp, line 89 https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89 ooc.: what's wrong about just: signal(SIGUSR1, signalHandler); ? Wolfgang Bauer wrote

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-22 Thread Thomas Lübking
://git.reviewboard.kde.org/r/117091/#comment39263 /me would not insist on newline, but there needs to be a blank after the if if (!m_instance) return; - Thomas Lübking On April 22, 2014, 7:28 p.m., Wolfgang Bauer wrote

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-22 Thread Thomas Lübking
On April 22, 2014, 5:34 p.m., Thomas Lübking wrote: ksmserver/screenlocker/greeter/main.cpp, line 89 https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89 ooc.: what's wrong about just: signal(SIGUSR1, signalHandler); ? Wolfgang Bauer wrote

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-22 Thread Thomas Lübking
do not maintain the screenlocker), but SIGTERM is oc. far better than SIGKILL - Thomas Lübking On April 22, 2014, 8:41 p.m., Wolfgang Bauer wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Kronometer now in KDE Review

2014-04-19 Thread Thomas Lübking
Am Freitag, 18. April 2014 schrieb Elvis Angelaccio : Final screenshot with all these changes: http://abload.de/img/kronometerdrkjq.png I think by right align, Ingo meant numerical, not pixelwise, ie the display should be 00 00 00 00 even if the left digit would be invisible It's actually that

Re: meinproc4 on Mac, KLocale (was Re: What to test for 4.13?)

2014-04-17 Thread Thomas Lübking
On Donnerstag, 17. April 2014 20:32:17 CEST, Luigi Toscano wrote: Ian Wadham ha scritto: Sorry it has been such a while since you wrote. A lot of water has flowed under the bridge since then, but this issue is still of the utmost importance to MacPorts. See:

Re: Kronometer now in KDE Review

2014-04-15 Thread Thomas Lübking
On Tue, Apr 15, 2014 at 10:27 PM, Albert Astals Cid aa...@kde.org wrote: I just don't see the need for the splitters, why would someone want to have them? I see a limited usage (and only) in case they're collapsible (and grow by char width) what would allow to set a target scale (if you

Re: Review Request 109892: introduce kconfig as replacement for kreadconfig and kwriteconfig

2014-04-13 Thread Thomas Lübking
kreadconfig/kconfig.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/109892/diff/ Testing --- Thanks, Thomas Lübking

Re: Disabling baloo-integration possible?

2014-04-09 Thread Thomas Lübking
Am Donnerstag, 10. April 2014 schrieb : So, I wonder what baloo would be doing on OSX to get its hands into the user’s emails… I hope Vishesh can clarify this! Sure one doesn’t want to see any collisions between OSX’ Spotlight indexer on one side and baloo on the other. i assume,

Re: Review Request 117157: Unlock session via DBus

2014-04-04 Thread Thomas Lübking
On Freitag, 4. April 2014 02:42:32 CEST, Michael Pyne wrote: Of course if an attacker is running code they'd probably just find it easier to open the .kwl directly and read the folder and key names, since apparently those are stored unencrypted, if the API docs are to be believed.

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-01 Thread Thomas Lübking
On March 26, 2014, 10:07 p.m., Thomas Lübking wrote: you could sighup or sigusr the greeter process and have it setImmediateLock(true); desktopResized(); in return Wolfgang Bauer wrote: I agree, this would be a bit nicer... But I tried it and cannot get it to work

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 00:07:15 CEST, Martin Klapetek wrote: However many distros disable gdb attach to running processes by default; you have to either be root or echo 1 somewhere in /proc (for which you also need to be root). /proc/sys/kernel/yama/ptrace_scope On top of this, one could

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
(unfortunately). Thomas Lübking wrote: you need access to a random shell of that user (what does not imply you actively logged into it), but can expose another session that pot. allows access to other logins (mail, webservices, even banking) this should (by default) no way

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 19:14:32 CEST, Thiago Macieira wrote: /proc/sys/kernel/yama/ptrace_scope I'd never heard of Yama. https://www.kernel.org/doc/Documentation/security/Yama.txt Kinda new, but it's a stock kernel feature: http://kernelnewbies.org/Linux_3.4 On top of this, one could

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 19:26:21 CEST, Thiago Macieira wrote: Em dom 30 mar 2014, às 10:10:06, Thomas Lübking escreveu: Unlocking via a dbus command is imo very problematic. I disagree. The user already authenticated via their password I should have been more precise in the first

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 20:53:01 CEST, Thiago Macieira wrote: Em dom 30 mar 2014, às 19:38:14, Thomas Lübking escreveu: Unlocking via a dbus command [that requires password authentication] is imo very problematic [because that will end up exposing the password on-disk] How does

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 23:25:58 CEST, Michael Pyne wrote: I'll note I've actually done this before, during the development process for the new QML-based screenlocker. Me fixed the issue in the greeter code (while doing multiscreen/input handling), installed the greeter and SIGTERM'd the

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Montag, 31. März 2014 00:36:29 CEST, Thiago Macieira wrote: They can already access all of the other applications depends on whether they actively suppress such. and the user's files. true. They can attach gdb to any of the user processes. depends on whether they actively suppress

Re: Systems Settings - Desktop Search

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 23:21:18 CEST, Albert Astals Cid wrote: El Dissabte, 29 de març de 2014, a les 15:21:26, Thomas Lübking va escriure: On Samstag, 29. März 2014 15:09:10 CEST, Vishesh Handa wrote: I currently have no idea what is being indexed on my pc. I have no way of finding out

Re: Systems Settings - Desktop Search

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 23:46:01 CEST, Pablo Sanchez wrote: [ Comments below, in-line ] On 03/30/2014 05:43 PM, Albert Astals Cid wrote: I did that twice today already. I am sorry i failed your reading test. Will refrain for further commenting in this thread. I don't think you should get

Re: Systems Settings - Desktop Search

2014-03-30 Thread Thomas Lübking
On Montag, 31. März 2014 00:20:39 CEST, Pablo Sanchez wrote: I wasn't suggesting you were getting offended ... I was suggesting Albert. Yupp, got that. No, didn't mean to. Yes, was irritated by Alberts (suggestive) question. Cheers, Thomas Visit

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Thomas Lübking
(unfortunately). Thomas Lübking wrote: you need access to a random shell of that user (what does not imply you actively logged into it), but can expose another session that pot. allows access to other logins (mail, webservices, even banking) this should (by default) no way

Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117166/#review54562 --- On March 29, 2014, 8:32 p.m., Thomas Lübking wrote

Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Thomas Lübking
On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: Why not simply add a parameter to KApplication constructor? Thomas Lübking wrote: Being? I'm not aware of such parameter, kdelibs is semi-frozen and the requirement is also pretty special to add such feature to KApplication

Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Thomas Lübking
On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: Why not simply add a parameter to KApplication constructor? Thomas Lübking wrote: Being? I'm not aware of such parameter, kdelibs is semi-frozen and the requirement is also pretty special to add such feature to KApplication

Re: Systems Settings - Desktop Search

2014-03-29 Thread Thomas Lübking
On Samstag, 29. März 2014 15:09:10 CEST, Vishesh Handa wrote: I currently have no idea what is being indexed on my pc. I have no way of finding out. If I change my directory structure or add extra media mounts I just have to have faith that baloo does the right thing. It just seems a recipe

Re: Review Request 117088: Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime

2014-03-26 Thread Thomas Lübking
On March 26, 2014, 2:29 p.m., Hrvoje Senjan wrote: (dbus docs say the name of a .service file is arbitrary) it is. however, with this solution, user will never know (i.e. predict) will kuiserver, or kuiserver5 be started - unless you also change the name (not filename) of the service.

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-03-26 Thread Thomas Lübking
it setImmediateLock(true); desktopResized(); in return - Thomas Lübking On March 26, 2014, 4:58 p.m., Wolfgang Bauer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091

Re: debuggind keypress event handling in the plasmoid

2014-03-26 Thread Thomas Lübking
On Dienstag, 25. März 2014 14:31:05 CEST, Marek Kochanowicz wrote: entry field works but it is not quite functional yet. What bothers me right now, are segfaults triggered with any none alpha numeric key (for instance print-screen but also alt-gr). http://wklej.org/id/1311595 i'm not sure

Re: Missing application icons of many KDE apps on MacPorts/OSX

2014-03-24 Thread Thomas Lübking
On Montag, 24. März 2014 00:41:12 CEST, Ian Wadham wrote: I notice there are TWO kde4_add_app_icon() macro refs in that CMakeLists.txt. The other one has no _bin in it … seems odd ... No, kdevelop_bin_SRCS or kdevelop_SRCS or foo_bar_SRCS are just matter of the project name And, Marko,

Re: Launch Bug Report Wizard failing on Apple OS X (was ksycoca4)

2014-03-23 Thread Thomas Lübking
On Sonntag, 23. März 2014 11:55:02 CEST, Ian Wadham wrote: In all three cases, an icon appears in the Dock (task bar equivalent) and vanishes too soon to see what it is. Additionally, I am finding messages on the Apple OS X Console log (see attached). Can a KDE guy tell Marko and me what is

Re: Launch Bug Report Wizard failing on Apple OS X (was ksycoca4)

2014-03-23 Thread Thomas Lübking
On Sonntag, 23. März 2014 13:08:50 CEST, mk-li...@email.de wrote: Does this open kde.org in any browser? No, it didn’t open a browser. Do you get a dialog for kcmshell4 componentchooser $ kcmshell4 componentchooser -bash: kcmshell4: command not found Well, I seem to have to install some

Re: ksycoca4

2014-03-22 Thread Thomas Lübking
On Samstag, 22. März 2014 18:52:14 CEST, Marko wrote: Hi, I just tried to start KDE's bug reporter from a little tutorial application on MacOSX, but I got this spat out at the console: — $ tutorial2.app/Contents/MacOS/tutorial2 tutorial2(1006)/kdecore (KSycoca) KSycocaPrivate::openDatabase:

Re: meinproc4 on Mac, KLocale (was Re: What to test for 4.13?)

2014-03-21 Thread Thomas Lübking
On Freitag, 21. März 2014 08:24:06 CEST, Ian Wadham wrote: That call to KGlobal::locale(); seems an odd one, KDE guys. That function is supposed to return a locale (KLocale *), but here it is executed as a procedure, ignoring the return result. I can only conclude that the code is being

Re: meinproc4 on Mac, KLocale (was Re: What to test for 4.13?)

2014-03-19 Thread Thomas Lübking
On Mittwoch, 19. März 2014 22:24:13 CEST, mk-li...@email.de wrote: On 19 Mar 2014, at 21:50 , Luigi Toscano luigi.tosc...@tiscali.it wrote: The crash described in that stack trace happens in a part of code which is executed *before* initializing livxml. OK, and what do we learn from that?

Re: MacPorts: Running KDE ports on Apple OS X

2014-03-15 Thread Thomas Lübking
On Samstag, 15. März 2014 12:07:46 CEST, René JV Bertin wrote: and who knows maybe even support KWin for those of us using X11 apps ... What's your concern here? X11 on OSX should be provided by XQuartz which should provide native OSX titlebars (and integration into the OSX WM) I do not see

Re: MacPorts: Running KDE ports on Apple OS X

2014-03-15 Thread Thomas Lübking
On Samstag, 15. März 2014 14:35:15 CEST, mk-li...@email.de wrote: On 15 Mar 2014, at 13:35 , Thomas Lübking thomas.luebk...@gmail.com wrote: On Samstag, 15. März 2014 12:07:46 CEST, René JV Bertin wrote: and who knows maybe even support KWin for those of us using X11 apps ... What's your

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-14 Thread Thomas Lübking
On March 13, 2014, 10:40 p.m., Thomas Lübking wrote: You'll need a drawable, clients will require XInitThreads if that is accessed from a different than the GUI thread, but it might be possible to use an internal Window and move the QObject to the GUI thread on construction

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-14 Thread Thomas Lübking
On March 13, 2014, 10:40 p.m., Thomas Lübking wrote: You'll need a drawable, clients will require XInitThreads if that is accessed from a different than the GUI thread, but it might be possible to use an internal Window and move the QObject to the GUI thread on construction

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-13 Thread Thomas Lübking
https://git.reviewboard.kde.org/r/116787/#comment37246 QWidget::winId() - Thomas Lübking On March 13, 2014, 6:44 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

2014-03-04 Thread Thomas Lübking
and this will segfault. (Or I missed something?) - Thomas Lübking On Jan. 31, 2014, 1:01 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137

Re: Lokalization for KDE AppStream AppData files

2014-02-25 Thread Thomas Lübking
Notice that I don't care much about i18n at all (so i don't intend nor could argue), just curious: On Dienstag, 25. Februar 2014 15:13:07 CEST, Matthias Klumpp wrote: Hi again! I talked to some people, and it looks like merging the translation back into one file using existing tools is not

Re: Lokalization for KDE AppStream AppData files

2014-02-25 Thread Thomas Lübking
On Dienstag, 25. Februar 2014 22:22:36 CEST, Matthias Klumpp wrote: 2014-02-25 21:51 GMT+01:00 Kevin Krammer kram...@kde.org: On Tuesday, 2014-02-25, 21:36:27, Albert Astals Cid wrote: ... If that is your final statement, I will write the AppData recommendation without any translation support

Re: Lokalization for KDE AppStream AppData files

2014-02-25 Thread Thomas Lübking
On Dienstag, 25. Februar 2014 23:20:18 CEST, Matthias Klumpp wrote: No, it takes pfoo bar/p and turns that into pfoo bar/p p lang=enfoo bar/p p lang=deföö bär/p p lang=frle fó et la bàr/p p lang=esel fobarro/p I thought, plain p would *not* to be translated? However, same procedure. That

Re: Lokalization for KDE AppStream AppData files

2014-02-25 Thread Thomas Lübking
On Dienstag, 25. Februar 2014 23:45:59 CEST, Matthias Klumpp wrote: Well, it's not a threat. That's my point ;-) I am no Fedora guy I didn't mean to imply that or that you were trying to threat anyone - just that If you don't do this, i'll get myself bugreports is certainly nothing that

Re: Moving Baloo forward

2014-02-23 Thread Thomas Lübking
On Samstag, 22. Februar 2014 10:37:04 CEST, GEO wrote: You could a share a document not containing any personal information (a third party document stored on your hdd), but the comments or tags could contain information you do not want to share with others. And you might just as well want

Re: Downgrade KDE SC Version 4.12.2

2014-02-23 Thread Thomas Lübking
On Sonntag, 23. Februar 2014 09:22:22 CEST, Kanjana wrote: Thanks for responding. Yes, I tried several pertinent n/g's and fora. I'd better prepare to reinstall the distro. a) You can ask such questions at http://forum.kde.org b) something very much likely overrode your

Re: KWindowSystem

2014-02-19 Thread Thomas Lübking
On Mittwoch, 19. Februar 2014 23:19:00 CEST, Damian Ivanov wrote: Usecase: Well in kwindowsystem.h you already have stuff like minimizeWindow,unminize, raise,lower, so it would just be logical to look for it there. Convenience access to certain properties and features of the window manager.

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-02-18 Thread Thomas Lübking
::setxattr; --- getxattr setxattr should then always be in scope and refer to the Baloo variants (ie. the wrappers) - Thomas Lübking On Feb. 18, 2014, 10:51 p.m., Raphael Kubo da Costa wrote

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-17 Thread Thomas Lübking
On Feb. 8, 2014, 2:34 p.m., Thomas Lübking wrote: Here's my vote then. Unless there's concern, push it in some days™ (ie. tuesday or so, should leave enough time to cry out) kdeuser56 kdeuser56 wrote: push it sounds like I should push it, however I can't do it, as I do not have

Re: Keyboard shortcut enhancement.

2014-02-14 Thread Thomas Lübking
Am Freitag, 14. Februar 2014 schrieb Andreas Pakulat : In particular I'm using it to start my preferred browser and to control my preferred mp3 player. The latter is a cli-tool so it has no global shortcuts support but it has invocations which talk to the running instance and can do play, pause

Re: Keyboard shortcut enhancement.

2014-02-14 Thread Thomas Lübking
On Samstag, 15. Februar 2014 00:48:26 CEST, p.kubik...@gmail.com wrote: On Friday 14 of February 2014 17:20:44 Michael Jansen wrote: Window Trigger Action == This is more or less broken since kde4 afaik (never used it myself). This is the first candidate to go. Does edge

Re: Keyboard shortcut enhancement.

2014-02-13 Thread Thomas Lübking
On Freitag, 14. Februar 2014 01:22:19 CEST, Christoph Feck wrote: On Friday 14 February 2014 01:07:10 p.kubik...@gmail.com wrote: The mechanism behind that feature is quite strict. There are always some mod keys + ONE other keys (such as letters). There is no way to create a shortcut with two

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-08 Thread Thomas Lübking
it in some days™ (ie. tuesday or so, should leave enough time to cry out) - Thomas Lübking On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

2014-01-30 Thread Thomas Lübking
On Jan. 20, 2014, 5 p.m., Thomas Lübking wrote: given the ratio by this property is set (often) and read (rarely), i wonder whether we could establish a semi-async functionality, where the client sends a message to have the property updated, then syncs, reads and returns the updated

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 --- tried to center align it? - Thomas Lübking On Jan. 30

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread Thomas Lübking
On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: tried to center align it? kdeuser56 kdeuser56 wrote: Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread Thomas Lübking
On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: tried to center align it? kdeuser56 kdeuser56 wrote: Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-01-30 Thread Thomas Lübking
On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: tried to center align it? kdeuser56 kdeuser56 wrote: Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position

Re: Moving Baloo forward

2014-01-27 Thread Thomas Lübking
On Freitag, 24. Januar 2014 12:59:12 CEST, Vadim Zhukov wrote: It's doubtful at least whether xattr support is a good thing, because it's too easily gets misused: for example, there were viruses on Windows which effectively hidden themselves in NTFS streams. IOW: It's doubtful at least whether

Re: Moving Baloo forward

2014-01-25 Thread Thomas Lübking
On Samstag, 25. Januar 2014 21:03:44 CEST, Matthew Dawson wrote: At least for ext4, xattrs are the default mode Indeed - removed user_xattr and they're still there. Do you happen to know when this happened? (google got me a patch suggest from mid 2011 but i found no hey heads up: xattr now

Re: Review Request 115311: [kwin] Don't call into GL without a context

2014-01-24 Thread Thomas Lübking
commit rights (nor do intend to ask for), please upload a git format-patch variant (to maintain the commit metadata, namely your identity) For potential future patches (welcome ;-) please set the group to kwin, the KWin maintainer is graesslin. - Thomas Lübking On Jan. 25, 2014, 1:57 a.m

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

2014-01-21 Thread Thomas Lübking
On Jan. 20, 2014, 5 p.m., Thomas Lübking wrote: given the ratio by this property is set (often) and read (rarely), i wonder whether we could establish a semi-async functionality, where the client sends a message to have the property updated, then syncs, reads and returns the updated

Re: Review Request 115079: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Thomas Lübking
On Jan. 21, 2014, 1:16 p.m., Martin Gräßlin wrote: I guess it's obvious from the matching review request for kgloballacel: I consider copying the files to every user as the wrong solution. In Qt terms I would give it a -2. esp. since that means to keep them sync'd all the time...

Re: Moving Baloo forward

2014-01-21 Thread Thomas Lübking
On Dienstag, 21. Januar 2014 13:37:29 CEST, viv...@gmail.com wrote: And windows? HPFS/NTFS has xattr support (through alternative data streams) and WINNT supports handling xattr on FAT as well. The problem about xattr is rather that 99% of all ext3/4 users will atm get setfattr:

Re: Qt 5.3 to log all debug/warning/error messages to journald on systemd systems

2014-01-21 Thread Thomas Lübking
On Dienstag, 21. Januar 2014 13:55:15 CEST, Sebastian Kügler wrote: One thing that may concern me is how to clean the system from debugging messages then. Sometimes applications go rogue on qDebug() What - from multiple bug reports and personal observation - can make journald going rogue

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

2014-01-20 Thread Thomas Lübking
/output problem to end users. Also Qt talks of screen in this regard. I'd suggest to keep activeScreen and specify the meaning in the comment. - Thomas Lübking On Jan. 20, 2014, 1:14 p.m., Martin Gräßlin wrote

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-17 Thread Thomas Lübking
is not installed? KF/5 would be broken then, would it not? What about having a common data package downstream? - Thomas Lübking On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 115079: don't install dbus interface files in kglobalaccel

2014-01-17 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115079/#review47586 --- there's no diff - should there be? - Thomas Lübking On Jan

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-14 Thread Thomas Lübking
On Jan. 14, 2014, 7:22 p.m., Martin Gräßlin wrote: like with the other patch I'm not sure whether that's a good idea as that breaks any communication with the kdelibs4. is there a functional incompitibility between SC4 and KF5 that requires such disambiguation or is this merely a package

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-14 Thread Thomas Lübking
On Jan. 14, 2014, 7:22 p.m., Martin Gräßlin wrote: like with the other patch I'm not sure whether that's a good idea as that breaks any communication with the kdelibs4. Thomas Lübking wrote: is there a functional incompitibility between SC4 and KF5 that requires

Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-13 Thread Thomas Lübking
On Jan. 13, 2014, 6:03 p.m., Martin Gräßlin wrote: Wouldn't that break KDElibs4 applications talking to kglobalacceld from KF5? On Montag, 13. Januar 2014 19:24:12 CEST, Michael Jansen wrote: Yes it would. There can be only one kglobalaccel. If its from kde4 or kde4 shouldn't matter so it

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-12 Thread Thomas Lübking
On Sonntag, 12. Januar 2014 12:28:09 CEST, Vishesh Handa wrote: How should one go about this? Dot article? An article on dot will help, but it's not important where the information is hosted. What is important is that it has the character of an official press release. a) It has to show up

Re: Review Request 114910: Patch for bug 317066 (systray leaves garbage on the panel when resizing )

2014-01-08 Thread Thomas Lübking
cause a full parent repaint when adding/removing an (fdo) icon? - Thomas Lübking On Jan. 8, 2014, 8:59 a.m., Dmitry Ivanov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Thomas Lübking
On Jan. 7, 2014, 8:51 a.m., Martin Gräßlin wrote: how does that behave with the normal locker (that is no screensaver)? None is not blank - the patch is correct. If a cursor is specified, it is displayed regardless of what window the pointer is in. If None is specified, the normal cursor

Re: Review Request 114632: Improve pdf title extraction

2014-01-06 Thread Thomas Lübking
On Dec. 26, 2013, 1:57 a.m., Christoph Feck wrote: Hm, you broke the comment :) Luis Silva wrote: What do you mean? It all works fine here. Christoph Feck wrote: Yes, because the compiler does not read comments. Thomas Lübking wrote: Aside this, the approach seems too

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread Thomas Lübking
On Mittwoch, 25. Dezember 2013 21:06:56 CEST, David Edmundson wrote: With the planned slow transition of apps from kdelibs4 to frameworks we are going to have a point where we have apps on either side. I expect Dolphin to port very soon, KMail isn't planned for a long time as KDE PIM libs are

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Thomas Lübking
On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote: On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: How does Baloo cooperate with Nepomuk? Note that we have ABI guarantees, so if the metadata is not shared between running instances of two services, but applications would

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Thomas Lübking
On Dienstag, 24. Dezember 2013 22:03:28 CEST, Àlex Fiestas wrote: On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote: I would like baloo to be available in 4.x, with no API stability guarantees, ... As I see it, the nepomuk maintainer says it works better than Nepomuk for all cases

Re: background plasma crash

2013-12-22 Thread Thomas Lübking
the linked issue is dead old - it's more likely that you're using an abi incompatible decoration plugin (qtcurve? any 3rd party one, though) since debian/ubuntu has (had?) falsepositive abi management. however and once more: you got a crash - you show the backtrace, since otherwise this is all

Re: background plasma crash

2013-12-20 Thread Thomas Lübking
and don't forget to attach a backtrace to the bug in case you want to know whether it's related or have it fixed ;-) 2013/12/20, Martin Graesslin mgraess...@kde.org: Hi Edgar, thanks for your mail. Please be aware that we use bugzilla for managing bugs. It doesn't scale if everybody sends

Re: Review Request 114484: Fix KMainWindow size management, esp. on asymmetric multiscreens

2013-12-16 Thread Thomas Lübking
in addition. Thank you for reading until this point ;-) Diffs - kdeui/widgets/kmainwindow.cpp 85beacc Diff: http://git.reviewboard.kde.org/r/114484/diff/ Testing --- KWin + Metacity; glib + unix event dispatcher. Thanks, Thomas Lübking

Re: Send a custom key sequence to konsole

2013-12-16 Thread Thomas Lübking
On Montag, 16. Dezember 2013 09:08:22 CEST, Jörg Ehrichs wrote: Basically I want to clear t Which internal function should I call? Is it as simple as passing a QString Seems you are looking for QProcess here. To do what? @Aaron: do you want to operate on a konsole part in your own process

Review Request 114484: Fix KMainWindow size management, esp. on asymmetric multiscreens

2013-12-15 Thread Thomas Lübking
://git.reviewboard.kde.org/r/114484/diff/ Testing --- KWin + Metacity; glib + unix event dispatcher. Thanks, Thomas Lübking

Re: Review Request 114484: Fix KMainWindow size management, esp. on asymmetric multiscreens

2013-12-15 Thread Thomas Lübking
any impact on the unspecified special handling in KWin - Thomas Lübking On Dec. 15, 2013, 11:28 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114484

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

2013-12-13 Thread Thomas Lübking
On Dec. 13, 2013, 2:27 p.m., Frank Reininghaus wrote: Thanks for looking into this, Dawit! I greatly appreciate this effort. Two questions come to my mind: 1. Why should these dialogs be modal at all? Everything that KIO does is asynchronous, so it could very well be that the

Re: Debug messages

2013-12-12 Thread Thomas Lübking
Am Donnerstag, 12. Dezember 2013 schrieb Kevin Krammer kram...@kde.org: That will get all Akonadi output, including that of resources, in that shell. You can then use kdebugdialog to turn on/off whatever you want. or you run kdebugdialog --fullmode and log messages to a dedicated file which

<    2   3   4   5   6   7   8   9   10   11   >