rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1567662461
##
superset-frontend/cypress-base/cypress/e2e/dashboard/editmode.test.ts:
##
@@ -771,7 +771,7 @@ describe('Dashboard edit', () => {
visitEdit();
});
-
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1561871095
##
superset-frontend/src/dashboard/types.ts:
##
@@ -237,3 +237,32 @@ export type Slice = {
owners: { id: number }[];
created_by: { id: number };
};
+
+export
github-actions[bot] commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-2043208148
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
geido merged PR #26138:
URL: https://github.com/apache/superset/pull/26138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@sup
geido commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1555992160
##
superset-frontend/src/dashboard/types.ts:
##
@@ -237,3 +237,32 @@ export type Slice = {
owners: { id: number }[];
created_by: { id: number };
};
+
+export en
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1539906736
##
superset-frontend/src/dashboard/types.ts:
##
@@ -237,3 +237,32 @@ export type Slice = {
owners: { id: number }[];
created_by: { id: number };
};
+
+export
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1483744360
##
superset-frontend/cypress-base/cypress/e2e/dashboard/editmode.test.ts:
##
@@ -483,51 +483,6 @@ describe('Dashboard edit', () => {
selectColorScheme('lyftC
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1504611266
##
superset-frontend/src/features/home/Menu.tsx:
##
@@ -306,11 +306,15 @@ export function Menu({
arrowPointAtCenter
>
{isFronte
eschutho commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1967924347
> When I'm navigating the dropdown with arrows, the whole page scrolls with
every click 🙁 And it looks like I can't navigate to Submenus
>
Yeah, I didn't add the submenus yet. T
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1505152719
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -170,25 +182,91 @@ const dropdownIconsStyles = css`
}
`;
+export const hand
kgabryje commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1967092977
When I'm navigating the dropdown with arrows, the whole page scrolls with
every click 🙁 And it looks like I can't navigate to Submenus
https://github.com/apache/superset/as
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1504600244
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -170,25 +182,91 @@ const dropdownIconsStyles = css`
}
`;
+export const hand
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1504600244
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -170,25 +182,91 @@ const dropdownIconsStyles = css`
}
`;
+export const hand
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1504591459
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -309,6 +403,7 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsWit
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500147799
##
superset-frontend/src/features/home/Menu.tsx:
##
@@ -306,11 +306,15 @@ export function Menu({
arrowPointAtCenter
>
{isFronte
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500146106
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -573,15 +691,39 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsW
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500145863
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -573,15 +691,39 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsW
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500143454
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -309,6 +403,7 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsWit
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500134026
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -261,10 +340,23 @@ const ViewResultsModalTrigger = ({
};
const SliceHeaderCon
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500133320
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -231,7 +310,7 @@ const ViewResultsModalTrigger = ({
setShowModal(
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500133320
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -231,7 +310,7 @@ const ViewResultsModalTrigger = ({
setShowModal(
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500108280
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -170,25 +182,91 @@ const dropdownIconsStyles = css`
}
`;
+export const hand
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500106059
##
superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx:
##
@@ -123,7 +123,7 @@ export default function ErrorAlert({
{!isExpandable && !description
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1489518822
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -573,15 +691,39 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsW
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1489517335
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -573,15 +691,39 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsW
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1489509614
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -170,25 +182,91 @@ const dropdownIconsStyles = css`
}
`;
+export const hand
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1488290992
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -309,6 +403,7 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsWit
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1488289157
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -261,10 +340,23 @@ const ViewResultsModalTrigger = ({
};
const SliceHeaderCon
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1488287336
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -231,7 +310,7 @@ const ViewResultsModalTrigger = ({
setShowModal(
kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1488285460
##
superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx:
##
@@ -123,7 +123,7 @@ export default function ErrorAlert({
{!isExpandable && !description
github-actions[bot] commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1939378896
@eschutho Ephemeral environment spinning up at http://35.90.66.154:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
eschutho commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1939361057
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1483744360
##
superset-frontend/cypress-base/cypress/e2e/dashboard/editmode.test.ts:
##
@@ -483,51 +483,6 @@ describe('Dashboard edit', () => {
selectColorScheme('lyftC
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1483712249
##
superset-frontend/src/dashboard/styles.ts:
##
@@ -97,3 +111,43 @@ export const chartContextMenuStyles = (theme:
SupersetTheme) => css`
min-width: ${theme.g
rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1483304552
##
superset-frontend/src/dashboard/styles.ts:
##
@@ -97,3 +111,43 @@ export const chartContextMenuStyles = (theme:
SupersetTheme) => css`
min-width: ${theme.g
rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1483298339
##
superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx:
##
@@ -350,3 +353,127 @@ test('Should not show the "Edit chart" with
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1482278486
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -305,6 +399,7 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsWit
eschutho commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1933180065
> This changes the default behavior of the Edit Chart link, from opening in
the same window to a new one. This might open an old can of worms — is it
intentional?
No, not inten
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1482257270
##
superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx:
##
@@ -350,3 +353,127 @@ test('Should not show the "Edit chart" with
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1482241616
##
superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts:
##
@@ -249,9 +249,13 @@ describe('Drill to detail modal', () => {
it('opens th
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1482171039
##
superset-frontend/src/dashboard/styles.ts:
##
@@ -97,3 +111,43 @@ export const chartContextMenuStyles = (theme:
SupersetTheme) => css`
min-width: ${theme.g
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1482169349
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -305,6 +399,7 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsWit
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1482168142
##
superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx:
##
@@ -350,3 +353,127 @@ test('Should not show the "Edit chart" with
eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1482165415
##
superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts:
##
@@ -249,9 +249,13 @@ describe('Drill to detail modal', () => {
it('opens th
rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1481972747
##
superset-frontend/src/dashboard/styles.ts:
##
@@ -97,3 +111,43 @@ export const chartContextMenuStyles = (theme:
SupersetTheme) => css`
min-width: ${theme.g
rusackas commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1932709054
This changes the default behavior of the Edit Chart link, from opening in
the same window to a new one. This might open an old can of worms — is it
intentional?
--
This is an autom
rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1481961971
##
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##
@@ -305,6 +399,7 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsWit
rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1481914607
##
superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx:
##
@@ -350,3 +353,127 @@ test('Should not show the "Edit chart" with
rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1481913845
##
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx:
##
@@ -233,6 +234,18 @@ const DashboardContainer: FC = ({
topLevelTabs }) =>
rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1481912848
##
superset-frontend/src/components/PageHeaderWithActions/index.tsx:
##
@@ -43,6 +43,9 @@ export const menuTriggerStyles = (theme: SupersetTheme) =>
css`
&:hove
rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1481766735
##
superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts:
##
@@ -249,9 +249,13 @@ describe('Drill to detail modal', () => {
it('opens th
kasiazjc commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1903880674
> @eschutho Ephemeral environment spinning up at http://35.87.72.46:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
I think t
github-actions[bot] commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1900957816
@eschutho Ephemeral environment spinning up at http://35.87.72.46:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
T
eschutho commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1900952633
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1866819839
@eschutho Ephemeral environment spinning up at http://52.35.108.27:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
eschutho commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1866815913
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1857121136
@eschutho Ephemeral environment spinning up at http://54.202.14.64:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
eschutho commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1857118309
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
yousoph commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1851123540
When using keyboard navigation to tab through on a dashboard, the highlight
on the chart title in dashboards doesn't seem to be appearing for me
--
This is an automated message from
github-actions[bot] commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1847705184
@eschutho Ephemeral environment spinning up at http://54.213.200.158:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
eschutho commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1847703227
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
codecov[bot] commented on PR #26138:
URL: https://github.com/apache/superset/pull/26138#issuecomment-1836995899
##
[Codecov](https://app.codecov.io/gh/apache/superset/pull/26138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
eschutho opened a new pull request, #26138:
URL: https://github.com/apache/superset/pull/26138
### SUMMARY
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ]
63 matches
Mail list logo
