Re: Review Request 32070: Updated post-review installation link

070/#comment124023> s/post-review/RBTools ? - Dominic Hamon On March 14, 2015, 5:23 a.m., Akanksha Agrawal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 31997: Cleanup waiter timers so we don't send an event to a dead waiter

g/r/31997/#comment123781> CHECK_SOME(timer)? - Dominic Hamon On March 12, 2015, 11:25 a.m., Cody Maloney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 31324: Updated changelog for 0.22.0

> On March 11, 2015, 9:09 p.m., Adam B wrote: > > CHANGELOG, lines 39-40 > > > > > > Where should users look for this information now? The JIRA leads me to > > believe '/metrics/snapshot', but we need to have a clear a

Re: Review Request 31677: stout: Make the counting of netmask set bits more efficient.

e: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31677/ > --- > > (Updated March 10, 2015, 12:59 p.m.) > > >

Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.

gress again in future? - Dominic Hamon On March 10, 2015, 11:27 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 31677: stout: Make the counting of netmask set bits more efficient.

tps://reviews.apache.org/r/31677/#comment123225> add some pathological cases: 0, 0xffff - Dominic Hamon On March 10, 2015, 1:35 a.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 31677: stout: Make the counting of netmask set bits more efficient.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31677/#review76078 --- Ship it! Ship It! - Dominic Hamon On March 10, 2015, 12:59 p.m

Re: Review Request 31884: libprocess: Make the counting of netmask set bits more efficient.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31884/#review75899 --- Ship it! Ship It! - Dominic Hamon On March 10, 2015, 1:38 a.m

Re: Review Request 31867: Fixed the right angle brackets in the routing library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31867/#review75752 --- Ship it! Ship It! - Dominic Hamon On March 9, 2015, 12:41 p.m

Re: Review Request 30841: Remove static strings and split process.cpp

/profiler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/30841/diff/ Testing --- make check Thanks, Dominic Hamon

Re: Review Request 30841: Remove static strings and split process.cpp

s.cpp 0b3ce9fc7bf183ffc2b8a6d0b7ce06767841cfcd 3rdparty/libprocess/src/profiler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/30841/diff/ Testing --- make check Thanks, Dominic Hamon

Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction.

- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31471/ > --- > > (Updated March 5, 2015, 11:39 a.m.) > > > Review

Re: Review Request 31250: Expose the number of processes and threads in a container when cgroup is enabled.

sts.cpp <https://reviews.apache.org/r/31250/#comment120243> s/> >/>>/ throughout. src/slave/flags.hpp <https://reviews.apache.org/r/31250/#comment122593> having this in slave makes me uncomfortable. it really should be somewhere like the isolator given that it&#x

Re: Review Request 31250: Expose the number of processes and threads in a container when cgroup is enabled.

> On Feb. 23, 2015, 9:43 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/cgroups/cpushare.cpp, line 421 > > > > > > It's hitting the kernel: I'm not sure how it internally keeps track of > > the processe

Re: Review Request 30841: Remove static strings and split process.cpp

3rdparty/libprocess/src/profiler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/30841/diff/ Testing --- make check Thanks, Dominic Hamon

Re: Review Request 31724: Replace hardcoded constants from libprocess with INADDR_ANY and INADDR_LOOPBACK

g/r/31724/#comment122196> so we store in network order? - Dominic Hamon On March 4, 2015, 12:37 p.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 31699: Added reserving c-tor to JSON::Array.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31699/#review75028 --- Ship it! Ship It! - Dominic Hamon On March 3, 2015, 12:11 p.m

Re: Deprecating /stats.json endpoints

This change has landed in head: commit d9ba9199a8c8357ab13a1b14f8ee63409c5ac310 (HEAD, origin/master, origin/HEAD, master) Author: Dominic Hamon Commit: Dominic Hamon Deprecate /stats.json endpoint and supporting code. Review: https://reviews.apache.org/r/30296 On Mon, Jan 26, 2015

Re: Review Request 31700: Reserved memory for JSON arrays where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31700/#review75029 --- do you have a benchmark for before/after? - Dominic Hamon On

Re: Review Request 30296: Deprecate /stats.json endpoint and supporting code.

, Dominic Hamon

Re: Review Request 30296: Deprecate /stats.json endpoint and supporting code.

a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 src/tests/master_tests.cpp 3af20e9492ca38edd7a49b4e1f82c30880f53fa5 src/tests/slave_tests.cpp a74ff7b914b6d68a8d1149a1b86426537f08deae Diff: https://reviews.apache.org/r/30296/diff/ Testing --- make check Thanks, Dominic Hamon

Re: Review Request 30296: Deprecate /stats.json endpoint and supporting code.

date the CHANGELOG for 0.22.0 with this change (ask Niklas to cherry pick > > for 0.22.0) and send an email to dev/user lists. > > Dominic Hamon wrote: > the stats.json removal was in there, but not this. I did mention this in > my email to dev/user though on Jan 26. >

Re: Review Request 31324: Updated changelog for 0.22.0

937> s/./ and task status counts from state.json./ CHANGELOG <https://reviews.apache.org/r/31324/#comment121938> watch the tabs here - Dominic Hamon On Feb. 25, 2015, 5:03 p.m., Niklas Nielsen wrote: > > --- > Thi

Re: Review Request 30296: Deprecate /stats.json endpoint and supporting code.

y/std/ in this review. we can do it in a sweep later. by mistake. - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30296/#review74999 ---------

Review Request 31695: Addendum to stats.json deprecation notice in CHANGELOG

Description --- Addendum to stats.json deprecation notice in CHANGELOG Please cherry pick this onto 0.22 Diffs - CHANGELOG 2a54f08b7bb9cc6983631268eafec8cb7d166d97 Diff: https://reviews.apache.org/r/31695/diff/ Testing --- Thanks, Dominic Hamon

Re: Review Request 31677: stout: Make the counting of netmask set bits more efficient.

tps://reviews.apache.org/r/31677/#comment121852> this should almost certainly be wrapped in a utility method elsewhere in stout. stout/bits.hpp? other useful utilities would be aligning addresses, etc. - Dominic Hamon On March 3, 2015, 8:22 a.m., Evelina Dumitrescu

Re: Review Request 29288: stout: Extend the IP and IPNetwork classes to support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/#review74981 --- Ship it! Ship It! - Dominic Hamon On March 3, 2015, 3:28 a.m

Re: Review Request 29288: stout: Extend the IP and IPNetwork classes to support IPv6.

tps://reviews.apache.org/r/29288/#comment121856> no need to htonl here as in the loopback case? - Dominic Hamon On March 3, 2015, 3:28 a.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction.

tps://reviews.apache.org/r/31471/#comment121855> why did this change? - Dominic Hamon On March 3, 2015, 3:27 a.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 31470: stout: Introduce IPNetwork class to encapsulate an IP address and netmask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31470/#review74977 --- Ship it! Ship It! - Dominic Hamon On March 3, 2015, 3:27 a.m

Re: Review Request 30296: Deprecate /stats.json endpoint and supporting code.

a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 src/tests/master_tests.cpp 3af20e9492ca38edd7a49b4e1f82c30880f53fa5 src/tests/slave_tests.cpp a74ff7b914b6d68a8d1149a1b86426537f08deae Diff: https://reviews.apache.org/r/30296/diff/ Testing --- make check Thanks, Dominic Hamon

Re: Review Request 30546: MemIsolator: expose memory pressures for containers.

295> cbegin is only in c++11 .. is it definitely in g++-4.6? src/slave/containerizer/isolators/cgroups/mem.cpp <https://reviews.apache.org/r/30546/#comment121296> iterator->isReady() is clearer src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/30546/#c

Re: Review Request 31470: stout: Introduce IPNetwork class to encapsulate an IP address and netmask.

> > (Updated Feb. 26, 2015, 10:52 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Repository: mesos > > > Description > --- > > see summary > > > Di

Re: Review Request 31473: mesos: Make fromLinkDevice method member of the IPNetwork class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31473/#review74534 --- Ship it! Ship It! - Dominic Hamon On Feb. 27, 2015, 10:23 a.m

Re: Review Request 31472: stout: Make fromLinkDevice method member of the IPNetwork class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31472/#review74533 --- Ship it! Ship It! - Dominic Hamon On Feb. 27, 2015, 10:30 a.m

Re: Review Request 29290: mesos: Extend the IP and IPNetwork classes to support IPv6.

290/#comment121125> why not just return net::IP(info.ip()); ? - Dominic Hamon On Feb. 27, 2015, 10:27 a.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 29289: libprocess: Extend the IP and IPNetwork classes to support IPv6.

eviews.apache.org/r/29289/#comment121124> TODO to add an IPv6 version? or pass in AF_UNSPEC? - Dominic Hamon On Feb. 27, 2015, 1:22 a.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e

Re: Review Request 29288: stout: Extend the IP and IPNetwork classes to support IPv6.

iews.apache.org/r/29288/#comment121122> Try networkToHostNetmask = IP::networkToHost( IP(*(sockaddr_in6*) ifa->ifa_netmask)); and lose netm - Dominic Hamon On Feb. 27, 2015, 1:23 a

Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction.

/think/ this is the case here so it should be ok. - Dominic Hamon On Feb. 27, 2015, 1:22 a.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction.

you can see the danger here? - Dominic Hamon On Feb. 27, 2015, 1:22 a.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 31470: stout: Introduce IPNetwork class to encapsulate an IP address and netmask.

ll to try to create the IPNetwork, then free ifaddr before checking the error. - Dominic Hamon On Feb. 26, 2015, 10:52 p.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

ttps://reviews.apache.org/r/31505/#comment120973> metric for tracking removal errors? src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/31505/#comment120974> spaces at the front of comments please. - Dom

Re: Review Request 31504: (3/4) Add the default filter to match all packets

/Makefile.am <https://reviews.apache.org/r/31504/#comment120968> alphabetical order please - Dominic Hamon On Feb. 26, 2015, 3:15 p.m., Cong Wang wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 31503: (2/4) Add the Classifier action

. - Dominic Hamon On Feb. 26, 2015, 3:15 p.m., Cong Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502/#review74393 --- please also add a jira reference to the bug field. - Dominic Hamon

Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress

y not "fq_codel"? src/linux/routing/queueing/fq_codel.cpp <https://reviews.apache.org/r/31502/#comment120966> is this used? - Dominic Hamon On Feb. 26, 2015, 3:14 p.m., Cong Wang wrote: > > --- > This is a

Re: Review Request 31446: Add metric breakdown for terminal tasks in Slave

/utils.cpp 498c9aa1442c4e937a74364073b2267dde6ffcb2 Diff: https://reviews.apache.org/r/31446/diff/ Testing --- make check Thanks, Dominic Hamon

Re: Review Request 31472: stout: Make fromLinkDevice method member of the IPNetwork class.

> On Feb. 26, 2015, 10:47 a.m., Dominic Hamon wrote: > > i don't see the change to the actual method here.. > > Evelina Dumitrescu wrote: > The changes are in the fromLinkDevice test > ie: net::IPNetwork::fromLinkDevice(link, AF_INET); instead of > net:

Re: Review Request 31473: mesos: Make fromLinkDevice method member of the IPNetwork class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31473/#review74321 --- Ship it! Ship It! - Dominic Hamon On Feb. 25, 2015, 10:41 p.m

Re: Review Request 31472: stout: Make fromLinkDevice method member of the IPNetwork class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31472/#review74320 --- i don't see the change to the actual method here.. - Dominic

Re: Review Request 29288: stout: Extend the IP and IPNetwork classes to support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/#review74301 --- Ship it! Ship It! - Dominic Hamon On Feb. 25, 2015, 11:18 p.m

Re: Review Request 31246: stout: Extend the IP class to support IPv6 and renamed net::IP::fromDotDecimal to net::IP::parse

t's obsolete now? 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/31246/#comment120855> this is also in a previous patch. if it's not needed any more, please 'discard' the patch. - Dominic Hamon On Feb. 21

Re: Review Request 31489: Fix use of buffers in OS to remove leaks.

ointers? - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31489/#review74305 --- On Feb. 26, 2015, 10:14 a.m.,

Re: Review Request 31489: Fix use of buffers in OS to remove leaks.

Diff: https://reviews.apache.org/r/31489/diff/ Testing --- make check Thanks, Dominic Hamon

Re: Review Request 29289: libprocess: Extend the IP and IPNetwork classes to support IPv6.

tps://reviews.apache.org/r/29289/#comment120859> leaking of abstraction here. is there something we can do better? Can you just use sizeof(storage.get())? - Dominic Hamon On Feb. 25, 2015, 10:44 p.m., Evelina Dumitrescu wrote: > > ---

Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction.

s.cpp <https://reviews.apache.org/r/31471/#comment120853> why do you need this? - Dominic Hamon On Feb. 25, 2015, 10:41 p.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 31470: stout: Introduce IPNetwork class to encapsulate an IP address and netmask.

<https://reviews.apache.org/r/31470/#comment120848> should this check be inside the constructor? 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/31470/#comment120849> int should be fine here - Dominic Hamon On Feb

Re: Review Request 31455: Fixed the broken build on OS X 10.8.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31455/#review74296 --- Ship it! Ship It! - Dominic Hamon On Feb. 25, 2015, 5:49 p.m

Review Request 31489: Fix use of buffers in OS to remove leaks.

/ Testing --- make check Thanks, Dominic Hamon

Re: Review Request 31479: Add missing deletes in stout

://reviews.apache.org/r/31489/ - Dominic Hamon On Feb. 26, 2015, 1:10 a.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 31446: Add metric breakdown for terminal tasks in Slave

/slave_tests.cpp 7ea012ab0883cc030b3e62f59879613866dab0fa src/tests/utils.cpp 498c9aa1442c4e937a74364073b2267dde6ffcb2 Diff: https://reviews.apache.org/r/31446/diff/ Testing (updated) --- make check Thanks, Dominic Hamon

Review Request 31446: Add metric breakdown for terminal tasks in Slave

498c9aa1442c4e937a74364073b2267dde6ffcb2 Diff: https://reviews.apache.org/r/31446/diff/ Testing --- Thanks, Dominic Hamon

Re: Review Request 31440: Add os::getmode() wrapper.

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31440/ > ------- > > (Updated Feb. 25, 2015, 2:31 p.m.) > > > Revie

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

#comment120657> aside: why are we returning arbitrary integers instead of boolean or useful errors? src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/31444/#comment120658> i don't see where we mount flags.directory in to the chroot.

Re: Review Request 31439: Add os::chroot() wrapper.

/stout/os.hpp <https://reviews.apache.org/r/31439/#comment120645> ErrnoError("chroot") ? - Dominic Hamon On Feb. 25, 2015, 2:31 p.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 31440: Add os::getmode() wrapper.

tps://reviews.apache.org/r/31440/#comment120643> missing 'depends on' for the getrdev? 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/31440/#comment120641> s/getmode/mode/ ? - Dominic Hamon On Feb. 25, 2015, 2:31

Re: Review Request 31441: Add os::mknod() wrapper.

tps://reviews.apache.org/r/31441/#comment120640> with this, you should be able to test getrdev (the other patch). please do :) - Dominic Hamon On Feb. 25, 2015, 2:31 p.m., Ian Downes wrote: > > --- > This is a

Re: Review Request 31441: Add os::mknod() wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31441/#review74120 --- Ship it! Ship It! - Dominic Hamon On Feb. 25, 2015, 2:31 p.m

Re: Review Request 31442: Add Linux pivot_root() wrapper.

EBUSY). - Dominic Hamon On Feb. 25, 2015, 2:31 p.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 31443: Accept dummy arguments for fs::mount().

flags, data) < 0) { ... also, does it make sense for type to be non-null if source is null? and vice versa? - Dominic Hamon On Feb. 25, 2015, 2:31 p.m., Ian Downes wrote: > > --- > This is an autom

Re: Review Request 31438: Add os::getrdev() wrapper.

tps://reviews.apache.org/r/31438/#comment120636> s/getrdev/rdev/ ? #consistency - Dominic Hamon On Feb. 25, 2015, 2:31 p.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 31438: Add os::getrdev() wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31438/#review74115 --- Ship it! Ship It! - Dominic Hamon On Feb. 25, 2015, 2:31 p.m

Review Request 31426: Move test utility from mesos.hpp to utils.hpp

/utils.cpp f4f90b99277b3f3ec97ded5623e4e104827333cb Diff: https://reviews.apache.org/r/31426/diff/ Testing --- make check Thanks, Dominic Hamon

Re: Review Request 31424: Resolve TODO and remove METRICS_SNAPSHOT macro

e4fa8f006e6a8f8804cfd47d3ad12b55cf064f99 Diff: https://reviews.apache.org/r/31424/diff/ Testing --- make check Thanks, Dominic Hamon

Review Request 31424: Resolve TODO and remove METRICS_SNAPSHOT macro

--- Resolve TODO and remove METRICS_SNAPSHOT macro Diffs - src/tests/rate_limiting_tests.cpp e4fa8f006e6a8f8804cfd47d3ad12b55cf064f99 Diff: https://reviews.apache.org/r/31424/diff/ Testing --- make check Thanks, Dominic Hamon

Review Request 31382: Various zookeeper test fixes.

tests/zookeeper.cpp 08cab86d148edf0cae3aaebfda30c21a75bca2b2 src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 Diff: https://reviews.apache.org/r/31382/diff/ Testing --- make check GTEST_FILTER='Group*.Zoo*' Thanks, Dominic Hamon

Re: Review Request 31315: Wait for status update to be processed before getting master metrics

Diff: https://reviews.apache.org/r/31315/diff/ Testing --- 300 repeats without failure of the test under a debugger. Thanks, Dominic Hamon

Re: Review Request 31315: Wait for status update to be processed before getting master metrics

. Thanks, Dominic Hamon

Re: Review Request 31315: Wait for status acknowledgement before getting master metrics

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31315/#review73659 --- On Feb. 23, 2015, 11:56 a.m., Dominic Hamon wrote: > > ---

Re: Review Request 31315: Wait for status acknowledgement before getting master metrics

: https://reviews.apache.org/r/31315/diff/ Testing --- 300 repeats without failure of the test under a debugger. Thanks, Dominic Hamon

Re: Review Request 31318: Fixed the flaky test SlaveTest.TaskLaunchContainerizerUpdateFails.

318/#comment120061> according to our style guide we don't do this: " You may not use a using-directive to make all names from a namespace available. // Forbidden -- This pollutes the namespace. using namespace foo; " - Dominic Hamon On Feb. 23,

Re: Review Request 31315: Wait for status acknowledgement before getting master metrics

pache.org/r/31315/#review73652 --- On Feb. 23, 2015, 11:56 a.m., Dominic Hamon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Review Request 31315: Wait for status acknowledgement before getting master metrics

/ Testing --- 300 repeats without failure of the test under a debugger. Thanks, Dominic Hamon

Re: Review Request 31308: mesos: Fixed compilation problems caused by mesos::internal namespace removal.

> > (Updated Feb. 23, 2015, 9:37 a.m.) > > > Review request for mesos and Dominic Hamon. > > > Repository: mesos > > > Description > --- > > see summary > > > Diffs > - > > src/tests/port_mapping_tests.cpp a03

Review Request 31312: Add new stout headers to Makefile.am

--- Add new stout headers to Makefile.am Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 8f6ac1539805d9de8f50c2d7402aebdf32fc48d2 Diff: https://reviews.apache.org/r/31312/diff/ Testing --- Thanks, Dominic Hamon

Re: Build failed in Jenkins: mesos-reviewbot #4245

i'm looking at it. i'm a bit confused as everything built locally. similarly, the error is that stout/ip.hpp is missing but https://builds.apache.org/job/mesos-reviewbot/4245/changes shows it being added. maybe it needs a bootstrap kick to rebuild correctly? On Mon, Feb 23, 2015 at 10:38 AM, Nikl

Re: Review Request 31308: mesos: Fixed compilation problems caused by mesos::internal namespace removal.

g/r/31308/#comment120008> we may not, but it was there before the namespace was removed. - Dominic Hamon On Feb. 23, 2015, 9:37 a.m., Evelina Dumitrescu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 31308: mesos: Fixed compilation problems caused by mesos::internal namespace removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31308/#review73599 --- Ship it! Ship It! - Dominic Hamon On Feb. 23, 2015, 9:37 a.m

Re: Review Request 31247: stout: Renamed net::ip to net::IP::fromLinkDevice

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31247/#review73596 --- Ship it! Ship It! - Dominic Hamon On Feb. 23, 2015, 8:23 a.m

Re: Review Request 31307: mesos: Renamed net::ip to net::IP::fromLinkDevice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31307/#review73597 --- Ship it! Ship It! - Dominic Hamon On Feb. 23, 2015, 8:23 a.m

Re: Review Request 30545: cgroups: added support to listen on memory pressures.

he.org/r/30545/#comment119981> thank you for using Owned! src/linux/cgroups.cpp <https://reviews.apache.org/r/30545/#comment119982> maybe CHECK_NOTNULL(process.get()) in case someone is trying to call counter during Listener destruction? - Dominic Hamon On Feb. 22, 2015, 8:4

Re: Review Request 31250: Expose the number of processes and threads in a container when cgroup is enabled.

<https://reviews.apache.org/r/31250/#comment119670> does this scale linearly with number of processes? src/slave/containerizer/isolators/cgroups/cpushare.cpp <https://reviews.apache.org/r/31250/#comment119671> does this scale linearly with number of threads? - Dominic Hamon

Re: Review Request 31247: stout: Renamed net::ip to net::IP::fromLinkDevice

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31247/#review73346 --- Ship it! Ship It! - Dominic Hamon On Feb. 20, 2015, 4:02 p.m

Re: Review Request 30545: cgroups: added support to listen on memory pressures.

enerProcess in its constructor and therefore own the lifetime of it? - Dominic Hamon On Feb. 20, 2015, 1:37 p.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 31139: Change EventLoop::delay to use lambda::function.

g/r/31139/#comment118946> reinterpret_cast(..) is unnecessary but provides some documentation. 3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/31139/#comment118947> explicit on one-arg constructors please. - Dominic Hamon On Feb. 17, 2015, 4:27 p.m

Re: Review Request 31008: Refactored EventListener to allow for continuous monitoring of an event.

008/#comment118849> is it worth trying again in these circumstances? src/linux/cgroups.cpp <https://reviews.apache.org/r/31008/#comment118850> so there's no way for me to reset this promise to try again once it fails once? - Dominic Hamon On Feb. 17, 2015, 12:10 p.m.

Re: Review Request 30545: cgroups: added support to listen on memory pressures.

che.org/r/30545/#comment118833> this should probably be an enum that you map to a string to avoid unexpected levels. - Dominic Hamon On Feb. 13, 2015, 10:08 a.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 30999: mesos: Moved MAC and IP classes to stout/mac.hpp and stout/ip.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30999/#review72759 --- Ship it! Ship It! - Dominic Hamon On Feb. 13, 2015, 7:22 a.m

Re: Review Request 31001: libprocess: Moved MAC and IP classes to stout/mac.hpp and stout/ip.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31001/#review72758 --- Ship it! Ship It! - Dominic Hamon On Feb. 13, 2015, 2:28 p.m

Re: Review Request 31000: stout: Moved MAC and IP classes to stout/mac.hpp and stout/ip.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31000/#review72750 --- Ship it! Ship It! - Dominic Hamon On Feb. 13, 2015, 7:23 a.m

  1   2   3   4   5   6   7   8   9   10   >