build.txt link to Perl return 404

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I'm trying to setup a build environment. When downloading the requirements 
I noticed the second link to Perl return an "Oops, This page could not be 
found". I believe the new link should be

https://www.activestate.com/products/perl/

(I didn't check the first link for Perl since my antivirus program threw up 
on that for some reason probably because of dangerous open source 
programs).

I didn't make a patch since I thought it would would be efficient for you 
to review the link and change yourself than to review a patch - but let me 
know and I can create a patch as well.

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a6844755-c405-49bd-891f-6392f4aa69ecn%40googlegroups.com.

Re: [PATCH] Pre-lock script and general hook script fixes

[Daniel Sahlberg via TortoiseSVN-dev]

I have investigated further and it seems that pre-lock hook scripts on a 
specific working copy path[1] doesn't work in 1.14.0 (and up to r29050). 
Only pre-lock hook scripts on path *[2] works.

I made an initial note of this and then proceeded to work on the other 
patches. When I got back to this (well past midnight, which might have 
clouded my judgement) I thought that the map never found the path (as 
described above). However it turns out that the actual problem was already 
solved by the "LockCommand SetSelectedList" patch and I just misdiagnosed 
the whole thing. Adding insult to injury I misunderstood how std::map works 
and didn't notice that it actually use the operator<(CTSVNPath&, 
CTSVNPath&) function (which work perfectly fine).


*All in all, please ignore the "hookkey as CString" patch.*

Images for reference, in case someone else is struggling with pre-lock hook 
scripts in 1.14.0 and below.

[1] This hook script will not execute in 1.14.0 and below:
[image: wontwork.png]

[2] This hook script will execute (for all WCs):
[image: works.png]

söndag 10 januari 2021 kl. 21:34:34 UTC+1 skrev Stefan:

> Well, CTSVNPath has multiple private members, but when comparing paths 
> that should never matter because each member is constructed as necessary.
> If you have a situation where the hook scripts are not executed/found for 
> a specific path, I'd like to have a clear example of that situation so I 
> can fix the real problem - usind CString instead is not really a solution 
> but I think only a workaround in this case.
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/5941a4d3-ba10-4169-a5ef-0c3d29475b30n%40googlegroups.com.

Re: Doing a diff from Log Messages causes an SVN assertion in offline mode

[Daniel Sahlberg via TortoiseSVN-dev]

Thank you, I can confirm that this avoid the assertion. I now get the error 
message "Could not retrieve URL of the file".

However I thinkt that error message might cause confusion amont users as to 
what the actual error is.

In my test case I have two revisions, one add and then one modification. It 
is when I try to view the diff from the modification I end up in the above 
code path.

If I try to show changes from the add (which obviously doesn't have a 
change, but it should show the initial version of the file, I get the 
following error message which is a bit better - at least it reports that 
the server is unreachable. (Sorry about the Swedish in the last line, it 
says No connection could be made because the target machine actively 
refused it).


I still believe that many of the commands doesn't make much sense in 
offline mode. Or is the idea that there could be a local cache also of the 
old revisions?
torsdag 17 december 2020 kl. 19:36:40 UTC+1 skrev Stefan:

> fixed in r29043

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a33117de-8183-4c6d-b9e8-7f2fbcfa2275n%40googlegroups.com.

Re: Cannot checkout. An operation was attempted on something that is not a socket.

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

>From a cursory glance, based on the error message, this originate deep down 
in the APR library in code which has not been changed between 1.7 and 1.14.

Just to rule out anything in TortoiseSVN, you could install the SVN command 
line tools (available in the TortoiseSVN installer) and try checking out 
from the command line: svn co [url]

To be able to help further it would be helpful to know
* The url you try checkout (if you can share it)
* If not, at least the access method (svn://, http://, https:// etc.)
* If you are able to checkout other repositories (especially with the same 
access method)

Without any other evidence I would look at firewalls/antivirus programs 
that might step in the way of things.

Kind regards,
Daniel
torsdag 24 december 2020 kl. 17:59:06 UTC+1 skrev sergio.fe...@gmail.com:

> Hi, 
>
> I have a little problem doing a checkout of a repository.
>
> Y get this error:
>
>  Cannot checkout. An operation was attempted on something that is not a 
> socket.
>
> svn: Can't write to connection: An operation was attempted on something 
> that is not a socket.
>
> I have the 1.14.0 version of Tortise on Windows 10, I've tried with older 
> version (1.7) and it works properly. Do you know if it is a bug o whatever 
> whit this tortoiseSVN version and if there are any solution?
>
> Best Regards.
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a9eea0da-c972-4540-bed3-02b9fa3f21bbn%40googlegroups.com.

[PATCH] Pre-lock script and general hook script fixes

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I've been investigating the pre-lock script and found a few things that 
doesn't make sense to me.

*The first file in the pre-lock script argument is always empty*
This is because CSVNProgressDlg::CmdLock is calling the PreLock hook using 
m_selectedPaths, however LockCommand::Execute is setting m_targetPathList. 
I believe it is more consistent to use m_selectedPaths (as with Commit 
hooks) and I've attached a patch to call CSVNProgressDlg::SetSelectedList 
in addition to CSVNProgressDlg::SetPathList (which is needed for 
SetWindowTitle among others).

*Parameter missmatch between documentation and implementation*
The documentation (dug_settings_hooks.xml) list the following parameters 
for Pre-lock: PATH LOCK FORCE MESSAGEFILE ERROR CWD
Actual parameters seems to be missing the ERROR parameter.

It would be handy to be return an error message from the pre-lock script 
instead of just returning an error code and getting:

However since none of the other pre-... scripts have the error parameter I 
think this is by design.

I'm attaching a patch to adjust the documentation to actual behaviour, but 
if it is preferred I can instead create a patch to add the error parameter 
and read the contents of the file to the error string. (In that case I 
believe the ERROR parameter should be moved last to avoid messing up any 
existing pre-lock scripts that depend on the actual parameters. I also 
believe it would be good to add the same parameter to the other pre-... 
scripts for consistency.)

*Difficulties finding the hook from Settings *
I have set a hook script in the general settings for TSVN like this.

I'm trying to lock C:\devel\test2\test.txt. However CHooks::FindItem 
doesn't find my pre-lock script. I had to resort to setting Working Copy 
Path to * to get a match.
I believe this is because CHooks:Create() is reading the hooks settings 
from the Registry and create a key.path as a CTSVNPath which only contains 
an m_sFwdslashPath. However CHooks::FindItem is working with a CTSVNPath 
object that have several of the strings defined and then map::find won't 
find the proper script.

I'm not completely sure how to solve this. I tried a naive solution to 
modify CHooks::FindItem to make sure the path only contained 
m_sFwdslashPath, however that failed when testing hooks set in the 
tsvn:prelockhook property (these contained a "fuller" path object). One 
possible solution would be to change the hookkey class to a plain CString 
(attached), I choosed GetWinPathString since it was already used in a few 
places to convert the path to CString.

*Displaying the Lock comment when lock(ing) fails*
The background of this whole thread was that I tried to create a pre-lock 
script that added the current computer name and WC path to the lock 
message. I can see the lock comment in "Check for modifications". However 
it would be very handy to get the lock comment already in the error message 
when SVN fails to aquire the lock.

I have made a very naive solution to catch m_bLockExists in 
CSVNProgressDlg::CmdLock and calling SVNInfo and then adding the comment 
using ReportString. It works [in principle], but fails miserably when 
locking more than one file (since the message is added in the end of the 
list and not next to the relevant file). Therefor I'm not attaching the 
patch.

Any ideas on this? Ideally Subversion would return the comment in addition 
to the W160035 "Path ... is already locked ..." error message. I will see 
if this is possible to add, it would also be beneficial for other clients 
than TSVN.

Kind regards,
Daniel Sahlberg



 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/178e8431-7bb8-4174-beb6-a6c3eb29c07en%40googlegroups.com.
Index: src/TortoiseProc/Commands/LockCommand.cpp
===
--- src/TortoiseProc/Commands/LockCommand.cpp	(revision 29048)
+++ src/TortoiseProc/Commands/LockCommand.cpp	(working copy)
@@ -1,4 +1,4 @@
-// TortoiseSVN - a Windows shell extension for easy version control
+// TortoiseSVN - a Windows shell extension for easy version control
 
 // Copyright (C) 2007-2009, 2014 - TortoiseSVN
 
@@ -48,6 +48,7 @@
 progDlg.SetCommand(CSVNProgressDlg::SVNProgress_Lock);
 progDlg.SetOptions(lockDlg.m_bStealLocks ? ProgOptForce : ProgOptNone);
 progDlg.SetPathList(lockDlg.m_pathList);
+progDlg.SetSelectedList(lockDlg.m_pathList);
 progDlg.SetCommitMessage(lockDlg.m_sLockMessage);
 progDlg.SetAutoClose (parser);
 progDlg.DoModal();
Index: doc/source/en/TortoiseSVN/tsvn_dug/dug_settings_hooks.xml
===
--- 

Re: [PATCH] Pre-lock script and general hook script fixes

[Daniel Sahlberg via TortoiseSVN-dev]

Answering myself..

måndag 4 januari 2021 kl. 01:13:27 UTC+1 skrev Daniel Sahlberg:

> Any ideas on this? Ideally Subversion would return the comment in addition 
> to the W160035 "Path ... is already locked ..." error message. I will see 
> if this is possible to add, it would also be beneficial for other clients 
> than TSVN.
>

It  looked quite complicated to change W160035. So I digged deeper and 
think I have figured out a way get the lock  comments in the right place. 
The "Locked on DESKTOP-..." lines are the lock comments.

The Action column should/could probably be set to something. Also multi 
line lock messages should probably be handled in some way - now the lines 
are just concatenated to a single line (I haven't tried very long lock 
messages).

Kind regards
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/e8bc9083-c527-49ac-b98c-6e884817be21n%40googlegroups.com.
Index: src/TortoiseProc/SVNProgressDlg.cpp
===
--- src/TortoiseProc/SVNProgressDlg.cpp	(revision 29048)
+++ src/TortoiseProc/SVNProgressDlg.cpp	(working copy)
@@ -52,6 +52,7 @@
 #include "BrowseFolder.h"
 #include "SimplePrompt.h"
 #include "Theme.h"
+#include "../SVN/SVNInfo.h"
 #include 
 
 BOOLCSVNProgressDlg::m_bAscending = FALSE;
@@ -716,7 +717,18 @@
 if ((err)&&(err->apr_err == SVN_ERR_FS_OUT_OF_DATE))
 m_bLockWarning = true;
 if ((err)&&(err->apr_err == SVN_ERR_FS_PATH_ALREADY_LOCKED))
+{
 m_bLockExists = true;
+SVNInfoinfo;
+const SVNInfoData* infodata = info.GetFirstFileInfo(path, SVNRev(L"HEAD"), SVNRev(L"HEAD"));
+if (infodata && !infodata->lock_comment.IsEmpty())
+{
+NotificationData* data2  = new NotificationData();
+data2->sActionColumnText = L"";
+data2->sPathColumnText = infodata->lock_comment;
+AddItemToList(data2);
+}
+}
 break;
 case svn_wc_notify_failed_unlock:
 data->sActionColumnText.LoadString(IDS_SVNACTION_FAILEDUNLOCK);

Re: [PATCH] Pre-lock script and general hook script fixes

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks!

Did you also take a look at the patches in the first message? Sorry if it 
caused extra work for you but I split it up to make it easier to review.

I realize I forgot to attach one of the patches to the first message, I'm 
attaching all three again for easier reference.

Kind regards,
Daniel

fredag 8 januari 2021 kl. 21:45:03 UTC+1 skrev Stefan:

> committed your patch in r29050

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/6aca0b1e-f530-4ce1-bc34-346384ab8a57n%40googlegroups.com.
Index: src/TortoiseProc/Commands/LockCommand.cpp
===
--- src/TortoiseProc/Commands/LockCommand.cpp	(revision 29048)
+++ src/TortoiseProc/Commands/LockCommand.cpp	(working copy)
@@ -1,4 +1,4 @@
-// TortoiseSVN - a Windows shell extension for easy version control
+// TortoiseSVN - a Windows shell extension for easy version control
 
 // Copyright (C) 2007-2009, 2014 - TortoiseSVN
 
@@ -48,6 +48,7 @@
 progDlg.SetCommand(CSVNProgressDlg::SVNProgress_Lock);
 progDlg.SetOptions(lockDlg.m_bStealLocks ? ProgOptForce : ProgOptNone);
 progDlg.SetPathList(lockDlg.m_pathList);
+progDlg.SetSelectedList(lockDlg.m_pathList);
 progDlg.SetCommitMessage(lockDlg.m_sLockMessage);
 progDlg.SetAutoClose (parser);
 progDlg.DoModal();
Index: doc/source/en/TortoiseSVN/tsvn_dug/dug_settings_hooks.xml
===
--- doc/source/en/TortoiseSVN/tsvn_dug/dug_settings_hooks.xml	(revision 29048)
+++ doc/source/en/TortoiseSVN/tsvn_dug/dug_settings_hooks.xml	(working copy)
@@ -273,7 +273,6 @@
 LOCK
 FORCE
 MESSAGEFILE
-ERROR
 CWD
   
 
Index: src/TortoiseProc/Settings/SetHooks.cpp
===
--- src/TortoiseProc/Settings/SetHooks.cpp	(revision 29048)
+++ src/TortoiseProc/Settings/SetHooks.cpp	(working copy)
@@ -1,4 +1,4 @@
-// TortoiseSVN - a Windows shell extension for easy version control
+// TortoiseSVN - a Windows shell extension for easy version control
 
 // Copyright (C) 2003-2010, 2012, 2014-2015 - TortoiseSVN
 
@@ -95,7 +95,7 @@
 for (hookiterator it = CHooks::Instance().begin(); it != CHooks::Instance().end(); ++it)
 {
 int pos = m_cHookList.InsertItem(m_cHookList.GetItemCount(), CHooks::Instance().GetHookTypeString(it->first.htype));
-m_cHookList.SetItemText(pos, 1, it->first.path.GetWinPathString());
+m_cHookList.SetItemText(pos, 1, it->first.path);
 m_cHookList.SetItemText(pos, 2, it->second.commandline);
 m_cHookList.SetItemText(pos, 3, (it->second.bWait ? L"true" : L"false"));
 m_cHookList.SetItemText(pos, 4, (it->second.bShow ? L"show" : L"hide"));
@@ -121,7 +121,7 @@
 {
 hookkey key;
 key.htype = CHooks::GetHookType((LPCTSTR)m_cHookList.GetItemText(index, 0));
-key.path = CTSVNPath(m_cHookList.GetItemText(index, 1));
+key.path = CTSVNPath(m_cHookList.GetItemText(index, 1)).GetWinPathString();
 CHooks::Instance().Remove(key);
 m_cHookList.DeleteItem(index);
 SetModified();
@@ -140,7 +140,7 @@
 CSetHooksAdv dlg;
 int index = m_cHookList.GetNextSelectedItem(pos);
 dlg.key.htype = CHooks::GetHookType((LPCTSTR)m_cHookList.GetItemText(index, 0));
-dlg.key.path = CTSVNPath(m_cHookList.GetItemText(index, 1));
+dlg.key.path = CTSVNPath(m_cHookList.GetItemText(index, 1)).GetWinPathString();
 dlg.cmd.commandline = m_cHookList.GetItemText(index, 2);
 dlg.cmd.bWait = (m_cHookList.GetItemText(index, 3).Compare(L"true")==0);
 dlg.cmd.bShow = (m_cHookList.GetItemText(index, 4).Compare(L"show")==0);
@@ -149,7 +149,7 @@
 if (dlg.DoModal() == IDOK)
 {
 CHooks::Instance().Remove(key);
-CHooks::Instance().Add(dlg.key.htype, dlg.key.path, dlg.cmd.commandline,
+CHooks::Instance().Add(dlg.key.htype, CTSVNPath(dlg.key.path), dlg.cmd.commandline,
dlg.cmd.bWait, dlg.cmd.bShow, dlg.cmd.bEnforce);
 RebuildHookList();
 SetModified();
@@ -162,7 +162,7 @@
 CSetHooksAdv dlg;
 if (dlg.DoModal() == IDOK)
 {
-CHooks::Instance().Add(dlg.key.htype, dlg.key.path, dlg.cmd.commandline,
+CHooks::Instance().Add(dlg.key.htype, CTSVNPath(dlg.key.path), dlg.cmd.commandline,
dlg.cmd.bWait, dlg.cmd.bShow, dlg.cmd.bEnforce);
 RebuildHookList();
 

Re: [PATCH] Pre-lock script and general hook script fixes

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks!

The problem I'm trying to solve is that I couldn't get the hooks to execute 
when I set them to a specific path (c:\devevel\test, which is my wc), only 
when using *. I stepped through the code in Visual Studio and I noticed 
that CHooks::FindItem didn't find a hook (it = find(key) always returned 
end()) for a path even though I had seen it being added from the registry 
just before.

My understanding is as follows:
* A CTSVNPath object contain a number of separate CStrings for storing the 
path. Depending on how it is set, only some are populated. (The rest are 
populated if requested).
* When the hookkey is created the path is constructed in different ways in 
different places of the code, for example in Hooks.cpp when reading from 
the Registry it is created using the constructor (which 
calls SetFromUnknown, in turn calling SetFwdslashPath) and in 
ParseAndInsertProjectProperty the wcRootPath has been constructed in a 
different way.
* The pathList in CHooks::FindItem again contain different members of 
CTSVNPath.
* The STL map::find function will only match a key if all members are 
exactly the same.
(The last point is merely an observation of behaviour, I can't give any 
references to this being expected behaviour).

By switching out the CTSVNPath to CString (and being strict about that 
string always being retrieved from CTSVNPath::GetWinPathString()) I'm able 
to find my hook scripts.

Initially I made a simpler patch in CHooks::FindItem which instead of just 
taking pathList[i] created a new CTSVNPath object that only had the 
forwardslashpath set. That worked for hook scripts from the registry 
however failed for hook scripts as project properties. For this to work all 
places where the hookkey path is set must create a new CTSVNPath with only 
the forwardslashpath set. [Of course it could also be using the 
backslashpath instead].

Sorry for the long explaination but I must admit C++ is not my primary 
langauge.

Kind regards,
Daniel Sahlberg
söndag 10 januari 2021 kl. 18:20:00 UTC+1 skrev Stefan:

> committed two of your patches in r29051, but I don't see the benefit of 
> your hookkey-as-CString patch. Why do you think using a CString is better 
> there?
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/90db78be-79cd-430a-8695-a53c5398a10dn%40googlegroups.com.

Re: Doing a diff from Log Messages causes an SVN assertion in offline mode

[Daniel Sahlberg via TortoiseSVN-dev]

I saw the further change in r29044 and I would just like to say that it 
seems much better now. Thanks for your support!

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/f7918b44-3f87-4d2f-99d3-44a80593dabcn%40googlegroups.com.

Doing a diff from Log Messages causes an SVN assertion in offline mode

[Daniel Sahlberg via TortoiseSVN-dev]

An error was reported in the Subversion Users mailing list regarding an 
assertion thrown in TortoiseSVN 
(https://mail-archives.apache.org/mod_mbox/subversion-users/202011.mbox/%3CPH0PR11MB4789BCA6DF5CB62E5198CBA491E20%40PH0PR11MB4789.namprd11.prod.outlook.com%3E).

The basic premisis is that the server is not currently reachable and the 
user has selected to be offline. In the original report there was a VPN 
involved but it doesn't matter why the server is unreachable, when 
investigating I modified the DNS resolution by inserting a fake entry in 
the c:\windows\system32\drivres\etc\hosts file.

I have dug into this and it seems to originate in CLogDlg:DoDiffFromLog. 
The call to GetRepositoryRoot (line 2855) return differently depending on 
whether the server is available (https://server.url/svn/trunk/test.txt) or 
not (blank). Following the code it seems that GetRepositoryRootAndUUID 
tries to call svn_client_get_repos_root, which fail because the server is 
not available.

If I fake the return value from GetRepositoryRoot I will end up with an 
error "Unable to connect to a repository at URL 
https://server.url/svn/trunk/test.txt;.

*Summary*
Is it reasonable that it is possible to "Show changes" from the Log dialog 
when in offline mode since we would not be able to get the files from the 
server anyway?
If reasonable, could the error from svn_client_get_repos_root be handled 
differently to avoid setting filepath empty and thus avioding the assertion 
later on?

Kind regards
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/8d8ef431-b810-44bf-bf03-01ec39491c27n%40googlegroups.com.

Re: SVN: externals with propset/propedit

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 1 juli 2021 kl. 12:02:04 UTC+2 skrev sanket belsare:

> Hi,
>
> I am creating one branch from the trunk through batch script using svn 
> copy command. Trunk is having some externla link folders.
>
> Now I just want to use SVN:externals command to link the branches folder. 
> Could anyone suggest what will be the exact command to use.
>
> I have tried with SVN propset command after copy but somehow getting an 
> error.
>
> svn propset svn:externals //https:/svn/trunk //https:/svn/branch
>

This is probably a question better suited for TortoiseSVN Users or even 
us...@subversion.apache.org (see 
https://subversion.apache.org/mailing-lists.html). The -dev list is 
primarily for questions related to development of TortoiseSVN.

It is a a bit unclear what your paths are but I was able to switch the 
svn:externals properties for a working copy pointing 
at  http://svn.osdn.net/svnroot/tortoisesvn/trunk/ext (ie, part of the 
TortoiseSVN code base) using:

svn propset svn:externals  
"https://svn.apache.org/repos/asf/subversion/trunk Subversion" .

(Obviously my current working directory - "." in the command above - was 
the working copy folder).

Please note that the above command will break the build of TortoiseSVN 
since it contains more externals than just Subversion - it is just an 
example.

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/7c02c5a5-f9f5-45ab-8d6c-6a0ebe936f6an%40googlegroups.com.

Re: Pre-lock script templates (to the contrib directory)

[Daniel Sahlberg via TortoiseSVN-dev]

Sorry, the attachments were not accepted. Adding them here, should be 
renamed .js.tmpl.

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/56e6d72f-2174-48d3-b607-4453993a4aa3n%40googlegroups.com.
/* this script is a local pre-lock hook script that sets the lock message to 
include the computer name and wc path. */

var ForAppending = 8;
var objArgs, num;

objArgs = WScript.Arguments;
num = objArgs.length;
if (num !== 5)
{
WScript.Echo("Usage: [CScript | WScript] PreLock.js path/to/pathsfile lock 
force path/to/msgfile path/to/CWD ");
WScript.Quit(1);
}

if (objArgs(1) == "true")
{
var fs = new ActiveXObject("Scripting.FileSystemObject");
if (fs.FileExists(objArgs(3)))
{
var wshl = new ActiveXObject("WScript.Shell")
var a = fs.OpenTextFile(objArgs(3), ForAppending);
a.WriteLine("Locked on " + 
wshl.ExpandEnvironmentStrings("%COMPUTERNAME%") + " in wc " + objArgs(4));
a.Close();
}
}
/* this script is a local pre-lock hook script. */

var ForReading = 1;
var objArgs, num;

objArgs = WScript.Arguments;
num = objArgs.length;
if (num !== 5)
{
WScript.Echo("Usage: [CScript | WScript] PreLock.js path/to/pathsfile lock 
force path/to/msgfile path/to/CWD ");
WScript.Quit(1);
}

var paths = readPaths(objArgs(0));
var message = "list of paths selected for locking:\n";

for (var i = 0; i < paths.length; i++)
{
message = message + paths[i] + "\n";
}

message = message + (objArgs(1) == "true" ? "Getting" : "Releasing") + " lock" 
+ (objArgs(2) == "true" ? " - forcefully" : "") + "\n";
message = message + readFile(objArgs(3));
message = message + "CWD is: " + objArgs(4) + "\n";

WScript.Echo(message);
WScript.Quit(0);


function readPaths(path)
{
var retPaths = [];
var fs = new ActiveXObject("Scripting.FileSystemObject");
if (fs.FileExists(path))
{
var a = fs.OpenTextFile(path, ForReading);
while (!a.AtEndOfStream)
{
var line = a.ReadLine();
retPaths.push(line);
}
a.Close();
}
return retPaths;
}

function readFile(path)
{
var msg = "";
var lines = 0;
var fs = new ActiveXObject("Scripting.FileSystemObject");
if (fs.FileExists(path))
{
var a = fs.OpenTextFile(path, ForReading);
while (!a.AtEndOfStream)
{
msg += a.ReadLine() + "\r\n";
lines++;
}
a.Close();
}
return "Lock message (" + lines + " lines):\r\n" + msg;
}

Pre-lock script templates (to the contrib directory)

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I would like to contribute two PreLock script templates (for the 
contrib/hook-scripts/client-side directory).

PreLock.js.tmpl is based on PreUpdate.js.tmpl, adding a display of the 
msgfile and adjusting the parameters.

PreLock-add-computer-and-path.js.tmpl is a script to add the computer name 
and local WC path to the end of the lock message, a feature requested from 
time to time on the mailing lists (both here and upstream).

Please add them if you find them useful (and anyone else, feel free to use 
them on your side).

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/84c32725-cceb-44b0-9a10-5e6eb4f6dad3n%40googlegroups.com.

Nightly builds failure

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

The nightly builds doesn't seem to work at the moment.

Copied from the build log 
at https://nightlybuilds.tortoisesvn.net/latest/x64/full/buildlog64.txt:

[[[
setup:

 [echo] TortoiseSVN will be built without support for the 
Windows 11 context menu
 [exec] TortoiseSVN.wxs
 [exec] FeaturesFragment.wxs
 [exec] StructureFragment.wxs
 [exec] UIFragment.wxs
 [exec] 
C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\StructureFragment.wxs(24) : error 
LGHT0103 : The system cannot find the file 'c:\Program Files 
(x86)\Microsoft Visual 
Studio\2019\Community\VC\Redist\MSVC\14.29.30133\\MergeModules\Microsoft_VC142_CRT_x64.msm'.
 [exec] 
C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\StructureFragment.wxs(25) : error 
LGHT0103 : The system cannot find the file 'c:\Program Files 
(x86)\Microsoft Visual 
Studio\2019\Community\VC\Redist\MSVC\14.29.30133\\MergeModules\Microsoft_VC142_MFC_x64.msm'.
 [exec] 
C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\StructureFragment.wxs(26) : error 
LGHT0103 : The system cannot find the file 'c:\Program Files 
(x86)\Microsoft Visual 
Studio\2019\Community\VC\Redist\MSVC\14.29.30133\\MergeModules\Microsoft_VC142_MFCLOC_x64.msm'.
 [exec] 
C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\StructureFragment.wxs(27) : error 
LGHT0103 : The system cannot find the file 'c:\Program Files 
(x86)\Microsoft Visual 
Studio\2019\Community\VC\Redist\MSVC\14.29.30133\\MergeModules\Microsoft_VC142_CRT_x86.msm'.

BUILD FAILED - 0 non-fatal error(s), 1 warning(s)

C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\setup.build(160,8):
External Program Failed: light (return code was 103)

Total time: 6 seconds.


BUILD FAILED

Nested build failed.  Refer to build log for exact reason.

Total time: 3445.3 seconds.
]]]

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/fd44c9a1-d285-43b4-9aba-a040944a402bn%40googlegroups.com.

Re: Nightly builds failure

[Daniel Sahlberg via TortoiseSVN-dev]

Bonus points for checking if the following folder should really exist on 
the build 
server: https://nightlybuilds.tortoisesvn.net/latest/win32/full/release64/bin/
It seems to contain files from 2021-Mar-17.

/Daniel

söndag 19 september 2021 kl. 17:27:01 UTC+2 skrev Daniel Sahlberg:

> Hi,
>
> The nightly builds doesn't seem to work at the moment.
>
> Copied from the build log at 
> https://nightlybuilds.tortoisesvn.net/latest/x64/full/buildlog64.txt:
>
> [[[
> setup:
> 
>  [echo] TortoiseSVN will be built without support for the 
> Windows 11 context menu
>  [exec] TortoiseSVN.wxs
>  [exec] FeaturesFragment.wxs
>  [exec] StructureFragment.wxs
>  [exec] UIFragment.wxs
>  [exec] 
> C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\StructureFragment.wxs(24) : error 
> LGHT0103 : The system cannot find the file 'c:\Program Files 
> (x86)\Microsoft Visual 
> Studio\2019\Community\VC\Redist\MSVC\14.29.30133\\MergeModules\Microsoft_VC142_CRT_x64.msm'.
>  [exec] 
> C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\StructureFragment.wxs(25) : error 
> LGHT0103 : The system cannot find the file 'c:\Program Files 
> (x86)\Microsoft Visual 
> Studio\2019\Community\VC\Redist\MSVC\14.29.30133\\MergeModules\Microsoft_VC142_MFC_x64.msm'.
>  [exec] 
> C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\StructureFragment.wxs(26) : error 
> LGHT0103 : The system cannot find the file 'c:\Program Files 
> (x86)\Microsoft Visual 
> Studio\2019\Community\VC\Redist\MSVC\14.29.30133\\MergeModules\Microsoft_VC142_MFCLOC_x64.msm'.
>  [exec] 
> C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\StructureFragment.wxs(27) : error 
> LGHT0103 : The system cannot find the file 'c:\Program Files 
> (x86)\Microsoft Visual 
> Studio\2019\Community\VC\Redist\MSVC\14.29.30133\\MergeModules\Microsoft_VC142_CRT_x86.msm'.
> 
> BUILD FAILED - 0 non-fatal error(s), 1 warning(s)
> 
> C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\setup.build(160,8):
> External Program Failed: light (return code was 103)
> 
> Total time: 6 seconds.
> 
>
> BUILD FAILED
>
> Nested build failed.  Refer to build log for exact reason.
>
> Total time: 3445.3 seconds.
> ]]]
>
> Kind regards,
> Daniel Sahlberg
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/6cdaa6fd-e406-49eb-86b7-6c6d755d363en%40googlegroups.com.

[PATCH] Invalid path in default.build.user.tmpl

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I got an error message when building:

C:\Devel\tortoisesvn\default.build(358,6):
'C:\Program Files (x86)\Windows Kits\10\Debuggers\x86>\srcsrv\svnindex.cmd' 
is not a valid value for attribute 'program' of .

I traced it to an invalid oath in default.build.user which I initially 
copied from default.build.user.tmpl and didn't pay enough attention.

I'm attaching a patch, just removing a > from the path.

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/e719bd5e-a084-44f2-a77f-a0891ffe0f70n%40googlegroups.com.
--- 
C:/Users/danie/AppData/Local/Temp/default.build.user.tmpl-revBASE.svn001.tmp.tmpl
   tor apr 11 18:18:48 2019
+++ C:/Devel/tortoisesvn/default.build.user.tmplsön sep 19 17:04:33 2021
@@ -107 +107 @@
-
+

Re: Link to books in /support.html

[Daniel Sahlberg via TortoiseSVN-dev]

r29235 looks very good. I don't mean to be a PITA but in 
/testimonials.html, the quote from Eric Hanchrow ends rather abruptly 
"...ranting about the\n".

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/b9ba23c2-8c2f-4b60-90f8-f8fb58195309n%40googlegroups.com.

Re: Nightly builds with support for Win11

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 7 oktober 2021 kl. 21:32:41 UTC+2 skrev Stefan:

> As you've already noticed, you need to digitally sign the binaries if you 
> want to get the support for the Win11 context menu.
> I've added a few lines to the build.txt file:
> https://svn.osdn.net/svnroot/tortoisesvn/trunk/build.txt
>
> basically, you need to create two files (signinfo.txt and 
> signpublisher.txt) in the wc root, and then start the build.
> just have a look at the build.txt file, section "digitally signing the 
> binaries and installers"
>

Thanks, yes, I saw those. My problem was in creating a suitable 
(selfsigned) certificate. I think I managed, but I'll have to doublecheck 
the different steps. Would it make sense to document these steps in 
build.txt? I can write them up after double checking.

if you then still have questions, please ask!
>

Yes, but maybe this should be a new thread. Even though I have everything 
signed (almost - TortoiseSVN32.dll and TortoiseStub32.dll are not signed) 
and no error messages during the build, the context menu is still only 
available under Shift-F10. Is this a known problem with a selfsigned cert 
or can I check somewhere if it was installed properly? (I've rebooted my 
computer after installation).
 

> as for the nightly builds getting that, I don't think this will happen - 
> the WANdisco guys can't get the digital signing to work, and I've asked 
> many, many times
>

Oh, that's too bad.

Thanks for your help so far!

Kind regards
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/6ef11d8e-d8f3-4d39-a3dc-9cc2b9b7fbc8n%40googlegroups.com.

Re: Nightly builds with support for Win11

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 13 oktober 2021 kl. 20:33:00 UTC+2 skrev Stefan:

> here's how to create a self-signed certificate that's compatible with 
> Windows identity needed for packages:
>
> https://docs.microsoft.com/en-us/windows/win32/appxpkg/how-to-create-a-package-signing-certificate
>

Thank you Stefan, that was the final piece of the puzzle. I now have a 
working context menu in Win11.

Would you consider to add this link to build.txt?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/b16a60cf-d9d0-45b1-af50-4e3157a57da8n%40googlegroups.com.

Re: Nightly builds with support for Win11

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 12 oktober 2021 kl. 18:34:11 UTC+2 skrev Stefan:

> On Sunday, October 10, 2021 at 11:13:55 PM UTC+2 daniel.l...@gmail.com 
> wrote:
>
>> torsdag 7 oktober 2021 kl. 21:32:41 UTC+2 skrev Stefan:
>>
>>> As you've already noticed, you need to digitally sign the binaries if 
>>> you want to get the support for the Win11 context menu.
>>> I've added a few lines to the build.txt file:
>>> https://svn.osdn.net/svnroot/tortoisesvn/trunk/build.txt
>>>
>>> basically, you need to create two files (signinfo.txt and 
>>> signpublisher.txt) in the wc root, and then start the build.
>>> just have a look at the build.txt file, section "digitally signing the 
>>> binaries and installers"
>>>
>>
>> Thanks, yes, I saw those. My problem was in creating a suitable 
>> (selfsigned) certificate. I think I managed, but I'll have to doublecheck 
>> the different steps. Would it make sense to document these steps in 
>> build.txt? I can write them up after double checking.
>>
>
> yes, of course you can add to build.txt!
>  
>
>>
>> if you then still have questions, please ask!
>>>
>>
>> Yes, but maybe this should be a new thread. Even though I have everything 
>> signed (almost - TortoiseSVN32.dll and TortoiseStub32.dll are not signed) 
>> and no error messages during the build, the context menu is still only 
>> available under Shift-F10. Is this a known problem with a selfsigned cert 
>> or can I check somewhere if it was installed properly? (I've rebooted my 
>> computer after installation).
>>
>
> well, unfortunately, there's no way (I know of) to really figure out why 
> the menu won't show up. It took me more than a week to get this working...
> Since most of what I learned is now in the build script, a few pointers:
> * the text in signpublisher.txt must match the certificate DN *exactly* 
> (but it must be xml quoted, e.g. a " must be changed to )
> * signing must be done with the /fd SHA256 switch, otherwise you'll get a 
> non-descriptive error when building the msix
> as for self-signed certificates, I'm not sure these would even work. But 
> you will have to install the certificate into the Windows root chain if you 
> want any chance to get that to work. Just signing without having the cert 
> also installed will definitely not work. And the certificate needs to be 
> created with SHA256 encryption - anything else won't work (but you won't 
> get any errors, it just silently won't work).
>

Thanks. I believe I've done all this, still doesn't work. I think I'm able 
to get an official certificate from digicert through apache.org so I'll 
investigate that route first and come back if I have further questions.

Kind regards,
Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/2507773a-314a-497c-9961-d51913758880n%40googlegroups.com.

Re: TortoiseSVN missing CA Certificate

[Daniel Sahlberg via TortoiseSVN-dev]

What version of TortoiseSVN are you using and what version of Windows?

I also have a Let's Encrypt certificate and I don't get the same warning.

Kind regards
Daniel Sahlberg

torsdag 30 september 2021 kl. 17:52:54 UTC+2 skrev Matthew Trescott:

> Hello TortoiseSVN developers,
>
> I host a small SVN server for my university project team and have a Let's 
> Encrypt TLS certificate. Today we started getting this error:
>
> C:\Users\mtrescott\Documents\formulasae>svn up
> Updating '.':
> Error validating server certificate for '
> https://fsae-demo.trescott.net:443':
>  - The certificate is not issued by a trusted authority. Use the
>fingerprint to validate the certificate manually!
> Certificate information:
>  - Hostname: trescott.net
>  - Valid: from Aug  4 05:36:20 2021 GMT until Nov  2 05:36:18 2021 GMT
>  - Issuer: R3, Let's Encrypt, US
>  - Fingerprint: 07:D0:B7:05:56:E1:76:29:BC:30:82:10:22:DF:29:4B:5F:5B:6A:6D
> (R)eject, accept (t)emporarily or accept (p)ermanently? t
>
> I believe the problem is caused by Tortoise not including the ISRG Root X1 
> CA certificate. Let's Encrypt has an article about this. 
> https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/
>
> It's not too inconvenient because we can just manually trust the 
> certificate, but it would be helpful to have this CA certificate included, 
> since we'd have a permanent fix then.
>
> Best regards,
> Matt
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a8f7b774-dca3-4e4a-b01c-b66198e30ef4n%40googlegroups.com.

Re: Nightly builds failure

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks!

onsdag 22 september 2021 kl. 09:14:39 UTC+2 skrev Stefan:

> nightly builds are up again.
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/988908d7-4e84-4e04-bb83-6f3a531ee755n%40googlegroups.com.

Nightly builds with support for Win11

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I've been trying to build my own setup to test on Win11, however I'm have 
not been able to make the code signing work yet.

In the meantime I looked at the nightly builds but it seems they are not 
built with support for the Windows 11 context menu either.

Is there any chance to configure the nightly builds with support for the 
Windows 11 context menus? Or is it still too much work in progress to be 
meaningful to test?

Kind regards
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/f3087b5e-03c9-4f30-8c84-4c2956cb83fan%40googlegroups.com.

Link to books in /support.html

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

While looking at the translated documentation on the website (prompted by 
Stefan's question in the TortoiseSVN group [1]), I checked the links in the 
/support.html page.

Under TortoiseSVN book, there is a link "TortoiseSVN 1.7 Beginner's Guide", 
but following the link I find the book "Drupal Intranets with Open Atrium".

Under Subversion book, next to the link "Version Control with Subversion", 
there is a broken image (alt "wtf").

I might also mention that svnbook.red-bean.com support https since a few 
weeks so you might want to update any links to that site.

Kind regards,
Daniel Sahlberg 


[1] https://groups.google.com/g/tortoisesvn/c/XJJ473UgSIQ

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/697d7121-c544-46ff-a7a0-9a764e19b23bn%40googlegroups.com.

Re: Why the options "Allow ambiguous URLs" and "Allow ambiguous UUIDs" are enabled by default?

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 13 juli 2021 kl. 07:17:33 UTC+2 skrev Stefan:

> On Monday, June 7, 2021 at 8:50:02 PM UTC+2 Pavel Lyalyakin wrote:
>
>>
>> Do I understand correctly that these options are enabled by default in 
>> all TortoiseSVN versions? Is there a rationale for enabling these options 
>> by default?
>>
>>
> yes, these options are enabled by default. That's because this is the safe 
> option. When this option is disabled but the user connects to wrongly 
> configured/set-up repos then there will be crashes and completely wrong 
> logs being shown.
> So the user can disable these options to get a little more performance, 
> but then the user is responsible to make sure that uuids and urls are not 
> ambiguous, or life with the consequences...
>
> If it were the other way around, users would get crashes/wrong logs and 
> not know why, so they either would just think that TSVN is unstable/crap or 
> complain here about "the bug".
>
> Stefan
>

I believe the wording is a bit counter intuitive because it implies, at 
least to me, that it is by default ("leave it") unchecked.

I would propose a rewording like this:

[[[
Index: doc/source/en/TortoiseSVN/tsvn_dug/dug_settings_logcache.xml
===
--- doc/source/en/TortoiseSVN/tsvn_dug/dug_settings_logcache.xml
(revision 29091)
+++ doc/source/en/TortoiseSVN/tsvn_dug/dug_settings_logcache.xml
(working copy)
@@ -43,7 +43,7 @@
 the same URL for all repositories. Older versions of
 svnbridge would do this. If you need to
 access such repositories you will have to check this option.
-If you don't, leave it unchecked to improve performance.
+If you don't, uncheck it to improve performance.
   
 
   
@@ -57,7 +57,7 @@
 reasons this is a bad idea - a UUID should be
 unique. However, the log cache will
 still work in this situation if you check this box.
-If you don't need it, leave it unchecked to improve 
performance.
+If you don't need it, uncheck it to improve performance.
   
 
   
]]]

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/5c2732a5-c48c-455f-8791-1dec9dc5b485n%40googlegroups.com.

Re: Link to books in /support.html

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 24 juli 2021 kl. 09:47:53 UTC+2 skrev Stefan:

> Thanks for noticing.
> I've fixed the links and changed many other links to https.
> Since I can't update the website myself, we'll have to wait for the next 
> release when the website gets updated for these changes to appear.
>

I checked the changes and it mostly looks good to me! However I found some 
issues:

issuetrackerplugins.html:
- TurtleSpira is still "Open Source" in DE, changed in r29068.
- Rally Software seems to be owned by Broadcom, link redirects 
to https://www.broadcom.com/products/software/agile-development/rally-software
- JiraSvn has different links in EN and in DE, it seems to be the EN link 
(to github.com) that is correct
- HP QC/ALM seems to Micro Focus ALM / Quality Center these days (according 
to Wikipedia it was aquired by Micro Focus in 2017), new URL seems to 
be https://www.microfocus.com/en-us/products/alm-quality-center/overview
- TurtleTFS has different links in EN and in DE, it seems to be the EN link 
(to github.com) that is correct
- Artifacts only exists in the DE version. And it seems broken.
- The SubversionOne link has a message "CodePlex Archive will be shut down 
after July 1st, 2021" and www.versionone.com redirects to www.collab.net, 
proper link is probably https://www.collab.net/products/versionone
- www.bugseverywhere.org doesn't exist anymore
- TurtleSift has different links in EN and in DE, it seems to be the EN 
link (to github.com) that is correct

issuetrackers.html:
Links to fogcreek.com and citydesknews.com (last paragraph of the page) 
seems dead.

majorupgrade.html:
Most of the links are 404 (for example robmensching.com ("keypath"), 
support.microsoft.com and tortoisesvn.tigris.org

ssh_howto.html:
- www.antedes.com link is 404.

testimonials.html:
- https://thomson.com is 404. This one seems better with plain http:// 
since it redirects to https://www.thomsonreuters.com/
- www.onlamp.com is broken (The Subversion site had a lot of these links 
and I had to replace them all with links through archive.org).
- The googledocs-link from Eric Hanchrow is 404.
- www.iexperts.ru give (at least for me) an SSL version error

translation_instructions.html:
- The link to poEdit doesn't work with https. With http it is a redirect 
to https://poedit.net/
- The link to Virtaal doesn't work with https. With http it is a redirect 
to https://virtaal.translatehouse.org/?id=virtaal/index
- The link to iso.ch redirects to iso.org (with a certificate warning), but 
the redirect is a 404.

visualstudio.html:
AnkhSVN seems to be at https://github.com/AmpScm/AnkhSVN/

Kind regards
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/1eb0bfab-f3fe-464d-b7da-f92160df10d9n%40googlegroups.com.

Re: SVN installation white Command Line Client

[Daniel Sahlberg via TortoiseSVN-dev]

This was asked last year, please check if this answers your question:

https://groups.google.com/g/tortoisesvn-dev/c/WjL5HOWCJpM/m/mfzAuc0dAwAJ


måndag 7 mars 2022 kl. 13:40:14 UTC+1 skrev simon...@kabelmail.de:

> How can I install the software unattended with the command line client, in 
> normal unattended installation this is missing and must be installed 
> manually.
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/6499d7ed-cd40-42aa-ab82-94aa55257bf8n%40googlegroups.com.

Re: Nightly builds failed for couple of days.

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 14 februari 2022 kl. 09:10:39 UTC+1 skrev 张正培:

> Nightly builds failed for couple of days.
> NMAKE : fatal error U1052: file 'makefile' not found
>

Working again: https://nightlybuilds.tortoisesvn.net/latest/x64/full/ 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/660578fc-8eff-496c-854c-ba6198be6cfen%40googlegroups.com.

Re: Nightly Build Windows 11 context menu not showed

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 16 februari 2022 kl. 10:55:06 UTC+1 skrev 张正培:

> Nightly Build Windows 11 context menu not showed.
>

This has been discussed in the thread 
https://groups.google.com/g/tortoisesvn-dev/c/zf6JjngNfEs/m/tg41llmZBAAJ

TL;DR: No, it is not because of limitations on the build machine. It is 
possible to build yourself with a self-signed certificate. I've done it and 
Stefan updated the build instructions sligthly based to make it easier.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/b53e763b-c91a-4206-a7e9-058de70e79bbn%40googlegroups.com.

r29609

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

In r29609 there is a text "based upon their visit to www.website.com". 
Looks like boilerplate text where the URL should be replaced with the 
actual URL that should be replaced with "www.tortoisesvn.net"`, or is this 
intentional?

Kind regards,
/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d9b2334f-4c66-4cc8-8c24-3eb34cb55c82n%40googlegroups.com.

Re: Add additional information to the Windows Explorer Title Bar - SVN

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 17 oktober 2023 kl. 01:25:04 UTC+2 skrev arathb...@gmail.com:

I found this info in the documentation:
https://tortoisegit.org/docs/tortoisegit/tgit-dug-settings.html

ModifyExplorerTitle

When using the status cache, the title bar of explorer windows are modified 
to include the branch name, stash count and if an upstream is set also the 
outgoing and incoming commits. Set this to false if you don't want this or 
if you have other tools which already do that. The default is true.
Best regards.
On Monday, October 16, 2023 at 4:19:47 PM UTC-7 Arath Burgos Hernandez 
wrote:

Hi Everyone,

I saw this interesting feature in TortoiseGit (attached 
as currentBranchInTittle.png).
Which can be enabled as follow (attached 
as currentBranchInTittle_TGit_Setting.png).
The feature basically integrates the current branch in Windows Explorer 
Title when it is a Git repo.

I saw that it was developed in this commit:
https://github.com/TortoiseGit/TortoiseGit/commit/2871c9646ef0931c955ef1617a6e7db00e0e43ad

However, this feature is not available for TortoiseSvn. I know that Git is 
better than Svn. Unfortunately, I have to continue using SVN yet. It would 
be great to have this feature.


I tried to download an re-compile the project but I had some issues. Do you 
know if is it too complicated integrate that change on TortoiseSvn?


A difference between Git and SVN is that a branch in Git is something that 
applies to a whole repository. In SVN, a branch is only a certain directory 
within the tree, copied from some other directory. By convention, branches 
live in /branches but there is nothing in the SVN design enforcing this. A 
repository can also contain multiple projects where each project has its 
own directory (with "branches" below). Finally, the equivalent of the Git 
Master/Main branch is the directory /trunk, which doesn't live beneath 
/branches at all.

So the problem to solve is how to figure out the branch name. The only way 
is to have some heuristics that look at the path name, but that is bound to 
fail sooner or later depending on the repository layout.

What was the problem compiling? Can we help with that?

Kind regards,
Daniel 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/ebb28d0b-ca83-41f0-9cdf-c5fecbd2aab1n%40googlegroups.com.

1.10.x EOL

[Daniel Sahlberg via TortoiseSVN-dev]

As the Subversion project just announced 1.10.x as EOL (in reality it has 
been EOL since April last year), I've removed the download links from the 
website. I couldn't find a news article from other EOLs so I didn't add 
anything.

On the Download page, there is a section on the "Context menu in 
file-open/save dialogs" there is a reference to Windows 7 / Windows 8. Do 
we still support those or should this section be removed?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/de2dbc8f-c47a-41bd-8433-9e44e711eab3n%40googlegroups.com.

Re: Switch vc2019 to vs2022

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks!

There are some additional instances in build.txt, see attached. The start 
menu references are as they appear in my Win11 machine. It doesn't match 
the folder names in "Start menu" though and I'm not sure why. I'm also not 
sure if I picked the correct command prompts for the different builds so 
you may want to change it yourself instead of using the patch.

@Bruce Clark: Thanks for noticing. It seems Stefan caught this before 
committing.

/Daniel
måndag 11 april 2022 kl. 20:21:40 UTC+2 skrev Stefan:

> Thanks, committed in r29390

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/fc9cd482-25c3-4c62-82f3-bc8df0cda5bdn%40googlegroups.com.
--- C:/Users/danie/AppData/Local/Temp/build.txt-revBASE.svn003.tmp.txt  tor jan 
 6 19:19:54 2022
+++ C:/Devel/tortoisesvn/build.txt  lör apr 16 14:43:48 2022
@@ -104 +104 @@ https://docs.microsoft.com/en-us/windows/win32/app
-  file which is located in C:\Program Files (x86)\Microsoft Visual 
Studio\2019\Community\VC\Auxiliary\Build.
+  file which is located in C:\Program Files\Microsoft Visual 
Studio\2022\Community\VC\Auxiliary\Build.
@@ -143,3 +143,2 @@ https://docs.microsoft.com/en-us/windows/win32/app
-  open "Microsoft Visual Studio 2019" -> "Visual Studio Tools" ->
-  "Visual Studio 2019 Command Prompt", change to the TortoiseSVN source
-  directory and run
+  open "Visual Studio 2022" -> "x86 Native Tools Command Prompt for VS 2022",
+  change to the TortoiseSVN source directory and run
@@ -151,4 +150,3 @@ https://docs.microsoft.com/en-us/windows/win32/app
-  Now, build the x64 packages: Open
-  "Microsoft Visual Studio 2019" -> "Visual Studio Tools" ->
-  "Visual Studio 2019 x64 Cross Tools Command Prompt", change to the
-  TortoiseSVN source directory and run
+  Now, build the x64 packages: Open "Visual Studio 2022" ->
+  "x86_x64 Cross Tools Command Prompt for VS 2022", change to the TortoiseSVN
+  source directory and run
@@ -165,3 +163,2 @@ https://docs.microsoft.com/en-us/windows/win32/app
-  "Microsoft Visual Studio 2019" -> "Visual Studio Tools" ->
-  "Visual Studio 2019 Win64 Command Prompt", change to the
-  TortoiseSVN source directory and run
+  "Visual Studio 2022" -> "x64 Native Tools Command Prompt for VS 2022",
+  change to the TortoiseSVN source directory and run

Switch vc2019 to vs2022

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

The default.build.user.tmpl file is referring to vs2019. The attached patch 
updates the description and the error message to vs2022. It shouldn't have 
a functional difference.

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/81a17b56-6828-4a2a-abf3-435b977997aen%40googlegroups.com.
Index: default.build.user.tmpl
===
--- default.build.user.tmpl (revision 29388)
+++ default.build.user.tmpl (working copy)
@@ -19,9 +19,9 @@
   
   
 
-  
+  
 
-  You must first call "C:\Program Files (x86)\Microsoft Visual 
Studio\2019\Community\VC\Auxiliary\Build\vcvars32.bat"
+  You must first call "C:\Program Files (x86)\Microsoft Visual 
Studio\2022\Community\VC\Auxiliary\Build\vcvars32.bat"
 
 
 

Re: "Edit Conflicts" for Excel Files

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 8 november 2023 kl. 11:47:13 UTC+1 skrev Ömer GÜNDÜZ:

Hello,
I am searching for an effective solution to edit conflicts in Excel files. 
So, I've installed the "Spreadsheet Compare" add-ins owned by Stevetowner (
https://sourceforge.net/projects/spreadshcompare/) to my Excel. It is 
successful in visualizing the differences between two Excel files. However, 
I cannot integrate and use it for edit conflicts with TSVN. Would you 
happen to have any suggestions? Is it possible to call add-ins with TSVN 
scripts?
Thnx in advance.


Have you checked the user manual section on how to configure external diff 
/ merge tools? 

https://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-dug-settings.html#tsvn-dug-settings-progs
 

You might have to write a custom wrapper (the existing ones for merging 
Word documents should be a good starting point) to open Excel and configure 
the addin.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/2727efbc-3662-4719-b4f8-4506138f385bn%40googlegroups.com.

ignore tools.zip in tortoisesvn/trunk

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,
nant init seems to leave the tools.zip in the wc. Any particular reason why 
it is not in svn:ignore? Otherwise I'll add it there to remove at least one 
small thing from "Check for modifications".
/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/43892494-e218-4746-818e-10230aa2b44dn%40googlegroups.com.

Re: ignore tools.zip in tortoisesvn/trunk

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 30 maj 2022 kl. 21:04:58 UTC+2 skrev Stefan:

> you can of course add it to svn:ignore.
> But since it's not used after the download/unzip anymore, I usually just 
> delete it.
>

I'm lazy enough to forget about such things.

Better to have the build script delete the file?

[[[
Index: default.build
===
--- default.build(revision 29403)
+++ default.build(working copy)
@@ -545,6 +545,7 @@
   https://osdn.net/frs/redir.php?m=accf=%2Fstorage%2Fg%2Ft%2Fto%2Ftortoisesvn%2Fbuild+tools%2FTools-1.8.0.zip;
 
dest="tools.zip" />
   
   
+  
 
   
]]]

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/2a55a9e8-14fe-440f-a855-14cd46b01500n%40googlegroups.com.

[PATCH] Website, Status page, Upcoming point to 1.15

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

Small change on the website. The status page currently say that 1.14.0 is 
the next release, to appear shortly after Subversion 1.14.0.

I'm suggesting to replace this, and the reference to 1.13.x in the next 
paragraph, with 1.15.0 and 1.14.x respectively.

Patch attached, unless you want to author something else.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/23368a87-9340-4268-a959-cfa8579f3acfn%40googlegroups.com.

[PATCH] URL copied via "Copy URL to clipboard" results in error when pasted into Merge dialog

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I have investigated the issue mentioned in the users group in the thread 
with the same subject as above [1]. I'm providing an analysis and a few 
different patches (choose 1 of those).

The root cause is that CopyUrlsCommand add \n at the end of the copied 
paths. It has the capability to copy multiple paths and URLs so I believe 
this is a good thing for consistency. However it could be modified [2] to 
only emit the \n if more than 1 path is being copied. I believe this is the 
least sensible path, both since it changes external behaviour.

Another solution could be to adjust the consumer of the URL, in 
MergeCommand.cpp, to remove any trailing newline from the URL. See [3].

However I realised that this behaviour only exists on "Merge a range of 
revisions". If doing a "Merge two different trees", the trailing newline is 
filtered already in the dialog. On inspection MergeWizardRevRange.cpp does 
m_urlCombo.GetWindowText(sUrl) while MergeWizardTree.cpp does 
m_urlCombo.GetString(). (MergeWizardTree.cpp actually does both, with 
GetWindowText() to check if the text is a URL). I've made a patch [4] to 
have MergeWizardRevRange.cpp use GetString() just like MergeWizardTree.cpp. 
It is actually reversing part of the changes in r24686 since previously. 
This is the patch I personally prefer, it seems cleaner to remove the \n on 
the source, it also aligns with hor "Merge two different trees" behave.

Kind regards,
Daniel



[1] https://groups.google.com/g/tortoisesvn/c/PHloNjOHids
[2] Attachment CopyUrlsCommand_DontSetLFOnSinglePath.txt
[3] Attachment MergeCommand_RemoveTrailingNewlineFromUrl.txt
[4] Attachment MergeWizardRevRange_GetUrlByGetString.txt

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/2310c036-5e36-484b-84d1-4217b844a3fdn%40googlegroups.com.
--- 
C:/Users/danie/AppData/Local/Temp/MergeWizardRevRange.cpp-revBASE.svn001.tmp.cpp
fre apr 30 18:29:07 2021
+++ C:/Devel/tortoisesvn/src/TortoiseProc/MergeWizardRevRange.cpp   tor maj 
26 22:21:18 2022
@@ -126,0 +127 @@ LRESULT CMergeWizardRevRange::OnWizardNext()
+sUrl = m_urlCombo.GetString();
--- C:/Users/danie/AppData/Local/Temp/MergeCommand.cpp-revBASE.svn001.tmp.cpp   
fre apr 30 18:29:07 2021
+++ C:/Devel/tortoisesvn/src/TortoiseProc/Commands/MergeCommand.cpp tor maj 
26 22:10:50 2022
@@ -65,0 +66,4 @@ bool MergeCommand::Execute()
+// URL copied from the right-click context menu ends in \n. Remove it 
to avoid
+// errors accessing the repo with a URL ending in %0A.
+if (wizard.m_url1.Right(1) == '\n')
+wizard.m_url1 = wizard.m_url1.Left(wizard.m_url1.GetLength() - 1);
--- C:/Users/danie/AppData/Local/Temp/CopyUrlsCommand.h-revBASE.svn001.tmp.h
fre apr 30 18:35:34 2021
+++ C:/Devel/tortoisesvn/src/TortoiseProc/Commands/CopyUrlsCommand.htor maj 
26 22:08:54 2022
@@ -38 +38,2 @@ class CopyUrlsCommand : public Command
-for (int i = 0; i < pathList.GetCount(); ++i)
+const auto count = pathList.GetCount();
+for (int i = 0; i < count; ++i)
@@ -41 +42,2 @@ class CopyUrlsCommand : public Command
-sUrls += L"\n";
+if (count > 1)
+sUrls += L"\n";

Re: All TortoiseSVN 1.10+ builds inadvertently compile with APR_HAVE_IPV6 = 1?

[Daniel Sahlberg via TortoiseSVN-dev]

The ipv6 build option was removed in r29394.

Would it also make sense to remove the ipv6 scripts in contrib\choco? I've 
searched the source and I can't find them being used anywhere anymore.
tisdag 17 maj 2022 kl. 20:09:36 UTC+2 skrev Evgeny Kotkov:

> Hi,
>
> I see that all TortoiseSVN 1.10 and later builds (both regular and "-ipv6")
> have been compiled with APR_HAVE_IPV6 = 1.
>
> This happened because APR 1.6 changed the default value for APR_HAVE_IPV6
> from 0 to 1, so apr.build tries to replace the string that no longer 
> exists:
>
> to="#define APR_HAVE_IPV6   1"
>if="${ipv6 == 'enabled'}" />
>
> To confirm this, the most recent *non-ipv6* build says "ipv6 enabled" in 
> About:
>
> https://osdn.net/projects/tortoisesvn/storage/1.14.3/Application/TortoiseSVN-1.14.3.29387-x64-svn-1.14.2.msi
> [image: image.png]
>
> Maybe the script could be updated to disable IPv6 as originally intended.
>
> Or maybe there is no real problem in enabling IPv6, because the change
> happened 5 years ago in TSVN 1.10.0, and apparently it hasn't been causing
> issues for the users. If so, it might make sense to keep IPv6 enabled in 
> the
> mainstream builds and remove the non-ipv6/ipv6 distinction.
>
> Anyway, reporting this discrepancy just in case…
>
>
> Thanks,
> Evgeny Kotkov
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/bf0a6fd9-6608-47df-9fa0-0da194933115n%40googlegroups.com.

Re: Tortoise merge extended ascii support

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 24 maj 2022 kl. 07:30:13 UTC+2 skrev enricop...@gmail.com:

> as topic. thanks a lot


I'm sorry but it is not clear to me what you are suggesting. Can you 
elaborate please? 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/70f73fd9-7fa1-4a66-b41d-7008091a82a0n%40googlegroups.com.

Re: [PATCH] URL copied via "Copy URL to clipboard" results in error when pasted into Merge dialog

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 28 maj 2022 kl. 19:18:22 UTC+2 skrev Stefan:

> On Saturday, May 28, 2022 at 4:18:44 PM UTC+2 daniel.l...@gmail.com wrote:
>
>> lördag 28 maj 2022 kl. 10:24:21 UTC+2 skrev Stefan:
>>
>>> thanks for all your patches!
>>> I went with option 4, I agree that's the best solution.
>>>
>>
>> (y), LGTM.
>>
>> I realise you reworked the patch a bit and removed GetWindowText 
>> altogether (I thought about it but figured there was probably a reason it 
>> was used). For the matter of consistency, should the same be applied to 
>> MergeWizardTree? Something along the lines of [1]?
>>
>
> now that you mention it: yes there was (and is) a reason for using 
> GetWindowText: GetString can return an empty string sometimes (e.g. when 
> using up/down to select from the history without hitting return). Not 
> always, but sometimes.
>

Oh.  Sometimes is never nice.

So I'm going to change this back to using GetWindowText again and then trim 
> the string from newlines.
>

LGTM, again.

Just one more thing .  In MergeWizardTree.cpp, you first check the URL 
using GetWindowText but when setting the m_urlFrom and m_urlTo you still 
get the URL using GetString(). So I would re-order things as in patch [1]. 

TortoiseMerge seems to look at Software\TortoiseMerge\ContextLines (from 
>> the settings dialog), which I havn't set, and thus gets a default value of 
>> 0 from src/TortoiseMerge/MainFrm.cpp line 2950. I'm attaching a proposed 
>> patch [2] to change this to three, which seems a better default. There were 
>> a few additional places in the code looking at the above reg key, but with 
>> a default value of 1 that I didn't change. I'm not sure if it makes sense 
>> to have different default values for the same registry key. The attached 
>> patch [3] should change the default setting in the Settings dialog to 3 as 
>> well. 
>>
>
> Thanks!
> I've applied your patches.
>

LGTM.

I will have a second look at TortoiseProc (as mentioned in the previous 
message) to see if I can make it emit a path base in to WC root instead of 
just the file name. I guess it might be difficult to do with TortoiseMerge 
since it basically compares two different files on the computer. It could, 
possibly, emit a path based in the WC root if either file is in a WC (in 
the patches in the first message, C:/Devel/tortoisesvn is a WC), but it 
will be impossible to do with the file from %TEMP%.
 

> If you would register at osdn.net I can give you commit access so you can 
> commit your fixes yourself :)
>

Login: danielsahlberg

Appreciate your confidence :-)
 
Kind regards,
Daniel

[1] MergeWizardTree_DontUseGetString.txt
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/7d17d20f-ea96-411a-a5c3-4c51a6bf986fn%40googlegroups.com.
Index: MergeWizardTree.cpp
===
--- MergeWizardTree.cpp (revision 29401)
+++ MergeWizardTree.cpp (working copy)
@@ -202,6 +202,7 @@
 }
 
 CString sUrl;
+
 m_urlCombo.GetWindowText(sUrl);
 auto newlinePos = sUrl.FindOneOf(L"\r\n");
 if (newlinePos >= 0)
@@ -212,6 +213,10 @@
 ShowComboBalloon(_urlCombo, IDS_ERR_MUSTBEURL, IDS_ERR_ERROR, 
TTI_ERROR);
 return FALSE;
 }
+
+m_urlCombo.SaveHistory();
+m_urlFrom = sUrl;
+
 m_urlCombo2.GetWindowText(sUrl);
 newlinePos = sUrl.FindOneOf(L"\r\n");
 if (newlinePos >= 0)
@@ -223,11 +228,8 @@
 return FALSE;
 }
 
-m_urlCombo.SaveHistory();
-m_urlFrom = m_urlCombo.GetString();
-
 m_urlCombo2.SaveHistory();
-m_urlTo = m_urlCombo2.GetString();
+m_urlTo = sUrl;
 
 CStringsRegKeyFrom = 
L"Software\\TortoiseSVN\\History\\repoURLS\\MergeURLForFrom" + 
static_cast(GetParent())->m_wcPath.GetSVNPathString();
 CRegString regMergeUrlForWCFrom(sRegKeyFrom);

Re: [PATCH] URL copied via "Copy URL to clipboard" results in error when pasted into Merge dialog

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 28 maj 2022 kl. 10:24:21 UTC+2 skrev Stefan:

> thanks for all your patches!
> I went with option 4, I agree that's the best solution.
>

(y), LGTM.

I realise you reworked the patch a bit and removed GetWindowText altogether 
(I thought about it but figured there was probably a reason it was used). 
For the matter of consistency, should the same be applied to 
MergeWizardTree? Something along the lines of [1]?
 

> one question though: how did you create the patch files? They have 
> absolute paths 
> (e.g. C:/Users/danie/AppData/Local/Temp/MergeWizardRevRange.cpp) and no 
> context lines at all.
>

Commit dialog.  Double click changed file (=> Opens TortoiseMerge). File, 
Create patch file. Save.

The attached files in this message are created from the Commit dialog, 
selected the file(s), right click and Create patch. It contains three 
context lines. (I believe this patch is created by TortoiseProc.exe?). 
However it contains no paths at all which is a bit strange since I started 
from a commit dialog in the root of the WC [4], so the commit dialog at 
least know the relative paths within the WC. 

TortoiseMerge seems to look at Software\TortoiseMerge\ContextLines (from 
the settings dialog), which I havn't set, and thus gets a default value of 
0 from src/TortoiseMerge/MainFrm.cpp line 2950. I'm attaching a proposed 
patch [2] to change this to three, which seems a better default. There were 
a few additional places in the code looking at the above reg key, but with 
a default value of 1 that I didn't change. I'm not sure if it makes sense 
to have different default values for the same registry key. The attached 
patch [3] should change the default setting in the Settings dialog to 3 as 
well. 

/Daniel


[1] MergeWizardTree_DontUseGetWindowText.txt 
[2] TortoiseMerge_Unidiff_Default_ThreeLinesContext.txt
[3] SetMainPage_Default_ThreeLinesContext.txt
[4] commitdialog.png

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/3bb873c0-bc14-437e-a89c-41b87339392bn%40googlegroups.com.
Index: SetMainPage.cpp
===
--- SetMainPage.cpp (revision 29397)
+++ SetMainPage.cpp (working copy)
@@ -36,7 +36,7 @@
 , m_bSmartTabChar(FALSE)
 , m_nTabSize(0)
 , m_bEnableEditorConfig(FALSE)
-, m_nContextLines(0)
+, m_nContextLines(3)
 , m_bIgnoreEOL(FALSE)
 , m_bOnePane(FALSE)
 , m_bViewLinenumbers(FALSE)
@@ -63,7 +63,7 @@
 m_regAutoAdd = CRegDWORD(L"Software\\TortoiseMerge\\AutoAdd", 
TRUE);
 m_regMaxInline   = 
CRegDWORD(L"Software\\TortoiseMerge\\InlineDiffMaxLineLength", 3000);
 m_regUseRibbons  = 
CRegDWORD(L"Software\\TortoiseMerge\\UseRibbons", TRUE);
-m_regContextLines= 
CRegDWORD(L"Software\\TortoiseMerge\\ContextLines", 0);
+m_regContextLines= 
CRegDWORD(L"Software\\TortoiseMerge\\ContextLines", 3);
 
 m_bBackup  = m_regBackup;
 m_bFirstDiffOnLoad = m_regFirstDiffOnLoad;
Index: MainFrm.cpp
===
--- MainFrm.cpp (revision 29397)
+++ MainFrm.cpp (working copy)
@@ -2947,7 +2947,7 @@
 return; // user cancelled
 }
 
-CRegStdDWORD regContextLines(L"Software\\TortoiseMerge\\ContextLines", 0);
+CRegStdDWORD regContextLines(L"Software\\TortoiseMerge\\ContextLines", 3);
 CAppUtils::CreateUnifiedDiff(origFile, modifiedFile, outputFile, 
regContextLines, ignoreEOL, true);
 CAppUtils::StartUnifiedDiffViewer(outputFile, 
CPathUtils::GetFileNameFromPath(outputFile));
 }
Index: TortoiseMerge.cpp
===
--- TortoiseMerge.cpp   (revision 29397)
+++ TortoiseMerge.cpp   (working copy)
@@ -454,7 +454,7 @@
 }
 if (!outfile.IsEmpty())
 {
-CRegStdDWORD 
regContextLines(L"Software\\TortoiseMerge\\ContextLines", 0);
+CRegStdDWORD 
regContextLines(L"Software\\TortoiseMerge\\ContextLines", 3);
 CAppUtils::CreateUnifiedDiff(origFile, modifiedFile, outfile, 
regContextLines, true, false);
 return FALSE;
 }
Index: MergeWizardTree.cpp
===
--- MergeWizardTree.cpp (revision 29397)
+++ MergeWizardTree.cpp (working copy)
@@ -201,16 +201,15 @@
 return FALSE;
 }
 
-CString sUrl;
-m_urlCombo.GetWindowText(sUrl);
-CTSVNPath url(sUrl);
+auto sUrlFrom = m_urlCombo.GetString();
+CTSVNPath url(sUrlFrom);
 if (!url.IsUrl())
 {
 ShowComboBalloon(_urlCombo, IDS_ERR_MUSTBEURL, IDS_ERR_ERROR, 
TTI_ERROR);
 return 

Re: [PATCH] Website, Status page, Upcoming point to 1.15

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 28 maj 2022 kl. 10:10:11 UTC+2 skrev Stefan:

> can't find an attached patch.


Google Groups and I are not friends when it comes to attachments. Sorry.

But I just removed the whole "upcoming milestone" since it's hard to 
> predict the next releases.
>

I know. Let's hope it is not too long until 1.15 and the performance and WC 
size fixed.

There is still a reference to 1.13.x as the "stable branch", attached. 
(This time I'm sure the attachment is there..)

/Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a2a175d9-2399-49c3-b2ba-c4535f7a1ebbn%40googlegroups.com.
Index: status.html
===
--- status.html (revision 29397)
+++ status.html (working copy)
@@ -18,7 +18,7 @@
 {% include adsense_inpage.html %}
 
 What we are currently working on
-Apart from fixing bugs for the stable branch (1.13.x)
+Apart from fixing bugs for the stable branch (1.14.x)
 there are some new features and enhancements to existing
 features we are currently discussing and even already working on.
 

Re: [PATCH] URL copied via "Copy URL to clipboard" results in error when pasted into Merge dialog

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 28 maj 2022 kl. 20:45:42 UTC+2 skrev Stefan:

>
>> Just one more thing .  In MergeWizardTree.cpp, you first check the 
>> URL using GetWindowText but when setting the m_urlFrom and m_urlTo you 
>> still get the URL using GetString(). So I would re-order things as in patch 
>> [1]. 
>>
>
> nice catch!
> You can commit the patch now yourself.
>

r29402
 

> I will have a second look at TortoiseProc (as mentioned in the previous 
>> message) to see if I can make it emit a path base in to WC root instead of 
>> just the file name. I guess it might be difficult to do with TortoiseMerge 
>> since it basically compares two different files on the computer. It could, 
>> possibly, emit a path based in the WC root if either file is in a WC (in 
>> the patches in the first message, C:/Devel/tortoisesvn is a WC), but it 
>> will be impossible to do with the file from %TEMP%.
>>
>
> That would be good, yes.
> However, it is usually enough to emit the filename: when applying a patch, 
> TMerge automatically searches for a path that matches the paths/names in 
> the patchfile.
>

That's clever.

The command line 'svn diff' is basing the file names on the current working 
directory and not the WC root.

After some basic checks, it seems TortoiseProc is being fed a list of full 
paths without a notion for "working directory" and it bases the patch in 
the lowest common denominator of these paths.

Since there are already some differences and TMerge is clever enough to 
work them out I will probably ignore it (I've got other itches to scratch, 
more in a new thread).

If you would register at osdn.net I can give you commit access so you can 
>>> commit your fixes yourself :)
>>>
>>
>> Login: danielsahlberg
>>
>> Appreciate your confidence :-)
>>
>
> You now have full access.
>

Thanks!

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/50320682-9647-4c91-8d4d-4def12175432n%40googlegroups.com.

Preparing for the Multi-format-WC feature in Subversion 1.15

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I've started to look at the Multi-format-WC feature that is expected to be 
part of Subversion 1.15.

Summary for those not reading the d...@subversion.apache.org mailing list; 
Previously, each release of Subversion was tied to a specific working copy 
format number. Between some client versions (latest by the release of 
1.8.0) changes were made to the layout of the working copy (placement and 
content of the .svn folder). A particular WC could only be operated on by a 
client of the correct version, so using a 1.7 client (for example an IDE 
integrated client) and a 1.8 client (for example TortoiseSVN) on the same 
working copy would not work. There is an expectation that Subversion 1.15 
will introduce a new WC format with some additional features (most 
prominent the ability to remove the "pristine" copy of each file, basically 
dividing the space requirement for a working copy in half at the expense of 
some additional network traffic). Since there is a trade-off in the new WC 
format it is expected that not everyone want to update, and even then some 
might be locked in to old clients that *cannot* be updated. Therefor, 
Subversion 1.15 will introduce a possibility to work with multiple WC 
formats within the same client.

There is a more in-depth description in the Subversion 1.15 release notes, 
draft version at [1].

I have started to look at implementing support for this feature in 
TortoiseSVN.

1. Is there someone else looking at it as well, so we can cooperate?
2. I would propose to create a /branches/multi-format-wc based on current 
/trunk. Any opinions?

Kind regards,
Daniel

[1] https://subversion-staging.apache.org/docs/release-notes/1.15.html

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/17c8ccd7-d089-4434-b6fa-c41862a78822n%40googlegroups.com.

Nightlies build failure

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

The nightly builds are currently failing with the following message:

[exec] C:\TSVN\tortoisesvn\ext\TortoisePlink\defs.h(22,1): fatal error 
C1189: #error: Do not compile this code base with NDEBUG defined! 
[C:\TSVN\tortoisesvn\ext\TortoisePlink\windows\TPlink\TortoisePlink.vcxproj] 
[exec] TortoisePlink.c

I believe this is caused by a change to defs.h in r29425 which adds a 
change from upstream (97f7a7cb4deacbc92a9dbdc1b9394e4e1358e47a) enforcing 
that NDEBUG is not defined.

As far as I can see this code was added upstream in PuTTY 0.75 (which was 
added to TSVN in r29211), but I assume that code was manually deleted from 
defs.h before committing r29211.

I don't know enough about NDEBUG to dare touching this part of the code. I 
guess we should either remove the #error from defs.h via 
TortoisePlink.patch or change something to not compile TortoisePlink with 
NDEBUG.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/04b4abb2-15c9-46ea-b139-e16a045b5293n%40googlegroups.com.

Re: ignore tools.zip in tortoisesvn/trunk

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 31 maj 2022 kl. 17:33:46 UTC+2 skrev Stefan:

> I guess that's one solution. When I first created that script I though 
> maybe users would like to keep the file.
> But maybe it's really better to just delete it - users can always zip the 
> unzipped folder again...
>

r29405. Let's see how that works out. 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/ea0fa404-aa1b-4faf-836c-88c4807a99d0n%40googlegroups.com.

Re: Autocompletion in the CInputLogDlg

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 6 juni 2022 kl. 07:12:07 UTC+2 skrev Stefan:

> looks good to me.
> I made two small changes on your branch. If you're ok with that then 
> please merge it back to trunk.
>

+1 on the refactoring. This is what I wanted to do as well but I didn't 
really know where to place the function.

-1 on reusing GetAppDirectory() via the appDir variable. GetAppDirectory() 
!= GetAppDataDirectory(). (Otherwise no point in calling ParseSnippetFile 
twice). I have reverted this part of r29410.

L/_T. +0 (C++ is not my primary language, learning it is part of my 
motivation to contribute to TSVN) but I suppose TSVN is always compiled in 
Unicode so it doesn't matter.

+1 on const auto &.

I have changed CCommitDlg::GetAutocompletionList to include the last two 
changes as well.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/9a80f9b2-0ebd-4c4c-9065-e5b2d93b4caen%40googlegroups.com.

Autocompletion in the CInputLogDlg

[Daniel Sahlberg via TortoiseSVN-dev]

Based on the question in the users group about the name of the [deleted] 
file as a suggestion in the log message ([1]) , I have created a branch 
/branches/autocomplete_in_repobrowser_logdlg

Please check if this is reasonable / functional and if it should be merged 
to trunk. From my point of view it is feature complete but it might benefit 
from some code cleanup and possibly refactoring some of the duplicated code 
from CCommitDlg.

Kind regards,
Daniel

[1] https://groups.google.com/g/tortoisesvn/c/m1VpvqoSQTI


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/4abd3264-ea49-4c49-b03e-e9067720837an%40googlegroups.com.

Re: libxml2 python bindings

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 16 juni 2022 kl. 11:28:16 UTC+2 skrev Bruce C:

> I too recently tried to create the build environment for TortoiseSVN. I 
> had some teething problems that I've not yet reported but I've been 
> interested to see that you've apparently not had those issues.
>
> With respect to the libxml2 library, it seems to me that there are two 
> issues. The first is trying to get a copy of the library that's currently 
> being used. The second, as you've been discussing, is a replacement for the 
> library that is now difficult to obtain. I have nothing to contribute to 
> the latter.
>

I think we should start by dropping Python2 support, hoping that the 
library is more readily available for Python3.

For comparison, the policy of the Subversion project is to support Python2 
for the remainder of 1.14 "unless an unreasonable burden". That policy 
mainly applies to using Subversion but I think there was some work also on 
the build system to support old platforms where Python3 might not be 
available.

In our case, we have good support for Python3 on our build platform (we 
already require Visual Studio 2022 and Windows 10, so no-one should be 
building on old Windows versions where Python 3 isn't available) so it 
should not cause trouble for anyone.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/ae833294-21d3-4e66-bdbb-125e1a282052n%40googlegroups.com.

Re: libxml2 python bindings

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 15 juni 2022 kl. 18:01:14 UTC+2 skrev Stefan:

> On Tuesday, June 14, 2022 at 11:14:13 PM UTC+2 daniel.l...@gmail.com 
> wrote:
>
>> tisdag 14 juni 2022 kl. 20:48:00 UTC+2 skrev Stefan:
>>
>>> I know the problem :(
>>> That's why I thought of discontinuing the translated docs and only use 
>>> docs in English.
>>>
>>
>> Now that you mention. Did you get any feedback on this question 
>> out-of-band (I was the only one to respond on the group)? Did you come to a 
>> decision on this?
>>
>
> not really. You were as you've noticed the only one to respond.
> I've decided to keep them for now, but if we can't get it to work with 
> python3 then I'll drop the doc translations for the next svn/tsvn release.
>

Sounds good.

I /think/ I have manage to do a naive conversion of the scripts to the 
point where they at least run under Linux. I've also tried it under Python2 
on Windows to make sure it is backwards compatible. Please check!

My next problem is to find a libxml2 distribution. Even on Python3, it 
seems hard to get working. I think it should be possible using the Anaconda 
Python distribution (at least I get all the DLL files) but I can't get it 
to run, and I have to call it a night now.

The story will continue.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/1d3f0054-74e9-47aa-917f-62a356279317n%40googlegroups.com.

libxml2 python bindings

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

The download site for libxml2 python bindings (http://users.skynet.be, see 
build.txt and doc/readme.txt) seems to be discontinued, reference [1]. 

I have tried to find another distribution but only found another site that 
is due to be discontinued [2].

Any ideas on how to proceed from here? I guess moving to Python3 would be a 
good step and there has been some commits (r29299) however xml2po still 
seems to require Python2 (the original script is "obsolete" according to 
[3] but there seems to be a Py3 version, however our script is heavily 
modified). Any other scripts that are not Py3 compatible?

/Daniel

[1] 
https://nl.forum.proximus.be/internet-10/users-skynet-be-xxx-werkt-niet-meer-sinds-3juni-53672?postid=683135#post683135
[2] https://www.lfd.uci.edu/~gohlke/pythonlibs/
[3] https://gitlab.gnome.org/Infrastructure/damned-lies/-/issues/228

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/fec5d713-e351-4a78-add3-d3985cb35872n%40googlegroups.com.

Re: libxml2 python bindings

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 14 juni 2022 kl. 20:48:00 UTC+2 skrev Stefan:

> I know the problem :(
> That's why I thought of discontinuing the translated docs and only use 
> docs in English.
>

Now that you mention. Did you get any feedback on this question out-of-band 
(I was the only one to respond on the group)? Did you come to a decision on 
this?

As you've noticed I've already tried switching to python3, but I don't know 
> python so I couldn't get the py3 version of xml2po to work.
> If you know python well enough, you could give it a try though.
>

I can see what I can do, but it won't go to the top of the list.

Or: the [3] link mentions itstool ( https://itstool.org/ ). I haven't tried 
> this yet. Not sure if that tool would work with our docs - the output 
> should not be different that what the xml2po script does now, or we would 
> lose a lot of translations - and then we can just drop them and only use 
> English docs...
>

I will also investigate this route.

there are one or two other python scripts in the TSVN source tree, but 
> they're not really in use anymore (TranslationStatus.py was used to 
> generate a report that was sent to the mailing list, and chkidd.py was used 
> to check whether a TSVN dialog has a corresponding doc entry)
>

Just for the fun of it, I tried to convert TranslationStatus.py, see 
r29419. chkidd.py you did yourself in 29299 (I didn't test it, just saw the 
log entry).

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d271e623-79b9-4ec7-9815-c0dea5084fffn%40googlegroups.com.

Re: Autocompletion in the CInputLogDlg

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 7 juni 2022 kl. 17:34:23 UTC+2 skrev Stefan:

> +1
> please merge
>

I added a Changelog entry to the branch (r29413).

Then merged everything to trunk (r29414) excluding the BRANCH-README.

What is the policy for deleting feature branches? I can see that the shelve 
and tortoisemerge-native-ribbon branches were handled differently, where 
the first one still exists (although it was completely merged to trunk) and 
the second one deleted. Personally I believe there is little use in keeping 
the feature branches after merge to trunk, it is always possible to go back 
in time to check the logs if needed.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/47ff1835-0b99-4082-8725-fc95e1041709n%40googlegroups.com.

Nightly builds down

[Daniel Sahlberg via TortoiseSVN-dev]

Seems to be out of disk space:

[...]
  [exec]   Translator.cpp
  [exec]   utils.cpp
  [exec]   Generating code
  [exec]   Previous IPDB not found, fall back to full compilation.
  [exec]   All 5552 functions were compiled because no usable IPDB/IOBJ 
from previous compilation was found.
  [exec]   Finished generating code
  [exec] LINK : fatal error LNK1201: error writing to program database 
'C:\TSVN\tortoisesvn\ext\crashserver\CrashHandler\out\x64\Release\sendrpt.pdb'; 
*check for insufficient disk space, invalid path, or insufficient privilege* 
[C:\TSVN\tortoisesvn\ext\crashserver\CrashHandler\SendRpt\SendRpt.vcxproj]
   
BUILD FAILED
   
C:\TSVN\tortoisesvn\ext\build\crashserver.build(18,6):
External Program Failed: msbuild.exe (return code was 1)
   
Total time: 93.9 seconds.


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/397108fb-cad8-4173-8406-7f5c7b7d5f59n%40googlegroups.com.

Listing at openhub.net

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I stumbled upon openhub.net when checking the donation web page 
(https://tortoisesvn.net/donate.html)

There is a link "...you can look at some _statistics_ ..." pointing at 
https://www.openhub.net/p/tortoisesvn/contributors

That page complain about "no recognizable code" which led me to look the 
"code locations" where the svn repo is listed as failed and the github repo 
is "waiting in queue".

While looking at the project, I saw that most links are 404. It seems to be 
enough to add .html to the links (ie change https://tortoisesvn.net/faq 
to https://tortoisesvn.net/faq.html).

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/e0efd709-5992-4358-b583-c074c23a594en%40googlegroups.com.

Re: tsvn r29449

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 20 september 2022 kl. 16:46:27 UTC+2 skrev Stefan:

> I don't see anything removed in the diff:


You are right of course. My e-mail client removed the leading spaces in the 
diff which lead me to see the "-" in the bullet points as the removal of 
lines and not part of the context. My bad, sorry!

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/08aa12b2-a3e8-4471-8750-cde157ce2aefn%40googlegroups.com.

Re: my notes to TortoiseSVN 1.14.3, Build 29387 @ windows 11 insider

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 1 september 2022 kl. 11:19:20 UTC+2 skrev Ot(ik):

> Hi guys long time no talk, 
>
> I just did some more extensive work in TortoiseSVN and found this things:
>
> 1. link to translation status on https://tortoisesvn.net/translation.html 
> pointing to Translation status page (
> https://www.transifex.com/projects/p/tortoisesvn) seems to be 
> broken/outdated it should be update to 
> https://explore.transifex.com/luebbe/tortoisesvn/
>

Thanks for reporting this. I've committed a change to the website code, but 
as far as I understand there is some manual process that has to be done by 
someone to actually update the website.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/cf18306f-cfd6-435f-b907-ab986c945e73n%40googlegroups.com.

tsvn r29449

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

In the recent commit r29449 there were some items removed from 
Changelog.txt.

Was this intentional or accidental?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/46233e16-6b93-40f5-9e4b-b0e46329580bn%40googlegroups.com.

tsvn r29468

[Daniel Sahlberg via TortoiseSVN-dev]

Meta question: I'm getting notified by the mail from osdn.net about 
commits. Is this the best way to provide feedback on commits? It isn't 
clear to me if I can reply to the mail and have it distributed to all 
committers.

[[[
Modified: trunk/src/TortoiseShell/ContextMenu.cpp
===
--- trunk/src/TortoiseShell/ContextMenu.cpp 2022-09-26 17:17:51 UTC 
(rev 29467)
+++ trunk/src/TortoiseShell/ContextMenu.cpp 2022-10-04 18:00:51 UTC 
(rev 29468)

]]] ... [[[
@@ -1222,9 +1222,9 @@
 }
 }

-//add sub menu to main context menu
-//don't use InsertMenu because this will lead to multiple menu entries 
in the explorer file menu.
-//see http://support.microsoft.com/default.aspx?scid=kb;en-us;214477 for 
details of that.
+// add sub menu to main context menu
+// don't use InsertMenu because this will lead to multiple menu 
entries in the explorer file menu.
+// see http://support.microsoft.com/default.aspx?scid=kb;en-us;214477 for 
details of that.
 MAKESTRING(IDS_MENUSUBMENU);
 if (!g_shellCache.HasShellMenuAccelerators())
 {
]]]

I got curious and checked the link, but Microsoft seems to be deprecating 
old KB articles and I can't find the article on microsoft.com. 

Archive.org seems to have it: 
http://web.archive.org/web/20090728090357/http://support.microsoft.com:80/kb/214477

Does it seem reasonable to update these kind of links to archive.org (or 
does someone else know where to find it on microsoft.com)? I can do it, 
time permitting...

Kind regards,
Daniel


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/809bd0a2-60d9-4a0d-a893-e0814fd2d1b5n%40googlegroups.com.

Re: Assistance migrating our portable *ampp stack to tortoise

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 9 augusti 2022 kl. 16:49:39 UTC+2 skrev tr...@hallhome.us:

> Hello.  I apologize if this is the wrong place to ask this question.
> We've taken over an abandoned variant of wamp that is totally portable.
> We're having issues with svn and websvn not working fully and not at all 
> with php 8.
> Seems to be a long standing issue with them.
> I'd like to move svn & websvn over to tortoisesvn but we would need a lot 
> of help making that happen.
> http://github/Bearsampp is our organization page.
> Needless to say we're fully FOSS and will remain that way forever.
>
> Is there anyone on the team that would be willing to help us get our feet 
> under us in the migration?
>

Hi,

I'm not sure I understand what you are trying to accomplish.

Websvn seems to be a web based frontend for accessing Subversion. 
TortoiseSVN is a Windows based software.

I saw that Websvn is using the svn command line client to access the 
repository. TortoiseSVN does compile and include this in the MSI 
installation file, but I'm not sure if you were just looking for a new 
command line executable or if you want to replace Websvn completely.

If you want to replace websvn with another web viewer of an SVN repository, 
I'd suggest to look at https://viewvc.org/. It is written by C. Michael 
Pilato of Subversion fame.

(There are also project management applications, Redmine and Trac comes to 
mind, but these may be overkill depending on what you are looking for).

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a8242466-8db1-44d3-af5f-f4093d3f9070n%40googlegroups.com.

TortoiseSVN Book link on https://tortoisesvn.net/support.html

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I was looking at the TortoiseSVN book and found out that the link sort of 
broken. It still works, but it is not possible to access the book at the 
packtpub.com website (even when creating an account, the book is not 
available and packtpub support says "it was pulled for unknown reasons").

It seems to be available through a few other distributors, for example 
https://www.scribd.com/book/253046905/TortoiseSVN-1-7-Beginner-s-Guide

Would it make sense to replace the link (and is there another preferred 
vendor)? (In such case also the /beginnersguide.html should be updated, I 
didn't check if there are even more ).

Kind regards,
/Daniel


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/6361387d-faf2-4d78-b7cc-0a34c8b6ffaan%40googlegroups.com.

GetHEADRevision with illegal URL

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

Once again double checking my assumptions regarding the code. In the user 
group there [1] is a discussion where I believe the error is caused by 
GetHEADRevision returning a revision even when the URL is invalid.

The following patch is using svn_ra_stat to check if the path exists and it 
seems to do what it is supposed to do.

[[[
--- C:/Users/danie/AppData/Local/Temp/SVN.cpp-revBASE.svn005.tmp.cpptis 
jun  7 17:38:11 2022
+++ C:/Devel/tortoisesvn_trunk/src/SVN/SVN.cppsön dec 11 17:34:23 2022
@@ -2733,0 +2734,13 @@ svn_revnum_t SVN::GetHEADRevision(const CTSVNPath&
+
+/* Check if path actually exist */
+svn_dirent_t *dirent;
+SVNTRACE(
+svn_ra_stat(raSession, "", rev, , localPool),
+urla);
+if (dirent == nullptr)
+{
+CString 
message(MAKEINTRESOURCE(IDS_SVN_URL_NONEXISTENT_IN_REV));
+m_err = svn_error_createf(SVN_ERR_RA_ILLEGAL_URL, NULL, 
CUnicodeUtils::GetUTF8(message).GetString(), urla, rev);
+return -1;
+}
+
]]]

Will this break any other assumptions, where GetHEADRevision is assumed to 
return HEAD for an arbitrary path within the repository? I checked quickly 
in RepoBrowser but that seemed to work fine.

Kind regards,
Daniel

[1] https://groups.google.com/g/tortoisesvn/c/5juHVu4tioQ

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/e907d55a-3521-41d2-b996-30cbbbdf2995n%40googlegroups.com.

Re: GetHEADRevision with illegal URL

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks, r29499.

onsdag 14 december 2022 kl. 17:38:41 UTC+1 skrev Stefan:

> I think this should be ok. Please commit.
>
> Stefan
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/2a3509e0-ea82-4d6e-b3c8-d9a2bb91489an%40googlegroups.com.

Re: needed manual refresh after moving beween monit with different monitor

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 19 december 2022 kl. 11:38:17 UTC+1 skrev Ot(ik):

> I have reported this some time ago. I suspect after WM_DPICHANGED T-Merge 
> should drop line cache.
> I§ve tried to do local build and fix it, but I was not successful in 
> setting enviroment - I plan to try later.
>

Anything in particular causing trouble for you with the build environment? 
For me it was slightly confusing at first, you need to follow the steps in 
build.txt very carefully and do the build on the command line (for ALL 
configurations you plan to run in Visual Studio!) before you can open the 
Visual Studio solution.

> Trying last nightly build was not possible as there no actual build 
available.

@Stefan: The addition of WinMain in plink.c? It already exists in 
TortoisePlink.c - or maybe this file should have been deleted?

/Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/94e58092-e6d8-410c-837b-31c93a4c68c3n%40googlegroups.com.

Re: needed manual refresh after moving beween monit with different monitor

[Daniel Sahlberg via TortoiseSVN-dev]

@Ot(ik): Stefan made a fix yesterday and the nightly builds seems to be 
back. Can you check again? 

/Daniel

måndag 19 december 2022 kl. 11:55:33 UTC+1 skrev Daniel Sahlberg:

> måndag 19 december 2022 kl. 11:38:17 UTC+1 skrev Ot(ik):
>
>> I have reported this some time ago. I suspect after WM_DPICHANGED 
>> T-Merge should drop line cache.
>> I§ve tried to do local build and fix it, but I was not successful in 
>> setting enviroment - I plan to try later.
>>
>
> Anything in particular causing trouble for you with the build environment? 
> For me it was slightly confusing at first, you need to follow the steps in 
> build.txt very carefully and do the build on the command line (for ALL 
> configurations you plan to run in Visual Studio!) before you can open the 
> Visual Studio solution.
>
> > Trying last nightly build was not possible as there no actual build 
> available.
>
> @Stefan: The addition of WinMain in plink.c? It already exists in 
> TortoisePlink.c - or maybe this file should have been deleted?
>
> /Daniel
>  
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/fcdf0014-2317-4be8-bc48-4c4990cb10b7n%40googlegroups.com.

Project monitor, not updating the "failed" overlay even when the fail disappear

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I've been observing that Project monitor display a "failed" overlay in the 
tree after intermittent failures, even when the failure has disappeared. 
This has also been discussed in the groups previously, for example [1]. 
I've been trying to reproduce this and I believe I've found the root cause.

High level description:
- Setup monitoring a project.
- On checking the projects (timer or Check now), there is an error. For 
example due to missing network connectivity. The project is now marked as 
failed and error is stored in MonitoringData.ini.
- Later network connectivity is restored. The check will succeed, however 
this is not stored in MonitoringData.ini. Thus, the project still has the 
"failed" overlay and you have to manually clear errors and check again.

An easy way to reproduce this is to enter a fake entry in the 
%systemroot%\System32\drivers\etc\hosts overriding DNS lookup for the 
Subversion server and then remove the same entry again for the second 
update.

I would prefer that intermittent failures clear themselves.

As far as I understand, monitoring is performed by a separate thread. This 
is using a separate vector of items to check. After check is completed, the 
data is copied back to the main list in OnMonitorThreadFinished().

The current implementation is to only update the main list if the lastHead 
has changed or if the item *currently* has an error message. Ie: If there 
previously was an error message but it has now disappeared, the update will 
not happen (unless there was a new revision). I would propose to change 
this to lastHead has changed or the error message has changed, as follows:

[[[
--- C:/Users/danie/AppData/Local/Temp/LogDlg.cpp-revBASE.svn001.tmp.cpp   
 lör dec  3 17:51:45 2022
+++ C:/Devel/tortoisesvn_trunk/src/TortoiseProc/LogDialog/LogDlg.cpplör 
dec  3 20:09:59 2022
@@ -9436 +9440 @@ void CLogDlg::OnMonitorThreadFinished()
-if ((pItem->lastHead != item.lastHead) || 
(!item.lastErrorMsg.IsEmpty()))
+if ((pItem->lastHead != item.lastHead) || 
(pItem->lastErrorMsg.IsEmpty() != item.lastErrorMsg.IsEmpty()))
]]]

I believe the same root cause is also relevant in another thread [2] 
claiming that url changes doens't always work - but MonitoringData snippet 
it seems the error message is not related to the current URL.

Kind regards,
Daniel

[1] https://groups.google.com/g/tortoisesvn/c/fvLiiJl4-iI/m/9ZCXFwutAQAJ
[2] https://groups.google.com/g/tortoisesvn/c/5juHVu4tioQ/m/3YUVFfJ9AgAJ

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/1e428447-901d-4d48-9d5e-916a7b05f830n%40googlegroups.com.

Re: Project Monitor, assert if logcache disabled and monitoring an unaccessible url

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 1 december 2022 kl. 19:19:47 UTC+1 skrev Stefan:

>
>> I don't fully understand how the logcache works, but it seems the cache 
>> variable is not initialized with log caching turned off (which sounds 
>> reasonable!), however there should be no calls to the logcache objects. Or 
>> they should handle a NULL cache properly.
>>
>>
> The log cache is always used, even if disabled. But if disabled, the data 
> in the cache is not saved to disk or loaded from it. Then the 'cache' just 
> holds all the log info in memory.
>
> the assertion is fixed in r29488
>

Thanks both for the fix and the explaination. Seems to work now =) 

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/42fd045f-cca1-44ac-84a0-4129b4132ab5n%40googlegroups.com.

Re: Project monitor, not updating the "failed" overlay even when the fail disappear

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 5 december 2022 kl. 18:49:13 UTC+1 skrev Stefan:

> On Sunday, December 4, 2022 at 11:23:50 AM UTC+1 daniel.l...@gmail.com 
> wrote:
>
>> lördag 3 december 2022 kl. 20:38:35 UTC+1 skrev Daniel Sahlberg:
>> [...]
>>
>>> +if ((pItem->lastHead != item.lastHead) || 
>>> (pItem->lastErrorMsg.IsEmpty() != item.lastErrorMsg.IsEmpty()))
>>>
>>
>> On second thoughts, this is probably not the best solution. If there was 
>> an old error message and another error occurs, it will not be updated. Thus 
>> it should probably be
>> [[[
>> +if ((pItem->lastHead != item.lastHead) || 
>> (pItem->lastErrorMsg != item.lastErrorMsg))
>> ]]]
>>
>
> this looks very good! Please commit.
>

Thanks. I was mostly worried there was a design decision not to remove the 
error status. Committed as r29490.
 

> It seems I can retire now :)
>

Please don't!  I'm sure you've forgotten more about Subversion than I will 
ever learn. :-)

Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a4d6b5bc-8cb5-4adb-b829-86bfba147d3bn%40googlegroups.com.

Re: Project monitor, not updating the "failed" overlay even when the fail disappear

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 3 december 2022 kl. 20:38:35 UTC+1 skrev Daniel Sahlberg:
[...]

> +if ((pItem->lastHead != item.lastHead) || 
> (pItem->lastErrorMsg.IsEmpty() != item.lastErrorMsg.IsEmpty()))
>

On second thoughts, this is probably not the best solution. If there was an 
old error message and another error occurs, it will not be updated. Thus it 
should probably be
[[[
+if ((pItem->lastHead != item.lastHead) || 
(pItem->lastErrorMsg != item.lastErrorMsg))
]]]

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/8bb648fc-86da-4c94-b48f-153d2afb83b3n%40googlegroups.com.

CLogDlg::MonitorEditProject remove \r and \n from encrypted username/password

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

While investigating another issue in the Project Monitor, I saw the 
following code in MonitorEditProject:

[[[
pEditProject->username = CStringUtils::Encrypt(dlg.m_sUsername);
pEditProject->password = CStringUtils::Encrypt(dlg.m_sPassword);
pEditProject->username.Remove('\r');
pEditProject->password.Remove('\r');
pEditProject->username.Replace('\n', ' ');
pEditProject->password.Replace('\n', ' ');
]]]

Is there a guarantee that CryptBinaryToStringW (called by Encrypt) cannot 
return \r or \n in the encrypted (and formatted) data?

The code was added in r25576. In r25909, the flag CRYPT_STRING_NOCRLF was 
added in the call to CryptBinaryToStringW.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/7c0a7ba6-57a2-4021-bc60-c1340a370f0dn%40googlegroups.com.

Re: TortoiseMerge, paste multiline + undo doesn't restore line numbers correctly

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks. Committed r29487.
/Daniel

tisdag 29 november 2022 kl. 17:14:56 UTC+1 skrev Stefan:

> this patch looks fine. 
> I prefer this solution, because adding another SaveUndoStep() would cause 
> quite a few other problems.
>
> Stefan
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/ee223d55-8a21-408c-957c-f2e912b81efdn%40googlegroups.com.

Project Monitor, assert if logcache disabled and monitoring an unaccessible url

[Daniel Sahlberg via TortoiseSVN-dev]

  Hi,

I'm getting an assert in CCacheLogQuery::GetCache(). I believe it is 
reproducible:

- Disable log caching in the TortoiseSVN settings
- Setup two projects to monitor, one functional 
(eg https://svn.osdn.net/svnroot/tortoisesvn/) and one where you don't have 
access (I'm using https://svn.apache.org/repos/private/pmc/)
- Start Project Monitor
- Click on the functional project, then on the non-functional project, then 
on the functional project again. The assert in GetCache() triggers.

I don't fully understand how the logcache works, but it seems the cache 
variable is not initialized with log caching turned off (which sounds 
reasonable!), however there should be no calls to the logcache objects. Or 
they should handle a NULL cache properly.

Anyone?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/21fe6318-278f-4d33-a8c8-e348df872dacn%40googlegroups.com.

TortoiseMerge, paste multiline + undo doesn't restore line numbers correctly

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

In TortoiseMerge:
- Look at a diff of a changed file, for example from double click in the 
commit dialog.
- Paste a few lines (it doesn't have to be related to the changed lines, in 
the attached image I pasted a few lines in the beginning of the file). 
*TortoiseMerge 
correctly renumbers all lines.*
- Undo (Ctrl-Z). *TortoiseMerge removes the pasted lines but doesn't 
renumber the following lines.* See attached picture with lines 1 5 6 7 etc.

If I understand the code correctly, the line numbering is stored in the 
undo list so I propose to move the call to UpdateViewLineNumbers() above 
SaveUndoStep(), as follows.

[[[
Index: BaseView.cpp
===
--- BaseView.cpp(revision 29481)
+++ BaseView.cpp(working copy)
@@ -6765,9 +6765,9 @@
 {
 m_pwndBottom->InsertViewEmptyLines(nViewLine + 1, 
nLinesToPaste - 1);
 }
+UpdateViewLineNumbers();
 SaveUndoStep();
 
-UpdateViewLineNumbers();
 CUndo::GetInstance().EndGrouping();
 
 ptCaretViewPos = SetupPoint(lines[nLinesToPaste - 
1LL].GetLength(), nInsertLine);
]]]

Another solution would be to add another SaveUndoStep() after 
UpdateViewLineNumbers().

Is this analysis correct or do I miss something? Which version is preferred?

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/dc65329b-f756-4eaf-8fec-0ebda5ea2118n%40googlegroups.com.

Re: Abridged summary of tortoisesvn-dev@googlegroups.com - 2 updates in 2 topics

[Daniel Sahlberg via TortoiseSVN-dev]

Let's stick to the original topic, please.

fredag 2 december 2022 kl. 01:40:34 UTC+1 skrev shawn_...@cox.net:

> What would be the first steps to check?
>
> Thanks,
> Shawn
>  
> --
> *From:* TortoiseSVN-dev 
> *Sent:* Thursday, December 1, 2022 7:36 PM
> *To:* Abridged recipients 
> *Subject:* Abridged summary of tortois...@googlegroups.com - 2 updates in 
> 2 topics
>  
> tortois...@googlegroups.com Google Groups 
> 
>  
> 
>  
> Today's topic summary 
> View all topics 
>
>- Project Monitor, assert if logcache disabled and monitoring an 
>unaccessible url <#m_-7600060390020144987_group_thread_0> - 1 Update 
>- svn commit issue <#m_-7600060390020144987_group_thread_1> - 1 Update 
>
> Project Monitor, assert if logcache disabled and monitoring an 
> unaccessible url 
> 
>  
> Stefan: Dec 01 10:19AM -0800 
>
> > variable is not initialized with log caching turned off (which sounds 
> > reasonable!), however there should be no calls to the logcache objects 
> Or 
> > they should handle a NULL cache properly.
> ...more 
> 
>  
> Back to top <#m_-7600060390020144987_digest_top> 
> svn commit issue 
> 
>  
> tortois...@googlegroups.com: Dec 01 08:37AM -0800 
>
> is there a way to troubleshoot commit issues?
>  
> some items checkout fine some commit fin others will not commit.
>  
> thanks for any help!
> ...more 
> 
>  
> Back to top <#m_-7600060390020144987_digest_top> 
> You received this digest because you're subscribed to updates for this 
> group. You can change your settings on the group membership page.
> To unsubscribe from this group and stop receiving emails from it send an 
> email to tortoisesvn-d...@googlegroups.com. 
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/6932dd0c-1ff9-4d70-a061-8e140c856d78n%40googlegroups.com.

Re: svn commit issue

[Daniel Sahlberg via TortoiseSVN-dev]

Can you describe in more detail what happens? Error messages are always 
helpful. Pictures as well.

Kind regards,
Daniel

torsdag 1 december 2022 kl. 17:37:42 UTC+1 skrev shawn_...@cox.net:

> is there a way to troubleshoot commit issues?
>
> some items checkout fine  some commit fin others will not commit.
>
> thanks for any help!
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/60441c88-a562-4a9e-933e-a38940ad202bn%40googlegroups.com.

Re: "You have to update your working copy" doesn't offer to update

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 22 november 2022 kl. 18:31:53 UTC+1 skrev Stefan:

> yes, please commit.
>

Thanks for the review. Committed r29482.

/Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/cf5cf058-4747-4467-8e87-ed87f6d98c2fn%40googlegroups.com.

Re: CLogDlg::MonitorEditProject remove \r and \n from encrypted username/password

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 22 november 2022 kl. 18:36:08 UTC+1 skrev Stefan:

> Now that we don't support WinXP anymore, the string operations to 
> remove/replace newlines can be removed. But for XP it was necessary because 
> the CRYPT_STRING_NOCRLF option doesn't work on XP, which means there the 
> CryptBinaryToStringW API always appended a newline.
>
> Stefan
>

Thanks, committed r29483.
/Daniel 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d250c9e7-a2cf-4938-8987-9ad2e6432d0cn%40googlegroups.com.

"You have to update your working copy" doesn't offer to update

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

There has been reports about commits (and merge?) failing with "You have to 
update your working copy first" but without the subsequent offer to update.

Today I stumbled on one such case. I traced it 
to CommitCommand::IsOutOfDate not checking for error 155011 
(SVN_ERR_WC_NOT_UP_TO_DATE).

Is there a particular reason not to include this in "IsOutOfDate"?

I'm suggesting a simple patch:

[[[
Index: src/TortoiseProc/Commands/CommitCommand.cpp
===
--- src/TortoiseProc/Commands/CommitCommand.cpp(revision 29480)
+++ src/TortoiseProc/Commands/CommitCommand.cpp(working copy)
@@ -62,6 +62,7 @@
 const apr_status_t errorStatus = pErr->apr_err;
 if ((errorStatus == SVN_ERR_FS_TXN_OUT_OF_DATE) ||
 (errorStatus == SVN_ERR_RA_OUT_OF_DATE) ||
+(errorStatus == SVN_ERR_WC_NOT_UP_TO_DATE) ||
 (errorStatus == SVN_ERR_FS_CONFLICT))
 {
 return true;
]]]

(And yes, I've got commit bits and can do this myself, but on the principle 
of knowing what I don't know, I'm asking before committing something 
stupid).

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/7c66d4ee-0957-41d5-bb93-47c1661a1f31n%40googlegroups.com.

Re: CVE-2007-3846 Vunerability

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 22 mars 2023 kl. 15:53:09 UTC+1 skrev F Technologies:

Good day all.

My organization is trying to use TortoiseSVN as a version control client. 
In researching, from the user group, it looks as though this may not be 
accepted as a vulnerability by TortoiseSVN.

The concern is that a macro can be executed which might harm a network. It 
appears that there are a number of steps to get there. 

1. Can someone please advise if this was addressed? 

2. If addressed, where might I find documentation on the resolution?

3. If not are there plans to?

4. If no plans requesting explanation why so I can present to organization.

I am hoping to obtain answer by end of day Thursday as I have a meeting to 
rebut objections.

Thanks.

https://www.cvedetails.com/cve/CVE-2019-14422/


In the title you mention CVE-2007-3846 but the link is something else. I 
assume this is a case of copy-paste error and assume it is CVE-2007-3846 
you refer to.

Please see the Apache Subversion advisory:
https://subversion.apache.org/security/CVE-2007-3846-advisory.txt

The version numbers for TortoiseSVN and Apache Subversion are in general 
the same. Exceptions exist, for example within the 1.14 line, TortoiseSVN 
in general have a higher version number than the Apache Subversion library 
version.

Thus I'm sure TortoiseSVN version 1.14.5 are not affected by CVE-2007-3846.

Kind regards
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/601a953a-5a53-40ff-8fff-b6faea1ac731n%40googlegroups.com.

Re: CVE-2019-14422 Vulnerability

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 22 mars 2023 kl. 15:53:04 UTC+1 skrev F Technologies:

Good day all.

My organization is trying to use TortoiseSVN as a version control client. 
In researching, from the user group, it looks as though this may not be 
accepted as a vulnerability by TortoiseSVN.

The concern is that a macro can be executed which might harm a network. It 
appears that there are a number of steps to get there. 

1. Can someone please advise if this was addressed? 

2. If addressed, where might I find documentation on the resolution?

3. If not are there plans to?

4. If no plans requesting explanation why so I can present to organization.

I am hoping to obtain answer by end of day Thursday as I have a meeting to 
rebut objections.

Thanks.

https://www.cvedetails.com/cve/CVE-2019-14422/


Please check r28647 of the diff script at 
https://svn.osdn.net/svnroot/tortoisesvn/trunk/contrib/diff-scripts/, it 
adds a protection layer by disabling macros:

// disable all macros
objExcelApp.AutomationSecurity = 3; //msoAutomationSecurityForceDisable

Based on the date it seems to be in reaction to the CVE. It should have 
been included in the 1.13 release, it certainly is included as installed in 
1.14.5.

Kind regards,
Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/55f3c4f1-4ef4-4841-82e5-ebc33ee9c599n%40googlegroups.com.

Re: Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 11 april 2023 kl. 22:47:54 UTC+2 skrev Daniel Sahlberg:

tisdag 11 april 2023 kl. 19:33:37 UTC+2 skrev Stefan:

yep, it's the new apr version.
I'll go back to apr 1.7.2 - this needs to be fixed either in apr or the svn 
lib.


Doh. That is rather stupid. I'm sending this upstream, first to the 
Subversion project but I have a feeling it is a problem in APR.

+1 on reverting to 1.7.2.


There was a quick response on the Subversion dev mailing list [1] and a fix 
has already been committed in the APR tree. It should be possible to switch 
to https://svn.apache.org/repos/asf/apr/apr/branches/1.7.x for verification.

Kind regards,
Daniel


[1] https://lists.apache.org/thread/56gnyc3tc0orjh5mfsqo9gpq1br59b01


 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/1543d411-52d5-4f54-9d1b-2642b1c4ab19n%40googlegroups.com.

No nightly builds

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

Nightly builds currently fail with:

[[[
[exec] Microsoft (R) Program Maintenance Utility Version 14.30.30706.0 
[exec] Copyright (C) Microsoft Corporation. All rights reserved. [exec] 
[exec] "cl" /Zi /Fdossl_static.pdb /MD /Zl /Gs0 /GF /Gy /W3 /wd4090 /nologo 
/O2 -I"." -I"include" -I"apps\include" -I".." -I"..\include" 
-I"..\apps\include" -D"L_ENDIAN" -D"OPENSSL_PIC" 
-D"OPENSSLDIR=\"C:\\Program Files (x86)\\Common Files\\SSL\"" 
-D"ENGINESDIR=\"C:\\TSVN\\tortoisesvn\\ext\\build\\ext\\openssl\\out32\\lib\\engines-3\""
 
-D"MODULESDIR=\"C:\\TSVN\\tortoisesvn\\ext\\build\\ext\\openssl\\out32\\lib\\ossl-modules\""
 
-D"OPENSSL_BUILDING_OPENSSL" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" 
-D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" 
-D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"NDEBUG" 
-DOPENSSL_SSL_CLIENT_ENGINE_AUTO=capi -DOPENSSL_CAPIENG_DIALOG -c 
/Foapps\lib\libapps-lib-app_libctx.obj "..\apps\lib\app_libctx.c" [exec] 
app_libctx.c [exec] ..\apps\lib\app_libctx.c(9): fatal error C1083: Cannot 
open include file: 'app_libctx.h': No such file or directory [exec] NMAKE : 
fatal error U1077: '"c:\Program Files\Microsoft Visual 
Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX86\x86\cl.EXE"' : 
return code '0x2' [exec] Stop. [exec] NMAKE : fatal error U1077: 
'"c:\Program Files\Microsoft Visual 
Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX86\x86\nmake.exe"' 
: return code '0x2' [exec] Stop.
]]]

I assume the missing header file was my mistake on the OpenSSL 3 upgrade. 
However, I added those in r29540 and I can't figure out why this isn't 
picked up by the nightly builds.

"openssl/apps/include" was previously an ignored folder (r29014), could it 
be that the build host is stuck on a tree conflict from r29540?

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/872a077a-15b4-4bea-88d0-a50cb4c8d862n%40googlegroups.com.

Re: Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 12 april 2023 kl. 16:59:15 UTC+2 skrev Daniel Sahlberg:

tisdag 11 april 2023 kl. 22:47:54 UTC+2 skrev Daniel Sahlberg:

tisdag 11 april 2023 kl. 19:33:37 UTC+2 skrev Stefan:

yep, it's the new apr version.
I'll go back to apr 1.7.2 - this needs to be fixed either in apr or the svn 
lib.


Doh. That is rather stupid. I'm sending this upstream, first to the 
Subversion project but I have a feeling it is a problem in APR.

+1 on reverting to 1.7.2.


There was a quick response on the Subversion dev mailing list [1] and a fix 
has already been committed in the APR tree. It should be possible to switch 
to https://svn.apache.org/repos/asf/apr/apr/branches/1.7.x for verification.


APR will shortly release 1.7.4 with the above fix as the only change. The 
1.7.4 tag already exists and it builds fine and the error is gone.

Any objections to switch to 1.7.4?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/07c6b646-4c40-4773-acaa-f061cda4850dn%40googlegroups.com.

Re: Windows Search stopped indexing folders containing .svn and .git subfolders

[Daniel Sahlberg via TortoiseSVN-dev]

fredag 28 april 2023 kl. 10:14:16 UTC+2 skrev i.ku...@soton.ac.uk:

The above is a major pain! I am very remote from software development, but 
how difficult would it be to add an option to give those folders different 
names in local copies when TortoiseSVN is installed? - Ilya


There is an option to ask Subversion to use the directory name "_svn" 
instead of ".svn", see the SVN Book: 
https://svnbook.red-bean.com/en/1.7/svn-book.html#svn.basic.in-action.wc

I'm not sure if/how well it works with TortoiseSVN but since it is done in 
the Subversion library, I assume it should work.

Towards the end of this superuser.com article, there is a suggestion to 
exclude .git folders making the indexer work again, maybe the same works 
with .svn folders:

https://superuser.com/questions/1540945/how-to-stop-windows-search-from-auto-excluding-repository-folders

Kind regards,
Daniel Sahlberg
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/c513afa9-b468-4992-a6b3-a15a88fe8235n%40googlegroups.com.

Re: Hardware question

[Daniel Sahlberg via TortoiseSVN-dev]

fredag 31 mars 2023 kl. 05:09:47 UTC+2 skrev Shiko Emiya:

Good day
My company wants to build a server that allows about 50 people use it in 
the same time. 
Could you please give me some suggestions about what kind of hardware 
should I use?
Thank you very much.


Hi,

You need to provide a lot more details than the above to get a reasonably 
accurate answer. For example, what is the intended use for the server, what 
kind of OS and software will you run?

Since you are asking in the TortoiseSVN forum, I'm assuming you are looking 
for a server providing some sort of virtual desktops. TortoiseSVN will not 
require much in resources in excess of what you need for your other use 
cases. If you scale your server for your main use case it will cope easily 
with TortoiseSVN.

If you are thinking about building an SVN server (ie, hosting repositories) 
you can probably get better answers on us...@subversion.apache.org or by 
asking the vendor providing your Subversion server (if you run one of the 
commercial distributions). The answer will depend a lot on the amount of 
data you plan to store and how you plan to use SVN, however my gut feeling 
is that for 50 developers committing normal source code, almost any server 
produced within the last 10 years should cope easily.

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/3f6c9a77-4f0c-4048-b0c0-625d109da48cn%40googlegroups.com.

Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I've spent the weekend updating several dependencies for TortoiseSVN:
- APR: 1.7.2 to 1.7.3
- OpenSSL: 1.1.1t to 3.1.0 (the 1.1 series is EOL on 11th September 2023).
- Serf: 1.3.9 to current trunk version (needed for OpenSSL 3 compatibility, 
I'm hoping for a new release of Serf before the next Subversion/TSVN 
release, otherwise there is a simple patch we can apply in the build 
process).
- Zlib: 1.2.11 to 1.2.13.

Nightly builds should be available from tomorrow (the nightly builds today 
failed because of a missing buildstep).

The update to OpenSSL 3 should solve a problem with building the ARM 
version (unfortunately there is no nightly build for ARM).

Please feel free to test!

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/608a1f0f-b183-4662-9189-19a0f62bb7b5n%40googlegroups.com.

Re: Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 11 april 2023 kl. 19:33:37 UTC+2 skrev Stefan:

yep, it's the new apr version.
I'll go back to apr 1.7.2 - this needs to be fixed either in apr or the svn 
lib.


Doh. That is rather stupid. I'm sending this upstream, first to the 
Subversion project but I have a feeling it is a problem in APR.

+1 on reverting to 1.7.2.

Kind regards,
Daniel 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/66f0e4cb-d0d3-4de6-8b46-9d3067b1c497n%40googlegroups.com.

Re: No nightly builds

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 22 april 2023 kl. 07:13:50 UTC+2 skrev Stefan:

I've mailed Ian, and he deleted the include folder and ran an 'svn up', so 
there should not be any more conflicts.
But the build still fails...


Sorry it took a while for me to circle back to this - I looked quickly and 
everything seemed fine and it took some time to take a closer look.

I believe 'svn up' might not be enough if there is already a tree conflict. 
I think I reproduced the issue by updating to r29539, building, then trying 
to update to HEAD. I had do 'svn resolve' (selecting r to Mark as resolved) 
and 'svn revert ext\openssl\apps\include --depth=infinity' followed by 'svn 
up'. After this I had a clear 'svn st' and the build succeeded.

/Daniel


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/0b8263ce-4876-4239-a6a6-4ef5134134afn%40googlegroups.com.

osdn.net longterm stability

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

osdn.net seems to have issues [1] and I'd like to bring it up to make sure 
that we don't end up in a situation where it starts affecting TortoiseSVN.

* Nobody seems to monitor the issue tracker [1] anymore - it is full of 
spam and no-one seems to respond to issues. It is mentioned in one of the 
issues [2] that "there is no more support here".
* Several different errors occur throughout the site: Accessing the source 
code through the web interface [3] only report an error message.
* The commit notify e-mail contain a link [4] to the web page, however the 
link give the same error message as elsewhere in the web interface.

As far as I know we use osdn.net for the source code repository and for 
hosting release artifacts (installers and documentation).

So far I've seen no negative effects on development and/or distribution 
workflows but as the support is not there anymore I think we need to think 
about a backup plan.

I've personally configured an svnsync mirroring of the repository to have a 
backup in place - I know there is also a mirror in Github so we should not 
risk loosing source or history. The release artifacts also seem easy enough 
to mirror, but I havn't done that yet.

- Does anyone know more about what is going on with osdn.net?
- Did I miss any useage of osdn.net above?
- Does it make sense to make a contingency plan or even migrate away from 
osdn.net? The list of free hosting is rather thin (except Github, but 
migrating the repository to git would be.. should I say against the spirit 
of the project).

Kind regards,
Daniel Sahlberg

[1] https://osdn.net/projects/support/ticket/
[2] https://osdn.net/projects/support/ticket/47324
[3] https://osdn.net/projects/tortoisesvn/scm/svn/tree/head/
[4] https://osdn.net/projects/tortoisesvn/scm/svn/commits/29571

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/1d3cb951-2fe0-4fcb-b06e-3387171c989fn%40googlegroups.com.

Re: Enable asm for OpenSSL

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 1 juni 2023 kl. 20:11:11 UTC+2 skrev Denis Kovalchuk:

> Very interesting results. Did you run this on a build from /trunk/ -
> ie with OpenSSL 3.1?

Yes, these results were from trunk with OpenSSL 3.1. However, I believe that
they should be similar with OpenSSL 1.1.x as well.


Thanks for confirming.

> The reason for the no-asm option was that the asm code often (it felt like
> every other release) was broken. Either with the asm that comes with VS,
> or later with MASM as well: When they switched to requiring MASM I thought
> the build problems were solved, but the second version after the switch
> failed again.
>
> So I had enough and used the no-asm switch.

Let me try to summarize and list a few more reasons on why I think that
switching to the default OpenSSL build could be beneficial for the project:

1. The improvement comes from using AES-NI instructions for HTTPS.

So this should reduce the CPU usage for all network operations. Perhaps, it
could be especially visible on low-tier hardware.


I doubt there will in average be much gain by handoptimizing ASM code 
compared to a modern compiler. But if it is required to get access to 
AES-NI and similar specialized instructions, it make sense.

2. Spending less CPU on common operations means more laptop battery time
and more CPU available for other tasks, in all setups.

For example, here are a couple of additional benchmarks performed over
typical 1Gb LAN that illustrate the overall CPU time reduction:

Null-export of Subversion root dir, 1Gb LAN:
CPU time: 130 sec  8 sec (16x less CPU used)
Total time: 175 sec  175 sec
Avg CPU load: 74%  4%

Null-export of .iso file, 1Gb LAN:
CPU time: 13 sec  1 sec (13x less CPU used)
Total time: 63 sec  63 sec
Avg CPU load: 20%  2%


If I understand the figures, the total time doesn't change, ie the CPU is 
quick enough to decrypt the traffic in either case. But the CPU spends more 
time idling with the ASM optimized code. (With a faster network, the CPU 
will of course be the bottleneck).

The improvement on the export of the Subversion root dir is even more 
impressive.

Power consumption is a valid argument, although I doubt that the power 
consumption from SVN usage will make a noticeable difference in total 
battery life - I assume `svn up` (or `svn export`) is a relatively 
infrequent operation for the average developer. Still, if it doesn't have 
negative side effects why not use it.

3. Building OpenSSL with assembler support is the current default.

Multiple known projects such as Node.js seem to use and regularly test this
configuration on different platforms and provide additional test coverage.
Compared to that, I think that the `no-asm` build falls into the group of
non-standard configurations (maybe even not intended for production use),
and therefore it could be far less tested in practice.


I agree the no-asm seems to be the less supported option. Quoting again 
from the OpenSSL INSTALL.md: "This should be viewed as 
debugging/troubleshooting option rather than for production use."

4. Perhaps you are right about the real setups/throughput, but SVN is good
at handling large files and so there might be users that have multi-terabyte
repositories containing assets and other large binaries.


The large file handling has been a motivation for a recent development of 
Subversion, the "pristine-less working copy" concept. Yet to be released, 
but it is part of Subversion /trunk.

To summarize: I'm +0 to removing the no-asm. I'd like to build it myself 
before upgrading to +1, we also need to figure out a plan to update the 
nightly build servers so we don't break the nightly builds again. (I 
believe the nightly builds are provided by a third party, with Stefan being 
the only one in contact with them).

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d7617d8d-6a18-4e16-8a3d-45d989a5792fn%40googlegroups.com.

Re: osdn.net longterm stability

[Daniel Sahlberg via TortoiseSVN-dev]

I'm also aware of the story of SourceForge and I feel reluctant suggesting 
to go back there.
Github seems like a solid choice if it wasn't for the Git part (I'm not 
against Git as such but using Git for TortoiseSVN seems wrong). I've heard 
about some interesting build automation workflows but I'm also not aware of 
their features and exact terms.
Otherwise there are a few companies making business based on Subversion 
hosting / products that might be interested in sponsoring at least the 
source code hosting.

Maybe a combination of repository hosting at some "closely related company" 
and website / release artifacts on Github.

Kind regards,
Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/dfb96be9-6a86-4123-9ee6-528dc30a25c6n%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 24 maj 2023 kl. 21:52:29 UTC+2 skrev Daniel Sahlberg:

I've reverted this in r29564 and the crash seems to be gone.


Unfortunately it was not enough, the log still crash (I've also seen the 
same error as in Pavel's screen shot "Illegal repository URL 
'[gibberish]'". I'll try to take a second look.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/5b8e4c65-0a54-4384-97ec-667615e91c24n%40googlegroups.com.

Re: Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

fredag 19 maj 2023 kl. 11:12:15 UTC+2 skrev Evgeny Kotkov:

Daniel Sahlberg writes: 

> - Serf: 1.3.9 to current trunk version (needed for OpenSSL 3 
compatibility, 
> I'm hoping for a new release of Serf before the next Subversion/TSVN 
> release, otherwise there is a simple patch we can apply in the build 
> process). 

With the recent backports on the branch, serf 1.3.x should work fine with 
OpenSSL 3. There is no release yet, but perhaps it would be nice to switch 
TSVN externals to the current state of the serf 1.3.x branch, to ensure 
that 
everything works as expected.


Evgeny,

Since  r29562 (nightly builds 2023-05-21 and later) TortoiseSVN should be 
using the 1.3.x branch. Builds seems fine, I've been using them for a few 
days. Please be aware of a regression in the LogCache, hopefully fixed in 
r29564 (nightly builds 2023-05-25 and later).

Kind regards,
Daniel

[1] https://groups.google.com/g/tortoisesvn-dev/c/lTyZdQwpvGo

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/3b7d4218-2936-4f2d-850d-f34c6b7403a2n%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 23 maj 2023 kl. 18:53:06 UTC+2 skrev Stefan:

I made a few changes to the log caching, but those changes are mostly 
refactoring.
Unfortunately, I can't reproduce a crash of the error message on my machine 
here.

Maybe you guys can debug the problem on your machine?'


I found a way to reproduce it: when I deleted the log cache, the error also 
occured within Visual Studio.

I believe the error is the following change. Please note the comment, it 
was added in r14384 when the arguments was changed from const CString& to 
CString (ie, the opposite of the change below). I'm supporting the analysis 
that the parameters may come from a cache entry being deleted, in this case 
from a call in CLogCachePool::AutoRemoveUnused() where the 
repositoryInfo->data object is iterated and then the very same object is 
deleted by DropEntry. Suddenly the uuid and urls are unreachable.

[[[
Index: src/LogCache/RepositoryInfo.h
===
--- src/LogCache/RepositoryInfo.h (revision 29553)
+++ src/LogCache/RepositoryInfo.h (revision 29554)
[...]
@@ -232,27 +232,27 @@
 /// Parameters must be copied because they may stem from the
 /// info object being deleted.
 
-void DropEntry(CString uuid, CString url);
+void   DropEntry(const CString& uuid, const CString& 
url);
 ]]]

I've reverted this in r29564 and the crash seems to be gone.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/0e750ce8-a193-446f-be55-2c34f9578552n%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

- Good news: No more crasches.

- Bad news: Logcache shows a lot of duplicates. There seems to be only one 
file in %appdata%\TortoiseSVN\logcache.

So something should probably be done to the logcache "add to cache" logic. 
I'm favoring letting Add() have the same functionality as AutoInsert 
already has (and getting rid of the latter). However no time to look at the 
code before next week (probably not before next weekend).

/Daniel
tisdag 6 juni 2023 kl. 19:59:36 UTC+2 skrev Stefan:

> you're right. The problem is the == operator. To work properly it would 
> require to know the settings allowAmbiguousUrl/Uuid and act accordingly.
> While that could be done, it would make for very ugly code.
>
> I added the 'avoid duplicate' code because my local cache showed 10 
> entries for the same repo in the settings dialog. But maybe my cache was 
> just corrupted.
> So I reverted that commit for now. If I ever get those multiple entries 
> again, I'll try to come up with a solution that works.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/be411ccb-02e1-446b-b2ab-3e844f0ec7fan%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks! I'll test the nightly build tomorrow.

Any idea why only the nightly build would fail and not when I built it 
myself? The settings should have been the same...

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/b48f40a7-54d7-46ab-9d34-c9e769aa6882n%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

I really need some help with this...

My understanding is as follows:
CRepositoryInfo::CData::AutoInsert() is called to find/add an 
SPerRepositoryInfo() object (basically a {uuid, root} tuple) to data (and 
urlIndex, uuidIndex, fullIndex). 
It will first call CRepositoryInfo::CData::Lookup() to see if there already 
exists an object with the key {uuid, root} by searching fullIndex (and 
possibly uuidIndex, urlIndex, depending on the AllowAmbiguousUUID and 
AllowAmbiguousURL settings). If it finds something it will return a 
pointer, otherwise nullptr.
If Lookup() returns a nullptr, CRepositoryInfo::CData::Add() is called to 
create a new SPerRepositoryInfo and to add it to data (and urlIndex, 
uuidIndex, fullIndex).
However Add() will "avoid duplicate entries" by searching data 
with std::ranges::find_if() and checking for equality using 
SPerRepositoryInfo::operator==(). If it finds a duplicate, it will not add 
anything to the data/indicies.
AutoInsert() will then try the Lookup() again to find the newly added 
object and assumes success since the object was just Add()ed.

Only in my test case the object was NOT added by Add(), since Add() hits 
line 176 and returns "to avoid duplicate entries".

I believe there is a difference between the code in Lookup() (using 
fullIndex.find(std::make_pair(uuid, root))) and the code in Add() 
(using std::ranges::find_if(data, [&](auto* i) { return (*i) == info; }) 
where the code in Lookup() fail to find an object that is later found by 
Add().

However I'm not clever enough to figure out what the difference is. I was 
first suspecting that SPerRepositoryInfo::operator==() was too sensitive, 
but I figure if that was the case objects would be added even though they 
are "duplicate".

I'm currently leaning towards changing CRepositoryInfo::CData::Add(const 
SPerRepositoryInfo& info) to return a pointer to the newInfo object, to let 
AutoInsert return this instead of doing another Lookup(), but I feel this 
would only plaster over the difference between the code in Lookup() and 
Add().

I'm also considering reverting r29558 (which added the "avoid duplicate 
entries" in Add()) but I'm assuming it was added for good reasons.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/48e3e330-85ca-4299-9488-8d0a01e15a3fn%40googlegroups.com.

Re: No nightly builds

[Daniel Sahlberg via TortoiseSVN-dev]

fredag 5 maj 2023 kl. 14:53:41 UTC+2 skrev Pavel Lyalyakin:

It appears that the issue is still there:
[[[
 [exec] app_libctx.c
 [exec] ..\apps\lib\app_libctx.c(9): fatal error C1083: 
Cannot open include file: 'app_libctx.h': No such file or directory
 [exec] NMAKE : fatal error U1077: '"c:\Program 
Files\Microsoft Visual 
Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX64\x64\cl.EXE"' : 
return code '0x2'
 [exec] Stop.
 [exec] NMAKE : fatal error U1077: '"c:\Program 
Files\Microsoft Visual 
Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX64\x64\nmake.exe"' 
: return code '0x2'
 [exec] Stop.
]]]

And there are no new nightly builds. T_T


Stefan made a cleaver fix in the build script which resolved the conflict 
that prevented a successful build.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/4435e3e5-1194-40e7-bf28-9b9e3d5cf00bn%40googlegroups.com.