Shu Ming has abandoned this change.
Change subject: Get oop from object instance
..
Abandoned
See Mark's comment
--
To view, visit http://gerrit.ovirt.org/8920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Shu Ming has abandoned this change.
Change subject: Source image exception when querying source image
..
Abandoned
Not relevant
--
To view, visit http://gerrit.ovirt.org/8479
To unsubscribe, visit http://gerrit.ovirt.org/sett
Shu Ming has abandoned this change.
Change subject: Make HSM service self containted
..
Abandoned
Not the way to go
--
To view, visit http://gerrit.ovirt.org/11502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Shu Ming has abandoned this change.
Change subject: '0' is a valid master version
..
Abandoned
It seems most of the people don't agree on it.
--
To view, visit http://gerrit.ovirt.org/7948
To unsubscribe, visit http://gerrit.
Shu Ming has posted comments on this change.
Change subject: Bump up libvirt version to fix network linking.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
...
Shu Ming has posted comments on this change.
Change subject: image: update the volume permissions when needed
..
Patch Set 2:
I can not access the Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=911417 and it resulted in
Shu Ming has posted comments on this change.
Change subject: Make sr-iov hook use interface instead of hostdev
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Shu Ming has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 11: I would prefer that you didn't submit this
(1 inline comment)
...
Shu Ming has posted comments on this change.
Change subject: getAllTasksList\Status with 'spm_tasks' option retrieves info
only if host SPM
..
Patch Set 6:
Can you help to move https://bugzilla.redhat.com/show_bug.cgi?id=8805
Shu Ming has posted comments on this change.
Change subject: Adding isSpm parameter to getAllTasksList\Status
..
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
.
Shu Ming has posted comments on this change.
Change subject: Fix the broken PYTHONPATH
..
Patch Set 1:
Hi Dan,
"@builddir@/vdsm" will generate "./vdsm" in the run_test_local.sh file after
successful build. And run_test_local.
Shu Ming has uploaded a new change for review.
Change subject: Fix the broken PYTHONPATH
..
Fix the broken PYTHONPATH
@builddir@/vdsm is a non-exsiting path
Change-Id: I438936a7eb98206426a15aa0a751a22060b9c895
Signed-off-by: Sh
Shu Ming has posted comments on this change.
Change subject: Ignore postZero flag when deleting an image on a fileSD.
..
Patch Set 3: I would prefer that you didn't submit this
Can you update the bugzilla to explain the postZer
Shu Ming has posted comments on this change.
Change subject: Make HSM service self containted
..
Patch Set 3: (2 inline comments)
It is right that both the normal VDSM service and the storage service will
depend on the site pa
Shu Ming has posted comments on this change.
Change subject: Adding constant for log file permissions
..
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/12380
To unsubscribe, vi
Shu Ming has posted comments on this change.
Change subject: Adding constant for log file permissions
..
Patch Set 1: (1 inline comment)
File vdsm/vdsm-logrotate.conf.in
Line
Shu Ming has uploaded a new change for review.
Change subject: [WIP]Make HSM service self containted
..
[WIP]Make HSM service self containted
After moving the share files between common
VDSM service and HSM service to site packa
Shu Ming has uploaded a new change for review.
Change subject: Nits: clean the magic number for seek()
..
Nits: clean the magic number for seek()
Change-Id: I65625ae7a41649e290636c95f0e694c065fe42dc
Signed-off-by: Shu Ming
---
Shu Ming has posted comments on this change.
Change subject: Storage: Check that underlying file system supports direct IO
..
Patch Set 6: (1 inline comment)
Commit Message
L
Shu Ming has posted comments on this change.
Change subject: Storage: Check that underlying file system supports direct IO
..
Patch Set 6: No score
(1 inline comment)
File v
Shu Ming has posted comments on this change.
Change subject: Storage: Check that underlying file system supports direct IO
..
Patch Set 6: (3 inline comments)
File vdsm/stora
Shu Ming has posted comments on this change.
Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test
..
Patch Set 2: (4 inline comments)
Commit Message
Li
Shu Ming has posted comments on this change.
Change subject: Storage: Check that underlying file system supports direct IO
..
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
Shu Ming has posted comments on this change.
Change subject: make misc.pgrep for general usage
..
Patch Set 2: (2 inline comments)
File vdsm/storage/blockSD.py
Line 1087:
Shu Ming has posted comments on this change.
Change subject: Remove redundant exception assignations.
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
..
Shu Ming has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 8: I would prefer that you didn't submit this
(3 inline comments)
File vdsm/A
Shu Ming has posted comments on this change.
Change subject: get the status of core dump
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Some English syntax nits
Shu Ming has posted comments on this change.
Change subject: vdsm: Throw MountError in mount.getRecord()(#883877)
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
..
Shu Ming has posted comments on this change.
Change subject: Use cp to copy sparse volumes when moving a vm
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
Shu Ming has posted comments on this change.
Change subject: adding getHardwareInfo API to vdsm
..
Patch Set 19: (1 inline comment)
File vdsm/Makefile.am
Line 31:clie
Shu Ming has posted comments on this change.
Change subject: adding getHardwareInfo API to vdsm
..
Patch Set 19: Looks good to me, but someone else must approve
(1 inline comment)
A nit inline.
...
Shu Ming has posted comments on this change.
Change subject: pool: refactor getInfo and getRepoStats
..
Patch Set 1: I would prefer that you didn't submit this
Please add some comments about why we should refactor getInfo and g
Shu Ming has posted comments on this change.
Change subject: catch libvirt timeout and return an error on setVmTicket
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
..
Shu Ming has posted comments on this change.
Change subject: Do not fail when getVSize is called on an inctive LV.
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: A
Shu Ming has posted comments on this change.
Change subject: Distinguish between local and mounted SD's.
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
...
Shu Ming has posted comments on this change.
Change subject: Take care of 'No devices found' when calling dmsetup status
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
...
Shu Ming has posted comments on this change.
Change subject: Distinguish between local and mounted SD's.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
...
Shu Ming has posted comments on this change.
Change subject: Adding check of os.access to vdsm log file during startup
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Shu Ming has posted comments on this change.
Change subject: Adding check of os.access to vdsm log file during startup
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.
Shu Ming has posted comments on this change.
Change subject: Move hsm.validatePoolSD() -> pool.validatePoolSD().
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9455
To
Shu Ming has posted comments on this change.
Change subject: Do not fail when getVSize is called on an inctive LV.
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: A
Shu Ming has posted comments on this change.
Change subject: Move hsm.validatePoolSD() -> pool.validatePoolSD().
..
Patch Set 2: (1 inline comment)
File vdsm/storage/sp.py
Li
Shu Ming has posted comments on this change.
Change subject: Move hsm.validatePoolSD() -> pool.validatePoolSD().
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
..
Shu Ming has posted comments on this change.
Change subject: dd: use iflag=direct only when supported by the os
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
...
Shu Ming has posted comments on this change.
Change subject: Fix return value of shutdown() on failure
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5434
To unsubscrib
Shu Ming has posted comments on this change.
Change subject: Fix block volume atomicity creation issue.
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Shu Ming has posted comments on this change.
Change subject: Have direct file not use the O_DIRECT flag on tmpfs and ramfs
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Shu Ming has posted comments on this change.
Change subject: mailbox: daemonize the hsm mailbox thread
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.
Shu Ming has posted comments on this change.
Change subject: forceVMstart: Initial commit
..
Patch Set 3: I would prefer that you didn't submit this
(5 inline comments)
File
Shu Ming has posted comments on this change.
Change subject: libvirtvm: use
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9441
To unsubscribe, visit http://gerrit.ovi
Shu Ming has posted comments on this change.
Change subject: libvirtvm: use
..
Patch Set 1: Looks good to me, but someone else must approve
Please fix the function comments to match the test examples. It might confuse
others
Shu Ming has posted comments on this change.
Change subject: libvirtvm: use
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
File tests/libvirt
Shu Ming has posted comments on this change.
Change subject: vdsm.spec: Add packages versions for rhel7
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
...
Shu Ming has posted comments on this change.
Change subject: Fix warnings at end of tests
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Commi
Shu Ming has posted comments on this change.
Change subject: split config file for HSM service standalone
..
Patch Set 1: (4 inline comments)
In general, "config" and "hsmconfig" were used in these files as object name.
It i
Shu Ming has posted comments on this change.
Change subject: integrate zombie reaper in supervdsmServer
..
Patch Set 2: Looks good to me, but someone else must approve
One nit. Is that 5 seconds are too long to reap the zombie
Shu Ming has posted comments on this change.
Change subject: Nit fixes of supervdsmServer
..
Patch Set 1: (1 inline comment)
File vdsm/supervdsmServer.py
Line 372:
Shu Ming has posted comments on this change.
Change subject: Adding threads limitation to misc.tmap
..
Patch Set 2: (2 inline comments)
File vdsm/storage/misc.py
Line 1227:
Shu Ming has posted comments on this change.
Change subject: mom: Report the status of the mom threads
..
Patch Set 1: Looks good to me, but someone else must approve
A nit, Is it more meaningful to use the state "inative" inst
Shu Ming has posted comments on this change.
Change subject: Alert if vdsm log has wrong user\group permissions
..
Patch Set 3: No score
(1 inline comment)
File vdsm/vdsmd.i
Shu Ming has posted comments on this change.
Change subject: Alert if vdsm log has wrong user\group permissions
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Shu Ming has posted comments on this change.
Change subject: Adding support for force extend block domains
..
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
.
Shu Ming has posted comments on this change.
Change subject: used gluster cli xml output
..
Patch Set 4: I would prefer that you didn't submit this
Please fix the indent pep8 errors in gluster_cli_tests.py at least.
--
To view
Shu Ming has posted comments on this change.
Change subject: Adding support for force extend block domains
..
Patch Set 5:
I really don't understand why we need the force flag here. It seems _initpvs()
try to reinitialize the
Shu Ming has posted comments on this change.
Change subject: remoteFileHandler: improve PYTHONPATH definition
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
..
Shu Ming has posted comments on this change.
Change subject: Logging: config logging in new process of remoteFileHandler
..
Patch Set 1: (1 inline comment)
File vdsm/storage/
Shu Ming has posted comments on this change.
Change subject: Handle spaces in device names using lvm filter
..
Patch Set 1: (1 inline comment)
File vdsm/storage/lvm.py
Line 1
Shu Ming has posted comments on this change.
Change subject: drop type() calls
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8816
To unsubscribe, visit http://gerrit.o
Shu Ming has posted comments on this change.
Change subject: Integrate zombie reaper in test framework
..
Patch Set 3: Looks good to me, but someone else must approve
Yaniv, thanks for your explanation.
--
To view, visit http:
Shu Ming has posted comments on this change.
Change subject: Integrate zombie reaper in test framework
..
Patch Set 3: No score
Saggi, sorry about confusing. I suppose you mean the sleep child process in
testProcessDiesAfterB
Shu Ming has posted comments on this change.
Change subject: Integrate zombie reaper in test framework
..
Patch Set 3: I would prefer that you didn't submit this
The test case set the signal handler to reap the child PID after
Shu Ming has posted comments on this change.
Change subject: Changing threadName when using multiprocessing package
..
Patch Set 1:
Not sure if it is a right fix. I am thinking to decorate the
multiprocessing.baseManager clas
Shu Ming has posted comments on this change.
Change subject: Using only globalPool allow only 10 processes
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Also, see my concern about possibleD
Shu Ming has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
..
Patch Set 8: (1 inline comment)
Commit Message
Line 6:
Line 7: BZ#83616
Shu Ming has posted comments on this change.
Change subject: Don't forget to close thread pool when stopping the SPM mailer
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Shu Ming has posted comments on this change.
Change subject: Adding threads limitation to misc.tmap
..
Patch Set 8: Looks good to me, but someone else must approve
It looks good to me, but I still get two questions.
I) It seems
Shu Ming has posted comments on this change.
Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Shu Ming has posted comments on this change.
Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.
..
Patch Set 10: I would prefer that you didn't submit this
Unfortunately, there are two other places call
Shu Ming has posted comments on this change.
Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.
..
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
...
Shu Ming has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
..
Patch Set 8: (1 inline comment)
File vdsm/storage/blockSD.py
Line 913:
Shu Ming has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
..
Patch Set 8: No score
(2 inline comments)
Commit Message
Line 6:
Line
Shu Ming has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
..
Patch Set 8: I would prefer that you didn't submit this
(3 inline comments)
Shu Ming has uploaded a new change for review.
Change subject: Get oop from object instance
..
Get oop from object instance
In FileStorageDomain non-class method, self.oop should
be used instead of oop
Change-Id: Ia6b86f2c5e382
Shu Ming has posted comments on this change.
Change subject: Misc storage exception class name style
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8847
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shu Ming has posted comments on this change.
Change subject: Adding threads limitation to misc.tmap
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
...
Shu Ming has posted comments on this change.
Change subject: storage: Don't ignore nfs_mount_options in vdsm.conf
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5368
T
Shu Ming has uploaded a new change for review.
Change subject: Misc storage exception class name style
..
Misc storage exception class name style
All the misc storage exception class name should
be prefixed with "Misc"
Change-I
Shu Ming has posted comments on this change.
Change subject: storage: Don't ignore nfs_mount_options in vdsm.conf
..
Patch Set 10: I would prefer that you didn't submit this
(1 inline comment)
.
Shu Ming has posted comments on this change.
Change subject: Replace 'has_key' with 'in'
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8769
To unsubscribe, visit http:
Shu Ming has posted comments on this change.
Change subject: Validating number of required args in spmStart()
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8731
To uns
Shu Ming has posted comments on this change.
Change subject: Add lvm.lvPhysDev() to get the physical LV device.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8751
To u
Shu Ming has posted comments on this change.
Change subject: Validating number of required args in spmStart()
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
..
Shu Ming has posted comments on this change.
Change subject: Fix race in fileUtils.createdir().
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Shu Ming has posted comments on this change.
Change subject: Clean /rhev/data-center/mnt/ after failed mount command
..
Patch Set 4:
Yeela, thanks for explaining that. I am fine.
--
To view, visit http://gerrit.ovirt.org/8695
Shu Ming has posted comments on this change.
Change subject: BZ#836161 - Rewrited deleteImage().
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
..
Shu Ming has posted comments on this change.
Change subject: volume: save the correct size during creation
..
Patch Set 3: (1 inline comment)
File vdsm/storage/volume.py
Line
Shu Ming has posted comments on this change.
Change subject: Clean /rhev/data-center/mnt/ after failed mount command
..
Patch Set 3: I would prefer that you didn't submit this
Why should we bother to remove the local file direc
Shu Ming has posted comments on this change.
Change subject: volume: save the correct size during creation
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8629
To unsubs
Shu Ming has posted comments on this change.
Change subject: Handling removing file Exceptions.
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
...
Shu Ming has posted comments on this change.
Change subject: BZ#836161 - Refactored deleteImage.
..
Patch Set 1: I would prefer that you didn't submit this
See my comments in the above.
--
To view, visit http://gerrit.ovirt.or
1 - 100 of 220 matches
Mail list logo
