Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53677/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Milan Zamazal has posted comments on this change.
Change subject: vm: serialize destroy() and creation
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55150
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: safer early return if destroyed on startup
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55151
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 11:
(3 comments)
https://gerrit.ovirt.org/#/c/53677/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Milan Zamazal has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 3: Code-Review+1
(Assuming you fix the commit message.)
--
To view, visit https://gerrit.ovirt.org/54792
To
Milan Zamazal has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 8:
(3 comments)
I can't say there is something clearly wrong with the change, but it looks a
bit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
..
Patch Set 12:
Some test code added to better cover the moved code.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/44989/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: Add `vm' argument to underlying_device_info methods
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53676/1//COMMIT_MSG
Commit Message:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/53101/6/lib/vdsm/virt/vmdict.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: New method Vm.get_devices
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/54090/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: debian: add supervdsm_api
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54466
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/53677/7/tests/devices/data/testComplexVm.xml
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't use Vm device configuration in clientIF
..
Patch Set 7: Verified+1
Verified by running a VM from Engine, migrating it to another host and back and
Milan Zamazal has abandoned this change.
Change subject: virt: New method Vm.get_devices
..
Abandoned
Not a good idea, discarded.
--
To view, visit https://gerrit.ovirt.org/54090
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/53615/5/vdsm/virt/vmxml.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm
..
Patch Set 7:
> if you add a new module you need to update also the Makefile.am, vdsm.spec.in
> and
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/53619/8/vdsm/virt/vmdevices/graphics.py
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Use PEP8 identifiers in vmxml.device_address
..
virt: Use PEP8 identifiers in vmxml.device_address
This is a trivial change just renaming two local
Milan Zamazal has posted comments on this change.
Change subject: virt: Make Vm.devMapFromDevSpecMap() private
..
Patch Set 7: Verified+1
Verified by running a VM from Engine, migrating it to another host and back and
Milan Zamazal has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 7: Verified+1
Verified by running a VM from Engine, migrating it to another host and back and
shutting
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/53678/7/vdsm/virt/vmdevices/common.py
File
Milan Zamazal has posted comments on this change.
Change subject: v2v: fix handling virt-v2v fail on stream close
..
Patch Set 2: Code-Review+1
(2 comments)
OK, I just suggest improving the commit message.
Milan Zamazal has posted comments on this change.
Change subject: virt: clean and modernize the destroy() path
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/55534/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: clean and modernize the destroy() path
..
Patch Set 1: Code-Review+1
Oh, it's a backport.
--
To view, visit https://gerrit.ovirt.org/55534
To
Milan Zamazal has posted comments on this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Patch Set 2: Verified+1
Verified that the rpm package installs on current CentOS and a VM with
non-ASCII characters
Milan Zamazal has posted comments on this change.
Change subject: spec: bump libvirt requirement
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55570
To unsubscribe, visit
Milan Zamazal has abandoned this change.
Change subject: vdsm.spec: Require new libvirt on RHEL
..
Abandoned
Duplicate of http://gerrit.ovirt.org/54796
--
To view, visit https://gerrit.ovirt.org/54547
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 48:
(1 comment)
https://gerrit.ovirt.org/#/c/40053/48/tests/virt/bulk_sampling_test.py
File
Milan Zamazal has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 3:
(1 comment)
I can't judge the technical side, but codewise fine, except for wondering about
one style issue.
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't set connected attribute in if already set
..
Patch Set 4: Verified+1
Verified by installing the hook as described in the referenced bug and
Milan Zamazal has posted comments on this change.
Change subject: migrations: change convergence schedule from time to iterations
..
Patch Set 3: Code-Review-1
(6 comments)
The code seems to be OK to me. But please fix errors
Milan Zamazal has posted comments on this change.
Change subject: hostdev: report additional information in 'scsi' device
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/56038/7/lib/vdsm/hostdev.py
File
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
virt: Don't fail when existingConnAction is unset for a SPICE device
When a ticket for
Milan Zamazal has abandoned this change.
Change subject: virt: Don't set connected attribute in if already set
..
Abandoned
Abandoned in favor of https://gerrit.ovirt.org/56836 + some Engine side
solution.
--
To view,
Milan Zamazal has posted comments on this change.
Change subject: migrations: change convergence schedule from time to iterations
..
Patch Set 4: -Code-Review
Thanks, the commit message is much better now.
I'm still a bit
Milan Zamazal has posted comments on this change.
Change subject: migrations: enhance legacy downtime alg
..
Patch Set 3:
(6 comments)
https://gerrit.ovirt.org/#/c/56561/3//COMMIT_MSG
Commit Message:
PS3, Line 12: during
Milan Zamazal has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56574/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 899:
Line 900:
Milan Zamazal has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56574/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 899:
Line 900:
Milan Zamazal has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev/sr-iov: use device setup instead of detach
..
Patch Set 13: Code-Review-1
(2 comments)
Documentation issues.
Milan Zamazal has posted comments on this change.
Change subject: hostdev: use setup instead of detach in hotplug
..
Patch Set 3: Code-Review-1
This is confusing. Why do we call the method HostDevice.setup when its
docstring
Milan Zamazal has posted comments on this change.
Change subject: hostdev: report storage model as product
..
Patch Set 3: Code-Review+1
Just thinking whether we should check for `product' presence before we override
it with
Milan Zamazal has posted comments on this change.
Change subject: hostdev: use libvirt flags to select capability
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/56037/4//COMMIT_MSG
Commit Message:
PS4, Line 10:
Milan Zamazal has posted comments on this change.
Change subject: hostdev: expose parameters needed to support hotunplug
..
Patch Set 19: Code-Review+1
(1 comment)
Better now.
> I don't feel like adding xpath test in this
Milan Zamazal has posted comments on this change.
Change subject: hostdev: expose generic scsi driver char device in device params
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55022
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: hostdev: expose parameters needed to support hotunplug
..
Patch Set 17:
(3 comments)
https://gerrit.ovirt.org/#/c/54939/17/vdsm/virt/vmdevices/hostdevice.py
Milan Zamazal has posted comments on this change.
Change subject: hostdev: add vdsClient hotunplug command
..
Patch Set 18: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54940
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev/sr-iov: use device setup instead of detach
..
Patch Set 14: Code-Review+1
(1 comment)
Milan Zamazal has posted comments on this change.
Change subject: hostdev: expose hotplug via vdsClient
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54938
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: expose parameters needed to support hotunplug
..
Patch Set 18: Code-Review-1
Some cosmetic issues. And how about adding a simple test to check we build
Milan Zamazal has posted comments on this change.
Change subject: virt: Set timeout on boot menu
..
Patch Set 4:
After some discussions we decided that we can omit the configuration option
completely. One must enable the boot
Milan Zamazal has posted comments on this change.
Change subject: virt: Set timeout on boot menu
..
Patch Set 5: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/56393/4//COMMIT_MSG
Commit Message:
PS4, Line 12: more a
>
Milan Zamazal has posted comments on this change.
Change subject: v2v: small test improvement
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56694
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Set timeout on boot menu
..
Patch Set 4: Verified+1
Verified by running a VM and checking that the boot menu prompt lasts
accordingly longer.
--
To
Milan Zamazal has posted comments on this change.
Change subject: virt: Set timeout on boot menu
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56393/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 240:
Milan Zamazal has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56291
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: get is_assignable from libvirt when available
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56299
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: use libvirt flags to select capability
..
Patch Set 5: Code-Review+1
(Although I still insist on that there is a grammar error in the commit
message.)
Milan Zamazal has posted comments on this change.
Change subject: hostdev: expose generic scsi driver char device in device params
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/55022/6/lib/vdsm/hostdev.py
File
Milan Zamazal has posted comments on this change.
Change subject: hostdev: report additional information in 'scsi' device
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/56038/5/lib/vdsm/hostdev.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't set connected attribute in if already set
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/56224/4//COMMIT_MSG
Commit Message:
Line 19:
Milan Zamazal has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 31:
(2 comments)
https://gerrit.ovirt.org/#/c/53305/31/lib/api/vdsm-api.yml
File
Milan Zamazal has posted comments on this change.
Change subject: tests: Prevent multiple invocations of makecerts.sh
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57344
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: fix behaviour with balloon model=none
..
Patch Set 1:
To clarify: We must be careful about balloon devices because if libvirt doesn't
find one in
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: fix behaviour with balloon model=none
..
Patch Set 1:
Couldn't we simply ignore balloon devices with model='none'?
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: utils: Making try block smaller in tobool()
..
Patch Set 1: Code-Review-1
Martin is right, the additional restriction to ValueError is not safe.
--
To view,
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: fix behaviour with balloon model=none
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/54440/2//COMMIT_MSG
Commit Message:
Line 5:
Milan Zamazal has abandoned this change.
Change subject: storage: Make _readspeed_regex compatible with more dd outputs
..
Abandoned
This change is not needed, it's already handled in the patches referred by Nir
above.
--
Milan Zamazal has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57511
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: schema: Marked optional fields in ExternalVmInfo.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57417
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/57418/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 413:
Milan Zamazal has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 2:
Tomas Golembiovsky was kind to resolve the puzzle for us:
- We can simply replace
Milan Zamazal has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57506
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 2:
(1 comment)
Just one PEP8 issue, otherwise fine for me now.
Milan Zamazal has posted comments on this change.
Change subject: utils: Fix bug in tobool()
..
Patch Set 1: Code-Review-1
Let's be a bit careful. We've had issues with string<->unicode conversions
involving non-ASCII
Milan Zamazal has posted comments on this change.
Change subject: v2v: Lazy loading of external VMs info
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57418
To unsubscribe, visit
Milan Zamazal has uploaded a new change for review.
Change subject: storage: Make _readspeed_regex compatible with more dd outputs
..
storage: Make _readspeed_regex compatible with more dd outputs
Some versions of dd, e.g. the
Milan Zamazal has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57506
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: fix behaviour with balloon model=none
..
Patch Set 1:
We've got a bug for this now: https://bugzilla.redhat.com/1335840
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: teardown non-scsi devices
..
Patch Set 6: Code-Review+1
Without understanding all the possible implications, it looks basically fine to
me. (And I
Milan Zamazal has posted comments on this change.
Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: migrations: enhance legacy downtime alg
..
Patch Set 5:
(2 comments)
Thanks for clarifications. I'm still confused about migration_downtime_delay
description,
Milan Zamazal has posted comments on this change.
Change subject: vm: devices: fix behaviour with balloon model=none
..
Patch Set 1:
For me, the balloon alias gets lost after libvirtd restart. Just restarting
Vdsm doesn't
Milan Zamazal has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 32: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 25:
(2 comments)
https://gerrit.ovirt.org/#/c/53305/30/vdsm/API.py
File vdsm/API.py:
Milan Zamazal has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 30: Code-Review-1
(2 comments)
Just a documentation issue, please fix it if possible to
Milan Zamazal has posted comments on this change.
Change subject: migrations: enhance legacy downtime alg
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56561
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: migration: log the convergence schedule only if provided
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57370
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: test: validate that OVS tests runs as root
..
Patch Set 1: Code-Review+1
It fixes the problem I had with `make rpm' in Vdsm.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 3: Verified+1
Verified by successfully opening a SPICE console with a patched
Milan Zamazal has posted comments on this change.
Change subject: migrations: change convergence schedule from time to iterations
..
Patch Set 4: Code-Review+1
To clarify the last Tomáš's comment: We primarily care about small
Milan Zamazal has posted comments on this change.
Change subject: migrations: change convergence schedule from time to iterations
..
Patch Set 4:
My last comment was wrong. The patch is actually targeted at large VMs. My
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/56836
To
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 4:
(2 comments)
Milan Zamazal has posted comments on this change.
Change subject: vmtests: use assertXMLEqual in assertBuildCmdline
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56973
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: delay appendFeatures and appendClock
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56974
To unsubscribe, visit
401 - 500 of 805 matches
Mail list logo